133 Commits (c936a52a9eb18e302fbd5158da7188f674912530)

Author	SHA1	Message	Date
Will Hunt	2ad3fc36e6	Fixes #3135 - Replace _OpenSSLECCurve with crypto.get_elliptic_curve (#3157) ... fixes #3135 Signed-off-by: Will Hunt will@half-shot.uk	7 years ago
Richard van der Hoff	2a13af23bc	Use run_in_background in preference to preserve_fn ... While I was going through uses of preserve_fn for other PRs, I converted places which only use the wrapped function once to use run_in_background, to avoid creating the function object.	7 years ago
Richard van der Hoff	9255a6cb17	Improve exception handling for background processes ... There were a bunch of places where we fire off a process to happen in the background, but don't have any exception handling on it - instead relying on the unhandled error being logged when the relevent deferred gets garbage-collected. This is unsatisfactory for a number of reasons: - logging on garbage collection is best-effort and may happen some time after the error, if at all - it can be hard to figure out where the error actually happened. - it is logged as a scary CRITICAL error which (a) I always forget to grep for and (b) it's not really CRITICAL if a background process we don't care about fails. So this is an attempt to add exception handling to everything we fire off into the background.	7 years ago
Adrian Tschira	1515560f5c	Use str(e) instead of e.message ... Doing this I learned e.message was pretty shortlived, added in 2.6, they realized it was a bad idea and deprecated it in 2.7 Signed-off-by: Adrian Tschira <nota@notafile.com>	7 years ago
Richard van der Hoff	7303ed65e1	Fix 500 when joining matrix-dev ... matrix-dev has an event (`$/6ANj/9QWQyd71N6DpRQPf+SDUu11+HVMeKSpMzBCwM:zemos.net`) which has no `hashes` member. Check for missing `hashes` element in events.	7 years ago
Richard van der Hoff	eaaabc6c4f	replace 'except:' with 'except Exception:' ... what could possibly go wrong	7 years ago
Richard van der Hoff	79b3cf3e02	Fix logcontxt leak in keyclient (#2465) ... preserve_context_over_function doesn't do what you want it to do.	7 years ago
Richard van der Hoff	c5c24c239b	Fix logcontext handling in verify_json_objects_for_server ... preserve_context_over_fn is essentially broken, because (a) it pointlessly drops the current logcontext before calling its wrapped function, which means we don't get any useful logcontexts for _handle_key_deferred; (b) it wraps the resulting deferred in a _PreservingContextDeferred, which is very dangerous because you then can't yield on it without leaking context back into the reactor. Instead, let's specify that the resultant deferreds call their callbacks with no logcontext.	7 years ago
Richard van der Hoff	c5b0e9f485	Turn _start_key_lookups into an inlineCallbacks function ... ... which means that logcontexts can be correctly preserved for the stuff it does. get_server_verify_keys is now called with the logcontext, so needs to preserve_fn when it fires off its nested inlineCallbacks function. Also renames get_server_verify_keys to reflect the fact it's meant to be private.	7 years ago
Richard van der Hoff	abdefb8a01	Fix potential race in _start_key_lookups ... If the verify_request.deferred has already completed, then `remove_deferreds` will be called immediately. It therefore might resolve the server_to_deferred deferred while there are still other requests for that server in flight. To avoid that, we should build the complete list of requests, and *then* add the callbacks.	7 years ago
Richard van der Hoff	afbd773dc6	Add some comments to _start_key_lookups	7 years ago
Richard van der Hoff	2a4b9ea233	Consistency for how verify_request.deferred is called ... Define that it is run with no log context, and make sure that happens. If we aren't careful to reset the logcontext, we can't bung the deferreds into defer.gatherResults etc. We don't actually do that directly, but we *do* resolve other deferreds from affected callbacks (notably the server_to_deferred map in _start_key_lookups), and those *do* get passed into defer.gatherResults. It turns out that this way ends up being least confusing.	7 years ago
Richard van der Hoff	3b98439eca	Factor out _start_key_lookups ... ... to make it easier to see what's going on.	7 years ago
Richard van der Hoff	fde63b880d	Replace `server_and_json` with `verify_requests` ... This is a precursor to factoring some of this code out.	7 years ago
Richard van der Hoff	2d511defd9	pull out handle_key_deferred to top level ... There's no need for this to be a nested definition; pulling it out not only makes it more efficient, but makes it easier to check that it's not accessing any local variables it shouldn't be.	7 years ago
Richard van der Hoff	dd1ea9763a	Fix incorrect key_ids in error message	7 years ago
Richard van der Hoff	9864efa532	Fix concurrent server_key requests (#2458) ... Fix a bug where we could end up firing off multiple requests for server_keys for the same server at the same time.	7 years ago
Richard van der Hoff	290777b3d9	Clean up and document handling of logcontexts in Keyring (#2452) ... I'm still unclear on what the intended behaviour for `verify_json_objects_for_server` is, but at least I now understand the behaviour of most of the things it calls...	7 years ago
Kenny Keslar	f18373dc5d	Fix iteration of requests_missing_keys; list doesn't have .values() ... Signed-off-by: Kenny Keslar <r3dey3@r3dey3.com>	7 years ago
Richard van der Hoff	4bd597d9fc	push federation retry limiter down to matrixfederationclient ... rather than having to instrument everywhere we make a federation call, make the MatrixFederationHttpClient manage the retry limiter.	8 years ago
Richard van der Hoff	64778693be	fix up some key verif docstrings	8 years ago
Richard van der Hoff	c36d15d2de	Add some debug to help diagnose weird federation issue	8 years ago
Erik Johnston	9219139351	Preserve some logcontexts	8 years ago
Erik Johnston	04fc8bbcb0	Update keyring Measure	8 years ago
Erik Johnston	2426c2f21a	Measure keyrings	8 years ago
Erik Johnston	fa1ce4d8ad	Don't print stack traces when failing to get remote keys	8 years ago
Mark Haines	fe1b369946	Clean up verify_json_objects_for_server	8 years ago
Mark Haines	a4b06b619c	Add a couple more checks to the keyring	8 years ago
Mark Haines	87ffd21b29	Fix a couple of bugs in the transaction and keyring code	8 years ago
Erik Johnston	d26b660aa6	Cache getPeer	8 years ago
Erik Johnston	cf94a78872	Set host not path	8 years ago
Erik Johnston	081e5d55e6	Send the correct host header when fetching keys	8 years ago
David Baker	f28643cea9	Uncommit accidentally commited edit to cipher list	9 years ago
David Baker	d46b18a00f	Pass through _get_event_txn	9 years ago
Erik Johnston	2e2be463f8	Make key client send a Host header	9 years ago
Erik Johnston	2c1fbea531	Fix up logcontexts	9 years ago
Matthew Hodgson	6c28ac260c	copyrights	9 years ago
Paul "LeoNerd" Evans	a6ba41e078	Actually look up required remote server key IDs ... set.union() is a side-effect-free function that returns the union of two sets. This clearly wanted .update(), which is the side-effecting mutator version.	9 years ago
Erik Johnston	0eabfa55f6	Fix typo	9 years ago
Erik Johnston	6408541075	Don't limit connections to perspective servers	9 years ago
Erik Johnston	ffe8cf7e59	Fix bug where we sometimes didn't fetch all the keys requested for a ... server.	9 years ago
Erik Johnston	e1eb1f3fb9	Various bug fixes to crypto.keyring	9 years ago
Erik Johnston	dd0867f5ba	Various bug fixes to crypto.keyring	9 years ago
Daniel Wagner-Hall	81a93ddcc8	Allow configuration to ignore invalid SSL certs ... This will be useful for sytest, and sytest only, hence the aggressive config key name.	9 years ago
Mark Haines	78323ccdb3	Remove syutil dependency in favour of smaller single-purpose libraries	9 years ago
Matthew Hodgson	fb8d2862c1	remove the tls_certificate_chain_path param and simply support tls_certificate_path pointing to a file containing a chain of certificates	10 years ago
Matthew Hodgson	f26a3df1bf	oops, context.tls_certificate_chain_file() expects a file, not a certificate.	10 years ago
Matthew Hodgson	19fa3731ae	typo	10 years ago
Matthew Hodgson	64afbe6ccd	add new optional config for tls_certificate_chain_path for folks with intermediary SSL certs	10 years ago
Erik Johnston	f0dd568e16	Wait for previous attempts at fetching keys for a given server before trying to fetch more	10 years ago