10324 Commits (d1c7c2a98a133bdae7747601699a6b9ae0f90c8b)

Author	SHA1	Message	Date
Hubert Chathi	d1c7c2a98a	allow devices to be marked as "hidden" ... This is a prerequisite for cross-signing, as it allows us to create other things that live within the device namespace, so they can be used for signatures.	5 years ago
Jorik Schellekens	7b8bc61834	Don't accept opentracing data from clients. (#5715) ... * Don't accept opentracing data from clients. * newsfile	5 years ago
Erik Johnston	2410335507	Use upsert when updating destination retry interval	5 years ago
Erik Johnston	bd2e1a2aa8	LoggingTransaction accepts None for callback lists. ... Its a bit disingenuousto give LoggingTransaction lists to append callbacks to if we're not going to run the callbacks.	5 years ago
Erik Johnston	ebc5ed1296	Update comment for new column	5 years ago
Neil Johnson	5c05ae7ba0	Add 'rel' attribute to default welcome page. (#5695) ... add rel attribute as a precaution against reverse tabnabbing in future	5 years ago
Amber Brown	6a85cb5ef7	Remove non-dedicated logging options and command line arguments (#5678)	5 years ago
Neil Johnson	cfc00068bd	enable aggregations support by default	5 years ago
Erik Johnston	10523241d8	Delegate to cached version when using get_filtered_current_state_ids ... In the case where it gets called with `StateFilter.all()`	5 years ago
Richard van der Hoff	82345bc09a	Clean up opentracing configuration options (#5712) ... Clean up config settings and dead code. This is mostly about cleaning up the config format, to bring it into line with our conventions. In particular: * There should be a blank line after `## Section ##' headings * There should be a blank line between each config setting * There should be a `#`-only line between a comment and the setting it describes * We don't really do the `# #` style commenting-out of whole sections if we can help it * rename `tracer_enabled` to `enabled` While we're here, do more config parsing upfront, which makes it easier to use later on. Also removes redundant code from LogContextScopeManager. Also changes the changelog fragment to a `feature` - it's exciting!	5 years ago
Amber Brown	7ad1d76356	Support Prometheus_client 0.4.0+ (#5636)	5 years ago
Andrew Morgan	b2a382efdb	Remove the ability to query relations when the original event was redacted. (#5629) ... Fixes #5594 Forbid viewing relations on an event once it has been redacted.	5 years ago
Erik Johnston	8e1ada9e6f	Use the current_state_events.membership column	5 years ago
Erik Johnston	059d8c1a4e	Track if current_state_events.membership is up to date	5 years ago
Erik Johnston	c618a5d348	Add background update for current_state_events.membership column	5 years ago
Erik Johnston	6de09e07a6	Add membership column to current_state_events table. ... It turns out that doing a join is surprisingly expensive for the DB to do when room_membership table is larger than the disk cache.	5 years ago
Richard van der Hoff	fa8271c5ac	Convert synapse.federation.transport.server to async (#5689) ... * Convert BaseFederationServlet._wrap to async Empirically, this fixes some lost stacktraces. It should be safe because the wrapped function is called from JsonResource._async_render, which is already async. * Convert the rest of synapse.federation.transport.server to async We may as well do the whole file while we're here. * changelog * flake8	5 years ago
Richard van der Hoff	9c70a02a9c	Ignore redactions of m.room.create events (#5701)	5 years ago
Richard van der Hoff	2091c91fde	More refactoring in `get_events_as_list` (#5707) ... We can now use `_get_events_from_cache_or_db` rather than going right back to the database, which means that (a) we can benefit from caching, and (b) it opens the way forward to more extensive checks on the original event. We now always require the original event to exist before we will serve up a redaction.	5 years ago
Richard van der Hoff	375162b3c3	Fix redaction authentication (#5700) ... Ensures that redactions are correctly authenticated for recent room versions. There are a few things going on here: * `_fetch_event_rows` is updated to return a dict rather than a list of rows. * Rather than returning multiple copies of an event which was redacted multiple times, it returns the redactions as a list within the dict. * It also returns the actual rejection reason, rather than merely the fact that it was rejected, so that we don't have to query the table again in `_get_event_from_row`. * The redaction handling is factored out of `_get_event_from_row`, and now checks if any of the redactions are valid.	5 years ago
Richard van der Hoff	65c5592b8e	Refactor `get_events_as_list` (#5699) ... A couple of changes here: * get rid of a redundant `allow_rejected` condition - we should already have filtered out any rejected events before we get to that point in the code, and the redundancy is confusing. Instead, let's stick in an assertion just to make double-sure we aren't leaking rejected events by mistake. * factor out a `_get_events_from_cache_or_db` method, which is going to be important for a forthcoming fix to redactions.	5 years ago
Erik Johnston	5ed7853bb0	Remove pointless description	5 years ago
Erik Johnston	f44354e17f	Clean up arg name and remove lying comment	5 years ago
Erik Johnston	d0d479c1af	Fix typo in synapse/app/admin_cmd.py ... Co-Authored-By: Aaron Raimist <aaron@raim.ist>	5 years ago
Erik Johnston	03cc8c4b5d	Fix invoking add_argument from homeserver.py	5 years ago
Erik Johnston	eca4f5ac73	s/exfiltrate_user_data/export_user_data/	5 years ago
Erik Johnston	1b2067f53d	Add FileExfiltrationWriter	5 years ago
Erik Johnston	c8f35d8d38	Use set_defaults(func=) style	5 years ago
Erik Johnston	fdefb9e29a	Move creation of ArgumentParser to caller	5 years ago
Erik Johnston	37b524f971	Fix up comments	5 years ago
Erik Johnston	823e13ddf4	Change add_arguments to be a static method	5 years ago
Andrew Morgan	18c516698e	Return a different error from Invalid Password when a user is deactivated (#5674) ... Return `This account has been deactivated` instead of `Invalid password` when a user is deactivated.	5 years ago
Richard van der Hoff	5f158ec039	Implement access token expiry (#5660) ... Record how long an access token is valid for, and raise a soft-logout once it expires.	5 years ago
Erik Johnston	db0a50bc40	Fixup docstrings	5 years ago
Andrew Morgan	24aa0e0a5b	fix typo: backgroud -> background	5 years ago
Andrew Morgan	78a1cd36b5	small typo fix (#5655)	5 years ago
Richard van der Hoff	0a4001eba1	Clean up exception handling for access_tokens (#5656) ... First of all, let's get rid of `TOKEN_NOT_FOUND_HTTP_STATUS`. It was a hack we did at one point when it was possible to return either a 403 or a 401 if the creds were missing. We always return a 401 in these cases now (thankfully), so it's not needed. Let's also stop abusing `AuthError` for these cases. Honestly they have nothing that relates them to the other places that `AuthError` is used, other than the fact that they are loosely under the 'Auth' banner. It makes no sense for them to share exception classes. Instead, let's add a couple of new exception classes: `InvalidClientTokenError` and `MissingClientTokenError`, for the `M_UNKNOWN_TOKEN` and `M_MISSING_TOKEN` cases respectively - and an `InvalidClientCredentialsError` base class for the two of them.	5 years ago
Jorik Schellekens	38a6d3eea7	Add basic opentracing support (#5544) ... * Configure and initialise tracer Includes config options for the tracer and sets up JaegerClient. * Scope manager using LogContexts We piggy-back our tracer scopes by using log context. The current log context gives us the current scope. If new scope is created we create a stack of scopes in the context. * jaeger is a dependency now * Carrier inject and extraction for Twisted Headers * Trace federation requests on the way in and out. The span is created in _started_processing and closed in _finished_processing because we need a meaningful log context. * Create logcontext for new scope. Instead of having a stack of scopes in a logcontext we create a new context for a new scope if the current logcontext already has a scope. * Remove scope from logcontext if logcontext is top level * Disable tracer if not configured * typo * Remove dependence on jaeger internals * bools * Set service name * :Explicitely state that the tracer is disabled * Black is the new black * Newsfile * Code style * Use the new config setup. * Generate config. * Copyright * Rename config to opentracing * Remove user whitelisting * Empty whitelist by default * User ConfigError instead of RuntimeError * Use isinstance * Use tag constants for opentracing. * Remove debug comment and no need to explicitely record error * Two errors a "s(c)entry" * Docstrings! * Remove debugging brainslip * Homeserver Whitlisting * Better opentracing config comment * linting * Inclue worker name in service_name * Make opentracing an optional dependency * Neater config retreival * Clean up dummy tags * Instantiate tracing as object instead of global class * Inlcude opentracing as a homeserver member. * Thread opentracing to the request level * Reference opetnracing through hs * Instantiate dummy opentracin g for tests. * About to revert, just keeping the unfinished changes just in case * Revert back to global state, commit number: 9ce4a3d9067bf9889b86c360c05ac88618b85c4f * Use class level methods in tracerutils * Start and stop requests spans in a place where we have access to the authenticated entity * Seen it, isort it * Make sure to close the active span. * I'm getting black and blue from this. * Logger formatting Co-Authored-By: Erik Johnston <erik@matrix.org> * Outdated comment * Import opentracing at the top * Return a contextmanager * Start tracing client requests from the servlet * Return noop context manager if not tracing * Explicitely say that these are federation requests * Include servlet name in client requests * Use context manager * Move opentracing to logging/ * Seen it, isort it again! * Ignore twisted return exceptions on context exit * Escape the scope * Scopes should be entered to make them useful. * Nicer decorator names * Just one init, init? * Don't need to close something that isn't open * Docs make you smarter	5 years ago
Richard van der Hoff	1890cfcf82	Inline issue_access_token (#5659) ... this is only used in one place, so it's clearer if we inline it and reduce the API surface. Also, fixes a buglet where we would create an access token even if we were about to block the user (we would never return the AT, so the user could never use it, but it was still created and added to the db.)	5 years ago
Richard van der Hoff	953dbb7980	Remove access-token support from RegistrationStore.register (#5642) ... The 'token' param is no longer used anywhere except the tests, so let's kill that off too.	5 years ago
Brendan Abolivier	b2a2e96ea6	Typo	5 years ago
Brendan Abolivier	f77e997619	Send 3PID bind requests as JSON data	5 years ago
Andrew Morgan	f281714583	Don't bundle aggregations when retrieving the original event (#5654) ... A fix for PR #5626, which returned the original event content as part of a call to /relations. Only problem was that we were attempting to aggregate the relations on top of it when we did so. We now set bundle_aggregations to False in the get_event call. We also do this when pulling the relation events as well, because edits of edits are not something we'd like to support here.	5 years ago
Hubert Chathi	7b3bc755a3	remove unused and unnecessary check for FederationDeniedError (#5645) ... FederationDeniedError is a subclass of SynapseError, which is a subclass of CodeMessageException, so if e is a FederationDeniedError, then this check for FederationDeniedError will never be reached since it will be caught by the check for CodeMessageException above. The check for CodeMessageException does almost the same thing as this check (since FederationDeniedError initialises with code=403 and msg="Federation denied with %s."), so may as well just keep allowing it to handle this case.	5 years ago
Andrew Morgan	d88421ab03	Include the original event in /relations (#5626) ... When asking for the relations of an event, include the original event in the response. This will mostly be used for efficiently showing edit history, but could be useful in other circumstances.	5 years ago
Richard van der Hoff	824707383b	Remove access-token support from RegistrationHandler.register (#5641) ... Nothing uses this now, so we can remove the dead code, and clean up the API. Since we're changing the shape of the return value anyway, we take the opportunity to give the method a better name.	5 years ago
Brendan Abolivier	7556851665	Allow newly-registered users to lookup their own profiles ... When a user creates an account and the 'require_auth_for_profile_requests' config flag is set, and a client that performed the registration wants to lookup the newly-created profile, the request will be denied because the user doesn't share a room with themselves yet.	5 years ago
Richard van der Hoff	b70e080b59	Better logging for auto-join. (#5643) ... It was pretty unclear what was going on, so I've added a couple of log lines.	5 years ago
Richard van der Hoff	4b1f7febc7	Update ModuleApi to avoid register(generate_token=True) (#5640) ... * Update ModuleApi to avoid register(generate_token=True) This is the only place this is still used, so I'm trying to kill it off. * changelog	5 years ago
Richard van der Hoff	f9e99f9534	Factor out some redundant code in the login impl (#5639) ... * Factor out some redundant code in the login impl Also fixes a redundant access_token which was generated during jwt login. * changelog	5 years ago