watcha-synapse

Commit Graph

Author	SHA1	Message	Date
Erik Johnston	c4fa4f37cb	Fix perf of fetching the same events many times. (#10703 ) The code to deduplicate repeated fetches of the same set of events was N^2 (over the number of events requested), which could lead to a process being completely wedged. The main fix is to deduplicate the returned deferreds so we only await on a deferred once rather than many times. Seperately, when handling the returned events from the defrered we only add the events we care about to the event map to be returned (so that we don't pay the price of inserting extraneous events into the dict).	4 years ago

Author

SHA1

Message

Date

Erik Johnston

c4fa4f37cb

Fix perf of fetching the same events many times. (#10703 )

The code to deduplicate repeated fetches of the same set of events was
N^2 (over the number of events requested), which could lead to a process
being completely wedged.

The main fix is to deduplicate the returned deferreds so we only await
on a deferred once rather than many times. Seperately, when handling the
returned events from the defrered we only add the events we care about
to the event map to be returned (so that we don't pay the price of
inserting extraneous events into the dict).

4 years ago

1 Commits (e3abc0a5cc0669b76e5bdf2e1539645d790a7a3d)