watcha-synapse

History

David Robertson ffc2ee521d Use mypy 1.0 (#15052 ) * Update mypy and mypy-zope * Remove unused ignores These used to suppress ``` synapse/storage/engines/__init__.py:28: error: "__new__" must return a class instance (got "NoReturn") [misc] ``` and ``` synapse/http/matrixfederationclient.py:1270: error: "BaseException" has no attribute "reasons" [attr-defined] ``` (note that we check `hasattr(e, "reasons")` above) * Avoid empty body warnings, sometimes by marking methods as abstract E.g. ``` tests/handlers/test_register.py:58: error: Missing return statement [empty-body] tests/handlers/test_register.py:108: error: Missing return statement [empty-body] ``` * Suppress false positive about `JaegerConfig` Complaint was ``` synapse/logging/opentracing.py:450: error: Function "Type[Config]" could always be true in boolean context [truthy-function] ``` * Fix not calling `is_state()` Oops! ``` tests/rest/client/test_third_party_rules.py:428: error: Function "Callable[[], bool]" could always be true in boolean context [truthy-function] ``` * Suppress false positives from ParamSpecs ```` synapse/logging/opentracing.py:971: error: Argument 2 to "_custom_sync_async_decorator" has incompatible type "Callable[[Arg(Callable[P, R], 'func'), P], _GeneratorContextManager[None]]"; expected "Callable[[Callable[P, R], P], _GeneratorContextManager[None]]" [arg-type] synapse/logging/opentracing.py:1017: error: Argument 2 to "_custom_sync_async_decorator" has incompatible type "Callable[[Arg(Callable[P, R], 'func'), P], _GeneratorContextManager[None]]"; expected "Callable[[Callable[P, R], P], _GeneratorContextManager[None]]" [arg-type] ```` * Drive-by improvement to `wrapping_logic` annotation * Workaround false "unreachable" positives See https://github.com/Shoobx/mypy-zope/issues/91 ``` tests/http/test_proxyagent.py:626: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:762: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:826: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:838: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:845: error: Statement is unreachable [unreachable] tests/http/federation/test_matrix_federation_agent.py:151: error: Statement is unreachable [unreachable] tests/http/federation/test_matrix_federation_agent.py:452: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:60: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:93: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:127: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:152: error: Statement is unreachable [unreachable] ``` * Changelog * Tweak DBAPI2 Protocol to be accepted by mypy 1.0 Some extra context in: - https://github.com/matrix-org/python-canonicaljson/pull/57 - https://github.com/python/mypy/issues/6002 - https://mypy.readthedocs.io/en/latest/common_issues.html#covariant-subtyping-of-mutable-protocol-members-is-rejected * Pull in updated canonicaljson lib so the protocol check just works * Improve comments in opentracing I tried to workaround the ignores but found it too much trouble. I think the corresponding issue is https://github.com/python/mypy/issues/12909. The mypy repo has a PR claiming to fix this (https://github.com/python/mypy/pull/14677) which might mean this gets resolved soon? * Better annotation for INTERACTIVE_AUTH_CHECKERS * Drive-by AUTH_TYPE annotation, to remove an ignore		2 years ago
..
.gitignore	…
13755.misc	Return read-only collections from `@cached` methods (#13755 )	2 years ago
13779.bugfix	Prevent clients from reporting nonexistent events. (#13779 )	2 years ago
14605.bugfix	Respond correctly to unknown methods on known endpoints (#14605 )	2 years ago
14606.misc	Faster joins: don't stall when a user joins during a fast join (#14606 )	2 years ago
14675.misc	Add a class UnpersistedEventContext to allow for the batching up of storing state groups (#14675 )	2 years ago
14742.misc	Add check to ensure locked dependencies have source distributions available. (#14742 )	2 years ago
14834.misc	Tweak comment on `_is_local_room_accessible` as part of room visibility in `/hierarchy` to clarify the condition for a room being visible. (#14834 )	2 years ago
14840.misc	Do not always start a db txn on Postgres (#14840 )	2 years ago
14929.misc	Change collection[str] to StrCollection in event_auth code (#14929 )	2 years ago
14959.doc	…
14964.feature	Support for MSC3758: exact_event_match push condition (#14964 )	2 years ago
14973.misc	Avoid fetching unused account data in sync. (#14973 )	2 years ago
14977.misc	…
14980.misc	Skip calculating unread push actions in `/sync` when `enable_push` is false. (#14980 )	2 years ago
14982.misc	Make it easier to use DataGrip w/ Synapse's schema (#14982 )	2 years ago
15004.feature	…
15008.misc	…
15020.misc	…
15022.doc	…
15026.misc	…
15027.misc	…
15028.misc	Add more missing type hints to tests. (#15028 )	2 years ago
15031.misc	Proper types for `tests.module_api` (#15031 )	2 years ago
15033.misc	Bump ruff version from 0.0.230 to 0.0.237. (#15033 )	2 years ago
15034.feature	Support for selecting the Redis logical database. (#15034 )	2 years ago
15035.misc	Add final type hint to synapse.server. (#15035 )	2 years ago
15037.misc	Update intentional mentions (MSC3952) to depend on `exact_event_match` (MSC3758). (#15037 )	2 years ago
15038.bugfix	Avoid mutating cached room aliases. (#15038 )	2 years ago
15040.misc	Refactor get_user_devices_from_cache to avoid mutating cached values. (#15040 )	2 years ago
15041.misc	Fix exception on start up about device lists (#15041 )	2 years ago
15042.feature	Tag federation request spans with the worker name (#15042 )	2 years ago
15043.misc	Update pyo3-log to v0.8.1 (#15043 )	2 years ago
15045.feature	Implement MSC3966: Add a push rule condition to search for a value in an array. (#15045 )	2 years ago
15047.misc	Avoid mutating cached values in `_generate_sync_entry_for_account_data` (#15047 )	2 years ago
15052.misc	Use mypy 1.0 (#15052 )	2 years ago
15053.misc	Refactor arguments of `try_unbind_threepid(_with_id_server)` from dict to separate args (#15053 )	2 years ago
15054.misc	Apply logging from hotfixes branch to develop (#15054 )	2 years ago
15059.misc	Bump bleach from 5.0.1 to 6.0.0 (#15059 )	2 years ago
15060.misc	Bump dtolnay/rust-toolchain from 9cd00a88a73addc8617065438eff914dd08d0955 to 25dc93b901a87e864900a8aec6c12e9aa794c0c3 (#15060 )	2 years ago
15061.misc	Bump systemd-python from 234 to 235 (#15061 )	2 years ago
15062.misc	Bump serde_json from 1.0.92 to 1.0.93 (#15062 )	2 years ago
15063.misc	Bump types-requests from 2.28.11.8 to 2.28.11.12 (#15063 )	2 years ago
15064.misc	Bump types-pillow from 9.4.0.5 to 9.4.0.10 (#15064 )	2 years ago
15065.misc	Bump sentry-sdk from 1.13.0 to 1.15.0 (#15065 )	2 years ago
15068.bugfix	Fix order of partial state tables when purging (#15068 )	2 years ago
15069.misc	Faster joins: Omit device list updates from partial state rooms in /sync (#15069 )	2 years ago
15070.misc	Fix clashing DB txn name (#15070 )	2 years ago
15072.misc	Add final type hint to tests.unittest. (#15072 )	2 years ago
15073.feature	Remove spurious `dont_notify` action from `.m.rule.reaction` (#15073 )	2 years ago
15074.bugfix	Fix federated joins when the first server in the list is not in the room (#15074 )	2 years ago
15075.feature	Update the error code for duplicate annotation (#15075 )	2 years ago
15078.doc	Fix a mistake in registration_shared_secret_path docs (#15078 )	2 years ago