Avoid generatin a bogus ID token when generation fails (#2105)

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Issuer/OpenIDConnect.pm

@@ -795,6 +795,11 @@ sub run {
                 my $id_token =
                   $self->createIDToken( $id_token_payload_hash, $rp );
 
+                unless ($id_token) {
+                    $self->logger->error("Could not generate ID token");
+                    return PE_ERROR;
+                }
+
                 $self->logger->debug("Generated id token: $id_token");
 
                 # Send token response
@@ -941,6 +946,11 @@ sub run {
                     $id_token =
                       $self->createIDToken( $id_token_payload_hash, $rp );
 
+                    unless ($id_token) {
+                        $self->logger->error("Could not generate ID token");
+                        return PE_ERROR;
+                    }
+
                     $self->logger->debug("Generated id token: $id_token");
                 }
 
@@ -1276,6 +1286,12 @@ sub token {
         # Create ID Token
         my $id_token = $self->createIDToken( $id_token_payload_hash, $rp );
 
+        unless ($id_token) {
+            $self->logger->error(
+                "Failed to generate ID Token for service: $client_id");
+            return $self->p->sendError( $req, 'server_error', 500 );
+        }
+
         $self->logger->debug("Generated id token: $id_token");
 
         # Send token response
@@ -1496,6 +1512,12 @@ sub token {
         # Create ID Token
         my $id_token = $self->createIDToken( $id_token_payload_hash, $rp );
 
+        unless ($id_token) {
+            $self->logger->error(
+                "Failed to generate ID Token for service: $client_id");
+            return $self->p->sendError( $req, 'server_error', 500 );
+        }
+
         $self->logger->debug("Generated id token: $id_token");
 
         # Send token response