Fix warning if error is undefined (#2126 & #1625)

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Issuer/CAS.pm

@@ -35,7 +35,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{issuerDBCASRule} ) );
     unless ($rule) {
-        $self->error( "Bad CAS rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error("Bad CAS activation rule -> $error");
         return 0;
     }
     $self->{rule} = $rule;

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Issuer/Get.pm

@@ -24,7 +24,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{issuerDBGetRule} ) );
     unless ($rule) {
-        $self->error( "Bad GET rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error( "Bad GET activation rule -> $error" );
         return 0;
     }
     $self->{rule} = $rule;

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Issuer/OpenID.pm

@@ -64,7 +64,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{issuerDBOpenIDRule} ) );
     unless ($rule) {
-        $self->error( "Bad OpenID rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error( "Bad OpenID activation rule -> $error" );
         return 0;
     }
     $self->{rule} = $rule;

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Issuer/OpenIDConnect.pm

@@ -76,7 +76,8 @@ sub init {
       $hd->buildSub(
         $hd->substitute( $self->conf->{issuerDBOpenIDConnectRule} ) );
     unless ($rule) {
-        $self->error( "Bad OIDC rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error( "Bad OIDC activation rule -> $error" );
         return 0;
     }
     $self->{rule} = $rule;

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Issuer/SAML.pm

@@ -47,7 +47,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{issuerDBSAMLRule} ) );
     unless ($rule) {
-        $self->error( "Bad SAML rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error( "Bad SAML activation rule -> $error" );
         return 0;
     }
     $self->{rule} = $rule;

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/CheckUser.pm

@@ -55,8 +55,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{checkUserIdRule} ) );
     unless ($rule) {
-        $self->error(
-            "Bad checkUser identities rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error("Bad checkUser identities rule -> $error");
         return 0;
     }
     $self->idRule($rule);

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/ContextSwitching.pm

@@ -40,7 +40,7 @@ has idRule => ( is => 'rw', default => sub { 1 } );
 sub init {
     my ($self) = @_;
     my $hd = $self->p->HANDLER;
-    $self->addAuthRoute( switchcontext => 'run',  ['POST'] )
+    $self->addAuthRoute( switchcontext => 'run', ['POST'] )
       ->addAuthRoute( switchcontext => 'display', ['GET'] );
 
     # Parse activation rule
@@ -49,8 +49,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{contextSwitchingRule} ) );
     unless ($rule) {
-        $self->error(
-            'Bad contextSwitching rule -> ' . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error("Bad contextSwitching rule -> $error");
         return 0;
     }
     $self->rule($rule);
@@ -61,8 +61,8 @@ sub init {
     $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{contextSwitchingIdRule} ) );
     unless ($rule) {
-        $self->error( "Bad contextSwitching identities rule -> "
-              . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error("Bad contextSwitching identities rule -> $error");
         return 0;
     }
     $self->idRule($rule);

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/DecryptValue.pm

@@ -40,7 +40,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{decryptValueRule} ) );
     unless ($rule) {
-        $self->error( 'Bad decryptValue rule -> ' . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error("Bad decryptValue rule -> $error");
         return 0;
     }
     $self->rule($rule);

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/GlobalLogout.pm

@@ -45,7 +45,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{globalLogoutRule} ) );
     unless ($rule) {
-        $self->error( "Bad globalLogout rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error("Bad globalLogout rule -> $error");
         return 0;
     }
     $self->rule($rule);

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/GrantSession.pm

@@ -27,7 +27,8 @@ sub init {
           $hd->buildSub(
             $hd->substitute( $self->conf->{grantSessionRules}->{$_} ) );
         unless ($rule) {
-            $self->error( "Bad grantSession rule " . $hd->tsv->{jail}->error );
+            my $error = $hd->tsv->{jail}->error || '';
+            $self->error("Bad grantSession rule -> $error");
             return 0;
         }
         $self->rules->{$_} = $rule;
@@ -66,7 +67,8 @@ sub run {
                 my $hd  = $self->p->HANDLER;
                 my $msg = $hd->substitute($1);
                 unless ( $msg = $hd->buildSub($msg) ) {
-                    $self->error( "Bad message " . $hd->tsv->{jail}->error );
+                    my $error = $hd->tsv->{jail}->error || '';
+                    $self->error("Bad message -> $error");
                     return PE_OK;
                 }
                 $msg = $msg->( $req, $req->sessionInfo );

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/Impersonation.pm

@@ -31,7 +31,8 @@ sub init {
     my $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{impersonationRule} ) );
     unless ($rule) {
-        $self->error( "Bad impersonation rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error("Bad impersonation rule -> $error");
         return 0;
     }
     $self->rule($rule);
@@ -42,8 +43,8 @@ sub init {
     $rule =
       $hd->buildSub( $hd->substitute( $self->conf->{impersonationIdRule} ) );
     unless ($rule) {
-        $self->error(
-            "Bad impersonation identities rule -> " . $hd->tsv->{jail}->error );
+        my $error = $hd->tsv->{jail}->error || '';
+        $self->error("Bad impersonation identities rule -> $error");
         return 0;
     }
     $self->idRule($rule);