Handle missing nameid (#2420)

4 years ago · e05a167937
parent 512045c528
commit e05a167937
1 changed files with 6 additions and 2 deletions
--- a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/SAML.pm
+++ b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/SAML.pm
@ -297,9 +297,13 @@ sub extractFormInfo {
            }

            # Get NameID
-            my $nameid         = $login->nameIdentifier;
-            my $nameid_content = $nameid->content;
+            my $nameid = $login->nameIdentifier;
+            unless ($nameid) {
+                $self->userLogger->error("No NameID element found");
+                return PE_SAML_SSO_ERROR;
+            }

+            my $nameid_content = $nameid->content;
            unless ($nameid_content) {
                $self->userLogger->error("No NameID value found");
                return PE_SAML_SSO_ERROR;