Remove portalAutocomplete configuration (#824)

lemonldap-ng-common/lib/Lemonldap/NG/Common/Conf/DefaultValues.pm

@@ -128,14 +128,18 @@ sub defaultValues {
         'notificationStorageOptions' => {
             'dirName' => '/var/lib/lemonldap-ng/notifications'
         },
-        'notificationWildcard'            => 'allusers',
-        'notifyDeleted'                   => 1,
-        'notifyOther'                     => 0,
-        'nullAuthnLevel'                  => 2,
-        'oidcAuthnLevel'                  => 1,
-        'oidcRPCallbackGetParam'          => 'openidconnectcallback',
-        'oidcRPStateTimeout'              => 600,
-        'oidcServiceMetaDataAuthnContext' => {
+        'notificationWildcard'                  => 'allusers',
+        'notifyDeleted'                         => 1,
+        'notifyOther'                           => 0,
+        'nullAuthnLevel'                        => 2,
+        'oidcAuthnLevel'                        => 1,
+        'oidcRPCallbackGetParam'                => 'openidconnectcallback',
+        'oidcRPStateTimeout'                    => 600,
+        'oidcServiceAllowAuthorizationCodeFlow' => '1',
+        'oidcServiceAllowDynamicRegistration'   => '0',
+        'oidcServiceAllowHybridFlow'            => '0',
+        'oidcServiceAllowImplicitFlow'          => '0',
+        'oidcServiceMetaDataAuthnContext'       => {
             'loa-1' => 1,
             'loa-2' => 2,
             'loa-3' => 3,
@@ -143,6 +147,7 @@ sub defaultValues {
             'loa-5' => 5
         },
         'oidcServiceMetaDataAuthorizeURI'    => 'authorize',
+        'oidcServiceMetaDataCheckSessionURI' => 'checksession',
         'oidcServiceMetaDataEndSessionURI'   => 'logout',
         'oidcServiceMetaDataJWKSURI'         => 'jwks',
         'oidcServiceMetaDataRegistrationURI' => 'register',
@@ -159,7 +164,6 @@ sub defaultValues {
         'passwordDB'                         => 'Demo',
         'portal'                             => 'http://auth.example.com/',
         'portalAntiFrame'                    => 1,
-        'portalAutocomplete'                 => 0,
         'portalCheckLogins'                  => 1,
         'portalDisplayAppslist'              => 1,
         'portalDisplayChangePassword'        => '$_auth =~ /^(LDAP|DBI|Demo)$/',

lemonldap-ng-manager/lib/Lemonldap/NG/Manager/Attributes.pm

@@ -340,11 +340,6 @@ sub attributes {
             type          => 'bool',
             documentation => 'Avoid portal to be displayed inside frames',
         },
-        portalAutocomplete => {
-            default       => 0,
-            type          => 'bool',
-            documentation => 'Allow autocompletion of login input in portal',
-        },
         portalCheckLogins => {
             default       => 1,
             type          => 'bool',

lemonldap-ng-manager/lib/Lemonldap/NG/Manager/Tree.pm

@@ -77,7 +77,6 @@ sub tree {
                                     title => 'portalOther',
                                     form  => 'simpleInputContainer',
                                     nodes => [
-                                        'portalAutocomplete',
                                         'portalUserAttr',
                                         'portalOpenLinkInNewWindow',
                                         'portalAntiFrame',

lemonldap-ng-portal/example/skins/common/js/portal.js

@@ -5,20 +5,11 @@
 /* Used variables
  * - displaytab
  * - choicetab
- * - autocomplete
  * - login
  * - newwindow
  * - antiframe
  */
 
-/* Set autocomplete real value */
-if (autocomplete.match('1')) {
-	autocomplete = 'on';
-}
-if (autocomplete.match('0')) {
-	autocomplete = 'off';
-}
-
 /* Set newwindow value (default is false) */
 if (newwindow.match('1')) {
 	newwindow = true;
@@ -95,9 +86,6 @@ $(document).ready(function() {
 		$("input[type=password]:first").focus();
 	}
 
-	/* Password autocompletion */
-	$("input[type='password']").attr("autocomplete", autocomplete);
-
 	/* Open links in new windows */
 	if (newwindow) {
 		$('#appslist a').attr("target", "_blank");

lemonldap-ng-portal/example/skins/common/script.tpl

@@ -23,7 +23,6 @@
  <script type="text/javascript">//<![CDATA[
     var displaytab="<TMPL_VAR NAME="DISPLAY_TAB">";
     var choicetab="<TMPL_VAR NAME="CHOICE_VALUE">";
-    var autocomplete="<TMPL_VAR NAME="AUTOCOMPLETE">";
     var login="<TMPL_VAR NAME="LOGIN">";
     var newwindow="<TMPL_VAR NAME="NEWWINDOW">";
     var antiframe="<TMPL_VAR NAME="ANTIFRAME">";

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/CDA.pm

@@ -74,7 +74,7 @@ compatible portals with Cross Domain Authentication.
     print '<input type="hidden" name="url" value="'.$portal->param('url').'">';
     # Next, login and password
     print 'Login : <input name="user"><br>';
-    print 'Password : <input name="password" type="password" autocomplete="off">';
+    print 'Password : <input name="password" type="password">';
     print '<input type="submit" value="go" />';
     print '</form>';
   }

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Display.pm

@@ -98,7 +98,6 @@ sub display {
 
             %templateParams = (
                 AUTH_USER           => $auth_user,
-                AUTOCOMPLETE        => $self->{portalAutocomplete},
                 NEWWINDOW           => $self->{portalOpenLinkInNewWindow},
                 AUTH_ERROR          => $self->error( $self->{menuError} ),
                 AUTH_ERROR_TYPE     => $self->error_type( $self->{menuError} ),
@@ -199,7 +198,6 @@ sub display {
             AUTH_ERROR_TYPE       => $self->error_type,
             AUTH_URL              => $self->get_url,
             LOGIN                 => $self->get_user,
-            AUTOCOMPLETE          => $self->{portalAutocomplete},
             CHECK_LOGINS          => $self->{portalCheckLogins},
             ASK_LOGINS            => $self->{checkLogins},
             DISPLAY_RESETPASSWORD => $self->{portalDisplayResetPassword},

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/SharedConf.pm

@@ -172,7 +172,7 @@ compatible portals using a central configuration database.
     print '<input type="hidden" name="url" value="'.$portal->param('url').'">';
     # Next, login and password
     print 'Login : <input name="user"><br>';
-    print 'Password : <input name="password" type="password" autocomplete="off">';
+    print 'Password : <input name="password" type="password">';
     print '<input type="submit" value="go" />';
     print '</form>';
   }

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Simple.pm

@@ -2743,7 +2743,7 @@ Lemonldap::NG::Portal::Simple - Base module for building Lemonldap::NG compatibl
     print '<input type="hidden" name="url" value="'.$portal->param('url').'">';
     # Next, login and password
     print 'Login : <input name="user"><br>';
-    print 'Password : <input name="password" type="password" autocomplete="off">';
+    print 'Password : <input name="password" type="password">';
     print '<input type="submit" value="go" />';
     print '</form>';
   }

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/_WebForm.pm

@@ -110,11 +110,9 @@ sub setAuthSessionInfo {
     my $self = shift;
 
     # authenticationLevel
-    # -1 if password can be remebered
     # +1 for user/password with HTTPS
     $self->{_authnLevel} ||= 0;
     $self->{_authnLevel} += 1 if $self->https();
-    $self->{_authnLevel} -= 1 if $self->{portalAutocomplete};
 
     $self->{sessionInfo}->{authenticationLevel} = $self->{_authnLevel};