CI: Move `verify-storybook` command from grabpl (#59928)

* Move verify-storybook from grabpl

* Remove zerolog
pull/59935/head
Dimitris Sotirakis 3 years ago committed by GitHub
parent 440d8a3d88
commit 0801fce23c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 10
      .drone.yml
  2. 7
      pkg/build/cmd/main.go
  3. 32
      pkg/build/cmd/verifystorybook.go
  4. 2
      scripts/drone/steps/lib.star

@ -575,7 +575,7 @@ steps:
- failure - failure
- commands: - commands:
- yarn storybook:build - yarn storybook:build
- ./bin/grabpl verify-storybook - ./bin/build verify-storybook
depends_on: depends_on:
- build-frontend - build-frontend
- build-frontend-packages - build-frontend-packages
@ -1430,7 +1430,7 @@ steps:
- failure - failure
- commands: - commands:
- yarn storybook:build - yarn storybook:build
- ./bin/grabpl verify-storybook - ./bin/build verify-storybook
depends_on: depends_on:
- build-frontend - build-frontend
- build-frontend-packages - build-frontend-packages
@ -2155,7 +2155,7 @@ steps:
- failure - failure
- commands: - commands:
- yarn storybook:build - yarn storybook:build
- ./bin/grabpl verify-storybook - ./bin/build verify-storybook
depends_on: depends_on:
- build-frontend - build-frontend
- build-frontend-packages - build-frontend-packages
@ -4699,7 +4699,7 @@ steps:
- failure - failure
- commands: - commands:
- yarn storybook:build - yarn storybook:build
- ./bin/grabpl verify-storybook - ./bin/build verify-storybook
depends_on: depends_on:
- build-frontend - build-frontend
- build-frontend-packages - build-frontend-packages
@ -6318,6 +6318,6 @@ kind: secret
name: packages_secret_access_key name: packages_secret_access_key
--- ---
kind: signature kind: signature
hmac: efffc2eb55bbfa1cebe950585df1f3f81d2f2a38311e2854f3ce08d1eec16fe3 hmac: dcf24226fae30872050cdc031430374d811e6bbe13158ce0fbf234c90c1d83f9
... ...

@ -152,7 +152,7 @@ func main() {
}, },
{ {
Name: "store-storybook", Name: "store-storybook",
Usage: "Integrity check for storybook build", Usage: "Stores storybook to GCS buckets",
Action: StoreStorybook, Action: StoreStorybook,
Flags: []cli.Flag{ Flags: []cli.Flag{
&cli.StringFlag{ &cli.StringFlag{
@ -161,6 +161,11 @@ func main() {
}, },
}, },
}, },
{
Name: "verify-storybook",
Usage: "Integrity check for storybook build",
Action: VerifyStorybook,
},
{ {
Name: "upload-packages", Name: "upload-packages",
Usage: "Upload Grafana packages", Usage: "Upload Grafana packages",

@ -0,0 +1,32 @@
// Package verifystorybook contains the sub-command "verify-storybook".
package main
import (
"fmt"
"log"
"path/filepath"
"github.com/grafana/grafana/pkg/infra/fs"
"github.com/urfave/cli/v2"
)
// VerifyStorybook Action implements the sub-command "verify-storybook".
func VerifyStorybook(c *cli.Context) error {
const grafanaDir = "."
paths := []string{
"packages/grafana-ui/dist/storybook/index.html",
"packages/grafana-ui/dist/storybook/iframe.html"}
for _, p := range paths {
exists, err := fs.Exists(filepath.Join(grafanaDir, p))
if err != nil {
return cli.NewExitError(fmt.Sprintf("failed to verify Storybook build: %s", err), 1)
}
if !exists {
return fmt.Errorf("failed to verify Storybook build, missing %q", p)
}
}
log.Printf("Successfully verified Storybook integrity")
return nil
}

@ -246,7 +246,7 @@ def build_storybook_step(ver_mode):
}, },
'commands': [ 'commands': [
'yarn storybook:build', 'yarn storybook:build',
'./bin/grabpl verify-storybook', './bin/build verify-storybook',
], ],
'when': get_trigger_storybook(ver_mode), 'when': get_trigger_storybook(ver_mode),
} }

Loading…
Cancel
Save