Identity: Remove id token from extra info (#91169)

joey/trace-view-skipHeader
Ryan McKinley 10 months ago committed by GitHub
parent 68f1a0619d
commit 10170cb839
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      pkg/services/apiserver/auth/authenticator/signedinuser_test.go
  2. 9
      pkg/services/authn/identity.go
  3. 9
      pkg/services/user/identity.go

@ -47,7 +47,6 @@ func TestSignedInUser(t *testing.T) {
require.Equal(t, u.GetName(), res.User.GetName())
require.Equal(t, u.GetUID(), res.User.GetUID())
require.Equal(t, []string{"1", "2"}, res.User.GetGroups())
require.Empty(t, res.User.GetExtra()["id-token"])
})
t.Run("should set ID token when available", func(t *testing.T) {
@ -72,7 +71,6 @@ func TestSignedInUser(t *testing.T) {
require.Equal(t, u.GetName(), res.User.GetName())
require.Equal(t, u.GetUID(), res.User.GetUID())
require.Equal(t, []string{"1", "2"}, res.User.GetGroups())
require.Equal(t, "test-id-token", res.User.GetExtra()["id-token"][0])
})
}

@ -89,14 +89,7 @@ func (i *Identity) GetIdentityType() identity.IdentityType {
// GetExtra implements identity.Requester.
func (i *Identity) GetExtra() map[string][]string {
extra := map[string][]string{}
if i.IDToken != "" {
extra["id-token"] = []string{i.IDToken}
}
if i.GetOrgRole().IsValid() {
extra["user-instance-role"] = []string{string(i.GetOrgRole())}
}
return extra
return map[string][]string{}
}
// GetGroups implements identity.Requester.

@ -94,14 +94,7 @@ func (u *SignedInUser) GetName() string {
// GetExtra implements Requester.
func (u *SignedInUser) GetExtra() map[string][]string {
extra := map[string][]string{}
if u.IDToken != "" {
extra["id-token"] = []string{u.IDToken}
}
if u.OrgRole.IsValid() {
extra["user-instance-role"] = []string{string(u.GetOrgRole())}
}
return extra
return map[string][]string{}
}
// GetGroups implements Requester.

Loading…
Cancel
Save