Loki: Remove $__rate_interval from LogQL autocomplete (#31825)

* Remove $__rate_interval from LogQL autocomplete

* Remove unused const
pull/31888/head
Piotr Jamróz 4 years ago committed by GitHub
parent 3b6168eb4a
commit 31cc36dbb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 14
      public/app/plugins/datasource/loki/language_provider.ts
  2. 2
      public/app/plugins/datasource/prometheus/language_utils.ts
  3. 2
      public/app/plugins/datasource/prometheus/promql.ts

@ -15,7 +15,6 @@ import syntax, { FUNCTIONS, PIPE_PARSERS, PIPE_OPERATORS } from './syntax';
import { LokiQuery } from './types'; import { LokiQuery } from './types';
import { dateTime, AbsoluteTimeRange, LanguageProvider, HistoryItem } from '@grafana/data'; import { dateTime, AbsoluteTimeRange, LanguageProvider, HistoryItem } from '@grafana/data';
import { PromQuery } from '../prometheus/types'; import { PromQuery } from '../prometheus/types';
import { RATE_RANGES } from '../prometheus/promql';
import LokiDatasource from './datasource'; import LokiDatasource from './datasource';
import { CompletionItem, TypeaheadInput, TypeaheadOutput, CompletionItemGroup } from '@grafana/ui'; import { CompletionItem, TypeaheadInput, TypeaheadOutput, CompletionItemGroup } from '@grafana/ui';
@ -26,6 +25,19 @@ const EMPTY_SELECTOR = '{}';
const HISTORY_ITEM_COUNT = 10; const HISTORY_ITEM_COUNT = 10;
const HISTORY_COUNT_CUTOFF = 1000 * 60 * 60 * 24; // 24h const HISTORY_COUNT_CUTOFF = 1000 * 60 * 60 * 24; // 24h
const NS_IN_MS = 1000000; const NS_IN_MS = 1000000;
// When changing RATE_RANGES, check if Prometheus/PromQL ranges should be changed too
// @see public/app/plugins/datasource/prometheus/promql.ts
const RATE_RANGES: CompletionItem[] = [
{ label: '$__interval', sortText: '$__interval' },
{ label: '1m', sortText: '00:01:00' },
{ label: '5m', sortText: '00:05:00' },
{ label: '10m', sortText: '00:10:00' },
{ label: '30m', sortText: '00:30:00' },
{ label: '1h', sortText: '01:00:00' },
{ label: '1d', sortText: '24:00:00' },
];
export const LABEL_REFRESH_INTERVAL = 1000 * 30; // 30sec export const LABEL_REFRESH_INTERVAL = 1000 * 30; // 30sec
const wrapLabel = (label: string) => ({ label, filterText: `\"${label}\"` }); const wrapLabel = (label: string) => ({ label, filterText: `\"${label}\"` });

@ -2,8 +2,6 @@ import { PromMetricsMetadata } from './types';
import { addLabelToQuery } from './add_label_to_query'; import { addLabelToQuery } from './add_label_to_query';
import { SUGGESTIONS_LIMIT } from './language_provider'; import { SUGGESTIONS_LIMIT } from './language_provider';
export const RATE_RANGES = ['1m', '5m', '10m', '30m', '1h'];
export const processHistogramLabels = (labels: string[]) => { export const processHistogramLabels = (labels: string[]) => {
const resultSet: Set<string> = new Set(); const resultSet: Set<string> = new Set();
const regexp = new RegExp('_bucket($|:)'); const regexp = new RegExp('_bucket($|:)');

@ -1,6 +1,8 @@
import { Grammar } from 'prismjs'; import { Grammar } from 'prismjs';
import { CompletionItem } from '@grafana/ui'; import { CompletionItem } from '@grafana/ui';
// When changing RATE_RANGES, check if Loki/LogQL ranges should be changed too
// @see public/app/plugins/datasource/loki/language_provider.ts
export const RATE_RANGES: CompletionItem[] = [ export const RATE_RANGES: CompletionItem[] = [
{ label: '$__interval', sortText: '$__interval' }, { label: '$__interval', sortText: '$__interval' },
{ label: '$__rate_interval', sortText: '$__rate_interval' }, { label: '$__rate_interval', sortText: '$__rate_interval' },

Loading…
Cancel
Save