Tempo: Fix read-only assignment (#79183)

pull/79302/head
Fabrizio 1 year ago committed by GitHub
parent 096a3b148f
commit 42f3d1122b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 10
      public/app/core/components/TraceToMetrics/TraceToMetricsSettings.tsx

@ -135,8 +135,11 @@ export function TraceToMetricsSettings({ options, onOptionsChange }: Props) {
value={query.name} value={query.name}
width={40} width={40}
onChange={(e) => { onChange={(e) => {
let newQueries = options.jsonData.tracesToMetrics?.queries.slice() ?? []; const newQueries = (options.jsonData.tracesToMetrics?.queries ?? []).map(
newQueries[i].name = e.currentTarget.value; (traceToMetricQuery, index) => {
return index === i ? { ...traceToMetricQuery, name: e.currentTarget.value } : traceToMetricQuery;
}
);
updateDatasourcePluginJsonDataOption({ onOptionsChange, options }, 'tracesToMetrics', { updateDatasourcePluginJsonDataOption({ onOptionsChange, options }, 'tracesToMetrics', {
...options.jsonData.tracesToMetrics, ...options.jsonData.tracesToMetrics,
queries: newQueries, queries: newQueries,
@ -175,8 +178,7 @@ export function TraceToMetricsSettings({ options, onOptionsChange }: Props) {
icon="times" icon="times"
type="button" type="button"
onClick={() => { onClick={() => {
let newQueries = options.jsonData.tracesToMetrics?.queries.slice(); const newQueries = options.jsonData.tracesToMetrics?.queries.filter((_, index) => index !== i);
newQueries?.splice(i, 1);
updateDatasourcePluginJsonDataOption({ onOptionsChange, options }, 'tracesToMetrics', { updateDatasourcePluginJsonDataOption({ onOptionsChange, options }, 'tracesToMetrics', {
...options.jsonData.tracesToMetrics, ...options.jsonData.tracesToMetrics,
queries: newQueries, queries: newQueries,

Loading…
Cancel
Save