Dashboards/E2E: Remove unnecessary `e2e.pages.Dashboards.visit()` invocations (#106070)

e2e/dashboard-new-layouts/dashboards-add-panel.spec.ts

@@ -9,7 +9,6 @@ describe('Dashboard panels', () => {
   });
 
   it('can add a new panel', () => {
-    e2e.pages.Dashboards.visit();
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
     cy.contains(DASHBOARD_NAME).should('be.visible');
 

e2e/dashboard-new-layouts/dashboards-edit-adhoc-variables.spec.ts

@@ -11,8 +11,6 @@ describe('Dashboard edit - Ad hoc variables', () => {
   });
 
   it('can add a new adhoc variable', () => {
-    e2e.pages.Dashboards.visit();
-
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
     cy.contains(DASHBOARD_NAME).should('be.visible');
 

e2e/dashboard-new-layouts/dashboards-edit-panel-title-description.spec.ts

@@ -10,7 +10,6 @@ describe('Dashboard', () => {
   });
 
   it('can edit panel title and description', () => {
-    e2e.pages.Dashboards.visit();
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
 
     e2e.flows.scenes.toggleEditMode();

e2e/dashboard-new-layouts/dashboards-edit-panel-transparent-bg.spec.ts

@@ -8,7 +8,6 @@ describe('Dashboard', () => {
   });
 
   it('can toggle transparent background switch', () => {
-    e2e.pages.Dashboards.visit();
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
 
     e2e.flows.scenes.toggleEditMode();

e2e/dashboard-new-layouts/dashboards-edit-query-variables.spec.ts

@@ -11,8 +11,6 @@ describe('Dashboard edit - Query variable', () => {
   });
 
   it('can add a new query variable', () => {
-    e2e.pages.Dashboards.visit();
-
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
     cy.contains(DASHBOARD_NAME).should('be.visible');
 

e2e/dashboard-new-layouts/dashboards-edit-variables.spec.ts

@@ -11,8 +11,6 @@ describe('Dashboard edit - variables', () => {
   });
 
   it('can add a new custom variable', () => {
-    e2e.pages.Dashboards.visit();
-
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
     cy.contains(DASHBOARD_NAME).should('be.visible');
 
@@ -41,8 +39,6 @@ describe('Dashboard edit - variables', () => {
   });
 
   it('can add a new constant variable', () => {
-    e2e.pages.Dashboards.visit();
-
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
     cy.contains(DASHBOARD_NAME).should('be.visible');
 
@@ -73,8 +69,6 @@ describe('Dashboard edit - variables', () => {
   });
 
   it('can add a new textbox variable', () => {
-    e2e.pages.Dashboards.visit();
-
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
     cy.contains(DASHBOARD_NAME).should('be.visible');
 
@@ -109,8 +103,6 @@ describe('Dashboard edit - variables', () => {
   });
 
   it('can add a new interval variable', () => {
-    e2e.pages.Dashboards.visit();
-
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
     cy.contains(DASHBOARD_NAME).should('be.visible');
 

e2e/dashboard-new-layouts/dashboards-move-panel.spec.ts

@@ -8,7 +8,6 @@ describe('Dashboard', () => {
   });
 
   it('can drag and drop panels', () => {
-    e2e.pages.Dashboards.visit();
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
 
     e2e.flows.scenes.toggleEditMode();

e2e/dashboard-new-layouts/dashboards-remove-panel.spec.ts

@@ -8,7 +8,6 @@ describe('Dashboard panels', () => {
   });
 
   it('can remove a panel', () => {
-    e2e.pages.Dashboards.visit();
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
 
     e2e.flows.scenes.toggleEditMode();
@@ -22,7 +21,6 @@ describe('Dashboard panels', () => {
   });
 
   it('can remove several panels at once', () => {
-    e2e.pages.Dashboards.visit();
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
 
     e2e.flows.scenes.toggleEditMode();

e2e/dashboard-new-layouts/dashboards-title-description.spec.ts

@@ -8,7 +8,6 @@ describe('Dashboard', () => {
   });
 
   it('can change dashboard description and title', () => {
-    e2e.pages.Dashboards.visit();
     e2e.flows.openDashboard({ uid: `${PAGE_UNDER_TEST}?orgId=1` });
 
     e2e.flows.scenes.toggleEditMode();