enable rule jsx-a11y/role-supports-aria-props (#55839)

pull/55844/head
Ashley Harrison 3 years ago committed by GitHub
parent 422b22a513
commit 527c00dae5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      .eslintrc
  2. 2
      public/app/core/components/NavBar/NavBarMenuItem.tsx

@ -91,7 +91,7 @@
"jsx-a11y/no-redundant-roles": "error", "jsx-a11y/no-redundant-roles": "error",
"jsx-a11y/no-static-element-interactions": "off", "jsx-a11y/no-static-element-interactions": "off",
"jsx-a11y/role-has-required-aria-props": "off", "jsx-a11y/role-has-required-aria-props": "off",
"jsx-a11y/role-supports-aria-props": "off", "jsx-a11y/role-supports-aria-props": "error",
"jsx-a11y/scope": "error", "jsx-a11y/scope": "error",
"jsx-a11y/tabindex-no-positive": "error" "jsx-a11y/tabindex-no-positive": "error"
}, },

@ -65,7 +65,7 @@ export function NavBarMenuItem({
if (isMobile) { if (isMobile) {
return isDivider ? ( return isDivider ? (
<li data-testid="dropdown-child-divider" className={styles.divider} tabIndex={-1} aria-disabled /> <div data-testid="dropdown-child-divider" className={styles.divider} tabIndex={-1} aria-disabled />
) : ( ) : (
<li className={styles.listItem}>{element}</li> <li className={styles.listItem}>{element}</li>
); );

Loading…
Cancel
Save