Tempo: Add `}` when `{` is inserted automatically (#80113)

pull/80375/head
Hariom Maurya 1 year ago committed by GitHub
parent c9dd12851f
commit 5c8e88d6ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      public/app/plugins/datasource/tempo/traceql/autocomplete.test.ts
  2. 4
      public/app/plugins/datasource/tempo/traceql/autocomplete.ts

@ -137,8 +137,8 @@ describe('CompletionProvider', () => {
const { provider, model } = setup('', 0, v1Tags);
const result = await provider.provideCompletionItems(model, emptyPosition);
expect((result! as monacoTypes.languages.CompletionList).suggestions).toEqual([
...scopes.map((s) => expect.objectContaining({ label: s, insertText: `{ ${s}` })),
...intrinsics.map((s) => expect.objectContaining({ label: s, insertText: `{ ${s}` })),
...scopes.map((s) => expect.objectContaining({ label: s, insertText: `{ ${s}$0 }` })),
...intrinsics.map((s) => expect.objectContaining({ label: s, insertText: `{ ${s}$0 }` })),
expect.objectContaining({ label: 'bar', insertText: '{ .bar' }),
expect.objectContaining({ label: 'foo', insertText: '{ .foo' }),
expect.objectContaining({ label: 'status', insertText: '{ .status' }),
@ -149,8 +149,8 @@ describe('CompletionProvider', () => {
const { provider, model } = setup('', 0, undefined, v2Tags);
const result = await provider.provideCompletionItems(model, emptyPosition);
expect((result! as monacoTypes.languages.CompletionList).suggestions).toEqual([
...scopes.map((s) => expect.objectContaining({ label: s, insertText: `{ ${s}` })),
...intrinsics.map((s) => expect.objectContaining({ label: s, insertText: `{ ${s}` })),
...scopes.map((s) => expect.objectContaining({ label: s, insertText: `{ ${s}$0 }` })),
...intrinsics.map((s) => expect.objectContaining({ label: s, insertText: `{ ${s}$0 }` })),
expect.objectContaining({ label: 'cluster', insertText: '{ .cluster' }),
expect.objectContaining({ label: 'container', insertText: '{ .container' }),
expect.objectContaining({ label: 'db', insertText: '{ .db' }),

@ -305,8 +305,8 @@ export class CompletionProvider implements monacoTypes.languages.CompletionItemP
return [];
}
case 'EMPTY': {
return this.getScopesCompletions('{ ')
.concat(this.getIntrinsicsCompletions('{ '))
return this.getScopesCompletions('{ ', '$0 }')
.concat(this.getIntrinsicsCompletions('{ ', '$0 }'))
.concat(this.getTagsCompletions('{ .'));
}
case 'SPANSET_EMPTY':

Loading…
Cancel
Save