test(dashboard): add failing test for deleting dashboards

pull/5622/head
bergquist 9 years ago
parent 44310921b5
commit 5d5999561a
  1. 2
      pkg/services/sqlstore/alerting.go
  2. 14
      pkg/services/sqlstore/dashboard_test.go

@ -11,6 +11,8 @@ func init() {
}
func SaveAlerts(cmd *m.SaveAlertsCommand) error {
//this function should be refactored
fmt.Printf("Saving alerts for dashboard %v\n", cmd.DashboardId)
alerts, err := GetAlertsByDashboardId(cmd.DashboardId)

@ -5,6 +5,7 @@ import (
. "github.com/smartystreets/goconvey/convey"
"github.com/gosimple/slug"
"github.com/grafana/grafana/pkg/components/simplejson"
m "github.com/grafana/grafana/pkg/models"
"github.com/grafana/grafana/pkg/services/search"
@ -55,6 +56,19 @@ func TestDashboardDataAccess(t *testing.T) {
So(query.Result.Slug, ShouldEqual, "test-dash-23")
})
Convey("Should be able to delete dashboard", func() {
insertTestDashboard("delete me", 1, "delete this")
dashboardSlug := slug.Make("delete me")
err := DeleteDashboard(&m.DeleteDashboardCommand{
Slug: dashboardSlug,
OrgId: 1,
})
So(err, ShouldBeNil)
})
Convey("Should return error if no dashboard is updated", func() {
cmd := m.SaveDashboardCommand{
OrgId: 1,

Loading…
Cancel
Save