Chore: Add timeout for storybook e2e, only run on changes to @grafana/ui (#90035)

* add timeout for storybook, only run on changes to @grafana/ui

* add comment to trigger verify-storybook

* remove test comment

* add comment

* use a later version of wait-on

* remove comment and hardcode wait-on version
pull/90047/head
Ashley Harrison 12 months ago committed by GitHub
parent 4671b7d5ae
commit 5ed5a2de2a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 13
      .drone.yml
  2. 2
      scripts/drone/events/pr.star
  3. 2
      scripts/drone/steps/lib.star

@ -135,7 +135,7 @@ steps:
image: node:20.9.0-alpine image: node:20.9.0-alpine
name: start-storybook name: start-storybook
- commands: - commands:
- npx wait-on@7.0.1 http://$HOST:$PORT - npx wait-on@7.2.0 -t 1m http://$HOST:$PORT
- yarn e2e:storybook - yarn e2e:storybook
depends_on: depends_on:
- start-storybook - start-storybook
@ -151,11 +151,8 @@ trigger:
exclude: exclude:
- docs/** - docs/**
- '*.md' - '*.md'
- pkg/** include:
- packaging/** - packages/grafana-ui/**
- go.sum
- go.mod
include: []
type: docker type: docker
volumes: volumes:
- host: - host:
@ -1910,7 +1907,7 @@ steps:
image: node:20.9.0-alpine image: node:20.9.0-alpine
name: start-storybook name: start-storybook
- commands: - commands:
- npx wait-on@7.0.1 http://$HOST:$PORT - npx wait-on@7.2.0 -t 1m http://$HOST:$PORT
- yarn e2e:storybook - yarn e2e:storybook
depends_on: depends_on:
- start-storybook - start-storybook
@ -5181,6 +5178,6 @@ kind: secret
name: gcr_credentials name: gcr_credentials
--- ---
kind: signature kind: signature
hmac: 6c273dec437d3ae5ae9a42450c57956259a691ff0df7c161a57eaa683c867acd hmac: c4a656d676b1228248f6948ac0347aea1d67016429aa24351d0a5c3e2d7dc617
... ...

@ -87,7 +87,7 @@ def pr_pipelines():
), ),
verify_storybook( verify_storybook(
get_pr_trigger( get_pr_trigger(
exclude_paths = ["pkg/**", "packaging/**", "go.sum", "go.mod"], include_paths = ["packages/grafana-ui/**"],
), ),
ver_mode, ver_mode,
), ),

@ -799,7 +799,7 @@ def e2e_storybook_step():
"PORT": "9001", "PORT": "9001",
}, },
"commands": [ "commands": [
"npx wait-on@7.0.1 http://$HOST:$PORT", "npx wait-on@7.2.0 -t 1m http://$HOST:$PORT",
"yarn e2e:storybook", "yarn e2e:storybook",
], ],
} }

Loading…
Cancel
Save