fix some types

pull/105986/head
ismail simsek 2 months ago
parent 5535ff6b5c
commit 7e64b93b5f
No known key found for this signature in database
  1. 5
      .betterer.results
  2. 4
      packages/grafana-prometheus/src/components/metrics-browser/MetricsBrowserContext.tsx
  3. 6
      packages/grafana-prometheus/src/components/metrics-browser/useMetricsLabelsValues.ts
  4. 4
      packages/grafana-prometheus/src/components/monaco-query-field/MonacoQueryFieldProps.ts
  5. 7
      packages/grafana-prometheus/src/components/monaco-query-field/monaco-completion-provider/data_provider.ts
  6. 4
      packages/grafana-prometheus/src/components/useMetricsState.ts
  7. 4
      packages/grafana-prometheus/src/components/usePromQueryFieldEffects.ts

@ -437,7 +437,10 @@ exports[`better eslint`] = {
],
"packages/grafana-prometheus/src/language_provider.ts:5381": [
[0, 0, 0, "Unexpected any. Specify a different type.", "0"],
[0, 0, 0, "Unexpected any. Specify a different type.", "1"]
[0, 0, 0, "Unexpected any. Specify a different type.", "1"],
[0, 0, 0, "Unexpected any. Specify a different type.", "2"],
[0, 0, 0, "Unexpected any. Specify a different type.", "3"],
[0, 0, 0, "Unexpected any. Specify a different type.", "4"]
],
"packages/grafana-prometheus/src/language_utils.ts:5381": [
[0, 0, 0, "Do not use any type assertions.", "0"]

@ -2,7 +2,7 @@ import { createContext, PropsWithChildren, useCallback, useContext, useMemo } fr
import { TimeRange } from '@grafana/data';
import PromQlLanguageProvider from '../../language_provider';
import { PrometheusLanguageProviderInterface } from '../../language_provider';
import { buildSelector } from './selectorBuilder';
import { Metric } from './types';
@ -50,7 +50,7 @@ const MetricsBrowserContext = createContext<MetricsBrowserContextType | undefine
type MetricsBrowserProviderProps = {
timeRange: TimeRange;
languageProvider: PromQlLanguageProvider;
languageProvider: PrometheusLanguageProviderInterface;
onChange: (selector: string) => void;
};

@ -1,14 +1,14 @@
import { useCallback, useEffect, useRef, useState, useMemo } from 'react';
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { useDebounce } from 'react-use';
import { TimeRange } from '@grafana/data';
import PromQlLanguageProvider from '../../language_provider';
import { PrometheusLanguageProviderInterface } from '../../language_provider';
import { buildSelector } from './selectorBuilder';
import { DEFAULT_SERIES_LIMIT, EMPTY_SELECTOR, LAST_USED_LABELS_KEY, Metric, METRIC_LABEL } from './types';
export const useMetricsLabelsValues = (timeRange: TimeRange, languageProvider: PromQlLanguageProvider) => {
export const useMetricsLabelsValues = (timeRange: TimeRange, languageProvider: PrometheusLanguageProviderInterface) => {
const timeRangeRef = useRef<TimeRange>(timeRange);
const lastSeriesLimitRef = useRef(DEFAULT_SERIES_LIMIT);
const isInitializedRef = useRef(false);

@ -2,7 +2,7 @@
import { HistoryItem, TimeRange } from '@grafana/data';
import { PrometheusDatasource } from '../../datasource';
import type PromQlLanguageProvider from '../../language_provider';
import { PrometheusLanguageProviderInterface } from '../../language_provider';
import { PromQuery } from '../../types';
// we need to store this in a separate file,
@ -11,7 +11,7 @@ import { PromQuery } from '../../types';
// props as the sync-component.
export type Props = {
initialValue: string;
languageProvider: PromQlLanguageProvider;
languageProvider: PrometheusLanguageProviderInterface;
history: Array<HistoryItem<PromQuery>>;
placeholder: string;
onRunQuery: (value: string) => void;

@ -1,7 +1,6 @@
import { HistoryItem } from '@grafana/data';
import type { Monaco } from '@grafana/ui'; // used in TSDoc `@link` below
import PromQlLanguageProvider from '../../../language_provider';
import { PrometheusLanguageProviderInterface } from '../../../language_provider';
import { PromQuery } from '../../../types';
import { isValidLegacyName } from '../../../utf8_support';
@ -31,12 +30,12 @@ interface Metric {
}
export interface DataProviderParams {
languageProvider: PromQlLanguageProvider;
languageProvider: PrometheusLanguageProviderInterface;
historyProvider: Array<HistoryItem<PromQuery>>;
}
export class DataProvider {
readonly languageProvider: PromQlLanguageProvider;
readonly languageProvider: PrometheusLanguageProviderInterface;
readonly historyProvider: Array<HistoryItem<PromQuery>>;
readonly getSeriesLabels: typeof this.languageProvider.getSeriesLabels;
readonly getSeriesValues: typeof this.languageProvider.getSeriesValues;

@ -1,7 +1,7 @@
import { useMemo } from 'react';
import { PrometheusDatasource } from '../datasource';
import PromQlLanguageProvider from '../language_provider';
import { PrometheusLanguageProviderInterface } from '../language_provider';
function getChooserText(metricsLookupDisabled: boolean, hasSyntax: boolean, hasMetrics: boolean) {
if (metricsLookupDisabled) {
@ -21,7 +21,7 @@ function getChooserText(metricsLookupDisabled: boolean, hasSyntax: boolean, hasM
export function useMetricsState(
datasource: PrometheusDatasource,
languageProvider: PromQlLanguageProvider,
languageProvider: PrometheusLanguageProviderInterface,
syntaxLoaded: boolean
) {
return useMemo(() => {

@ -2,13 +2,13 @@ import { MutableRefObject, useEffect, useRef } from 'react';
import { DataFrame, DateTime, TimeRange } from '@grafana/data';
import PromQlLanguageProvider from '../language_provider';
import { PrometheusLanguageProviderInterface } from '../language_provider';
import { roundMsToMin } from '../language_utils';
import { CancelablePromise } from './cancelable-promise';
export function usePromQueryFieldEffects(
languageProvider: PromQlLanguageProvider,
languageProvider: PrometheusLanguageProviderInterface,
range: TimeRange | undefined,
series: DataFrame[] | undefined,
refreshMetrics: (languageProviderInitRef: MutableRefObject<CancelablePromise<unknown> | null>) => Promise<void>,

Loading…
Cancel
Save