DashboardSettings: Fixed scrolling (#23108)

pull/23112/head
Torkel Ödegaard 5 years ago committed by GitHub
parent 4c5005e575
commit 936594f5d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx
  2. 6
      public/sass/components/_dashboard_settings.scss
  3. 2
      public/sass/components/_navbar.scss

@ -9,6 +9,7 @@ import { DashboardModel } from '../../state/DashboardModel';
import { BackButton } from 'app/core/components/BackButton/BackButton'; import { BackButton } from 'app/core/components/BackButton/BackButton';
import { e2e } from '@grafana/e2e'; import { e2e } from '@grafana/e2e';
import { updateLocation } from 'app/core/actions'; import { updateLocation } from 'app/core/actions';
import { CustomScrollbar } from '@grafana/ui';
export interface Props { export interface Props {
dashboard: DashboardModel | null; dashboard: DashboardModel | null;
@ -57,7 +58,9 @@ export class DashboardSettings extends PureComponent<Props> {
<span>{dashboard.title} / Settings</span> <span>{dashboard.title} / Settings</span>
</div> </div>
</div> </div>
<CustomScrollbar>
<div className="dashboard-settings__body1" ref={element => (this.element = element)} /> <div className="dashboard-settings__body1" ref={element => (this.element = element)} />
</CustomScrollbar>
</div> </div>
); );
} }

@ -8,15 +8,17 @@
bottom: 0; bottom: 0;
z-index: $zindex-modal; z-index: $zindex-modal;
background: $body-bg; background: $body-bg;
display: flex;
flex-direction: column;
} }
.dashboard-settings__body1 { .dashboard-settings__body1 {
height: calc(100% - #{$navbarHeight}); min-height: 100%;
width: 100%; width: 100%;
} }
.dashboard-settings__body2 { .dashboard-settings__body2 {
height: 100%; min-height: 100%;
width: 100%; width: 100%;
display: flex; display: flex;
flex-direction: row; flex-direction: row;

@ -4,7 +4,7 @@
height: $navbarHeight; height: $navbarHeight;
padding: 0 16px 0 60px; padding: 0 16px 0 60px;
display: flex; display: flex;
flex-grow: 1; flex-grow: 0;
border-bottom: 1px solid transparent; border-bottom: 1px solid transparent;
transition-duration: 350ms; transition-duration: 350ms;
transition-timing-function: ease-in-out; transition-timing-function: ease-in-out;

Loading…
Cancel
Save