SQL: change buttons aria-label to title (#88744)

pull/88692/head^2
Zoltán Bedi 12 months ago committed by GitHub
parent 56ea7fd2c4
commit a1851b4c0a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      packages/grafana-sql/src/components/visual-query-builder/GroupByRow.tsx
  2. 4
      packages/grafana-sql/src/components/visual-query-builder/SelectRow.tsx

@ -51,7 +51,7 @@ function makeRenderColumn({ options }: { options?: Array<SelectableValue<string>
menuShouldPortal menuShouldPortal
onChange={({ value }) => value && onChangeItem(setGroupByField(value))} onChange={({ value }) => value && onChangeItem(setGroupByField(value))}
/> />
<AccessoryButton aria-label="Remove group by column" icon="times" variant="secondary" onClick={onDeleteItem} /> <AccessoryButton title="Remove group by column" icon="times" variant="secondary" onClick={onDeleteItem} />
</InputGroup> </InputGroup>
); );
}; };

@ -150,7 +150,7 @@ export function SelectRow({ sql, format, columns, onSqlChange, functions }: Sele
/> />
</EditorField> </EditorField>
<Button <Button
aria-label="Remove" title="Remove column"
type="button" type="button"
icon="trash-alt" icon="trash-alt"
variant="secondary" variant="secondary"
@ -164,9 +164,9 @@ export function SelectRow({ sql, format, columns, onSqlChange, functions }: Sele
type="button" type="button"
onClick={addColumn} onClick={addColumn}
variant="secondary" variant="secondary"
title="Add column"
size="md" size="md"
icon="plus" icon="plus"
aria-label="Add"
className={styles.addButton} className={styles.addButton}
/> />
</Stack> </Stack>

Loading…
Cancel
Save