turn on tabindex-no-positive rule (#55830)

3 years ago · afdb094983
parent d17ab82b98
commit afdb094983
2 changed files with 5 additions and 5 deletions
--- a/.eslintrc
+++ b/.eslintrc
@ -93,7 +93,7 @@
    "jsx-a11y/role-has-required-aria-props": "off",
    "jsx-a11y/role-supports-aria-props": "off",
    "jsx-a11y/scope": "error",
-    "jsx-a11y/tabindex-no-positive": "off"
+    "jsx-a11y/tabindex-no-positive": "error"
  },
  "overrides": [
    {
--- a/packages/grafana-ui/src/components/Dropdown/Dropdown.story.tsx
+++ b/packages/grafana-ui/src/components/Dropdown/Dropdown.story.tsx
@ -27,10 +27,10 @@ const meta: ComponentMeta<typeof Dropdown> = {
 export function Examples() {
  const menu = (
    <Menu>
-      <Menu.Item label="View settings" tabIndex={0} />
+      <Menu.Item label="View settings" />
-      <Menu.Item label="Edit actions" tabIndex={1} />
+      <Menu.Item label="Edit actions" />
-      <Menu.Item label="Share" tabIndex={2} />
+      <Menu.Item label="Share" />
-      <Menu.Item label="Delete" tabIndex={3} />
+      <Menu.Item label="Delete" />
    </Menu>
  );