Drilldown: Require `datasources:explore` RBAC action (#101366)

Drilldown: Require `datasources:explore` acton
pull/101225/head^2
Sven Grossmann 4 months ago committed by GitHub
parent c3505f0864
commit b5faf5d9a1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 3
      pkg/api/accesscontrol.go
  2. 2
      pkg/api/api.go
  3. 1
      pkg/services/accesscontrol/models.go
  4. 2
      pkg/services/navtree/navtreeimpl/navtree.go

@ -66,9 +66,6 @@ func (hs *HTTPServer) declareFixedRoles() error {
{ {
Action: ac.ActionDatasourcesExplore, Action: ac.ActionDatasourcesExplore,
}, },
{
Action: ac.ActionDatasourcesDrilldown,
},
}, },
}, },
Grants: []string{string(org.RoleEditor)}, Grants: []string{string(org.RoleEditor)},

@ -183,7 +183,7 @@ func (hs *HTTPServer) registerRoutes() {
} }
r.Get("/explore", authorize(ac.EvalPermission(ac.ActionDatasourcesExplore)), hs.Index) r.Get("/explore", authorize(ac.EvalPermission(ac.ActionDatasourcesExplore)), hs.Index)
r.Get("/drilldown", authorize(ac.EvalPermission(ac.ActionDatasourcesDrilldown)), hs.Index) r.Get("/drilldown", authorize(ac.EvalPermission(ac.ActionDatasourcesExplore)), hs.Index)
r.Get("/playlists/", reqSignedIn, hs.Index) r.Get("/playlists/", reqSignedIn, hs.Index)
r.Get("/playlists/*", reqSignedIn, hs.Index) r.Get("/playlists/*", reqSignedIn, hs.Index)

@ -387,7 +387,6 @@ const (
// Datasources actions // Datasources actions
ActionDatasourcesExplore = "datasources:explore" ActionDatasourcesExplore = "datasources:explore"
ActionDatasourcesDrilldown = "datasources:drilldown"
// Global Scopes // Global Scopes
ScopeGlobalUsersAll = "global.users:*" ScopeGlobalUsersAll = "global.users:*"

@ -130,7 +130,7 @@ func (s *ServiceImpl) GetNavTree(c *contextmodel.ReqContext, prefs *pref.Prefere
}) })
} }
if hasAccess(ac.EvalPermission(ac.ActionDatasourcesDrilldown)) { if hasAccess(ac.EvalPermission(ac.ActionDatasourcesExplore)) {
drilldownChildNavLinks := s.buildDrilldownNavLinks(c) drilldownChildNavLinks := s.buildDrilldownNavLinks(c)
treeRoot.AddSection(&navtree.NavLink{ treeRoot.AddSection(&navtree.NavLink{
Text: "Drilldown", Text: "Drilldown",

Loading…
Cancel
Save