Fix: Propagate unhandled errors when saving Dashboard (#24081)

* only handle error for cases we handle

* added missing case

* remove not used import
pull/24100/head
Peter Holmberg 5 years ago committed by GitHub
parent dda8caf48c
commit ca7a373983
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 14
      public/app/features/dashboard/components/SaveDashboard/SaveDashboardErrorProxy.tsx

@ -25,7 +25,7 @@ export const SaveDashboardErrorProxy: React.FC<SaveDashboardErrorProxyProps> = (
const { onDashboardSave } = useDashboardSave(dashboard);
useEffect(() => {
if (error.data) {
if (error.data && isHandledError(error.data.status)) {
error.isHandled = true;
}
}, []);
@ -106,6 +106,18 @@ const ConfirmPluginDashboardSaveModal: React.FC<SaveDashboardModalProps> = ({ on
);
};
const isHandledError = (errorStatus: string) => {
switch (errorStatus) {
case 'version-mismatch':
case 'name-exists':
case 'plugin-dashboard':
return true;
default:
return false;
}
};
const getConfirmPluginDashboardSaveModalStyles = stylesFactory((theme: GrafanaTheme) => ({
modal: css`
width: 500px;

Loading…
Cancel
Save