apitech
/
grafana
mirror of https://github.com/grafana/grafana
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Chore: Move Prometheus datasorce tests from specs folder and merge duplicated test files (#20755)

Browse Source
pull/20814/head
Ivana Huckova 6 years ago committed by GitHub
parent 87d19787b4
commit e68e93f595
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 1843 additions and 1885 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 2
      public/app/plugins/datasource/prometheus/add_label_to_query.test.ts
  2. 1709
      public/app/plugins/datasource/prometheus/datasource.test.ts
  3. 2
      public/app/plugins/datasource/prometheus/language_utils.test.ts
  4. 6
      public/app/plugins/datasource/prometheus/metric_find_query.test.ts
  5. 2
      public/app/plugins/datasource/prometheus/module.test.ts
  6. 153
      public/app/plugins/datasource/prometheus/query_hints.test.ts
  7. 2
      public/app/plugins/datasource/prometheus/result_transformer.test.ts
  8. 1696
      public/app/plugins/datasource/prometheus/specs/datasource.test.ts
  9. 152
      public/app/plugins/datasource/prometheus/specs/query_hints.test.ts

2
public/app/plugins/datasource/prometheus/specs/add_label_to_query.test.ts → public/app/plugins/datasource/prometheus/add_label_to_query.test.ts
Unescape View File

@ -1,4 +1,4 @@
import { addLabelToQuery, addLabelToSelector, keepSelectorFilters } from '../add_label_to_query';
import { addLabelToQuery, addLabelToSelector, keepSelectorFilters } from './add_label_to_query';
describe('addLabelToQuery()', () => {
it('should add label to simple query', () => {

1709
public/app/plugins/datasource/prometheus/datasource.test.ts
View File

File diff suppressed because it is too large Load Diff

2
public/app/plugins/datasource/prometheus/specs/language_utils.test.ts → public/app/plugins/datasource/prometheus/language_utils.test.ts
Unescape View File

@ -1,4 +1,4 @@
import { expandRecordingRules, parseSelector } from '../language_utils';
import { expandRecordingRules, parseSelector } from './language_utils';
describe('parseSelector()', () => {
let parsed;

6
public/app/plugins/datasource/prometheus/specs/metric_find_query.test.ts → public/app/plugins/datasource/prometheus/metric_find_query.test.ts
Unescape View File

@ -1,7 +1,7 @@
import { PrometheusDatasource } from '../datasource';
import PrometheusMetricFindQuery from '../metric_find_query';
import { PrometheusDatasource } from './datasource';
import PrometheusMetricFindQuery from './metric_find_query';
import { toUtc, DataSourceInstanceSettings } from '@grafana/data';
import { PromOptions } from '../types';
import { PromOptions } from './types';
import templateSrv from 'app/features/templating/template_srv';
import { getTimeSrv, TimeSrv } from 'app/features/dashboard/services/TimeSrv';

2
public/app/plugins/datasource/prometheus/specs/module.test.ts → public/app/plugins/datasource/prometheus/module.test.ts
Unescape View File

@ -1,4 +1,4 @@
import { plugin as PrometheusDatasourcePlugin } from '../module';
import { plugin as PrometheusDatasourcePlugin } from './module';
describe('module', () => {
it('should have metrics query field in panels and Explore', () => {

153
public/app/plugins/datasource/prometheus/query_hints.test.ts
Unescape View File

@ -1,6 +1,155 @@
import { getQueryHints } from './query_hints';
import { getQueryHints, SUM_HINT_THRESHOLD_COUNT } from './query_hints';
//////
describe('getQueryHints()', () => {
it('returns no hints for no series', () => {
expect(getQueryHints('', [])).toEqual(null);
});
it('returns no hints for empty series', () => {
expect(getQueryHints('', [{ datapoints: [] }])).toEqual(null);
});
it('returns no hint for a monotonically decreasing series', () => {
const series = [
{
datapoints: [
[23, 1000],
[22, 1001],
],
},
];
const hints = getQueryHints('metric', series);
expect(hints).toEqual(null);
});
it('returns no hint for a flat series', () => {
const series = [
{
datapoints: [
[null, 1000],
[23, 1001],
[null, 1002],
[23, 1003],
],
},
];
const hints = getQueryHints('metric', series);
expect(hints).toEqual(null);
});
it('returns a rate hint for a monotonically increasing series', () => {
const series = [
{
datapoints: [
[23, 1000],
[24, 1001],
],
},
];
const hints = getQueryHints('metric', series);
expect(hints!.length).toBe(1);
expect(hints![0]).toMatchObject({
label: 'Time series is monotonically increasing.',
fix: {
action: {
type: 'ADD_RATE',
query: 'metric',
},
},
});
});
it('returns no rate hint for a monotonically increasing series that already has a rate', () => {
const series = [
{
datapoints: [
[23, 1000],
[24, 1001],
],
},
];
const hints = getQueryHints('rate(metric[1m])', series);
expect(hints).toEqual(null);
});
it('returns a rate hint w/o action for a complex monotonically increasing series', () => {
const series = [
{
datapoints: [
[23, 1000],
[24, 1001],
],
},
];
const hints = getQueryHints('sum(metric)', series);
expect(hints!.length).toBe(1);
expect(hints![0].label).toContain('rate()');
expect(hints![0].fix).toBeUndefined();
});
it('returns a rate hint for a monotonically increasing series with missing data', () => {
const series = [
{
datapoints: [
[23, 1000],
[null, 1001],
[24, 1002],
],
},
];
const hints = getQueryHints('metric', series);
expect(hints!.length).toBe(1);
expect(hints![0]).toMatchObject({
label: 'Time series is monotonically increasing.',
fix: {
action: {
type: 'ADD_RATE',
query: 'metric',
},
},
});
});
it('returns a histogram hint for a bucket series', () => {
const series = [{ datapoints: [[23, 1000]] }];
const hints = getQueryHints('metric_bucket', series);
expect(hints!.length).toBe(1);
expect(hints![0]).toMatchObject({
label: 'Time series has buckets, you probably wanted a histogram.',
fix: {
action: {
type: 'ADD_HISTOGRAM_QUANTILE',
query: 'metric_bucket',
},
},
});
});
it('returns a sum hint when many time series results are returned for a simple metric', () => {
const seriesCount = SUM_HINT_THRESHOLD_COUNT;
const series = Array.from({ length: seriesCount }, _ => ({
datapoints: [
[0, 0],
[0, 0],
],
}));
const hints = getQueryHints('metric', series);
expect(hints!.length).toBe(1);
expect(hints![0]).toMatchObject({
type: 'ADD_SUM',
label: 'Many time series results returned.',
fix: {
label: 'Consider aggregating with sum().',
action: {
type: 'ADD_SUM',
query: 'metric',
preventSubmit: true,
},
},
});
});
describe('getQueryHints', () => {
describe('when called without datapoints in series', () => {
it('then it should use rows instead and return correct hint', () => {
const series = [

2
public/app/plugins/datasource/prometheus/specs/result_transformer.test.ts → public/app/plugins/datasource/prometheus/result_transformer.test.ts
Unescape View File

@ -1,4 +1,4 @@
import { ResultTransformer } from '../result_transformer';
import { ResultTransformer } from './result_transformer';
import { DataQueryResponseData } from '@grafana/data';
describe('Prometheus Result Transformer', () => {

1696
public/app/plugins/datasource/prometheus/specs/datasource.test.ts
View File

File diff suppressed because it is too large Load Diff

152
public/app/plugins/datasource/prometheus/specs/query_hints.test.ts
Unescape View File

@ -1,152 +0,0 @@
import { getQueryHints, SUM_HINT_THRESHOLD_COUNT } from '../query_hints';
describe('getQueryHints()', () => {
it('returns no hints for no series', () => {
expect(getQueryHints('', [])).toEqual(null);
});
it('returns no hints for empty series', () => {
expect(getQueryHints('', [{ datapoints: [] }])).toEqual(null);
});
it('returns no hint for a monotonically decreasing series', () => {
const series = [
{
datapoints: [
[23, 1000],
[22, 1001],
],
},
];
const hints = getQueryHints('metric', series);
expect(hints).toEqual(null);
});
it('returns no hint for a flat series', () => {
const series = [
{
datapoints: [
[null, 1000],
[23, 1001],
[null, 1002],
[23, 1003],
],
},
];
const hints = getQueryHints('metric', series);
expect(hints).toEqual(null);
});
it('returns a rate hint for a monotonically increasing series', () => {
const series = [
{
datapoints: [
[23, 1000],
[24, 1001],
],
},
];
const hints = getQueryHints('metric', series);
expect(hints!.length).toBe(1);
expect(hints![0]).toMatchObject({
label: 'Time series is monotonically increasing.',
fix: {
action: {
type: 'ADD_RATE',
query: 'metric',
},
},
});
});
it('returns no rate hint for a monotonically increasing series that already has a rate', () => {
const series = [
{
datapoints: [
[23, 1000],
[24, 1001],
],
},
];
const hints = getQueryHints('rate(metric[1m])', series);
expect(hints).toEqual(null);
});
it('returns a rate hint w/o action for a complex monotonically increasing series', () => {
const series = [
{
datapoints: [
[23, 1000],
[24, 1001],
],
},
];
const hints = getQueryHints('sum(metric)', series);
expect(hints!.length).toBe(1);
expect(hints![0].label).toContain('rate()');
expect(hints![0].fix).toBeUndefined();
});
it('returns a rate hint for a monotonically increasing series with missing data', () => {
const series = [
{
datapoints: [
[23, 1000],
[null, 1001],
[24, 1002],
],
},
];
const hints = getQueryHints('metric', series);
expect(hints!.length).toBe(1);
expect(hints![0]).toMatchObject({
label: 'Time series is monotonically increasing.',
fix: {
action: {
type: 'ADD_RATE',
query: 'metric',
},
},
});
});
it('returns a histogram hint for a bucket series', () => {
const series = [{ datapoints: [[23, 1000]] }];
const hints = getQueryHints('metric_bucket', series);
expect(hints!.length).toBe(1);
expect(hints![0]).toMatchObject({
label: 'Time series has buckets, you probably wanted a histogram.',
fix: {
action: {
type: 'ADD_HISTOGRAM_QUANTILE',
query: 'metric_bucket',
},
},
});
});
it('returns a sum hint when many time series results are returned for a simple metric', () => {
const seriesCount = SUM_HINT_THRESHOLD_COUNT;
const series = Array.from({ length: seriesCount }, _ => ({
datapoints: [
[0, 0],
[0, 0],
],
}));
const hints = getQueryHints('metric', series);
expect(hints!.length).toBe(1);
expect(hints![0]).toMatchObject({
type: 'ADD_SUM',
label: 'Many time series results returned.',
fix: {
label: 'Consider aggregating with sum().',
action: {
type: 'ADD_SUM',
query: 'metric',
preventSubmit: true,
},
},
});
});
});
Write Preview
Loading…
Cancel
Save