Typescript: Fixed strict null errors. (#25609)

public/app/plugins/panel/bargauge/BarGaugePanel.tsx

@@ -45,7 +45,7 @@ export class BarGaugePanel extends PureComponent<PanelProps<BarGaugeOptions>> {
     const { value } = valueProps;
     const { hasLinks, getLinks } = value;
 
-    if (!hasLinks) {
+    if (!hasLinks || !getLinks) {
       return this.renderComponent(valueProps, {});
     }
 

public/app/plugins/panel/gauge/GaugePanel.tsx

@@ -35,7 +35,7 @@ export class GaugePanel extends PureComponent<PanelProps<GaugeOptions>> {
     const { value } = valueProps;
     const { getLinks, hasLinks } = value;
 
-    if (!hasLinks) {
+    if (!hasLinks || !getLinks) {
       return this.renderComponent(valueProps, {});
     }
 

public/app/plugins/panel/graph/module.ts

@@ -246,7 +246,7 @@ class GraphCtrl extends MetricsPanelCtrl {
     );
   }
 
-  getDataWarning(): DataWarning {
+  getDataWarning(): DataWarning | undefined {
     const datapointsCount = this.seriesList.reduce((prev, series) => {
       return prev + series.datapoints.length;
     }, 0);
@@ -302,8 +302,7 @@ class GraphCtrl extends MetricsPanelCtrl {
 
       return dataWarning;
     }
-
+    return undefined;
-    return null;
   }
 
   onRender() {

public/app/plugins/panel/news/module.tsx

@@ -1,3 +1,4 @@
+import { isString } from 'lodash';
 import { PanelPlugin } from '@grafana/data';
 import { NewsPanel } from './NewsPanel';
 import { NewsOptions } from './types';
@@ -18,7 +19,7 @@ export const plugin = new PanelPlugin<NewsOptions>(NewsPanel).setPanelOptions(bu
       name: 'Use Proxy',
       description: 'If the feed is unable to connect, consider a CORS proxy',
       showIf: (currentConfig: NewsOptions) => {
-        return currentConfig.feedUrl && !currentConfig.feedUrl.startsWith(PROXY_PREFIX);
+        return isString(currentConfig.feedUrl) && !currentConfig.feedUrl.startsWith(PROXY_PREFIX);
       },
     });
 });

public/app/plugins/panel/singlestat/specs/singlestat.test.ts

@@ -90,7 +90,7 @@ describe('SingleStatCtrl', () => {
     });
 
     it('Should use series avg as default main value', () => {
-      const name = getFieldDisplayName(ctx.data.field);
+      const name = getFieldDisplayName(ctx.data.field!);
       expect(name).toBe('test.cpu1');
     });
 

public/app/plugins/panel/stat/StatPanel.tsx

@@ -65,7 +65,7 @@ export class StatPanel extends PureComponent<PanelProps<StatPanelOptions>> {
     const { value } = valueProps;
     const { getLinks, hasLinks } = value;
 
-    if (!hasLinks) {
+    if (!hasLinks || !getLinks) {
       return this.renderComponent(valueProps, {});
     }
 

scripts/ci-frontend-metrics.sh

@@ -2,9 +2,7 @@
 
 echo -e "Collecting code stats (typescript errors & more)"
 
-
+ERROR_COUNT_LIMIT=724
-
-ERROR_COUNT_LIMIT=726
 DIRECTIVES_LIMIT=172
 CONTROLLERS_LIMIT=139