grafana

Commit Graph

Author	SHA1	Message	Date
Matthew Jacobson	0301d956da	Alerting: Create fewer contact points on migration (#47291 ) * Alerting: Create fewer contact points on migration Previously a new contact point was created for every unique combination of channels attached to any legacy alert. This was very hard to maintain, requiring modifications in every generated contact point. This change deduplicates the generated contact points to a more reasonable state. There should now only be one contact point per legacy channel, and we attached multiple contact points to a route by nesting them. The sole exception to this is if there were multiple default legacy channels, in which case we create a redundant contact point containing all of them used only in the root policy. This allows for a much simpler notification policy structure. Co-authored-by: gotjosh <josue.abreu@gmail.com>	4 years ago
Matthew Jacobson	8972418113	Alerting: Add integration test for AddDashAlertMigration (#47730 ) * Alerting: Add integration test for AddDashAlertMigration * Add more targeted test cases * Apply suggestions from code review Co-authored-by: gotjosh <josue.abreu@gmail.com> * Reorganize file and improve comments * Replace custom sort+trim with go-cmp * Add test for AddDashAlertMigration * Rename test cases to standard format * Apply suggestions from code review Co-authored-by: gotjosh <josue.abreu@gmail.com> * Remove test-only snapshots of PostableUserConfig et al. * Organize imports * Fix linting Co-authored-by: gotjosh <josue.abreu@gmail.com>	4 years ago
Jean-Philippe Quéméner	e135b8531a	Alerting: refactor receiver validation to be reusable (#46103 )	4 years ago
Serge Zaitsev	84a5910e56	Chore: Remove bus from ngalert (#44465 ) * pass notification service down to the notifiers * add ns to all notifiers * remove bus from ngalert notifiers * use smaller interfaces for notificationservice * attempt to fix the tests * remove unused struct field * simplify notification service mock * trying to resolve issues in the tests * make linter happy * make linter even happier * linter, you are annoying	4 years ago
Yuriy Tseretyan	ce0ef0ef5e	create only one folder per dashboard with acl (#44283 )	4 years ago
Armand Grillet	6523486122	Alerting: Make Unified Alerting enabled by default for those who do not use legacy alerting (#42200 ) * update AlertingEnabled and UnifiedAlertingSettings.Enabled to be pointers * add a pseudo migration to fix the AlertingEnabled and UnifiedAlertingSettings.Enabled if the latter is not defined * update the default configuration file to make default value for both 'enabled' flags be undefined Misc * update Migrator to expose DB engine. This is needed for a ualert migration to access the database while the list of migrations is created. * add more verbose failure when migrations do not match Co-authored-by: gotjosh <josue@grafana.com> Co-authored-by: Yuriy Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: gillesdemey <gilles.de.mey@gmail.com>	4 years ago
Tania B	5652bde447	Encryption: Use secrets service (#40251 ) * Use secrets service in pluginproxy * Use secrets service in pluginxontext * Use secrets service in pluginsettings * Use secrets service in provisioning * Use secrets service in authinfoservice * Use secrets service in api * Use secrets service in sqlstore * Use secrets service in dashboardshapshots * Use secrets service in tsdb * Use secrets service in datasources * Use secrets service in alerting * Use secrets service in ngalert * Break cyclic dependancy * Refactor service * Break cyclic dependancy * Add FakeSecretsStore * Setup Secrets Service in sqlstore * Fix * Continue secrets service refactoring * Fix cyclic dependancy in sqlstore tests * Fix secrets service references * Fix linter errors * Add fake secrets service for tests * Refactor SetupTestSecretsService * Update setting up secret service in tests * Fix missing secrets service in multiorg_alertmanager_test * Use fake db in tests and sort imports * Use fake db in datasources tests * Fix more tests * Fix linter issues * Attempt to fix plugin proxy tests * Pass secrets service to getPluginProxiedRequest in pluginproxy tests * Fix pluginproxy tests * Revert using secrets service in alerting and provisioning * Update decryptFn in alerting migration * Rename defaultProvider to currentProvider * Use fake secrets service in alert channels tests * Refactor secrets service test helper * Update setting up secrets service in tests * Revert alerting changes in api * Add comments * Remove secrets service from background services * Convert global encryption functions into vars * Revert "Convert global encryption functions into vars" This reverts commit `498eb19859`. * Add feature toggle for envelope encryption * Rename toggle Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com>	4 years ago
ying-jeanne	681218275e	remove crit and trace (#40320 )	4 years ago
gotjosh	74fb491b6a	Alerting: Validate contact point configuration during migration to Unified Alerting (#40717 ) * Alerting: Validate contact point configuration during the migration This minimises the chances of generating broken configuration as part of the migration. Originally, we wanted to generate it and not produce a hard stop in Grafana but this strategy has the chance to avoid delivering notifications for our users. We now think it's better to hard stop the migration and let the user take care of resolving the configuration manually.	4 years ago
Yuriy Tseretyan	5836def6c2	Alerting: declare constants for __dashboardUid__ and __panelId__ literals (#39976 )	4 years ago
George Robinson	935bd34a30	Panel ID annotation cannot be set without Dashboard UID (#40019 )	4 years ago
George Robinson	2a4c1b1aa6	You can now get alert rules for a dashboard or a panel using /api/v1/rules endpoints. (#39476 ) Get alert rules for a dashboard and panel in /api/v1/rules	4 years ago
Sofia Papagiannaki	012d4f0905	Alerting: Remove `ngalert` feature toggle and introduce two new settings for enabling Grafana 8 alerts and disabling them for specific organisations (#38746 ) * Remove `ngalert` feature toggle * Update frontend Remove all references of ngalert feature toggle * Update docs * Disable unified alerting for specific orgs * Add backend tests * Apply suggestions from code review Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Disabled unified alerting by default * Ensure backward compatibility with old ngalert feature toggle * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Yuriy Tseretyan	5d0d7dcb3a	Update migration to not delete existing Grafana alerts (#39541 ) * keep existing unified alert rules untouched * move silences and other alertmanager files to the organization directory (only if it is a single organization deployment) * assign the existing notification settings and routes to the first organization * create default notification settings for each organization in the case of multi org deployment	4 years ago
Sofia Papagiannaki	ba4242bdb9	Cleanup kv_store alertmanager namespace when disabling unified alerting (#39554 )	4 years ago
Sofia Papagiannaki	81e82ebbbd	Alerting: fix the migrated silence file content (#39557 )	4 years ago
Santiago	ae9343f8ae	Clear ngalert configuration table (#38940 )	4 years ago
Sofia Papagiannaki	04d5dcb7c8	Alerting: modify DB table, accessors and migration to restrict org access (#37414 ) * Alerting: modify table and accessors to limit org access appropriately * Update migration to create multiple Alertmanager configs * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com> * replace mg.ClearMigrationEntry() mg.ClearMigrationEntry() would create a new session. This commit introduces a new migration for clearing an entry from migration log for replacing mg.ClearMigrationEntry() so that all dashboard alert migration operations will run inside the same transaction. It adds also `SkipMigrationLog()` in Migrator interface for skipping adding an entry in the migration_log. Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Ganesh Vernekar	10f8a138ae	Alerting: Deduplicate receivers during migration (#36812 ) * Alerting: Deduplicate receivers during migration Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix review comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Better naming of contact points Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Handle some edge cases Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Don't add routes which point to default contact point Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	4 years ago
Sofia Papagiannaki	423474325a	Alerting: fix postgres migration on conflict (#35556 )	5 years ago
Sofia Papagiannaki	15c55b0115	Alerting: Fix notification channel migration and handle case when Alertmanager default configuration is absent (#35086 ) * Fix dashboard alert and nootifier migration for MySQL * Fix POSTing Alertmanager configuration if no current configuration exists in case the default configuration has not be stored yet or has failed to get stored * Change CreatedAt field type	5 years ago
Ganesh Vernekar	aa4c5bbfe4	Alerting: Don't save Alertmanager config on migration when 0 channels (#35119 ) * Alerting: Don't save Alertmanager config on migration when 0 channels Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix review Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	5 years ago
Ganesh Vernekar	7c25465b3a	Alerting: Migrate paused alerts to silences (#34898 ) * Alerting: Migrate paused alerts to silences Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	5 years ago
Ganesh Vernekar	e52f718a87	NGAlert: Migrate old notification channel config (#33846 ) * NGAlert: Migrate old notification channel config Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Copy the required structs and functions Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix review comments and error on discontinued channels Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Use both ID and UID to map channels, attach UID to channels Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Bug fixes Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Use alert table instead of dashboard for channel IDs Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix offline reviews: don't add empty receivers and routes, add receiver for unmigrated channels Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Handle multiple default channels, pick default from used channels Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Include default channels in all receivers Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	5 years ago
Kyle Brandt	b987237c9b	Alerting: Remove UALERT_MIG env guard from dashboard rule migration (#34384 ) Rules/notifications/etc migration will now be activated with feature flag alone. When the feature flag is enabled dashboard alerts are migrated into the system. When the feature flag is removed, all migrated and newly created alerts in the new system are deleted.	5 years ago
Kyle Brandt	3da8db7f3f	Alerting: Run table migrations regardless of feature flag and move out of service (#33996 )	5 years ago
Kyle Brandt	dc3e17ba5b	Alerting: Change rule migration to be based on feature flag (#33792 ) makes it so the feature flag can be turned on off, and the migration will be cleared and rerun. All existing NG alert rules, configuration settings, etc are removed when disabling the feature flag. for https://github.com/grafana/alerting-squad/issues/142 Co-authored-by: Sofia Papagiannaki <sofia@grafana.com>	5 years ago
Kyle Brandt	57d46ea991	AlertingMigration: Separate info into multiple annos (#33641 )	5 years ago
Kyle Brandt	efe856ae4e	AlertingMigration: Create alert_rule_version entry (#33585 ) Create the alert rule version entry during the migration so it is consistent with rules created via api. for https://github.com/grafana/alerting-squad/issues/123	5 years ago
Kyle Brandt	713260f6fa	Alerting: Remove datasource (name) from migration (#33544 ) no longer needed as of https://github.com/grafana/grafana/pull/33416 for https://github.com/grafana/alerting-squad/issues/126	5 years ago
Kyle Brandt	6c8ef2a9c2	Alerting: Alert Rule migration (#33000 ) * Not complete, put migration behind env flag for now: UALERT_MIG=iDidBackup * Important to backup, and not expect the same DB to keep working until the env trigger is removed. * Alerting: Migrate dashboard alert permissions * Do not use imported models * Change folder titles Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>	5 years ago

31 Commits (0301d956daec4bcc4a23b6a144e23f840fc5ef0d)