grafana

Commit Graph

Author	SHA1	Message	Date
Konrad Lalik	0c9ca20bc5	Alerting: List v2 empty states (#105616 ) * Add empty state handling for GMA rules * Add handing empty states for Grafana and Datasource rules * Update translations, fix lint errors * Add empty state translation * WIP layout update * implement hover styles * update pagination * fix list item indent * clean up actions part 1 * only apply text fill to v2 list view * add missing returnTo for rule viewer * fix list styles for list view * i18n * update bulk actions to regular folder actions for list v2 * fix a few tests * simplify paginated loaders for new list view * i18n * more UI feedback * fix test * comment --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	4 days ago
Gilles De Mey	082b46067c	Alerting: New list view layout update (#105489 )	4 days ago
Alexander Akhmetov	c58ac15031	Alerting: Remove grafanaManagedRecordingRules feature flag (#105569 )	5 days ago
Hugo Häggmark	119d5897ea	i18n: imports use @grafana/i18n (#105177 ) * i18n: everything should target @grafana/i18n * wip * chore: updates after PR feedback * Trigger build * Trigger build * Trigger build * chore: skip flaky tests * chore: skip flaky tests * chore: skip flaky tests * chore: skip flaky tests * chore: skip flaky tests * chore: skip flaky tests * chore: revert all flaky tests * chore: some incorrect usages of useTranslate	1 week ago
Tom Ratcliffe	edfe690ea2	Chore: Move Mock API into separate package (#104644 )	1 week ago
Sonia Aguilar	550e60fe48	Alerting: Check permissions for showing create recording rules button (#105256 )	1 week ago
Alex Khomenko	a9b6d098e9	Chore: Add eslint no-restricted-globals rule (#104519 ) * Chore: Add no-restricted-globals eslint rule * Fix eslint warnings * Revert some changes * Update * Feedback	2 weeks ago
Sonia Aguilar	0ceea29787	Alerting: Remove alertingSimplifiedRouting feature toggle (#104980 ) Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 weeks ago
Konrad Lalik	620260fabc	Alerting: Fix alert list V2 preview toggle (#105062 ) * Use custom storage for previewing alerting features configuration * Fix tests, add localStorage mock * Use store singleton	2 weeks ago
Konrad Lalik	e3d9c5d33e	Alerting: Add support for unknown rule state (#105052 ) Add support for unknown rule state	3 weeks ago
Sonia Aguilar	277d271476	Alerting: Add delete bulk action in the alert list view (#104611 ) * Add pause/unpause bulk actions button in the alert list view * add delete bulk action * Add tracking and refactor FolderActionMenuItem * update translations and text * update text * add finally * use ability for delete action * don't show bulk actions if no action is allowed * invalidate tags for delete action * revert invalidating and redirect to list page instead * redirect when pausing/unpausing * add pause/unpause endpoints * add translations * add folder name in delete modal * address pr review * disable pause/unpause * update redirect * remove unnecessary prop * rename FolderActionMenuItem component to PauseUnpauseActionMenuItem * address review comments * fetch rules before redirecting in list view 1 --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Mariell Hoversholm <mariell.hoversholm@grafana.com>	3 weeks ago
Konrad Lalik	f79f6efdcb	Alerting: Use Prometheus endpoint as a primary source of data on the new list page (#104538 ) * Bring back contact points filter * Use GMA Prometheus endpoint as main source of truth on the list page * refactor: improve error handling in GrafanaRuleLoader	3 weeks ago
Ashley Harrison	1c5545da04	Internationalisation: Check and mark up tooltip content prop (#104536 ) * make lint rule check for "content" * undo unnecessary translation	3 weeks ago
Gilles De Mey	97a1614cde	Alerting: Rework rule editor layout (#103744 )	4 weeks ago
Tom Ratcliffe	a47a155a89	Alerting: Only show DMA button when query datasource supports it (#104158 )	1 month ago
Sonia Aguilar	2514944d3c	Alerting: Fix wrong conditional showing errors all the time (#104297 ) fix wrong conditional showing errors all the timne	1 month ago
Tom Ratcliffe	0860867b84	i18n: Fix all remaining alerting translation markup (#104103 ) * alerting markup * fix typo * Fix remaining Alerting issues 🎉 * Enable no-untranslated-strings rule for alerting * Fix i18n eslint rule for "fixed" areas of code * Remove auto fixing * kick CI --------- Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	1 month ago
Konrad Lalik	0a8dccc19a	Alerting: New alert list filter improvements (#103107 ) * Move filtering code to generators for performance reasons Discarding rules and groups early in the iterable chain limits the number of promises we need to wait for which improves performance significantly * Add error handling for generators * Add support for data source filter for GMA rules * search WIP fix * Fix datasource filter * Move filtering back to filtered rules hook, use paged groups for improved performance * Add queriedDatasources field to grafana managed rules and update filtering logic to rely on it - Introduced a new field `queriedDatasources` in the AlertingRule struct to track data sources used in rules. - Updated the Prometheus API to populate `queriedDatasources` when creating alerting rules. - Modified filtering logic in the ruleFilter function to utilize the new `queriedDatasources` field for improved data source matching. - Adjusted related tests to reflect changes in rule structure and filtering behavior. * Add FilterView performance logging * Improve GMA Prometheus types, rename queried datasources property * Use custom generator helpers for flattening and filtering rule groups * Fix lint errors, add missing translations * Revert test condition * Refactor api prom changes * Fix lint errors * Update backend tests * Refactor rule list components to improve error handling and data source management - Enhanced error handling in FilterViewResults by logging errors before returning an empty iterable. - Simplified conditional rendering in GrafanaRuleLoader for better readability. - Updated data source handling in PaginatedDataSourceLoader and PaginatedGrafanaLoader to use new individual rule group generator. - Renamed toPageless function to toIndividualRuleGroups for clarity in prometheusGroupsGenerator. - Improved filtering logic in useFilteredRulesIterator to utilize a dedicated function for data source type validation. - Added isRulesDataSourceType utility function for better data source type checks. - Removed commented-out code in PromRuleDTOBase for cleaner interface definition. * Fix abort controller on FilterView * Improve generators filtering * fix abort controller * refactor cancelSearch * make states exclusive * Load full page in one loadResultPage call * Update tests, update translations * Refactor filter status into separate component * hoist hook * Use the new function for supported rules source type --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	1 month ago
Ashley Harrison	c83c486c9b	Internationalisation: Lint rule improvement (#103788 ) * improve autofix so it can fix foo={"bar"} * apply fixes * fix type checks + betterer * tweak to make types happy	1 month ago
Sonia Aguilar	71c66acb2d	Alerting: Add keep_firing_for and Recovering state (#103248 ) * add keep_firing_for and Recovering state * prettier * translations * remove unused component/file * fix tests * fix test * prettier * fix tests * revert changes in go.work.sum * remove recovering from cloud rules filters * prettier * fix padding * fix wrong move in import * update text * fix filtering states in alert list panel * update translations * betterer * address feedback * translations * fix tests * prettier and betterer * update betterer.results * update translations * update snapshot * add divider in the alert rule form * address feedback * Improve translations * Update .betterer.results --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	2 months ago
Sonia Aguilar	a05b35a13c	Alerting: Fix wrong interpolation in translation (#103514 ) fix wrong interpolation in transalation	2 months ago
Tom Ratcliffe	a93e618102	Internationalisation: Auto mark-up Alerting's strings (#103354 ) * Internationalisation: Auto mark-up Alerting code strings * Update .betterer.results * Revert prometheus duration docs change * Fix duplicated import * Remove unneeded translation	2 months ago
Sonia Aguilar	9b91dc7855	Alerting: Migration UI (#102010 ) * add feature toggle alertingMigrationUI * wip * wip * wip2 * add button to export in alert list and add target folder in the form * update namings * protext migration route with alertingMigrationUI feature toggle * remove unused error style * add namspace and group filter * fix translations and prettier * fix duplication * use the new endpoint * update right roles for the FE route * refactor * notify success * address feedback * fix translations * Simplify migration UI for alert rules to GMA format Extracts migration button component and reuses it in banner for better code organization and consistency. * Fix root folder check in import alert rules UI Replace hardcoded empty string check with lodash isEmpty for folder UID validation * Add collapsible section for import rule options * address feedback * Split useAlertRuleSuggestions, one for labels, and other for namespaces * refactor splited hooks * Alerting: (PR review) Redesign slightly + use combobox (#102614) Redesign slightly + use combobox * udpate naming * remove eslint-disable-next-line @grafana/no-untranslated-strings and add hasDataSourcesConfigured as a condition to render the banner * use button instead of banner * fix routes * use new api * update api * remove query params * update translations * update ff files * skip subpath when redirecting to the alert list view with filters * prettier * disable provenance * prettier * Don't send target forlder uid in the payload as undefined if it's not selected * prettier * add confirmation modal with a preview * remove unnecessary export * Add target datasource UID for recording rules * Use skipToken * Add recording rule datasource and update designs * Use different hook to fetch rulerRules --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	2 months ago
Sonia Aguilar	3450d243b9	Alerting: Delete permanently deleted alert rules. (#102960 ) * add alertingDeletePermanently ff * add delete permanently button in Recently deleted page * use ff to protect delete permanent button column * update transations and prettier * invalidate tag and update transalations keys * add test * prettier * refactor test * restore wrong change in deleteRulerRuleGroupHandler * update test * linter * Alerting: Permanent delete rules code review (#103288) * Update feature toggle name and description * Rename mutation endpoint * Fix typo and update text to be "permanently delete" * Update feature toggle and test * Move delete button into actions column * generate ff * address feedback --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	2 months ago
Konrad Lalik	3e15459d20	Alerting: Enhance Ruler and Prometheus group synchronization (#99012 ) * Add group actions menu * Refactor modals to accept raw ruler group * Use prometheus and ruler responses to dispaly GMA rules in the hierarchical view * Add groups loader component for data source managed rules * Improve rules matching algorithm for the search results * Use plus and minus icons for reconciliation state * loading spinner WIP for operations / transactions * update comment * Use ruler rules order when displaying a group, change rurler preload behaviour * Add ruler-based ordering for GMA rules * Refactor ruler API mocking * Refactor rule components to accept ruler only rules * Add tests for GrafanaGroupLoader * Add tests for vanilla prom groups * Unify data matching code, add tests for DS groups loader * Fix errors after rebasing * Improve handling of ruler group absence * Fix cache key * Add group action buttons for the new group pages * Add new rule action buttons to the new list page * Address PR feeback, component renaming, missing translations * Unify groups and rules links and actions * Fix new rule button * Add rule list action buttons tests * Fix lint errors * Add redirect to rule details page on save * Update FilterView tests * Fix imports and remove unused code * Improve type definitions, add pooling to Prom hooks, add inline docs * Remove unused code of group modals * Update translations * Disable cache population for filter-view generators * Add consistency check Alert to the RuleViewer when V2 list is enabled * Disable UI errors in prom generator * Improve missing datasouce handling * Add missing translations * Improve group loader tests, remove unused code * Enhance Prometheus API query to include notification options * Improve error handling, remove consistency check for vanilla prom data sources * Address PR feedback, add new version of the useHasRuler hook --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 months ago
Sonia Aguilar	f9471ac10b	Alerting: Recover deleted alert rules (#101869 ) * add column guid to alert rule table and rule_guid to rule version table + populate the new field with UUID * update storage and domain models * patch GUID * ignore GUID in fingerprint tests * get alert rule versions by GUID * update rule delete to reset uid in history instead of deleting rows * add test * Update delete rule to require UserUID, remove all versions and create "delete" version that holds information about who and when deleted the rule * update usages of the delete method * add list deleted rules to store * list api to support deleted query parameter * add list deleted rules to store ^ Conflicts: ^ pkg/services/ngalert/store/alert_rule_test.go * list api to support deleted query parameter * Restore deleted rules * fix recovering manually recording rules * update role control for the trash route * add alertingRuleRecoverDeleted feature toggle enabled by default * fix access control for trash menu item in the navtree * Add alertingRuleRecoverDeleted feature toggle, add Delete permanently alert rule menu option * hide remove permanently functionality in the UI until we have the api available for it * discard wrong changes after merging * Reverted changes in pkg/apis/dashboard_manifest.go after fixing conflicts * Reverted changes in go.work.sum after fixing conflicts * Reverted changes in pkg/apis/dashboard_manifest.go after fixing conflicts * Reverted changes in pkg/services/ngalert/models/alert_rule.go after fixing conflicts * Reverted changes in pkg/apis/dashboard_manifest.go after fixing conflicts * restore delete permanently and add the queryparam for it * update snapshots * fix translations * protect trash route by the feature toggles * use the new rulerRuleType for checks * revert ability to delete permanently and alert rule from the ui * remove unnecessary update after reverting * fix ff * add tracking * use recently deleted instead of trash * create isRecoverDeletedRulesEnabled for checking ffs * address pr feedback 1 * include alert rule uid in getRowId * use RulerGrafanaRulesConfigDTO for deleted rules response * use isLoading in the AlertingPageWrapper * fix wrong check for recording rules type * add test for restoring manually through the alert rule form * add test for restoring deleted rule * use importAlertingComponent * udpate mock * address pr feedback * update translations * address feedback * address feedback 2 * address feedback 3 * address feedback 4 * move transformation of the response to the endpoint * fix typo * refactor grafanaRuleDtoToFormValues * update translations * use guid for identifying rows * prettier * use ONLY the guid for identifying rows * Add provides/invalidates tags for deleted rules --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	2 months ago
Jack Westbrook	6822805c32	Grafana Runtime: Use package.json exports for internal code (#102100 ) * refactor(frontend): update runtime import paths for grafana/runtime/src -> grafana/runtime * feat(runtime): introduce internal api entrypoint and exports property * refactor(frontend): update runtime imports to use internal entrypoint * chore(betterer): update results file * refactor(bookmarks): update runtime/unstable import * chore(betterer): update results file * test(frontend): fix failing tests due to mocking nested runtime imports * test(datasourcesrv): fix failing tests due to mocks * chore(alerting): clean up redundant import * fix(packages): fix default require export pointing to types declaration file * docs(packages): update readme related to exports * chore(internationalization): fix import paths * chore(betterer): update results file	2 months ago
Tom Ratcliffe	01c7283a88	Alerting: Check recording rules are enabled as well as feature toggle (#102633 ) * Add `recordingRulesEnabled` to grafanaBootData * Check for recording rules being enabled, as well as feature toggle * Remove unnecessary config line * Move recording rules check to featureToggles file * Update NoRulesCTA.tsx	2 months ago
Tom Ratcliffe	a13d90db45	Alerting: Fix display of `Normal (Updated)` in alert history (#102476 ) * Fix display of `Normal (Updated)` in alert history * Update useRuleHistoryRecords.test.tsx * Update regex	2 months ago
Jack Westbrook	1ca9910736	Grafana Data: Use package.json exports for internal code (#102696 ) * refactor(frontend): rename all @grafana/data/src imports to @grafana/data * feat(grafana-data): introduce internal entrypoint for sharing code only with grafana * feat(grafana-data): add test entrypoint for data test utils usage in core * refactor(frontend): update import paths to use grafana/data exports entrypoints * docs(grafana-data): update comment in internal/index.ts * refactor(frontend): prefer public namespaced exports over re-exporting via internal * chore(frontend): fix a couple more weird paths that typescript complains about	2 months ago
Tom Ratcliffe	b8c627c566	Alerting: Fix display of paused recording rules (#102348 ) * Fix display of paused recording rules * Simplify paused state check for Grafana alert rules The change eliminates redundant rule type checks by using a more generic grafana.rule() check that covers both alerting and recording rules. * Add test for recording rule paused state * Add test for paused Grafana alert in Details tab --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 months ago
Konrad Lalik	321a886b8b	Alerting: Add details and edit pages for groups (#100884 ) * Add basic details page for groups * Remove unused imports * Add basic edit page for groups * Add functional group details page * Improve form, add namespaces for DS groups * Add support for multiple actions in useProduceNewRuleGroup * Attach real actions to form submit * Add tests for the group details page * Add basic tests for the group edit page * Add tests for Mimir update * Add rule group consistency check * Extract draggable rules table to a separate file * Add prom consistency waiting after group saving * Add duration measure for Prometheus reconciliation time * Remove a blinking error when redirecting to a new group * Improve group details page. Use ruler or prom api depending on the ds capabilities * Add group delete action for DMA * Fix GroupDetailsPage tests * Update tests * Add and improve Edit page tests * Add Group export for GMA groups * Fix RulesGroup tests, add translations * Disable editing plugin provided groups * Fix alertingApi options, fix tests * Fix lint errors, update translations * use name for grafana managed recording rules * add namespace to nav * Remove group modals from the list page * add cancel button to edit form * add test for cancel butotn * fix recording rule badge for Grafana managed rules * Add doc comments, improve code * Move url changes to be the last action in form submit * Add returnTo URL handling for alert rule group navigation * Create dedicated Title component showing breadcrumb navigation between folder and group name. Add label distinction between folders and namespaces based on the rule source (Grafana vs external). * Address PR feedback, minor refactorings * Update rule group links to include return path and refactor rule type checks - Modified `RulesGroup` and `GroupDetailsPage` components to include `includeReturnTo` in edit page links. - Refactored rule type checks in `DraggableRulesTable` and `GroupDetailsPage` to use `rulerRuleType` for better clarity and maintainability. - Updated documentation in `useUpdateRuleGroup` to clarify functionality for updating or moving rule groups. * Refactor RulesGroup component and tests for improved link handling and permissions checks - Added `includeReturnTo` parameter to rule group detail links in `RulesGroup` for better navigation. - Updated test cases to verify rendering of edit and view buttons based on user permissions. - Simplified test setup by removing unnecessary Redux provider wrapping in tests. * Refactor: Update routing and test assertions in GroupDetails and GroupEdit pages - Modified route paths in GroupDetailsPage and GroupEditPage tests to use `dataSourceUid` instead of `sourceId`. - Updated test assertions to reflect changes in folder title and link structure in GroupDetailsPage. - Simplified Title component by removing folder-related props and logic, focusing solely on the group name. * Refactor: Simplify Title rendering in GroupDetailsPage - Updated the renderTitle function in GroupDetailsPage to remove the folder prop from the Title component, focusing solely on the group name. * Update GroupDetailsPage to prevent editing of provisioned groups * Fix imports * Improve styles * Fix navigation when served from subpath * Improve group removal handling in Prom consistency check. Fix Delete group button --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 months ago
Konrad Lalik	b11daf57bb	Alerting: Fix rule instances table (#102290 ) Fix the condition for displaying alert instances table in RuleDetails component	2 months ago
Jack Westbrook	5cd8547131	Revert "Grafana Data: Use package.json exports for internal code (#102286 ) Revert "Grafana Data: Use package.json exports for internal code (#102036)" This reverts commit `91116de790`.	2 months ago
Jack Westbrook	91116de790	Grafana Data: Use package.json exports for internal code (#102036 ) * refactor(frontend): rename all @grafana/data/src imports to @grafana/data * feat(grafana-data): introduce internal entrypoint for sharing code only with grafana * feat(grafana-data): add test entrypoint for data test utils usage in core * refactor(frontend): update import paths to use grafana/data exports entrypoints * docs(grafana-data): update comment in internal/index.ts * refactor(frontend): prefer public namespaced exports over re-exporting via internal	2 months ago
Tom Ratcliffe	2c1bc1bb7c	Alerting: Fix DataQuery and DataSourceRef deprecated imports in alerting code (#102095 ) Fix DataQuery and DataSourceRef deprecated imports in alerting code	2 months ago
Jack Westbrook	c9f563e576	Grafana UI: Use package.json exports for internal code (#101815 ) * feat(grafana-ui): introduce development exports to prevent importing from grafana/ui/src * refactor(theme-generation): move theme templates into scripts so themes continue to build * refactor(frontend): replace grafana/ui paths that use nested src with /internal or /unstable * chore(betterer): update better results file * feat(grafana-ui): support enterprise, remove Text component from internal * docs(packages): update readme with exporting code conventions	2 months ago
Tom Ratcliffe	9870718c3a	Alerting: Enable `jsx-no-useless-fragment` rule (#101884 ) * Add no-useless-fragment rule for alerting code * Auto-fix most no-useless-fragment cases * Manually fix remaining no-useless-fragment cases * Fix `invalid` passing to Field component * Allow AlertingPageWrapper to have optional children	2 months ago
Tom Ratcliffe	6b2c73141d	Alerting: Improve clarity of recording rule creation (#100700 ) * Add description below group and namespace fields to make creation clearer * Make DS managed recording rules clearer * Change link for recording rule on empty state to Grafana managed * Tweak empty state * Tidy up logic for display of recording rule buttons * Update .betterer.results	2 months ago
Gilles De Mey	da8f26a07c	Alerting: Refactor and clean up rule type guard functions (#101639 )	3 months ago
Tom Ratcliffe	5eb3f3a3cb	Chore: Fix some import issues in alerting code (#100962 )	3 months ago
Gilles De Mey	4270bf742a	Alerting: Fix label overflow for history common labels (#101343 )	3 months ago
Yuri Tseretyan	bbeae46105	Alerting: Fix rule state history with annotations backend (#101174 ) * add alertUID to annotations API query parameter * update state history UI to fetch rule by UID --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	3 months ago
Konrad Lalik	fbf96916aa	Alerting: Use alerting-specific error boundary for page components (#99980 ) Use alerting-specific error boundary for page components	3 months ago
Konrad Lalik	0bf31c14a7	Alerting: Improve default form values handling (#97564 ) This PR refactors how rule form state is managed and relies less on prop drilling and removes dependency on redux store.	4 months ago
Konrad Lalik	c5ff5d89df	Alerting: Add GMA action buttons to the new list view (#98449 ) * Add GMA action buttons based on the ruler rule definition * Improve imports * Remove rulesSource from Grafana group identifier * Improve ruler loader error handling * Clean imports, add details page link * Remove unnecessary property from the API: * Change Prometheus page size in the FilterView * Fix lint errors and tests * Revert filtered items page size * Fix cache invalidation for RTKQ ruler requests * Fix tags ids * Naming improvements * Fix lint errors, use util function for pause checking * Alerting: Add ruleGroupIdentifierV2toV1 function to PR 98449 (#99326) * Move params validation to the rulerUrlBuilder, tidy up code --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	4 months ago
Sonia Aguilar	63a89afe00	Alerting: Fix silence drawer being re-rendered when the alert list is refreshed (#99468 ) * Fix silence drawer being re-rendered when the alert list is refreshed * remove unnecessary formValues usage as prop * remove AlertmanagerProvider in RuleActionsButtonsV2	4 months ago
Tom Ratcliffe	f75bbe9f43	Alerting: Add self closing comp rule to alerting eslint config (#98603 )	5 months ago
Tom Ratcliffe	42894ba840	Alerting: Use common i18n phrases for cancel and save (#98600 )	5 months ago
Sonia Aguilar	cdd74aa144	Alerting: Fix ash not showing history graph in firefox (#98128 ) fix getEventsSceneObject	5 months ago

1 2 3 4 5 ...

366 Commits (0c9ca20bc586214a54d09e073a24fac551ac8fac)