grafana

Commit Graph

Author	SHA1	Message	Date
Tom Ratcliffe	482af91782	Alerting: Remove manual feature discovery mocking (#96243 ) * Update mock methods to remove discovery API * Update tests to remove mock discovery API * Remove ref in TESTING.md * Fix other references to 'mimir'	5 months ago
Konrad Lalik	8055d69ad2	Alerting: Alert list - pagination and filtering part 1 (#96423 ) * Add basic token-based paginated fetching * Add 1:many relation between UI and API pages * Fix pagination arrows * Add pagination to hierarchical view * Add multidatasource filtering * Improve flushing filtered rules, add better identifiers * Fix pagination for data sources not supporting server side pagination * Use alert rule loader on the filter view Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> * use useTransition and update loader * types * Update ruleGruopIdentifier. Add actions and location to recording rules * Update to the new API parameters * Refactor iterator code * Use ix to merge iterators * Improve perf * use AbortController to cancel loading pages * remove iterops for now * add comments * add application and rulesource information to list view * update test * update list view functionality * add emptystate * automatically load more items when we get to the bottom of the page * reduce number of loaders * separate hook for useFilteredRulesIteratorProvider * use useDeepCompareEffect to track filter state changes * fix weird no results loading glitch * fix rare case where changing filters wouldn't update the list * add number of results to component * Simplify FilterView rerendering * add filter for dashboard * Add tests for filtered view, use data source UID instead of names in the interator code * Improve HTML semantics, extract a separate GroupedView component * Split RuleList.v2 into multiple files * Split tests into Filtered and Grouped view files * PR feedback * Improve error handling, add tests for GroupedView * Improve types, small refactoring * Improve rules setup * Small improvements, v1 and v2 versions of the view type selector * Remove yarn cache changes * Import from test-utils * Move groupIdentifiers, improve state param parsing * reorder imports * reorder imports * update yarn resolution * i18n * Improve API mock, increase timeout limit * Add tests for RuleList.v2 * Update tests * Fix mocks in test * Fix lint * Fix data sources mock --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	5 months ago
Tom Ratcliffe	5be8a9b3c3	Alerting/chore: Deprecate MockDataSourceSrv and remove from Alerting tests (#97267 ) * Mark MockDataSourceSrv as deprecated * Add `module` into necessary existing mock datasources * Remove config mock * Update helper method for test datasources to more accurately reflect real behaviour * Update alerting/unified tests to remove mock datasource srv * Lint fix * Remove some unused re-exports * Make mock mimir use correct module Ⓜ️ * Add necessary handlers for mimir query editor responses * Lint fix * Add implementation to mock mimir data source	5 months ago
Tom Ratcliffe	19cc2efaf2	Chore: Fix unnecessary nullish-coalescing (#97555 ) * Fix unnecessary nullish-coalescing * Fix nullish use as per code review * Fix other incorrect use of nullish coalescing	5 months ago
Tom Ratcliffe	4f7ffafe98	Alerting: Consistently order member imports in alerting code (#97688 ) * Lint import member orders within alerting * Consistently order member imports in alerting code	6 months ago
Sonia Aguilar	dd9638cade	Alerting: Improve performance ash page (#97619 ) * first commit adding usememo and refactoring scenes objects to keep an state for variables values * Fix scenes with the panel reacting to variables changes * move body to the model * address some pr feedback * Refactoring central alert history scene (#97658) Refactoring * fix test and some wrong imports * update comments * add eslint-disable-next-line * remove unnecessary SceneFlexLayout and SceneFlexItem wrapper * address pr feedback * update tests for labels filtering --------- Co-authored-by: Torkel Ödegaard <torkel@grafana.com>	6 months ago
Gilles De Mey	c6d3cf89ad	Alerting: Fix navigating to URLs with "%" (#96992 ) Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>	6 months ago
Josh Hunt	f6b6935563	Chore: Make ResizeObserver test mock only emit if an element is being observed (#96770 ) * Chore: Make ResizeObserver test mock only emit if an element is being observed * update test that relied on old mock behaviour	6 months ago
Sonia Aguilar	1b0cc60d65	Alerting: Move evaluation outside folder section, and move labels in instead (#95121 ) * Move evaluation outside folder section, and move labels in instead * rename file * update translations * refactor * rename file and component * refactor * fix test * refactor * rename files and components * update translations * fix style * update translations * Use useAppNotification for toasts * update label when group can not be selected yet * update translations * update some texts and add comment * update translations * remove duplicated code * fix typo * update texts and translations * rename FolderWithoutGroup to FolderSelector * restore wrong updates * restore wrong updates * translations and remove GroupAndFolder component * address review comments * remove container * address review comments * address review comments * prettier * prettier	6 months ago
Gilles De Mey	73ae4a51b2	Alerting: Silence drawer being forcefully closed (#96579 ) Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	6 months ago
Konrad Lalik	b73ab15878	Alerting: New list view (Part 1) (#95039 ) * initial commit * update styles * wip * update list view * update translations * abstract components * metadata separator * refactor * cleanup * fix tests * WIP * translations * refactor to use maps and type-safety * WIP * UI updates * Rule action buttons early draft * recording rules * WIP typescript errors * implement action button loading * move section loader etc * add placeholder for group actions * Change files structure, remove CombinedRule from AlertRuleMenu * Refactor fetching data sources with ruler * Fix tests * Unify data source features * move files * make actions column wider * update translations * Update tests to reflect code changes * Remove direct buildinfo usages * Fix useCanSilence hook * Add missing translations, fix lint errors * PR feedback * update test * Remove featureDiscovery mock from a test --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	6 months ago
Tom Ratcliffe	cbe8b8a290	Alerting: Lint and remove unused object properties (#92996 )	6 months ago
Pepe Cano	7112a79b35	Alerting UI: Update help button and descriptions for recording rules (#96047 ) * Hide `Instances` field in RuleDetails view for recording rules * Alerting UI: add `helpLink` to Recording Rules docs * Make the Metric input placeholder more explicit for recording rules	7 months ago
Tom Ratcliffe	7e34c015ee	Alerting: Load alerting state view based on prom primary feature toggle (#95045 )	7 months ago
Gilles De Mey	c42f42223a	Alerting: New alert state list view (#94068 )	7 months ago
Alex Khomenko	f671ad51fe	Alerting: Update Alert State History router import (#95218 ) Update import	7 months ago
Alex Khomenko	97249d15d1	Routing: Update alerting routes to react router 6 (#94469 ) * Update alertingRuleEditor * Update Policy.test * Update AlertRuleForm * Update ReceiversSection * Update SimplifiedRuleEditor.test.tsx * Update CloneRule.tsx	8 months ago
Sonia Aguilar	fe656229c3	Alerting: Pluralize error tag (#94157 )	8 months ago
Alex Khomenko	f55f7f2634	Routing: Replace Redirect component with Navigate (#94072 ) * Routing: Replace Redirect with Navigate * Use replace state * Update routes.tsx * Fix test	8 months ago
Tom Ratcliffe	fc51ec70ba	Alerting: Add manage permissions UI logic for Contact Points (#92885 ) * Add showPolicies prop * Add manage permissions component for easier reuse within alerting * Add method for checking whether to show access control within alerting * Remove accidental console.log from main * Tweak styling for contact point width and add manage permissions drawer * Improve typing for access control type response * Add basic test for manage permissions on contact points list * Only show manage permissions if grafana AM and alertingApiServer is enabled * Update i18n * Add test utils for turning features on and back off * Add access control handlers * Update tests with new util * Pass AM in and add tests * Receiver OSS resource permissions There is a complication that is not fully addressed: Viewer defaults to read:* and Editor defaults to read+write+delete:* This is different to other resource permissions where non-admin are not granted any global permissions and instead access is handled solely by resource-specific permissions that are populated on create and removed on delete. This allows them to easily remove permission to view or edit a single resource from basic roles. The reason this is tricky here is that we have multiple APIs that can create/delete receivers: config api, provisioning api, and k8s receivers api. Config api in particular is not well-equipped to determine when creates/deletes are happening and thus ensuring that the proper resource-specific permissions are created/deleted is finicky. We would also have to create a migration to populate resource-specific permissions for all current receivers. This migration would need to be reset so it can run again if the flag is disabled. * Add access control permissions * Pass in contact point ID to receivers form * Temporarily remove access control check for contact points * Include access control metadata in k8s receiver List & Get GET: Always included. LIST: Included by adding a label selector with value `grafana.com/accessControl` * Include new permissions for contact points navbar * Fix receiver creator fixed role to not give global read * Include in-use metadata in k8s receiver List & Get GET: Always included. LIST: Included by adding a label selector with value `grafana.com/inUse` * Add receiver creator permission to receiver writer * Add receiver creator permission to navbar * Always allow listing receivers, don't return 403 * Remove receiver read precondition from receiver create Otherwise, Creator role will not be able to create their first receiver * Update routes permissions * Add further support for RBAC in contact points * Update routes permissions * Update contact points header logic * Back out test feature toggle refactor Not working atm, not sure why * Tidy up imports * Update mock permissions * Revert more test changes * Update i18n * Sync inuse metadata pr * Add back canAdmin permissions after main merge * Split out check for policies navtree item * Tidy up utils and imports and fix rules in use * Fix contact point tests and act warnings * Add missing ReceiverPermissionAdmin after merge conflict * Move contact points permissions * Only show contact points filter when permissions are correct * Move to constants * Fallback to empty array and remove labelSelectors (not needed) * Allow `toAbility` to take multiple actions * Show builtin alertmanager if contact points permission * Add empty state and hide templates if missing permissions * Translations * Tidy up mock data * Fix tests and templates permission * Update message for unused contact points * Don't return 403 when user lists receivers and has access to none * Fix receiver create not adding empty uid permissions * Move SetDefaultPermissions to ReceiverPermissionService * Have SetDefaultPermissions use uid from string Fixes circular dependency * Add FakeReceiverPermissionsService and fix test wiring * Implement resource permission handling in provisioning API and renames Create: Sets to default permissions Delete: Removes permissions Update: If receiver name is modified and the new name doesn't exist, it copies the permissions from the old receiver to the newly created one. If old receiver is now empty, it removes the old permissions as well. * Split contact point permissions checks for read/modify * Generalise getting annotation values from k8s entities * Proxy RouteDeleteAlertingConfig through MultiOrgAlertmanager * Cleanup permissions on config api reset and restore * Cleanup permissions on config api POST note this is still not available with feature flag enabled * Gate the permission manager behind FF until initial migration is added * Sync changes from config api PR * Switch to named export * Revert unnecessary changes * Revert Filter auth change and implement in k8s api only * Don't allow new scoped permissions to give access without FF Prevents complications around mixed support for the scoped permissions causing oddities in the UI. * Fix integration tests to account for list permission change * Move to `permissions` file * Add additional tests for contact points * Fix redirect for viewer on edit page * Combine alerting test utils and move to new file location * Allow new permissions to access provisioning export paths with FF * Always allow exporting if its grafana flavoured * Fix logic for showing auto generated policies * Fix delete logic for contact point only referenced by a rule * Suppress warning message when renaming a contact point * Clear team and role perm cache on receiver rename Prevents temporarily broken UI permissions after rename when a user's source of elevated permissions comes from a cached team or basic role permission. * Debug log failed cache clear on CopyPermissions --------- Co-authored-by: Matt Jacobson <matthew.jacobson@grafana.com>	8 months ago
Konrad Lalik	db42af20ca	Alerting: Prometheus primary mode for the alert list page (#92975 ) * Lazy loading of mimir groups * Refactor rule statuses * Use prometheus endpoint to populate namespace and group dropdowns * Add a feature toggle * Use lazy loading ruler rules if the feature toggle enabled * Remove unnecessary props form dynamic table * Remove query from hash calculation * Conditionally load ns and group autocompletions from Prom or Ruler APIs * Fix prometheus dto labels property type * Add a new suggestions hook which provides autocomplete options for the alert rule form * Improve delete status handling * Add waiting for Prometheus endpoint consistency after update submission * Get rule definition from ruler or prometheus endpoint in useCombinedRule * Add Prometheus consistency check. Fix view page redirects * Remove rules reload after rule creation, remove statuses from Prom primary mode * Add waiting for Prometheus consistency on delete rule action * Add groups list rendering improvements * Add memo to useAbilities * Fix GMA consistency check, fix GMA statuses * defer filered rules rendering * Update failing tests * Update locales * Add rule-id tests * Remove unused action * update loading styles * Fix unrelated test * Add a new object for reading alerting feature toggles, address minor review issues * Improve consistency check * update i18n * Improve rule form redirects * Refactor feature toggle handling * Update docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> * Update public/app/features/alerting/unified/components/rule-viewer/RuleViewer.tsx Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> * Fix prettier issues * Fix i18n * Fix the feature toggle description * Fix rule updates, fix ruler-based suggestions, wait for deletion for GMA rules * Fix rename * Remove unused code, improve copy * Update i18n * Fix url redirect when serving from subpath --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	8 months ago
Gilles De Mey	4b1d8eeef0	Alerting: Remove filter for state without reason (#93604 )	8 months ago
Gilles De Mey	70b5bd609c	Alerting: Update rules empty state CTA (#93276 )	8 months ago
Erik Sundell	8c702d4a6b	Plugin extensions: Make sure core features use new hooks (#92723 ) * use new extensions APIs across grafana core * setup setPluginLinksHook * fix tests * fix mock * fix more broken tests * use plugin components hook * remove unused func * fix tests * remove unused import	8 months ago
Gilles De Mey	90ee52e8d9	Alerting: New search UI – Part 1 (#91620 )	9 months ago
Gilles De Mey	c8dc4d93d4	Alerting: Rename list view section titles (#93182 )	9 months ago
Konrad Lalik	5942d8595d	Alerting: Fix pending period for vanilla prom rules (#92728 ) * Add support for reading pending period value from prom duration property * Add tests * Refactor the hook * Remove unused import	9 months ago
Tom Ratcliffe	172662af58	Alerting: Stop rule state view from crashing when prom rule state is missing (#91483 )	9 months ago
Alex Khomenko	0af4a20b58	Routing: Import useLocation from compat package (#92071 ) * Routing: Import useLocation from compat package * Add ComparRouter * Add CompatRouter * Fix tests * Add CompatRouter to TestProvider * Use findBy * Remove AppChromeService * Remove historyOptions * Routing: Fix alerting/test utils issues from react compat router usage (#92127) * Use render from test-utils * Use compat router * Convert more tests --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	9 months ago
Gilles De Mey	00381711a4	Alerting: useProduceNewRuleGroup for creating / updating alert rules. (#90497 ) Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	9 months ago
Konrad Lalik	db711d6a21	Alerting: Allow groups and namespaces with slashes (#92183 ) * Allow rule groups and namespaces with slashes * Fix lint	9 months ago
Tom Ratcliffe	735954386f	Alerting: Consolidate contact points dropdown and add filter in alert rules (#91690 ) Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	10 months ago
Gilles De Mey	d312e2aacf	Alerting: Swap useAsync return signature params (#91634 )	10 months ago
Tom Ratcliffe	3ec2084c23	Alerting: Remove all but one usage of `TestProvider` within test code (#91542 )	10 months ago
Tom Ratcliffe	b4a23e097a	Alerting: Add types to react hook form usage register method (#91566 )	10 months ago
Tom Ratcliffe	734af2ea9f	Alerting: Enable "dot-notation" rule (#91497 )	10 months ago
Tom Ratcliffe	500ae2ff1e	Alerting: Enable "prefer-const" rule (#91495 )	10 months ago
Tom Ratcliffe	e771500487	Alerting: Enable "no-unused-props" rule (#91492 )	10 months ago
Sonia Aguilar	d080a91e8a	Alerting: Refactor createUrl and createAbsoluteUrl (#90667 ) * Refactor url creatUrl and add tests * update createUrl to createRelativeUrl in GrafanaRules.tsx * Add slash if not present in createAbsoluteUrl * Use template type forcing url parameter to start with slash instead of adding slash if not present * address review comment	10 months ago
Tom Ratcliffe	6fcf594b32	Alerting: Add eslint testing-library plugin dependency and create separate ESLint config (#91052 )	10 months ago
Tom Ratcliffe	9d639278f4	Alerting: Refactor simplified routing contact points hook (#90762 )	10 months ago
Gilles De Mey	746e2eeee6	Alerting: Add validation for path separators in the rule group edit modal (#90887 ) Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	10 months ago
Sonia Aguilar	8423d06988	Alerting: Implement UI for grafana-managed recording rules (#90360 ) * Implement UI for grafana-managed recording rules * use undefined for the duration instead of null , for recording rules * Fix tests * add tests * Add pause functionality for grafana recording rules * update translations * remove obsolete snapshot * use createUrl instead of renderUrl * refactor * Add validation for grafana recording rule name * create util functions for rule types and add record field in mock function * add util isDatatSourceManagedRuleByType * refactor * Add metric field in alert rule form * fix alert name component * update width for alert name and metric * fix test * add validation back to cloud recording rules name * Alerting: Recording rules PR review (#90654) Update type helper methods * add slash in createUrl * fix baseurl in the returnTo * nits * Add metric on expanded row in the alert list view * nits Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com> * update snapshot --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	10 months ago
Tom Ratcliffe	a61cd94a70	Alerting: Tidy up contact points/misc other tests' mock server behaviour (#90469 )	10 months ago
Tom Ratcliffe	7829fced94	Alerting: Hide edit/view rule buttons according to deleting/creating state (#90375 )	10 months ago
Sonia Aguilar	dbc755925d	Alerting: Track central ash interactions (#90330 ) * Track central ash interactions * refactor	10 months ago
Tom Ratcliffe	0547a9ed88	Alerting: Remove unneeded uses of setBackendSrv in alerting tests (#90380 )	10 months ago
Gilles De Mey	e64ef2245c	Alerting: Re-organise rule group hooks (#90368 )	11 months ago
Ashley Harrison	b321dc7280	Chore: Migrate from `react-beautiful-dnd` to `@hello-pangea/dnd` (#90328 ) * migrate from react-beautiful-dnd to @hello-pangea/dnd * revert comment	11 months ago
Gilles De Mey	6874202dfa	Alerting: Implement "rename / move / update" for `useProduceNewRuleGroup` (#89706 )	11 months ago

1 2 3 4 5 ...

366 Commits (0c9ca20bc586214a54d09e073a24fac551ac8fac)