grafana

Commit Graph

Author	SHA1	Message	Date
Alexander Weaver	d66ed6fe35	Alerting: Move stray model structs in store package to model package (#55968 ) * Move stray command structs to model package like the rest * Fix broken references	3 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902 ) * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	3 years ago
Jean-Philippe Quéméner	d88f1c8e35	Alerting: validate am config changes before persisting (#54908 )	3 years ago
Jean-Philippe Quéméner	e41f78a56d	Alerting: make sure to update contact point references when updating (#54896 )	3 years ago
Alexander Weaver	b193eaed6e	Alerting: Resetting the notification policy tree to the default policy will also restore default contact points (#54608 ) * Add test that resetting the route restores the default receiver * Return error instead of panic * Adjust error string to match styleguide	3 years ago
Alexander Weaver	f093c249ac	Alerting: Fix incorrect embedded DTO being returned when handling rule groups (#53701 ) * Fix DTO embedding when getting/putting alert rule groups * Drop usage of word 'Domain' * Rename var as well	3 years ago
Jean-Philippe Quéméner	e14c91d5d4	Alerting: fetch interval from stored namespace UID (#53195 )	3 years ago
Alexander Weaver	b198559225	Alerting: Extend PUT rule-group route to write the entire rule group rather than top-level fields only (#53078 ) * Wire up to full alert rule struct * Extract group change detection logic to dedicated file * GroupDiff -> GroupDelta for consistency * Calculate deltas and handle backwards compatible requests * Separate changes and insert/update/delete as needed * Regenerate files * Don't touch the DB if there are no changes * Quota checking, delete unused file * Mark modified records as provisioned * Validation + a couple API layer tests * Address linter errors * Fix issue with UID assignment and rule creation * Propagate top level group fields to all rules * Tests for repeated updates and versioning * Tests for quota and provenance checks * Fix linter errors * Regenerate * Factor out some shared logic * Drop unnecessary multiple nilchecks * Use alternative strategy for rolling UIDs on inserted rules * Fix tests, add back nilcheck, refresh UIDs during test * Address feedback * Add missing nil-check	3 years ago
Alex Ratner	fecf4c41ad	Dashboard: Spelling corrections in end-user visible dialogs (#53340 )	3 years ago
Jean-Philippe Quéméner	54217a2037	Alerting: set dashboard and panel id using annotations in provisioning api (#53221 )	3 years ago
Yuriy Tseretyan	6e1e4a4215	Alerting: Update DbStore to use disabled orgs from the config (#52156 ) * update DbStore to use UnifiedAlerting settings * remove disabled orgs from scheduler and use config in db store instead * remove test	3 years ago
idafurjes	17ec9cac83	Add delete user from other services/stores (#51912 ) * Remove user from preferences, stars, orguser, team member * Fix lint * Add Delete user from org and dashboard acl * Delete user from user auth * Add DeleteUser to quota * Add test files and adjust user auth store * Rename package in wire for user auth * Import Quota Service interface in other services * do the same in tests * fix lint tests * Fix tests * Add some tests * Rename InsertUser and DeleteUser to InsertOrgUser and DeleteOrgUser * Rename DeleteUser to DeleteByUser in quota * changing a method name in few additional places * Fix in other places * Fix lint * Fix tests * Rename DeleteOrgUser to DeleteUserFromAll * Update pkg/services/org/orgimpl/org_test.go Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Update pkg/services/preference/prefimpl/inmemory_test.go Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Rename Acl to ACL * Fix wire after merge with main * Move test to uni test Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	3 years ago
Jean-Philippe Quéméner	41790083d2	Alerting: Add file provisioning for alert rules (#51635 )	3 years ago
Alexander Weaver	2d7389c34d	Alerting: Provisioning API respects global rule quota (#52180 ) * Inject interface for quota service and create mock * Check quota and return 403 if limit exceeded * Implement tests for quota being exceeded	3 years ago
Alexander Weaver	0e066dd5f8	Alerting: Allow filtering of contact points by name (#51933 ) * Define query param and regenerate * Add query struct for contact points * Filter contact points by name in query * Document that name filter is optional	3 years ago
Matthew Jacobson	434e94ef2b	Alerting: Update default route groupBy to [grafana_folder, alertname] (#50052 ) * Alerting: Update default route groupBy to [grafana_folder, alertname] Default group by for new routes and migrations is now [grafana_folder, alertname]	3 years ago
Alexander Weaver	fce283d73e	Alerting: Add method to reset notification policy tree back to the default (#51934 ) * Define route and run codegen * Wire up HTTP layer * Update API layer and test fakes * Implement reset of policy tree * Implement service layer test and authorization bindings * API layer testing * Be more specific when injecting settings	3 years ago
Jean-Philippe Quéméner	4a76436be2	Altering: validate that the mute time intervals exist when updating routing tree (#51573 ) * validate that the mute time intervals exist when updating routing tree * run lint * add tests	3 years ago
Alexander Weaver	b9c7eb1380	Alerting: Add method to provisioning API for obtaining a group and its rules (#51398 ) * Generate shell for new route * Propagate path parameters * Implement route logic * Add a couple simple tests * Use NotFound error for not found, avoid returning pointer * Regenerate	3 years ago
Jean-Philippe Quéméner	e64cde8727	Alerting: validate that the receiver exist when updating routing tree (#51561 ) * Alerting: validate that the receiver exist when updating routing tree * rename interface * add missing file * change constructor * fix e2e tests * only import package once * add unit test for bug * wording * close response body * Update pkg/services/ngalert/api/tooling/definitions/alertmanager_validation.go * refactor to remove database roundtrip	3 years ago
Jean-Philippe Quéméner	bf255965a2	Alerting: prevent the use of the same uid across all contact points (#51440 ) * Alerting: prevent the use of the same uid across all contact points * Update pkg/services/ngalert/provisioning/contactpoints.go Co-authored-by: Yuriy Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Yuriy Tseretyan <yuriy.tseretyan@grafana.com>	3 years ago
Alexander Weaver	0d9389e1f4	Alerting: Code-gen parsing of URL parameters and fix related bugs (#50731 ) * Extend template and generate * Generate and fix up alertmanager endpoints * Prometheus routes * fix up Testing endpoints * touch up ruler API * Update provisioning and fix 500 * Drop dead code * Remove more dead code * Resolve merge conflicts	3 years ago
Alexander Weaver	9bbfeedadf	Alerting: Create algorithm to process receiver changes and keep them consistent internally (#50738 ) * Algorithm to fix up receivers * Extract for tests * Add tests, fix bug * Add test which demonstrates how it fixes up broken groups * Fix package prefix	3 years ago
Jean-Philippe Quéméner	ed6a887737	Alerting: remove unused function in alert rule store (#50696 )	3 years ago
Jean-Philippe Quéméner	862f51216b	Alerting: improve provisioning docs (#50347 ) * Alerting: improve provisioning docs * add new provisioning page * add api docs * fix formatting and add better descriptions * fix typo	3 years ago
Alexander Weaver	7dd78fee2c	Alerting: Fix provisioning validation status codes and panics (#50464 ) * Updates to all except alert rules * Return 400 when rules fail to validate, add testinfra * More sane package aliases * More package alias renames * One more bug in contact point validation * remove unused function Co-authored-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>	3 years ago
Jean-Philippe Quéméner	cf684ed38f	Alerting: bump rule version when updating rule group interval (#50295 ) * Alerting: move group update to alert rule service * rename validateAlertRuleInterval to validateRuleGroupInterval * init baseinterval correctly * add seconds suffix * extract validation function for reusability * add context to err message	3 years ago
Jean-Philippe Quéméner	8de4ffe61f	Alerting: only delete mute time if not used by route (#50193 ) * Alerting: only delete mute time if not used by route * add a testcase * import package only once * replace apimodels with definitions	3 years ago
Jean-Philippe Quéméner	468ed68d64	Alerting: allow custom UID for contact points through API (#50089 ) * Alerting: allow custom UID for contact points through API * fix auth	3 years ago
Jean-Philippe Quéméner	81d360529b	Alerting: Provisioning API - Alert rules (#47930 )	3 years ago
Alexander Weaver	909ebcf979	Alerting: Endpoints for provisioning mute timings (#49635 ) * Add validator for mute timing and make it provisionable * Add tests to ensure prometheus validators are running and errors are propagated * Internal API for manipulating mute timings * Define and generate API layer * Wire up generated code * Implement API handlers * Tests for golang layer * Fix reference bug * Fix linter and auth tests * Resolve semantic errors and regenerate * Remove pointless comment * Extract out provisioning path param keys, simplify * Expected number of paths	3 years ago
Alexander Weaver	a92f85a87b	Alerting: Factor out shared code for working with configs in provisioning package (#49419 ) * Factor out shared code for working with configs * Refactor in notification policies and contact points * Better file ordering * Address feedback	3 years ago
Alexander Weaver	e8b498fe8b	Parse template when validating it (#49282 )	3 years ago
Alexander Weaver	9af30f6570	Alerting: Provisioning GET routes for mute timings (#49044 ) * Define GET routes and run codegen * Wire up forked and non-generated API * Implement and wire * Tests, authorization * Fix linter error	3 years ago
Alexander Weaver	0f56462fbe	Alerting: Provisioning message templates (#48665 ) * Generate API for writing templates * Persist templates app logic layer * Validate templates * Extract logic, make set and delete methods * Drop post route for templates * Fix response details, wire up remainder of API * Authorize routes * Mirror some existing tests on new APIs * Generate mock for prov store * Wire up prov store mock, add tests using it * Cover cases for both storage paths * Add happy path tests and fix bugs if file contains no template section * Normalize template content with define statement * Tests for deletion * Fix linter error * Move provenance field to DTO * empty commit * ID to name * Fix in auth too	3 years ago
Alexander Weaver	735822e48a	Alerting: Add provisioning GET routes for message templates (#48367 ) * Template service * Add GET routes and implement them * Generate mock for persist layer * Unit tests for reading templates * Set up composition root and get integration tests working * Fix prealloc issue * Extract setup boilerplate * Update AuthorizationTest * Rebase and resolve * Fix linter error	3 years ago
Alexander Weaver	60ec10566f	Extract Route validation from serialization methods so it can be re-used (#47649 ) * Extract validation and reject invalid policies * Validation in dedicated file * Tests for validation * Extract root route validation * Update call and drop TODO * empty commit to kick actions * Normalization should be idempotent * Cleaner representation of validation errors, chain errors properly * Make internal validate unexported * Fix missed rename * Genericize error message * Improve method names * Rebase, fix * Update asserts	3 years ago
Alexander Weaver	078a578803	Drop ProvenanceOrgAdapter and build into store API instead (#48137 )	3 years ago
Alexander Weaver	8310789ef1	Indicate whether routes are provisioned when GETting Alertmanager configuration (#47857 ) * Test composition simplification from last PR * Policies use proper API model everywhere * Expose policy provenance in API, miss some dep injection * Complete injection * fix args * Tests for provenance value * Extract test helpers so tests are very readable * Single source adapter struct that was copied in 3 places * Drop redundant test * Resolve merge conflicts on changelog	3 years ago
Jean-Philippe Quéméner	388ecb4037	Alerting: Provisioning API - Contact points (#47197 )	3 years ago
Alexander Weaver	dde0b93cf1	Alerting: Provisioning API - Notification Policies (#46755 ) * Base-line API for provisioning notification policies * Wire API up, some simple tests * Return provenance status through API * Fix missing call * Transactions * Clarity in package dependencies * Unify receivers in definitions * Fix issue introduced by receiver change * Drop unused internal test implementation * FGAC hooks for provisioning routes * Polish, swap names * Asserting on number of exposed routes * Don't bubble up updated object * Integrate with new concurrency token feature in store * Back out duplicated changes * Remove redundant tests * Regenerate and create unit tests for API layer * Integration tests for auth * Address linter errors * Put route behind toggle * Use alternative store API and fix feature toggle in tests * Fixes, polish * Fix whitespace * Re-kick drone * Rename services to provisioning	3 years ago

41 Commits (23e04c0f9c5ee419fa54fc4bf2c9807d19f1fd51)