grafana

Commit Graph

Author	SHA1	Message	Date
Joe Blubaugh	5e4fd94413	Alerting: Write and Delete multiple alert instances. (#54072 ) Prior to this change, all alert instance writes and deletes happened individually, in their own database transaction. This change batches up writes or deletes for a given rule's evaluation loop into a single transaction before applying it. Before: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 398 2991381 ns/op 1133537 B/op 27703 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: FovKXiRVzm} with title: "an alert definition FTvFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: foDFXmRVkm} with title: "an alert definition fovFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: VQvFuigVkm} with title: "an alert definition VwDKXmR4kz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.619s ``` After: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 1440 816484 ns/op 352297 B/op 6529 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: 302r_igVzm} with title: "an alert definition q0h9lmR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: 71hrlmR4km} with title: "an alert definition nJ29_mR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: Cahr_mR4zm} with title: "an alert definition ja2rlmg4zz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.383s ``` So we cut time by about 75% and memory allocations by about 60% when storing and deleting 100 instances. This change also updates some of our tests so that they run successfully against postgreSQL - we were using random Int64s, but postgres integers, which our tables use, max out at 2^31-1	3 years ago
Timur Olzhabayev	b5b41988cf	Docs: Deprecating packages_api and removing it from our pipelines (#54473 )	3 years ago
Yuriy Tseretyan	76ea0b15ae	Alerting: Scheduler to fetch folders along with rules (#52842 ) * Update GetAlertRulesForScheduling to query for folders (if needed) * Update scheduler's alertRulesRegistry to cache folder titles along with rules * Update rule eval loop to take folder title from the * Extract interface RuleStore * Pre-fetch the rule keys with the version to detect changes, and query the full table only if there are changes.	3 years ago
Jean-Philippe Quéméner	49b1182f34	Alerting: add missing yaml tag to mute time struct (#54287 )	3 years ago
Yuriy Tseretyan	db09a76125	update test environment to create folders (#54254 )	3 years ago
Marcus Efraimsson	87afd9cadc	Plugins: Remove various custom headers logic (#54146 ) Removes various custom headers logic sprinkled around in the backend. It should automatically be applied to outgoing HTTP requests via the CustomHeadersMiddleware. This also removes decryption of SecureJSONData to populate custom headers in ngalert which seemed to have caused a ton of CPU usage.	3 years ago
Karl Persson	5a1b9d2283	RBAC: Remove DeclareFixedRoles wrapper on Access control and inject service (#54153 ) * RBAC: Remove DeclareFixedRoles wrapper on Access control and inject service when needed	3 years ago
Yuriy Tseretyan	03e746d9df	Alerting: Delete state from the database on reset (#53919 ) * make ResetStatesByRuleUID return states * delete rule states when reset * rule eval routine to clean up the state only when rule is deleted	3 years ago
Yuriy Tseretyan	41bd36eb97	Alerting: Update rules delete endpoint to handle rules in group (#53790 ) * update RouteDeleteAlertRules rules to update as a group * remove expecter from scheduler mock to support variadic function * create function to check for provisioning status + tests Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	3 years ago
Santiago	4fad827acd	Alerting: log external alertmanager URLs #54127	3 years ago
Valério Valério	b5142832fa	Alerting: Fix saving of screenshots uploaded with a signed url (#53933 ) The URL of screenshots uploaded to external image storages can be optionally signed, resulting in a long string (800+ chars).	3 years ago
George Robinson	e163a976fa	Alerting: Fix width of Adapative Cards in Teams notifications (#53996 )	3 years ago
George Robinson	c960301aa8	Alerting: Fix links in Microsoft Teams notifications (#54003 )	3 years ago
Alexander Weaver	c7b93ec331	Make channels_config no longer depend on legacy alerting (#53799 )	3 years ago
Yuriy Tseretyan	9f90a7b54d	Alerting: State manager to use InstanceStore (#53852 ) * move saving the state to state manager when scheduler stops * move saving state to ProcessEvalResults * add GetRuleKey to State * add LogContext to AlertRuleKey	3 years ago
George Robinson	6d69d7acb8	Alerting: Fix notifications for Microsoft Teams (#53810 ) This commit fixes notifications for Microsoft Teams where notifications would just contain "Card" rather than the title.	3 years ago
sh0rez	635571db8a	pkg/web: remove Router and Logger from Context (#53765 ) web.Context previously held references to the current *web.Router albeit not using it. It also had a log.Logger only being used once internally	3 years ago
Alexander Weaver	f093c249ac	Alerting: Fix incorrect embedded DTO being returned when handling rule groups (#53701 ) * Fix DTO embedding when getting/putting alert rule groups * Drop usage of word 'Domain' * Rename var as well	3 years ago
Alexander Weaver	ccd41df603	Fix order-of-magnitude bug in DTO conversion (#53690 )	3 years ago
Yuriy Tseretyan	d8d97d15ba	Alerting: AlertingProxy to elevate permissions for request forwarded to data proxy when RBAC enabled (#53620 )	3 years ago
Jean-Philippe Quéméner	7f0002448d	Alerting: use duration model for alert rule provisioning api (#53196 )	3 years ago
Jean-Philippe Quéméner	e14c91d5d4	Alerting: fetch interval from stored namespace UID (#53195 )	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343 ) * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
Jo	ca72cd570e	Remove ioutil.ReadDir from usage (#53550 ) * add depguard rule for ioutil * replace ioutil.ReadDir with os.ReadDir * use legacy option in depguard supported in golangci-lint v1.40 * replace ioutil.ReadDir with os.ReadDir * return error for file info	3 years ago
George Robinson	5e1d628f21	Alerting: Use Adaptive Cards in Teams notifications (#53532 ) This commit changes the cards in Teams notifications from Office 365 Connector cards to Adaptive Cards to fix an issue where images were not shown in Teams for desktop and web. Since Office 365 Connector cards are deprecated, it made sense to move to Adapative Cards and fix this bug at the same time. The Adaptive Card messages maintain the design of the Office 365 Connector Card with a number of minor differences: - In Adaptive Card messages the color of the title is red or green depending on the status of the alerts, where as with Office 365 connector cards there was a colored border at the top of the title - In Adaptive Card messages the title is bold to make it easier to read when the color is red or green - In Adaptive Card messages the thumbnails for images are medium size if there are more than two images, otherwise large size	3 years ago
Alexander Weaver	b198559225	Alerting: Extend PUT rule-group route to write the entire rule group rather than top-level fields only (#53078 ) * Wire up to full alert rule struct * Extract group change detection logic to dedicated file * GroupDiff -> GroupDelta for consistency * Calculate deltas and handle backwards compatible requests * Separate changes and insert/update/delete as needed * Regenerate files * Don't touch the DB if there are no changes * Quota checking, delete unused file * Mark modified records as provisioned * Validation + a couple API layer tests * Address linter errors * Fix issue with UID assignment and rule creation * Propagate top level group fields to all rules * Tests for repeated updates and versioning * Tests for quota and provenance checks * Fix linter errors * Regenerate * Factor out some shared logic * Drop unnecessary multiple nilchecks * Use alternative strategy for rolling UIDs on inserted rules * Fix tests, add back nilcheck, refresh UIDs during test * Address feedback * Add missing nil-check	3 years ago
Jo	062d255124	Handle ioutil deprecations (#53526 ) * replace ioutil.ReadFile -> os.ReadFile * replace ioutil.ReadAll -> io.ReadAll * replace ioutil.TempFile -> os.CreateTemp * replace ioutil.NopCloser -> io.NopCloser * replace ioutil.WriteFile -> os.WriteFile * replace ioutil.TempDir -> os.MkdirTemp * replace ioutil.Discard -> io.Discard	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445 ) * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
George Robinson	196b781c70	Alerting: Delete expired images from the database (#53236 ) This commit adds a DeleteExpiredService that deletes expired images from the database. It is run in the periodic collector service.	3 years ago
Alex Ratner	fecf4c41ad	Dashboard: Spelling corrections in end-user visible dialogs (#53340 )	3 years ago
Jean-Philippe Quéméner	54217a2037	Alerting: set dashboard and panel id using annotations in provisioning api (#53221 )	3 years ago
Yuriy Tseretyan	718620c197	Alerting: Update forking request handlers to use the same errors (#52965 ) * generalize error handling in forking request handlers * remove MatchesBackend and change test to test Can * add 404 to route specs * change backendTypeByUID to getDatasourceByUID of expected type * use common errors in api testing * handle 401 in errorToResponse * replace backend type error with "unexpected datasource type" * update swagger spec	3 years ago
Alexander Weaver	c50cbea0bb	Alerting: Extract alert rule diff logic into separate file with exported API (#53083 ) * Refactor diff logic into separate file with exported API * Fix linter complaint	3 years ago
Yuriy Tseretyan	5fb778814c	Alerting: Update rules version when folder title is updated (#53013 ) * remove support for bus from scheduler * rename event to FolderTitleUpdated and fire only if title has changed * add method to increase version of all rules that belong to a folder * update ngalert service to subscribe to folder title change event call data store and update scheduler * add tests	3 years ago
Alexander Weaver	cc20f04860	Alerting: Increase alert rule operation perf by replacing subquery with threshold calculation (#53069 ) * Replace subquery with threshold calculation * Use offset/limit to account for orgs with large gaps in IDs * Collapse into one statement * Drop dead constants * Revert to 2 query approach * Drop unused consts again	3 years ago
Alexander Emelin	e791a4e576	Search: Move entity events to transaction (#52394 )	3 years ago
Konrad Lalik	54f2c056f5	Alerting: Configure alert manager data source as an external AM (#52081 ) Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com> Co-authored-by: gotjosh <josue.abreu@gmail.com> Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	3 years ago
Yuriy Tseretyan	a081764fd8	Alerting: Scheduler to use AlertRule (#52354 ) * update GetAlertRulesForSchedulingQuery to have result AlertRule * update fetcher utils and registry to support AlertRule * alertRuleInfo to use alert rule instead of version * update updateCh hanlder of ruleRoutine to just clean up the state. The updated rule will be provided at the next evaluation * update evalCh handler of ruleRoutine to use rule from the message and clear state as well as update extra labels * remove unused function in ruleRoutine * remove unused model SchedulableAlertRule * store rule version in ruleRoutine instead of rule * do not call the sender if nothing to send	3 years ago
gotjosh	d762de7aa7	Revert "Alerting: Add support for images in Line alerts (#50703 )" (#52593 ) This reverts commit `0af09b8c57`.	3 years ago
George Robinson	0af09b8c57	Alerting: Add support for images in Line alerts (#50703 )	3 years ago
gotjosh	b026f2bc5d	Alerting: Allow the webhook notifier to support a custom Authorization header (#52515 ) * Allow the webhook notifier to support a custom Authorization header Instead of doing something clever of re-using the existing username/password fields of Basic Authentication - I opted for two diffent fields to match the upstream Alertmanager configuration (that in turn is based of the HTTP Basic authentication). It'll fail if you have values for both HTTP Basic Authentication and Authorization.	3 years ago
Jean-Philippe Quéméner	ba9c18d9c3	Alerting: use static channel configuration to determinate secure fields (#52527 ) * Alerting: use static channel configuration to determinate secure fields * move to channels package * introduce channel_config package to fix cyclic import * add missing changes * compare type to type	3 years ago
Jean-Philippe Quéméner	320262c3db	Alerting: Cleanup the `alert_configuration` table on write (#51497 )	3 years ago
Jean-Philippe Quéméner	50ae42130b	Alerting: take datasources as external alertmanagers into consideration (#52534 )	3 years ago
Yuriy Tseretyan	79d92aa03e	Alerting: Rename sender.Sender to sender.ExternalAlertmanagers (#52463 )	3 years ago
George Robinson	094dfd0d4d	Alerting: Fix Slack push notifications (#52391 ) This commit fixes push notifications for Slack which used to show "This content cannot be displayed". The text field is shown in both the message and the push notification.	3 years ago
Yuriy Tseretyan	054fe54b03	Alerting: Split Scheduler and AlertRouter tests (#52416 ) * move fake FakeExternalAlertmanager to sender package * move tests from scheduler to router * update alerts router to have all fields private * update scheduler tests to use sender mock	3 years ago
Peter Holmberg	e74c2390de	Alerting: Prevent evaluation if "for" shorter than "evaluate" (#51797 ) Co-authored-by: Armand Grillet <armand.grillet@outlook.com>	3 years ago
George Robinson	e7feff6d99	Alerting: Move debug log line to where alert rules are updated (#52318 )	3 years ago
idafurjes	f5cace8bbd	Rename Acl to ACL (#52342 ) * Rename Acl to ACL * Fix yaml files * Add xorm tags and fix test	3 years ago

1 2 3 4 5 ...

661 Commits (5e4fd94413387e3f9692acc49aa5de9442bb2951)