grafana

Commit Graph

Author	SHA1	Message	Date
Armand Grillet	74a79b517d	Update Alerting changelog (#56684 ) Now simpler to use.	3 years ago
Peter Holmberg	e74c2390de	Alerting: Prevent evaluation if "for" shorter than "evaluate" (#51797 ) Co-authored-by: Armand Grillet <armand.grillet@outlook.com>	3 years ago
gotjosh	90646e7f41	Alerting: Don't stop the migration when alert rule tags are invalid (#51253 ) * Alerting: Don't stop the migration when alert rule tags are invalid As we migrate we expect the `alertRuleTags` on a dashboard alert to be a JSON object. However, it seems this is not really validated by Grafana and an user can change the format to something else that the JSON parser is not able to marshal into a `map[string]string`. Let's do a bit better by "attempting" to parse the tags and if we can't we'll simple return an empty map. The data is still there so if the user wishes they can go back, fix the data and attemp the migration again.	3 years ago
Yuriy Tseretyan	4d02f73e5f	Alerting: Persist rule position in the group (#50051 ) Migrations: * add a new column alert_group_idx to alert_rule table * add a new column alert_group_idx to alert_rule_version table * re-index existing rules during migration API: * set group index on update. Use the natural order of items in the array as group index * sort rules in the group on GET * update the version of all rules of all affected groups. This will make optimistic lock work in the case of multiple concurrent request touching the same groups. UI: * update UI to keep the order of alerts in a group	3 years ago
Yuriy Tseretyan	157c12211d	Alerting: State manager to use tick time to determine stale states (#50991 ) * use correct stale timestamp * calculate stale using tick time instead of time.now * remove unused dependency on sql store	3 years ago
Matthew Jacobson	5dee2ed24c	Alerting: Add first Grafana reserved label grafana_folder (#50262 ) * Alerting: Add first Grafana reserved label g_label g_label holds the title of the folder container the alert. The intention of this label is to use it as part of the new default notification policy groupBy. * Add nil check on updateRule labels map * Disable gocyclo lint on schedule.ruleRoutine will remove later in a separate refactoring PR to reduce complexity. * Address doc suggestions * Update g_folder for rules in folder when folder title changes * Remove global bus in FolderService * Modify tests to fit new common g_folder label * Add changelog entry * Fix merge conflicts * Switch GrafanaReservedLabelPrefix from `g_` to `grafana_`	3 years ago
Yuriy Tseretyan	c1550d1f07	Alerting: Rule api to fail update if provisioned rules are affected (#50835 ) * add function that checks whether changes mention provisioned rules * update API that updates group of rules to fail if check does not pass	3 years ago
Yuriy Tseretyan	c314ce48c7	Alerting: Support for optimistic locking for alert rules (#50274 ) * add support for optimistic locking for alert_rule table * return 409 in the case of opitimistic lock	3 years ago
Yuriy Tseretyan	b0ae4d460e	Alerting: Make ticker to tick at predictable time (#50197 )	3 years ago
Santiago	9dc7e752b7	Optional custom title and description for OpsGenie (#50131 ) * optional custom description for OpsGenie * custom title and message, tests * update changelog * check for empty / whitespace only strings * truncate the title to 130 characters if needed * unnecessary validation removed * truncate title to 127 characters and add three dots	3 years ago
gotjosh	c59938b235	Alerting: Schedule Alert rules metric tracking (#50415 ) * Alerting: Schedule Alert rules metric tracking Change the record of metrics from one place to two as an attempt to have a semi-accurate record.	3 years ago
Yuriy Tseretyan	a89d4a5be7	Alerting: Scheduler to drop ticks if a rule's evaluation is too slow (#48885 ) * drop ticks if evaluation of a rule is too slow. * add metric schedule_rule_evaluations_missed_total	3 years ago
gotjosh	0cde283505	Alerting: Logs should not be capitalized and the errors key should be "err" (#50333 ) * Alerting: decapitalize log lines and use "err" as the key for errors Found using (logger\|log).(Warn\|Debug\|Info\|Error)\([A-Z] and (logger\|log).(Warn\|Debug\|Info\|Error)\(.+"error"	3 years ago
George Robinson	c83f84348c	Alerting: Fix database unavailable removes rules from scheduler (#49874 )	3 years ago
Yuriy Tseretyan	49d93fb67e	Alerting: Update alert rule diff to not see difference between nil and empty map (#50192 )	3 years ago
gotjosh	1a50b0dbb7	Alerting: Remove double quotes from matchers (#50038 ) * Alerting: Remove double quotes from matchers With #38629 a new Alertmanager configuration object was introduced with `object_matchers`, it was meant to circumvent around the fact that Prometheus label names don't support a set of characters that Grafana needs to support for alerts, silences, matchers, etc. (with a common example being elasticsearch's `.`). This new object does not include the label of sanitzation or validation that its Prometheus equivalent supports in `matchers` and therefore are semantically not equivalent. This triggered the problem that when the migration is run, we use `matchers` as the object to populate in configuration for routing policies, but when the UI does its first save this object is transformed to `object_matchers`. Matchers that were previously running just fine would immediately stop working as soon as the configuration is saved. This problem surfaced with the introduction of #49952 where we stopped stripping double quotes from matchers (not just regex but _all_ of them). * Add comment explaining rationale and future removal Co-authored-by: Alex Weaver <weaver.alex.d@gmail.com>	3 years ago
Yuriy Tseretyan	c8d891785d	Alerting: Ticker to support stopping (#48142 ) * add stop for ticker * stop ticker when scheduler stops * stop ticker when legacy engine stops	3 years ago
Joe Blubaugh	a0193c248f	Alerting: Add entries to ngAlert changelog for screenshots. (#49457 ) Notes the PRs that added the feature.	3 years ago
Yuriy Tseretyan	3dfafbadef	Alerting: Fix access to alerts for viewer with editor permissions when RBAC is disabled (#49270 ) * Add folder edit permission for users with Viewer role * relax permissions required to create an alert when RBAC is disabled	3 years ago
Yuriy Tseretyan	258b3ab18b	Alerting: Fix RBAC actions for notification policies (#49185 ) * squash actions "alert.notifications:update", "alert.notifications:create", "alert.notifications:delete" to "alert.notifications:write" * add migration * update UI to use the write action * update docs * changelog	3 years ago
Yuriy Tseretyan	f7f2253072	Alerting: Fix anonymous access to alerting (#49203 ) * introduce a fallback handler that checks that role is Viewer. * update UI nav links to allow alerting tabs for anonymous user * update rule api to check for Viewer role instead of SignedIn when RBAC is disabled	3 years ago
Yuriy Tseretyan	d87fdc1037	Alerting: Update migration to migrate only alerts that belong to existing org\dashboard (#49192 ) * Update migration to migrate only alerts that belong to existing org\dashboard	3 years ago
Yuriy Tseretyan	e528f2e430	Alerting: Use UID scope for folders authorization (#48970 )	3 years ago
Yuriy Tseretyan	00ef1acb93	Alerting: Create folder for alerting when start from the scratch (#48866 ) * create folderHelper struct	3 years ago
gotjosh	7313310080	Alerting: Fix & Cut the changelog (#48714 )	3 years ago
Jean-Philippe Quéméner	9e21e4d1c1	Alerting: indicate whether an alertrule is provisioned (#48458 )	3 years ago
gotjosh	d451d02628	Alerting Changelog: Cut & Fix (#48402 )	3 years ago
Jean-Philippe Quéméner	a3256bafa7	Alerting: indicate whether contact point is provisioned (#48323 )	3 years ago
Matthew Jacobson	0301d956da	Alerting: Create fewer contact points on migration (#47291 ) * Alerting: Create fewer contact points on migration Previously a new contact point was created for every unique combination of channels attached to any legacy alert. This was very hard to maintain, requiring modifications in every generated contact point. This change deduplicates the generated contact points to a more reasonable state. There should now only be one contact point per legacy channel, and we attached multiple contact points to a route by nesting them. The sole exception to this is if there were multiple default legacy channels, in which case we create a redundant contact point containing all of them used only in the root policy. This allows for a much simpler notification policy structure. Co-authored-by: gotjosh <josue.abreu@gmail.com>	3 years ago
gotjosh	25c07ff85e	Alerting: Wrap legacy alerting metrics with `legacy_` (#48190 ) * Alerting: Wrap legacy alerting metrics with `legacy_`	3 years ago
Yuriy Tseretyan	75ba4e98c6	Alerting: Remove unused features from ticker + metric + tests (#47828 ) * remove not used code: - remove offset in ticket because it is not used - remove unused ticker and scheduler methods * use duration for interval * add metrics grafana_alerting_ticker_last_consumed_tick_timestamp_seconds, grafana_alerting_ticker_next_tick_timestamp_seconds, grafana_alerting_ticker_interval_seconds	3 years ago
Alexander Weaver	8310789ef1	Indicate whether routes are provisioned when GETting Alertmanager configuration (#47857 ) * Test composition simplification from last PR * Policies use proper API model everywhere * Expose policy provenance in API, miss some dep injection * Complete injection * fix args * Tests for provenance value * Extract test helpers so tests are very readable * Single source adapter struct that was copied in 3 places * Drop redundant test * Resolve merge conflicts on changelog	3 years ago
Joe Blubaugh	3d91047e6e	Alerting: Notification URL points to alert view page instead of alert edit page (#47752 ) Before this change, notifications generated by the Grafana Alertmanager pointed to '/alerting/:ruleID/edit'. This change instead points them to the view path '/alerting/grafana/:ruleID/view'. The view page has a better UX, including timeseries display. It's also where many alert state improvements will land in the next few versions of Grafana. Fixes #45301 Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com>	3 years ago
Jean-Philippe Quéméner	060ccacbf9	Alerting: unwrap upsert into insert and update function (#47731 ) * Alerting: unwrap upsert into insert and update function * add changelog entry * remove changelog entry * rename upsertrule to updaterule * use directly alertrule model for inserts * add test for updating a rule with a conflicting name	3 years ago
Santiago	5fb80498b1	Apply templating on alert notifications on OK state (#47355 ) * OK notifications using previous evaluation data * copy rule.EvalMatches to avoid changes to the underlying array * test cases added/modified * delete trailing newline * fix double newline in go import * add change to the changelog * specify that this only affects legacy alerting (changelog) * use current eval data instead of prev eval data * create evalMatch just once * code comments, renamings, getTemplateMatches() function * changelog and docs updated	3 years ago
Yuriy Tseretyan	884c885289	Alerting: Support OK option for Error state (#47670 ) * support OK state for Error	3 years ago
gotjosh	94f72acbb3	Alerting: Introduce an internal changelog (#47390 ) * Alerting: Introduce an internal changelog Please note that this is not intented to replace Grafana's "add to changelog" label. It is _mostly_ for internal consumption of the Alerting team that owns this part of Grafana. * Fix markdown formatting * Fix changelog entry	3 years ago

37 Commits (8d7314bb9a296fb9f8bf1e4f9a21cf478bb5945d)