grafana

Commit Graph

Author	SHA1	Message	Date
Sofia Papagiannaki	bb2e0dad22	Chore: Rename folder service query variables for consistency (#80735 ) Chore: Rename service query variables for consistency	2 years ago
Tania	a62db1e24b	Nested Folders: Move SharedWithMe to the top of the folders list (#79875 )	2 years ago
Sofia Papagiannaki	d89a8a3a82	Nested Folders: Fix /api/folders pagination (#79447 ) * Nested Folders: Fix /api/folders pagination We used to check access to the root folders after fetching them from the DB with pagination. This fix splits logic for fetching folders in: - fetching subfolders - fetching root folders and refactors the query for the latter so that is filters by folders with permissions * Add tests * Update benchmarks	2 years ago
Serge Zaitsev	06d2ae3ada	Chore: Move folder sync logic into one-shot migration (#78985 ) Chore: move folder sync code into one-shot migration	2 years ago
Alexander Zobnin	959ebf82da	Folders: Show dashboards and folders with directly assigned permissions in "Shared" folder (#78465 ) * Folders: Show folders user has access to at the root level * Refactor * Refactor * Hide parent folders user has no access to * Skip expensive computation if possible * Fix tests * Fix potential nil access * Fix duplicated folders * Fix linter error * Fix querying folders if no managed permissions set * Update benchmark * Add special shared with me folder and fetch available non-root folders on demand * Fix parents query * Improve db query for folders * Reset benchmark changes * Fix permissions for shared with me folder * Simplify dedup * Add option to include shared folder permission to user's permissions * Fix nil UID * Remove duplicated folders from shared list * Folders: Fix fetching empty folder * Nested folders: Show dashboards with directly assigned permissions * Fix slow dashboards fetch * Refactor * Fix cycle dependencies * Move shared folder to models * Fix shared folder links * Refactor * Use feature flag for permissions * Use feature flag * Review comments * Expose shared folder UID through frontend settings * Add frontend type for sharedWithMeFolderUID option * Refactor: apply review suggestions * Fix parent uid for shared folder * Fix listing shared dashboards for users with access to all folders * Prevent creating folder with "shared" UID * Add tests for shared folders * Add test for shared dashboards * Fix linter * Add metrics for shared with me folder * Add metrics for shared with me dashboards * Fix tests * Tests: add metrics as a dependency * Fix access control metadata for shared with me folder * Use constant for shared with me * Optimize parent folders access check, fetch all folders in one query. * Use labels for metrics	2 years ago
Sofia Papagiannaki	6d4625ad52	Alerting: Fix deleting rules in a folder with matching UID in another organization (#78258 ) * Remove usage of obsolete function for deleting alert rules under folder * Apply suggestion from code review * Update tests	2 years ago
Tania	39754ba2d6	Nested Folders: Wrap create/update operations with transactions (#78000 ) * Nested Folders: Add transaction to create and update methods * Update tests * Make IncreaseVersionForAllRulesInNamespace synchronous * Resolve merge conflicts	2 years ago
Kat Yang	2f2ce3edbb	Chore: Deprecate ID from Folder (#78281 ) * Chore: Deprecate ID from Folder * chore: add more linter comments * chore: add missing lint comment	2 years ago
Ieva	b0448b92e5	Dashboards: Allow updating a dashboard if the user doesn't have access to the parent folder (#78075 ) * change where folder checks are done for dash creation/updates * add test for folder not being found * test fixes * more test fixes * add nlint directive to where folder IDs are used * fix bad merge * fix test	2 years ago
Kat Yang	8d581b8358	Chore: Deprecate ID in GetFolderQuery (#77647 )	2 years ago
Kat Yang	3a2e96b0db	Chore: Deprecate FolderID from Dashboard (#77823 ) * Chore: Deprecate FolderID from Dashboard * chore: add two missing nolint comments	2 years ago
Tania	1d1d42c984	Nested Folders: Decrease max nested folders depth (#78133 ) * Nested Folders: Decrease allowed nested folders depth * Fix folder height check in Move	2 years ago
Ryan McKinley	f69fd3726b	FeatureToggles: Add context and and an explicit global check (#78081 )	2 years ago
Tania	6b4337a842	Nested folders: Write to folders table even if the feature toggle is off (#77788 ) * Update folders table even if the feature toggle is off * Fix failing test * Apply review feedback * Revert test changes	2 years ago
Alexander Zobnin	a39242890e	Folders: Able to fetch folders available for user as "shared" folder (#77774 ) * Folders: Show folders user has access to at the root level * Refactor * Refactor * Hide parent folders user has no access to * Skip expensive computation if possible * Fix tests * Fix potential nil access * Fix duplicated folders * Fix linter error * Fix querying folders if no managed permissions set * Update benchmark * Add special shared with me folder and fetch available non-root folders on demand * Fix parents query * Improve db query for folders * Reset benchmark changes * Fix permissions for shared with me folder * Simplify dedup * Add option to include shared folder permission to user's permissions * Fix nil UID * Remove duplicated folders from shared list * Only left the base part * Apply suggestions from code review Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Add tests * Fix linter errors --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Sofia Papagiannaki	dfc33a70b7	Dashboards: Fix creating dashboard under folder using deprecated API (#77501 ) * Dashboards: Add integration tests for creating a dashboard * Fix creating dashboard under folder using deprecated API * Update swagger response * Fix comments	2 years ago
Sofia Papagiannaki	03a626f1d6	Search: Fix empty folder details for nested folder items (#76504 ) * Introduce dashboard.folder_uid column * Add data migration * Search: Fix empty folder details for nested folders * Set `dashboard.folder_uid` and update tests * Add unique index * lint Ignore cyclomatic complexity of func `(DashboardServiceImpl).BuildSaveDashboardCommand Fix search by folder UID	2 years ago
Serge Zaitsev	1d19dcd009	Chore: Update data migration to update rows that have changes (#76545 ) * update data migration to update rows that have changes * fix migration for sqlite * remove id; fix postgres * Fix for MySQL * delete old items from folder table * change integer to boolean --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Jo	41bcb5e07f	Identity: Port folder library to identity.Requester (#76105 ) Port folders to identity.Requester	2 years ago
Sofia Papagiannaki	376f9a75db	Folders: Do not allow modifying the folder UID via the API (#74684 ) * Folders: Do not allow changing the folder UID via the API * Update Swagger/OpenAPI docs * Update HTTP API docs	2 years ago
linoman	0e8f19ca6a	Auth: Reduce restriction with non-user accounts (#74397 ) * Reduce restrictions with non-user accounts * Revert restrictions on anonymous accounts * Change log level from warning to debug * Change log messages to upper case	2 years ago
linoman	13f4382214	Auth: Implement requester interface in access control module (#74289 ) * Implement requester interface in the access control module	2 years ago
linoman	1b8e9b51b2	Replace signed in user for identity.requester (#74048 ) * Make identity.Requester available at Context * Clean pkg/services/guardian/guardian.go * Clean guardian provider and guardian AC * Clean pkg/api/team.go * Clean ctxhandler, datasources, plugin and live * Clean dashboards and guardian * Implement NewUserDisplayDTOFromRequester * Change status code numbers for http constants * Upgrade signature of ngalert services * log parsing errors instead of throwing error	2 years ago
Jo	a307582212	Revert "Replace signed in user for identity.requester (#73750 )" (#73962 ) This reverts commit `9b9c9e83dc`.	2 years ago
linoman	9b9c9e83dc	Replace signed in user for identity.requester (#73750 ) * Make identity.Requester available at Context * Clean pkg/services/guardian/guardian.go * Clean guardian provider and guardian AC * Clean pkg/api/team.go * Clean ctxhandler, datasources, plugin and live * Question: what to do with the UserDisplayDTO? * Clean dashboards and guardian * Remove identity.Requester from ReqContext * Implement NewUserDisplayDTOFromRequester * Fix tests * Change status code numbers for http constants * Upgrade signature of ngalert services * log parsing errors instead of throwing error * Fix tests and add logs * linting	2 years ago
Karl Persson	31df4db1d3	Dashboards+Folder: remove unused function MakeUserAdmin (#73635 ) * Dashboards+Folder: remove unused function MakeUserAdmin * Remove dead branch	2 years ago
Sofia Papagiannaki	1869da1d86	Nested folders: Fetch multiple folders from dashboard folder store (#72464 )	2 years ago
Serge Zaitsev	7767ab6f43	Chore: Add folder data migration, fix unique index (#72602 ) * add folder data migration, fix unique index * fix unique index * pass a fake store in tests * pass store into other providers in tests * and now with alerting!	2 years ago
Sofia Papagiannaki	1f742fcf93	Guardian: Split dashboard and folder guardian implementation (#69722 ) * Split dashboard and folder guardian implementations * Replace guardian constructors * Simplify tests * Add tests * Apply suggestion from code review Differentiate errors for dashboard and folders * Remove tests for general folder * Add tests for general scope	2 years ago
Arati R	20ffbbc41e	NestedFolders: Add library panels counting and deletion to folder registry (#69149 ) * Expose library element service's folder service * Register library panels, add count implementation * Expand folder counts test * Update registry deletion method interface * Allow getting library elements from any folder * Add test for library panel deletion * Add test for library panel counting	2 years ago
Ieva	a65cb4d808	RBAC: remove simple RBAC disabled checks (#71137 ) * remove simple RBAC disabled checks * fixing tests * remove old AC tests	2 years ago
Sofia Papagiannaki	22147c6230	NestedFolders: Do not perform guardian checks for subfolders (#69769 ) Nested folders: Do not perform guardian checks for subfolders Permissions are inherited so if the parent has access then the subfolder has access too	2 years ago
Arati R	6cb1a5e368	Nested folders: Add alert rule counts and deletion to folder registry (#67259 ) * Let alert rule service implement registry service * Add count method to RuleStore interface * Add implementation for deletion of alert rules * Rename uid to folderUID in registry methods * Check forceDeleteRule value for registry deletion * Register alerting store with folder service * Move folder test functions to separate package * Add testing for alert rule counting, deletion * Remove redundant count method * Fix deleteChildrenInFolder signature * Update pkg/services/ngalert/store/alert_rule.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Add tests for nested folder deletion * Refactor TestIntegrationNestedFolderService * Add rules store as parameter for alertng provider --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Sofia Papagiannaki	d458292b66	Nested folders: Allow renaming a folder multiple times (#68379 ) Return folder version in response that is required for updating the entry in the dashboard table.	2 years ago
Ieva	e51b92991d	Folders: return an error when listing folders if permission guardian returns an error (#68109 ) return an error when listing folders if perm gaurdian returns an error	2 years ago
Arati R	a5206a1cda	Nested folders: Provide count of all descendant dashboards and folders (#67184 ) * Add a method for getting descendant folders * Include dashboard count for descendant folders * Return subfolder count * Replace references to children with descendants * Update openapi specs * Add test for descendant counts * Add logging to GetDescendantCounts	2 years ago
Arati R	fd434cab58	NestedFolders: Add API endpoint for descendant count in a folder (#66550 ) * Add CountInFolder to RegistryService interface * Add folder children counts api route * Update fake GetFolderChildrenCounts * Add test for getting folder children counts * Add validation to folder children counts handler * Update openapi specs * Update pkg/services/folder/folderimpl/folder.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Sofia Papagiannaki	24696d593b	Nested folders: Fix error response codes (#66943 ) * Nested folders: Fix error response codes Fix error handling	2 years ago
Arati R	cab3ba519a	NestedFolders: Add folder service registry with dashboard service implementation (#65033 ) * Delete folders, dashboards with registry service Co-authored-by: Serge Zaitsev <hello@zserge.com> * Update signature of ProvideDashboardServiceImpl * Regenerate mockery file * Add test for DeleteInFolder * Add test for DeleteDashboardsInFolder * Delete child dashboard associations via registry * Add validation of folder uid and org id --------- Co-authored-by: Serge Zaitsev <hello@zserge.com>	2 years ago
Sofia Papagiannaki	a270188f0c	Nested folders: Fix moving folder under root (#65684 ) * Nested folders: Fix moving folder under root * Add store test for not empty parent after update * Modify folder and document store update implementation Move folder only if NewParentUID is not nil * Apply suggestion from code review	2 years ago
Ieva	7860ca6c3d	RBAC: protect folder creation and moving (#64636 ) * protect moving folders to a subfolder and creating folders in a subfolder * folder update endpoint isn't used for folder parent update * lint * move permission check logic to services, fix tests * linting	2 years ago
ying-jeanne	6974f4340b	NestedFolders: Fix nested folder deletion (#63572 ) --------- Co-authored-by: suntala <arati.rana@grafana.com> Co-authored-by: ying-jeanne <ying-jeanne@users.noreply.github.com> Co-authored-by: jeanne0731 <jeanne0731@users.noreply.github.com>	2 years ago
Ieva	a52999a886	Access Control: revert to using folder store from the scope resolvers (#64132 ) * revert to using folder store from the resolvers * fixing tests after revert * api test fixes --------- Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>	2 years ago
Kristin Laemmert	bb798e24f3	chore(services): replace dependencies on dashboard store with dashboard service (#63937 ) * chore(services): replace dependencies on dashboard store with dashboard service This continues the backend service/store split by replacing dashboard store dependencies with service dependencies. the folder service remains the single exception for now; otherwise we'd have a dependency cycle between the folder and dashboard services. I have some ideas for that, but I'll take care of all the easy parts first. While doing this, I identified and removed a number of unused arguments from the following functions: NewFolderNameScopeResolver NewFolderIDScopeResolver NewFolderUIDScopeResolver NewDashboardIDScopeResolver NewDashboardUIDScopeResolver resolveDashboardScope I have a small enterprise PR to support this commit. * lingering fmt	2 years ago
Ieva	4570131fe5	Folders: simplify guardian permissions checks (#63183 ) simplify code	2 years ago
Sofia Papagiannaki	225c8dbba7	Chore: Fix fetching the General folder when nested folders is set and improve error handling (#62951 ) * Nested folders: Modify Get() not to fail fetching the General folder * Add test	2 years ago
Ieva	078639abcd	RBAC: add folder UID scope resolver (#62695 ) * add folder uid scope resolver * undo guardian change, move it to a separate PR * fix test + linting	2 years ago
Ryan McKinley	b1e58eb47e	Chore: Replace short UID generation with more standard UUIDs (#62731 )	2 years ago
Sofia Papagiannaki	ee2878f189	Chore: Fix logging message in folder service (#62939 )	2 years ago
Josh Hunt	4d268cbcdb	NestedFolders: use guardian.NewByUID to check folder permissions (#62864 )	2 years ago

1 2 3

136 Commits (de1df2f4e95b6434e9b0370e694c0b3382d106fd)