136 Commits (de1df2f4e95b6434e9b0370e694c0b3382d106fd)

Author	SHA1	Message	Date
Sofia Papagiannaki	adaf82ffb7	Nested Folder: Fix for SQLite not to overwrite the parent on restarts (#62709) ... Nested Folder: Fix for SQLite not to overwrite the arent on restarts	2 years ago
Sofia Papagiannaki	f143b0a5b2	Chore: Move folder store interface, implementation and test under pkg/services/folder (#62586) ... * Chore: Move folder store into folder service package * Split folder and dashboard store implementations	3 years ago
Ieva	ee3d742c7d	RBAC: inherit folder permissions when resolving managed permissions (#62244) ... * add nested folder scope inheritance to managed permission services * add a more specific erorr * remove circular dependencies * use errutil for returning erorr * fix tests * fix tests * define a new error in ac package	3 years ago
Serge Zaitsev	bc2813ef06	Chore: Fix goimports grouping in pkg/services (#62420) ... * fix goimports * fix goimports order	3 years ago
Kristin Laemmert	e8b8a9e276	chore: move dashboard_acl models into dashboard service (#62151)	3 years ago
Sofia Papagiannaki	cd27562c76	Access control: Modify dashboard/folder resolvers so that return also the inherited scopes (#62025) ... * Access Control: Add folder service dependency to the dashboard/folder resolvers * Expose the function fetching parents to folder interface * Add generic prepend utility * Modify dashboard resolvers to return inherited scopes	3 years ago
idafurjes	b54b80f473	Chore: Remove Result from dashboard models (#61997) ... * Chore: Remove Result from dashboard models * Fix lint tests * Fix dashboard service tests * Fix API tests * Remove commented out code * Chore: Merge main - cleanup	3 years ago
Sofia Papagiannaki	c7a7ebd3e0	Chore: Drop search service dependency from folder service (#61789) ... * Chore: Drop search service dependency from folder service	3 years ago
idafurjes	68445a7c77	Chore: Remove dashboard ACL from models (#61749) ... * Remove dashboard ACL from models * Remove unused comment	3 years ago
Sofia Papagiannaki	c104cc7020	Chore: Split folder store and dashboard store interfaces (#61655) ... * update folder store mock * Split folder store and dashboard store interfaces	3 years ago
Sofia Papagiannaki	b80c9bb974	Chore: Drop dashboard service dependency from folder service (#61614) ... * Chore: Drop dashboard dependency from folder service	3 years ago
idafurjes	b573b19ca3	Chore: Remove dashboards from models pkg (#61578) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint * Chore: Remove dashboards models * Remove dashboards from models pkg * Fix lint in tests * Fix lint in tests 2 * Fix for import in auth * Remove newline * Revert unused fix	3 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	3 years ago
Sofia Papagiannaki	e2ed42c2a3	Nested folders: Do not expose the sequential ID from the folder store (#60702) ... * Nested folders: Do not expose the sequential ID from the folder store	3 years ago
Sofia Papagiannaki	4df78cebc2	Nested Folders: Unify folder services (#60390) ... * Nested Folders: Unify folder services	3 years ago
Sofia Papagiannaki	55b014974d	Nested folders: Refactor folder update (#60323) ... * Nested folders: Refactor folder update * Apply suggestions from code review	3 years ago
Sofia Papagiannaki	b1ef5ab320	Nested Folders: Support listing nested folder children (#58566) ... * Nested Folders: Support listing nested folder children * Filter out subfolders with no permissions * Apply suggestion from code review	3 years ago
Sofia Papagiannaki	11d8bcbea9	Guardian: Introduce additional constructors (#59577) ... * Guardian: Use dashboard UID instead of ID * Apply suggestions from code review Introduce several guardian constructors and each time use the most appropriate one.	3 years ago
ying-jeanne	b059296cb0	[nested folder]Add circular reference detection in create nested folder (#60163) ... * add circulic reference detection in create neste folder * redeclare mock * add log for getHeight when depassing limit	3 years ago
ying-jeanne	1131bac5da	[Nested Folder] Block move operation that could introduce more than 8 level of depth,… (#59832) ... * block move operation that could introduce more than 8 level of depth, forbid circular reference * move getHeight to store, mock store in service * fix linter	3 years ago
Sofia Papagiannaki	798a8ceb9c	Nested folders: Fix delete (#59627) ... * Fix deleting subfolder It used to fail with beause of missing signed in user * Add logging * fixup * Fail request if deleting nested folder has failed Before we only used to log the error * Fix failing test During failed nested folder creation call the dashboard store deletion instead of the service one.	3 years ago
Sofia Papagiannaki	f5c41ea497	Nested Folders: More API fixes (#59316) ... * Nested Folder: Fix create, use camel case for JSON properties * Fix get parents if the folder does not exist * Add store test for get parents	3 years ago
Sofia Papagiannaki	8e6d343981	Nested Folders: Some API fixes (#59298) ... * Nested Folders: Fix API responses * Fix panic during deletions * Add test	3 years ago
Sofia Papagiannaki	ad96b240fc	Nested Folder: Enforce maximum nested folder depth (#59213) ... * Nested Folder: Enforce maximum nested folder depth * Cleanup * Fix logging	3 years ago
Sofia Papagiannaki	0af96936be	Nested Folders: Do not refer to the configuration for checking for the flag (#59197) ... * Nested Folders: Do not refer to the configuration for checking for the flag Use always features.IsEnabled() instead * Depend on the interface instead	3 years ago
Sofia Papagiannaki	02b6b09121	Nested Folders: Set user in the API level (#59148)	3 years ago
ying-jeanne	69b5a9c752	Chore: [Nested Folder] Add db migration at service start time (#58590) ... * add db migration at service start time * make changes for the 3 db * revert migrator * fix feature toggle check Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com>	3 years ago
idafurjes	080ea88af7	Nested Folders: Support getting of nested folder in folder service wh… (#58597) ... * Nested Folders: Support getting of nested folder in folder service when feature flag is set * Fix lint * Fix some tests * Fix ngalert test * ngalert fix * Fix API tests * Fix some tests and lint * Fix lint 2 * Fix library elements and panels * Add access control to get folder * Cleanup and minor test change	3 years ago
ying-jeanne	b13b58ebf8	Add move endpoint into folder service (#58575) ... * add move endpoint * change signatures	3 years ago
idafurjes	30f0d66983	Folder: Add implementation for Update for nested folder (#58479) ... * Add implementation for Update nested folder * Remove parent uid from Update * Fix update	3 years ago
Sofia Papagiannaki	bf5a08e039	API: Support creating a nested folder (#58508) ... * API: Support nested folder creation * Update swagger * fixup * Update pkg/api/dtos/folder.go Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com> * Fix some tests * create legacy folder url from title and uid Co-authored-by: idafurjes <36131195+idafurjes@users.noreply.github.com> Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com> Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
ying-jeanne	accb4dea55	[Nested Folder] Delete folder methode (#58444) ... * transfer DeleteFolder changes from larger PR * finish some thingies * add the simplest delete logics * some intermedia steps * fix tests * add test * fix some comments Co-authored-by: yangkb09 <yangkb09@gmail.com>	3 years ago
Kristin Laemmert	a255c32e1a	nested folders: support creation of nested folders in folder service when feature flag is set (#58364) ... * nested folders: support creation of nested folders in folder service when feature flag is set	3 years ago
idafurjes	af2f51f196	Folder: Add folder service implementation (#58182) ... * Folder: Add folder service implementation * Add Move * Add tests * Add new servie method and adjust Update, Delete and Move * Remove contains * GetTree return children of depth one	3 years ago
Kristin Laemmert	b346ae0310	feat: add new Folder table migration & define nested folder interfaces (#56882) ... * feat: add new Folder table migration Add a new folder table to support the Nested Folders feature. https://github.com/grafana/grafana/issues/56880 * register nested folders feature flag (unused) * feat: nested folder service (experiment) This commit adds a NestedFolderSvc interface and stubbed out implementation as an alternative to the existing folder service. This is an experimental feature to try out different methods for backwards compatibility and parallelization, so that Grafana can continue to store folders in the existing (non-nested) manner while also using the new nested folder service. Eventually the new service will (hopefully) become _the_ service, at which point the legacy service can be deprecated (or remain, with the new service methods replacing the original. whatever makes sense at the time). * nested folders: don't run the new migration This commit removes the nested folder migration from the list of active migrations so we can merge this branch and continue development without impacting Grafana instances built off main.	3 years ago
Serge Zaitsev	53baecd71f	Chore: Move folder service into a separate package (#56591) ... * Chore: move folder service interface into a separate package * copy implementation into a standalone package * move implementation and tests to the new folder package * remove leftovers from wire * add test doubles for folder service * fix tests in library panels/elements * fix provideservice in ngalert	3 years ago
ying-jeanne	7b4cea8151	Chore: StoreSplit tag service (#55453) ... * move tag service outside * fix dashboard * fix test * lint * fix linter * remove spew	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343) ... * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
Yuriy Tseretyan	5fb778814c	Alerting: Update rules version when folder title is updated (#53013) ... * remove support for bus from scheduler * rename event to FolderTitleUpdated and fire only if title has changed * add method to increase version of all rules that belong to a folder * update ngalert service to subscribe to folder title change event call data store and update scheduler * add tests	3 years ago
Gabriel MABILLE	8d938175f5	Fix anonymous access (#52615)	3 years ago
Kristin Laemmert	9de00c8eb2	chore/backend: move dashboard errors to dashboard service (#51593) ... * chore/backend: move dashboard errors to dashboard service Dashboard-related models are slowly moving out of the models package and into dashboard services. This commit moves dashboard-related errors; the rest will come in later commits. There are no logical code changes, this is only a structural (package) move. * lint lint lint	3 years ago
Matthew Jacobson	5dee2ed24c	Alerting: Add first Grafana reserved label grafana_folder (#50262) ... * Alerting: Add first Grafana reserved label g_label g_label holds the title of the folder container the alert. The intention of this label is to use it as part of the new default notification policy groupBy. * Add nil check on updateRule labels map * Disable gocyclo lint on schedule.ruleRoutine will remove later in a separate refactoring PR to reduce complexity. * Address doc suggestions * Update g_folder for rules in folder when folder title changes * Remove global bus in FolderService * Modify tests to fit new common g_folder label * Add changelog entry * Fix merge conflicts * Switch GrafanaReservedLabelPrefix from `g_` to `grafana_`	3 years ago
Karl Persson	c4a75f9eb3	RBAC: Add scope resolvers for dashboards (#50110) ... * Inject access control into dashboard service * Add function to parse id scopes * Add dashboard as return value * Update mock * Return only err to keep service interface * Add scope resolvers for dashboard id scopes * Add function to parse uid scopes * Add dashboard uid scope resolver * Register scope resolvers for dashboards Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>	3 years ago
Kristin Laemmert	1df340ff28	backend/services: Move GetDashboard from sqlstore to dashboard service (#48971) ... * rename folder to match package name * backend/sqlstore: move GetDashboard into DashboardService This is a stepping-stone commit which copies the GetDashboard function - which lets us remove the sqlstore from the interfaces in dashboards - without changing any other callers. * checkpoint: moving GetDashboard calls into dashboard service * finish refactoring api tests for dashboardService.GetDashboard	3 years ago
Karl Persson	61772a66b6	AccessControl: Create own interface and impl for each permission service (#48871) ... * Create own interfaces for team, folder, dashboard and data source permissions services * Remove service container and inject them individually	3 years ago
Ieva	a5672758d8	Access control: further reduce access control feature toggle checks (#48171) ... * reduce the usage of access control flag further by removing it from SQL store methods * fixing tests * fix another test * linting * remove AC feature toggle use from API keys * remove unneeded function	3 years ago
Karl Persson	de50f39c12	Access Control: Refactor scope resolvers with support to resolve into several scopes (#48202) ... * Refactor Scope resolver to support resolving into several scopes * Change permission evaluator to match at least one of passed scopes	3 years ago
Karl Persson	a5e4a533fa	Access control: use uid for dashboard and folder scopes (#46807) ... * use uid:s for folder and dashboard permissions * evaluate folder and dashboard permissions based on uids * add dashboard.uid to accept list * Check for exact suffix * Check parent folder on create * update test * drop dashboard:create actions with dashboard scope * fix typo * AccessControl: test id 0 scope conversion * AccessControl: store only parent folder UID * AccessControl: extract general as a constant * FolderServices: Prevent creation of a folder uid'd general * FolderServices: Test folder creation prevention * Update pkg/services/guardian/accesscontrol_guardian.go * FolderServices: fix mock call expect * FolderServices: remove uneeded mocks Co-authored-by: jguer <joao.guerreiro@grafana.com>	3 years ago
Selene	d57c94fb6a	Chore: Remove bus from folder service (#46840) ... * Remove bus from folder service * Fix tests	3 years ago