grafana

Commit Graph

Author	SHA1	Message	Date
Karl Persson	0437a74956	RBAC: Render team, service account and user list when a user can see entities but not roles attached to them (#79642 ) * Render list even when user cannot list roles assigned for entities	1 year ago
kay delaney	9e11779921	Chore: Clean up usage of deprecated stylesFactory function (#78419 )	2 years ago
Josh Hunt	2f2be24e01	Chore: Remove unnecessary type assertions (#78009 ) * Chore: Remove unnecessary type assertions * betterer	2 years ago
Alexander Zobnin	cf7a2ea733	RolePicker: Optimise rendering inside lists of items (#77297 ) * Role picker: Load users roles in batch * Use orgId in request * Add roles to OrgUser type * Improve loading logic * Improve loading indicator * Fix org page * Update service accounts page * Use bulk roles query for teams * Use POST requests for search * Use post request for teams * Update betterer results * Review suggestions * AdminEditOrgPage: move API calls to separate file	2 years ago
Ieva	5e14d93530	Chore: remove hasAccess and hasAcessInMetadata (#76237 ) * remove hasAccess and hasAcessInMetadata in favour of hasPermission and hasPermissionInMetadata * test fixes * more test fixes	2 years ago
Alex Khomenko	4a692fc82e	Admin: Use backend sort (#75228 ) * Admin: Use InteractiveTable * Admin: Fix pagination * Admin: Use CellWrapper * Admin: Split components * Admin: Separate OrgUsersTable * Admin: Remove UsersTable * Admin: Use the new table for TeamList * Admin: Cleanup TeamList page * Admin: Add edit team action * Admin: Use explicit edit action instead of a link wrapper * Admin: Fix responsive styles * Cleanup * Remove redundant sort * Add item key * Fix icon styles * Set loading by default * Use separate pagination component * Use default sorting functionality * Fix merge conflicts * Update betterer * Add controlled sort * Revert pagination changes * Move pagination inside OrgUsersTable.tsx * Add missing prop * Sort users table * Fix tests * Remove loader * Add sort to Teams * Cleanup * Update loadTeams action * Remove sort condition	2 years ago
Alex Khomenko	87ced17060	Admin: Use InteractiveTable for user and team tables (#74821 ) * Admin: Use InteractiveTable * Admin: Fix pagination * Admin: Use CellWrapper * Admin: Split components * Admin: Separate OrgUsersTable * Admin: Remove UsersTable * Admin: Use the new table for TeamList * Admin: Cleanup TeamList page * Admin: Add edit team action * Admin: Use explicit edit action instead of a link wrapper * Admin: Fix responsive styles * Cleanup * Remove redundant sort * Add item key * Fix icon styles * Set loading by default * Use separate pagination component * Use default sorting functionality * Fix merge conflicts * Update betterer * Move pagination inside OrgUsersTable.tsx * Disable sort if results have more than 1 page * Update betterer results * Use CSS objects * More style fixes * Update betterer	2 years ago
Alexander Zobnin	d6e43a44bd	RBAC: Explain why org role selection is disabled for externally synced users (#72274 ) * Move builtin role selector to separate component * Show message if basic roles picker disabled * Show explanation in OSS	2 years ago
Ieva	f7c6491f73	Auth: add a feature toggle for locking user roles for users synced through GCom (#72202 ) * add a new feature toggle for locking down role sync for users managed by GCom * protect the frontend and the backend using the new feature toggle * fix merge	2 years ago
Ieva	e9ba6922c0	Auth: Lock organization roles for users who are managed through an external auth provider (#72204 ) remove onlyExternalOrgRoleSync feature flag	2 years ago
Ieva	21f8dd9599	Auth: Show invite button if disable login form is set to false (#69946 ) * show invite button if disable login form is set to false * fix test * Update public/app/features/users/UsersActionBar.tsx Co-authored-by: Misi <mgyongyosi@users.noreply.github.com> --------- Co-authored-by: Misi <mgyongyosi@users.noreply.github.com>	2 years ago
Khushi Jain	0645106184	Forms: Remove some gf-form appearances in Grafana (#66735 ) * Forms: Remove gf-form appearances in Grafana * Remove gf-form appearance * Forms: Remove gf-form appearances in Grafana * remove gf-form * remove gf-form * Remove gf-form appearance * Remove gf-form appearance * Remove gf-form appearance * Update UserListAdminPage.tsx * Update UserListAdminPage.tsx * Update UserListAdminPage	2 years ago
Misi	df4db412cb	Auth: Fix visibility of the Invite button on /admin/users page (#68991 ) * Fix for invite button visibility * Align test	2 years ago
Juan Cabanas	fc3737bf4f	PublicDashboards: Email sharing users page (#67124 )	2 years ago
Gabriel MABILLE	b7f047c8dd	Fix: Hide invite when disabled login form is set (#67031 ) * FIX: Hide Invite Button with external user management * Hide also when login form is disabled * add tests and readability --------- Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>	2 years ago
Eric Leijonmarck	3cd952b8ba	Auth: Fix orgrole picker disabled if isSynced user (#64033 ) * fix: disable orgrolepicker if externaluser is synced * add disable to role picker * just took me 2 hours to center the icon * wip * fix: check externallySyncedUser for API call * remove check from store * add: tests * refactor authproxy and made tests run * add: feature toggle * set feature toggle for tests * add: IsProviderEnabled * refactor: featuretoggle name * IsProviderEnabled tests * add specific tests for isProviderEnabled * fix: org_user tests * add: owner to featuretoggle * add missing authlabels * remove fmt * feature toggle * change config * add test for a different authmodule * test refactor * gen feature toggle again * fix basic auth user able to change the org role * test for basic auth role * make err.base to error * lowered lvl of log and input mesg	2 years ago
Alexander Zobnin	f1b5014efd	Preferences: Add pagination to org configuration page (#60896 ) * Add auth labels and access control metadata to org users search results * Fix search result JSON model * Org users: Use API for pagination * Fix default page size * Refactor: UsersListPage to functional component * Refactor: update UsersTable component code style * Add pagination to the /orgs/{org_id}/users endpoint * Use pagination on the AdminEditOrgPage * Add /orgs/{org_id}/users/search endpoint to prevent breaking API * Use existing search store method * Remove unnecessary error * Remove unused * Add query param to search endpoint * Fix endpoint docs * Minor refactor * Fix number of pages calculation * Use SearchOrgUsers for all org users methods * Refactor: GetOrgUsers as a service method * Minor refactor: rename orgId => orgID * Fix integration tests * Fix tests	2 years ago
Alex Khomenko	c3d13a0e2f	Admin: Combine org and admin user pages (#59365 ) * Admin: Add unified users page * Admin: Combine admin and org components * Admin: Add combined route * Admin: Show combined page in nav * Admin: Update translation * Admin: Update description * Admin: Update description on backend * Admin: Update translations * Admin: Use dynamic imports	3 years ago
linoman	6cc56311d9	Auth: Display id Provider label in orgs/users view (#58033 ) * Add frontend test * Add frontend label component * Adjust backend tests * Retrieve auth IDP labels for users at org/users. Co-authored-by: Misi <mgyongyosi@users.noreply.github.com> Co-authored-by: Kalle <kalleep@users.noreply.github.com> Co-authored-by: Jo <Jguer@users.noreply.github.com>	3 years ago
Karl Persson	4ff4aaab23	RBAC: Remove builtin role code (#53767 ) * remove rbacBuiltInRoleAssignmentEnabled from frontendsettings * RBAC: Remove RBACBuiltInRoleAssignmentEnabled * RBAC: Remove code for builtin role * RolePicker: Remove unused prop * RolePicker: Rename builtinRole to basicRole * RolePicker: Rename onBuiltinRoleChange to onBasicRoleChange * RolePicker: Rename properties	3 years ago
Mihály Gyöngyösi	1c0ab501aa	UsersTable: Display Disabled flag in Organizations' Users table (#53656 ) * Add disabled column to Org's Users table * fix typo * Change column order * Add test for testing whether GetOrgUsers populates the DTO correctly * Remove type assertion	3 years ago
Karl Persson	7e16d5b4b4	RBAC: Fix various ui issues for role picker (#53589 ) * RolePicker: Check if user has permissions to delegate roles * UserRolePicker: Require both UserRolsAdd and UserRolesRemove for chaning roles * RolePicker: Add option for controlling if roles can be updated to RolePicker * UserOrgs: Dont try to fetch roles with wrong permission * RolePicker: make usage consistent with allowed actions * RolePickerMenu: Remove unused property * UserOrgs: Check for correct permission * UserRolePicker: add apply to controll apply behaviour instand of updateDisabled * UserOrgs: Check for correct permission when trying to update roles * RolePicker: Disable button if no roles or org role can be updated * RolePicker: Always close on update * RolePicker: Fix issue with updating immutable value * ServiceAccountsListItem: Pass correct value to RolePicker * ServiceAccountCreatePage: Pass correct value	3 years ago
Ieva	0d324e931d	Access Control: Allow org admins to invite new users (#52894 ) * allow org admins to invite new users to Grafana * doc updates * fix test	3 years ago
Ieva	0c33b9f211	Access control: Allow organisation admins to add existing users to org (#51668 ) * check users with user add permission to access the invite endpoint * undo unneeded changes * tests and cleanup * linting * linting * betterer * betterer again * fix prettier issue Co-authored-by: jguer <joao.guerreiro@grafana.com>	3 years ago
Torkel Ödegaard	1e85a6f4fd	TopNav: New page layouts (#51510 ) * First stab at new page layouts behind feature toggle * Simplifying PageHeader * Progress on a new model that can more easily support new and old page layouts * Progress * rename folder * Progress * Minor change * fixes * Fixing tests * Make breadcrumbs work * Add tests for old Page component * Adding tests for new Page component and behavior * fixing page header test * Fixed test * AppChrome outside route * Renaming folder * Minor fix * Updated * Fixing StoragePage * Fix for banners Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	3 years ago
Alex Khomenko	701edcdc46	UserListPage: Convert tests to RTL (#50717 )	3 years ago
Ieva	5dbea9996b	RBAC: Make RBAC action names more consistent (#49730 ) * update action names * correctly retrieve teams for signed in user * remove test * undo swagger changes * undo swagger changes pt2 * add migration from old action names to the new ones * rename from list to read * linting * also update alertign actions * fix migration	3 years ago
polibb	a19c3dae5a	Convert Enzyme UsersTable test to RTL (#49836 ) * Convert Enzyme UsersTable test to RTL * Fixes on UsersTable test; no additions * remove snapshot of UsersTable test	3 years ago
Karl Persson	ef6b53ed23	AccessControl: Pass current org id to UsersTable (#49584 ) * Pass current org id to UsersTable * Mock contextSrv and update snapshot	3 years ago
Gabriel MABILLE	689f51599a	AccessControl: Use `RBACBuiltInRoleAssignmentEnabled` in the frontend instead of FeatureToggle (#49261 ) * AccessControl: Frontend changes to basic role enablement	3 years ago
tomxwang	a51c2774b8	convert UsersActionBar tests to RTL (#48737 )	3 years ago
Jguer	8ed3fb1f2d	AccessControl: don't pull builtin role assignments when refactor is enabled (#48675 )	3 years ago
Josh Hunt	3c6e0e8ef8	Chore: ESlint import order (#44959 ) * Add and configure eslint-plugin-import * Fix the lint:ts npm command * Autofix + prettier all the files * Manually fix remaining files * Move jquery code in jest-setup to external file to safely reorder imports * Resolve issue caused by circular dependencies within Prometheus * Update .betterer.results * Fix missing // @ts-ignore * ignore iconBundle.ts * Fix missing // @ts-ignore	3 years ago
kay delaney	d134740bba	Redux: Factor Invites out to separate slice (#45552 )	3 years ago
Karl Persson	3cf31451ec	Access control: Reduce number of API calls for role picker (#44905 ) * Restucture state for TeamRolePicker and UserRolePicker Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	3 years ago
Gabriel MABILLE	86756ee3e5	AccessControl: introduce a different accesscontrol check (licensed or not) (#44777 ) Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com>	3 years ago
renovate[bot]	d87cd6f26c	Update dependency prettier to v2.5.1 (#43473 ) * Update dependency prettier to v2.5.1 * prettier fixes * chore(toolkit): bump prettier to 2.5.1 * style(eslint): bump grafana config to 2.5.2 in core and toolkit * style(mssql-datasource): fix no-inferrable-types eslint errors Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>	3 years ago
Alexander Zobnin	dc913f2311	Access control: fetch role options only if user has permissions (#44201 ) * Access control: fetch role options only if user has permissions * Fix org/users page	3 years ago
Gabriel MABILLE	ba839d1f7c	AccessControl: Refactor `addAccessControlQueryParam` (#44191 ) Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	3 years ago
Alexander Zobnin	867ca5b59e	Access control: Team role picker (#43418 ) * Refactor: move fetching from role picker to parent component * Make built in role props optional * Initial team role picker * Add role picker to the teams list * Optimize fetching roles * Add pagination for the teams page * Fix tests * Hide roles if access control not enabled * Fix test snapshots * Refactor: use useAsync() hook * Refactor: simplify input component * Move api calls to separate file * Refactor: use useAsync() hook for user role picker * Tweak role picker input width * Fix pagination * Update test snapshots * Use loading state from useAsync() hook * Fix roles label if no roles assigned	3 years ago
Dominik Prokop	2a766c6a04	UsersTable: Render remove modal only once (#43885 ) * UsersTable: Render remove modal only once * Formatting cleanup * Snaps update	3 years ago
Eric Leijonmarck	0aa905bb1f	Serviceaccounts: feat - tabview for serviceaccounts (#43573 )	3 years ago
J Guerreiro	06d4cb0303	AccessControl: Disable user remove and user update roles when they do not have the permissions (#43429 ) * AccessControl: Disable user remove and update roles when they do not have the appropriate permissions * AccessControl: Ensure frontend tests pass in CI	3 years ago
Alexander Zobnin	6c3c82d132	Access control: Fix permission required to invite users (prevent access error) (#41943 ) * Fix permission required to invite users (prevent access error) * Use hasAccess method with fallback * Fix tests	4 years ago
Gabriel MABILLE	da5327ea14	AccessControl: RolePicker fetch roles in org (#41927 )	4 years ago
Alexander Zobnin	757463bd27	Add new role picker to admin/users page (#40631 ) * Very simple role picker * Style radio button * Separate component for the built-in roles selector * Custom component instead of Select * refactor * Custom input for role picker * Refactor * Able to select built-in role * Add checkboxes for role selector * Filter out fixed and internal roles * Add action buttons * Implement role search * Fix selecting roles * Pass custom roles to update * User role picker * Some UX work on role picker * Clear search query on close * Blur input when closed * Add roles counter * Refactor * Add disabled state for picker * Adjust disabled styles * Replace ChangeOrgButton with role picker on admin/users page * Remove unused code * Apply suggestions from code review Suggestions from the @Clarity-89 Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Refactor: fix some errors after applying review suggestions * Show fixed roles in the picker * Show applied fixed roles * Fix role counter * Fix checkbox selection * Use specific Role type for menu options * Fix menu when roles list is empty * Fix radio button name * Make fixed roles from built-in role disabled * Make whole menu scrollable * Add BuiltInRole type * Simplify appliedRoles * Simplify options and props * Do not select and disable inherited fixed roles * Enable selecting fixed role * Add description tooltip * Fix role param name * Export common input styles from grafana/ui * Add ValueContainer * Use value container * Refactor appliedRoles logic * Optimise role rendering * Display selected roles * Fix tooltip position * Use OrgRole type * Optimise role rendering * Use radio button from grafana UI * Submenu WIP * Role picker submenu WIP * Hide role description * Tweak styles * Implement submenu selection * Disable role selection if it's inherited * Show new role picker only in Enterprise * Fix types * Use orgid when fetching/updating roles * Use orgId in all access control requests * Styles for partially checked checkbox * Tweak group option styles * Role picker menu: refactor * Reorganize roles in menu * Fix input behaviour * Hide groups on search * Remove unused components * Refactor * Fix group selection * Remove icons from role tags * Add spacing for menu sections * Rename clear all to clear in submenu * Tweak menu width * Show changes in the input when selecting roles * Exclude inherited roles from selection * Increase menu height * Change built-in role in input on select * Include inherited roles to the built-in role selection * refcator import * Refactor role picker to be able to pass roles and builtin roles getters * Add role picker to the org users page * Show inherited builtin roles in the popup * Filter out managed roles * Fix displaying initial builtin roles * Show tooltip only for non-builtin roles * Set min width for focused input * Do not disable inherited roles (by design) * Only show picker if access control enabled * Fix tests * Only close menu on click outside or on indicator click * Open submenu on hover * Don't search on empty query * Do not open/close menu on click * Refactor * Apply suggestions from code review Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Fix formatting * Apply suggestions * Add more space for close menu sign * Tune tooltip styles * Move tooltip to the right side of option * Use info sign instead of question Co-authored-by: Clarity-89 <homes89@ukr.net> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	4 years ago
renovate[bot]	4565fcd0df	Update dependency @testing-library/user-event to v13 (#40394 ) * Update dependency @testing-library/user-event to v13 * Changes needed for userEvent v13 * Ignore pointer-event checks until jsdom issue is fixed * Remove unused act imports Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	4 years ago
Dominik Prokop	f887576a27	Table panel: Make filter case insensitive (#39746 ) * Expose FilterInput from grafana/ui * Make table filter case insensitive * Update packages/grafana-ui/src/components/Table/FilterList.tsx Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com> Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>	4 years ago
kay delaney	00dad0f4e8	A11y: Fix fastpass issues for /admin/* pages (#39435 ) * A11y: Fix fastpass issues for /admin/* pages See #39429	4 years ago
Jack Westbrook	8d3b31ff23	Build: Upgrade Webpack 5 (#36444 ) * build(webpack): bump to v5 and successful yarn start compilation * build(webpack): update postcss dependencies * build(webpack): silence warnings about hash renamed to fullhash * build(webpack): enable persistent cache to store generated webpack modules / chunks * build(webpack): prefer eslintWebpackPlugin over tschecker so eslint doesn't block typechecking * chore(yarn): run yarn-deduplicate to clean up dependencies * chore(yarn): refresh lock file after clean install * build(webpack): prefer output.clean over CleanWebpackPlugin * build(webpack): prefer esbuild over babel-loader for dev config * build(babel): turn off cache compression to improve build performance * build(webpack): get production builds working * build(webpack): remove phantomJS (removed from grafana in v7) specific loader * build(webpack): put back babel for dev builds no performance gain in using esbuild in webpack * build(webpack): prefer terser and optimise css plugins for prod. slower but smaller bundles * build(webpack): clean up redundant code. inform postcss about node_modules * build(webpack): remove deprecation warnings flag * build(webpack): bump packages, dev performance optimisations, attempt to get hot working * chore(storybook): use webpack 5 for dev and production builds * build(storybook): speed up dev build * chore(yarn): refresh lock file * chore(webpack): bump webpack and related deps to latest * refactor(webpack): put back inline-source-map, move start scripts out of grafana toolkit * feat(webpack): prefer react-refresh over react-hot-loader * build(webpack): update webpack.hot to use react-refresh * chore: remove react-hot-loader from codebase * refactor(queryeditorrow): fix circular dependency causing react-fast-refresh errors * revert(webpack): remove stats.errorDetails from common config * build(webpack): bump to v5 and successful yarn start compilation * build(webpack): update postcss dependencies * build(webpack): silence warnings about hash renamed to fullhash * build(webpack): enable persistent cache to store generated webpack modules / chunks * build(webpack): prefer eslintWebpackPlugin over tschecker so eslint doesn't block typechecking * chore(yarn): run yarn-deduplicate to clean up dependencies * chore(yarn): refresh lock file after clean install * build(webpack): prefer output.clean over CleanWebpackPlugin * build(webpack): prefer esbuild over babel-loader for dev config * build(babel): turn off cache compression to improve build performance * build(webpack): get production builds working * build(webpack): remove phantomJS (removed from grafana in v7) specific loader * build(webpack): put back babel for dev builds no performance gain in using esbuild in webpack * build(webpack): prefer terser and optimise css plugins for prod. slower but smaller bundles * build(webpack): clean up redundant code. inform postcss about node_modules * build(webpack): remove deprecation warnings flag * build(webpack): bump packages, dev performance optimisations, attempt to get hot working * chore(storybook): use webpack 5 for dev and production builds * build(storybook): speed up dev build * chore(yarn): refresh lock file * chore(webpack): bump webpack and related deps to latest * refactor(webpack): put back inline-source-map, move start scripts out of grafana toolkit * feat(webpack): prefer react-refresh over react-hot-loader * build(webpack): update webpack.hot to use react-refresh * chore: remove react-hot-loader from codebase * refactor(queryeditorrow): fix circular dependency causing react-fast-refresh errors * revert(webpack): remove stats.errorDetails from common config * revert(webpack): remove include from babel-loader so symlinks (enterprise) work as before * refactor(webpack): fix deprecation warnings in prod builds * fix(storybook): fix failing builds due to replacing css-optimise webpack plugin * fix(storybook): use raw-loader for svg icons * build(webpack): fix dev script colors error * chore(webpack): bump css-loader and react-refresh-webpack-plugin to latest versions Co-authored-by: Torkel Ödegaard <torkel@grafana.com>	4 years ago

1 2 3

129 Commits (e5d1cd8ea5903cf8170d99ac7ac5c255b4c25f61)