grafana

Commit Graph

Author	SHA1	Message	Date
George Robinson	802d67eeca	Alerting: Support values in notification templates (#56457 ) We have received a lot of feedback regarding the ValueString in alert notifications. Perhaps one of the most frequent complaints about ValueString is that it is difficult to read because it contains a lot of information, and the information is shown as a JSON-like string. Users have often asked how it can be templated and the answer is that it can't. Until now users have been able to add custom annotations to their alert rules which contains values via the $values variable added in previous versions of Grafana. However, these custom annotations must be added for each of the user's alert rule, instead of once in a template that all of their alerts can be notified via. This commit adds then the much requested feature to support values in notification templates. Users can then create a single template that prints the annotations, labels and values of their alerts in a format of their choice!	3 years ago
Joe Blubaugh	7312a2dab0	Alerting: Mark all tests that interact with the database as Integration tests. (#54875 ) Previously, two tests were not explicitly marked as integration tests and so were not run against all 3 supported databases in the CI environment.	3 years ago
Yuriy Tseretyan	e2f1201382	Alerting: Fix migration to not add label "alertname" (#56509 ) * do not add label alertname because it is overridden in state manager anyway * update state manager to not consider labels with same value as dupe	3 years ago
George Robinson	762688d67f	Alerting: Fix pq: missing FROM-clause for table "a" (#56453 ) This commit fixes a bug where changing the Folder or Rule Group of an existing rule returns the following error in PostgreSQL "pq: missing FROM-clause for table a"	3 years ago
Joe Blubaugh	13067b39da	Alerting: Update replacement of prometheus-alertmanager (#56519 ) grafana.com/grafana/prometheus-alertmanager has been updated to a version that fixes some bugs upstream. This change just updates that dependency and a few shared ones.	3 years ago
Yuriy Tseretyan	7b6437402a	Alerting: Refactor state manager's cache (#56197 ) * remove ResetAllStates because it's not used * refactor cache to accept logs, metrics and url as method args * update manager Warm method to set the entire state at once * remove unused reset method * introduce ruleStates * change getOrCreate to belong to ruleStates * update Get to not return error	3 years ago
Joe Blubaugh	b476ae62fb	Alerting: Write and Delete multiple alert instances. (#55350 ) Prior to this change, all alert instance writes and deletes happened individually, in their own database transaction. This change batches up writes or deletes for a given rule's evaluation loop into a single transaction before applying it. These new transactions are off by default, guarded by the feature toggle "alertingBigTransactions" Before: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 398 2991381 ns/op 1133537 B/op 27703 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: FovKXiRVzm} with title: "an alert definition FTvFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: foDFXmRVkm} with title: "an alert definition fovFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: VQvFuigVkm} with title: "an alert definition VwDKXmR4kz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.619s ``` After: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 1440 816484 ns/op 352297 B/op 6529 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: 302r_igVzm} with title: "an alert definition q0h9lmR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: 71hrlmR4km} with title: "an alert definition nJ29_mR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: Cahr_mR4zm} with title: "an alert definition ja2rlmg4zz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.383s ``` So we cut time by about 75% and memory allocations by about 60% when storing and deleting 100 instances.	3 years ago
Alexander Weaver	8df830557a	Alerting: Move annotation functionality behind a history persistence interface (#56133 ) * Move annotation functionality behind a history persistence interface * Rename to RecordState * Fix lint error in import aliasing * One more import linter error	3 years ago
Yuriy Tseretyan	ad2a1dd680	Alerting: Start ticker only when scheduler starts (#56339 )	3 years ago
Santiago	09f8e026a1	Alerting: Expose info about notification delivery errors in a new /receivers endpoint (#55429 ) * (WIP) switch to fork AM, first implementation of the API, generate spec * get receivers avoiding race conditions * use latest version of our forked AM, tests * make linter happy, delete TODO comment * update number of expected paths to += 2 * delete unused endpoint code, code review comments, tests * Update pkg/services/ngalert/notifier/alertmanager.go Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> * remove call to fmt.Println * clear naming for fields * shorter variable names in GetReceivers Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	3 years ago
Alexander Weaver	c16317e5b8	Alerting: Move fake rule store to the test utilities package (#56062 ) * Move fakeRuleStore to tests/fakes package * Break stub dependencies on store * Update existing tests to point to new location * Remove unused stub of TimeNow * Rename fake to take advantage of package name	3 years ago
Alexander Weaver	d66ed6fe35	Alerting: Move stray model structs in store package to model package (#55968 ) * Move stray command structs to model package like the rest * Fix broken references	3 years ago
Sofia Papagiannaki	8b77ee2734	SQLStore: Ensure that sessions are always closed (#55864 ) * SQLStore: Ensure that sessions are always closed Delete `NewSession()` in favour of `WithDbSession()` * Add WithDbSessionForceNewSession to the interface * Apply suggestions from code review	3 years ago
ying-jeanne	2472777ce2	Chore: implement sqlx into tag service (#55908 ) * add sqlx store to tag service * add sqlx into tag service * fix test * change to camal cases * change in xorm camal case	3 years ago
Yuriy Tseretyan	0b3c60fc22	Alerting: Refactor notifiers VictorOps, Threema, Telegram to use encoding/json to parse settings instead of simplejson (#55779 ) * update victorops * update threema * update telegram	3 years ago
Alexander Weaver	e6f99fc418	Alerting: Decouple schedule package from store (#55858 ) * Separate out fake for scheduler tests * Delete extracted methods from older fake	3 years ago
Alexander Weaver	81b631d1e9	Use separate fake for rule reader (#55835 )	3 years ago
Alexander Weaver	d17ab82b98	Alerting: Break up store.RuleStore interface, delete dead code (#55776 ) * Refactor state manager to not depend on rule store interface * Refactor grafana and proxied ruler APIs to not depend on store.RuleStore * Refactor folder subscription logic to not use store.RuleStore * Delete dead code * Delete store.RuleStore	3 years ago
George Robinson	a49fcbdbbc	Alerting: Add frames for all queries and expressions (#55609 ) This commit is one of two commits to make the data frames for all queries and expressions in an alert rule available to the state package for rendering a graph. It renames Result to Condition, and creates an additional field called Results that is a map of Ref ID to data.Frames.	3 years ago
Alexander Weaver	f11495a4c3	Alerting: Remove dead functionality from alert instance store (#55774 ) * Update tests to use ListAlertInstances * Drop the actual methods rather than just updating tests	3 years ago
Alexander Weaver	a00879ae21	Alerting: Refactor store to not export its own interface for InstanceStore, delete dead dependency injection (#55772 ) * Add consumer-side store interface to state manager * Remove dead dependency * Delete dead dependency in API struct * Delete store-layer InstanceStore interface * Move fake for state's InstanceStore interface to state package	3 years ago
Alexander Weaver	bd6a5c900f	Alerting: Extract ticker into shared package (#55703 ) * Move ticker files to dedicated package with no changes * Fix package naming and resolve naming conflicts * Fix up all existing references to moved objects * Remove all alerting-specific references from shared util * Rename TickerMetrics to simply Metrics * Rename base ticker type to T and rename NewTicker to simply New	3 years ago
Yuriy Tseretyan	29fdbf0354	Alerting: Refactor webhook notifier to use encoding/json to parse settings instead of simplejson (#55517 ) * update webhook to use json marshaller * make maxAlerts to be interface{}	3 years ago
Torkel Ödegaard	018733dd24	PluginDetails: Make plugin details page look good in topnav (#55571 ) * PluginDetails: Make plugin details page look good in topnav * Minor style tweak aligning things * minor refactoring where I moved the logic to decide the default tab into its own hook. * refactor(plugindetails): first pass at using navmodel for usePluginDetailsTabs hook * refactor(plugindetails): move "reset page when uninstalling plugin" to installcontrols this prevents a user from seeing a blank page if they uninstall an app plugin whilst viewing a config page * refactor(plugindetails): remove usage of toIconName and reduce nested if * Trying to fix tests * minor fix * test(plugindetails): update selectors causing failing tests * chore(plugindetails): remove commented out test code * test(plugindetails): clean up - remove unnecesary usage of waitFor Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>	3 years ago
Yuriy Tseretyan	2d38664fe6	Alerting: Improve validation of query and expressions on rule submit (#53258 ) * Improve error messages of server-side expression * move validation of alert queries and a condition to eval package	3 years ago
Yuriy Tseretyan	879241a48f	Alerting: Fix state manager tests (#55593 )	3 years ago
Yuriy Tseretyan	199996cbf9	Alerting: Resolve stale state + add state reason to notifications (#49352 ) * adds a new reserved annotation `grafana_state_reason` * explicitly resolve stale states	3 years ago
Yuriy Tseretyan	0629d3922a	stop flushing state when Grafana stops (#55504 )	3 years ago
ying-jeanne	7b4cea8151	Chore: StoreSplit tag service (#55453 ) * move tag service outside * fix dashboard * fix test * lint * fix linter * remove spew	3 years ago
George Robinson	bad4f7fec5	Alerting: Change screenshots to use components (#55156 ) * Alerting: Change screenshots to use components This commit changes screenshots to use a number of components instead of a set of functional wrappers. It moves the uploading of screenshots from the screenshot package to the image package so we can re-use the same code for both uploading screenshots and server-side images; SingleFlight from the screenshot package to the image package so we can use it for both taking and uploading the screenshot, where as before it was used just for taking the screenshot; and it also removes the use of a cache because we know that screenshots can be taken at most once per tick of the scheduler.	3 years ago
Yuriy Tseretyan	57a0b6db2c	Alerting: Refactor WeCom notifier to use encoding/json to parse settings instead of simplejson (#55423 )	3 years ago
Alexander Weaver	3a580dc3cd	Alerting: Extract default message embed into named constant (#55424 ) * Resolve conflicts * Combine multiple const definitions	3 years ago
Alexander Weaver	4df41972f1	Alerting: Refactor one notifier to use encoding/json to parse settings instead of simplejson (#55271 ) * Create struct for Slack's receiver settings * Remove one layer of indirection when building slack notifier * Delete un-used struct * Validate against settings struct instead of simplejson object * Genericize settings marshalling * Remove repetition between fields on notifier and fields on settings struct * Rename unmarshal settings wrapper * Handle comma separated strings at marshalling time rather than validation time * Address misc review feedback	3 years ago
Sofia Papagiannaki	754eea20b3	Chore: SQL store split for annotations (#55089 ) * Chore: SQL store split for annotations * Apply suggestion from code review	3 years ago
Jean-Philippe Quéméner	4dc0d49025	Alerting: make sure that rules in rule group are nil if not provided (#55301 )	3 years ago
George Robinson	5561f935e6	Alerting: Fix send resolved notifications (#54793 ) This commit fixes a bug where we did not send resolved alerts to Alertmanager for resolved alert instances. This meant that resolved notifications did not have the annotations from the resolved state, and a result did not also have the resolved screenshot.	3 years ago
Yuriy Tseretyan	8a62020211	Alerting: New API endpoint GET /api/v1/ngalert (#55134 ) * declare new endpoint /api/v1/ngalert * add authorization for new path * add request handler for the new path	3 years ago
Yuriy Tseretyan	896eeb65a9	Alerting: Fix alerting evaluation to use proper permissions (#55127 ) * access control to log user name if it does not have permissions * update ngalert Evaluator to accept user instead of creating a pseudo one * update alerting eval (rule\query testing) API to provide the real user to the Evaluator * update scheduler to create a pseudo user with proper permissions	3 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902 ) * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	3 years ago
Joe Blubaugh	22c937340e	Revert "Alerting: Write and Delete multiple alert instances. (#54072 )" (#54885 ) This reverts commit `5e4fd94413`.	3 years ago
Jean-Philippe Quéméner	d88f1c8e35	Alerting: validate am config changes before persisting (#54908 )	3 years ago
Jean-Philippe Quéméner	e41f78a56d	Alerting: make sure to update contact point references when updating (#54896 )	3 years ago
Matthew Jacobson	940d18ad57	Alerting: Sanitize invalid label/annotation names for external alertmanagers (#54537 ) * Alerting: Sanitize invalid label/annotation names for external alertmanagers Grafana's built-in Alertmanager supports both Unicode label keys and values; however, if using an external Prometheus Alertmanager label keys must be compatible with their data model. This means label keys must only contain ASCII letters, numbers, as well as underscores and match the regex `[a-zA-Z_][a-zA-Z0-9_]`. Any invalid characters will now be removed or replaced by the Grafana alerting engine before being sent to the external Alertmanager according to the following rules: - `Whitespace` will be removed. - `ASCII characters` will be replaced with `_`. - `All other characters` will be replaced with their lower-case hex representation. Prefix hex replacements with `0x` * Refactor for clarity * Apply suggestions from code review Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	3 years ago
Alexander Weaver	b193eaed6e	Alerting: Resetting the notification policy tree to the default policy will also restore default contact points (#54608 ) * Add test that resetting the route restores the default receiver * Return error instead of panic * Adjust error string to match styleguide	3 years ago
Alexander Weaver	b8d1474609	Fix incorrect propagation of org ID in rule endpionts (#54603 )	3 years ago
Ilya Galimyanov	b593d371ef	Alerting: Telegram: truncate long messages (#54339 ) Truncate messages longer than 4096 characters	3 years ago
George Robinson	77e53f9986	Alerting: Fix boolean comparison on PostgreSQL (#54730 )	3 years ago
Joe Blubaugh	5e4fd94413	Alerting: Write and Delete multiple alert instances. (#54072 ) Prior to this change, all alert instance writes and deletes happened individually, in their own database transaction. This change batches up writes or deletes for a given rule's evaluation loop into a single transaction before applying it. Before: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 398 2991381 ns/op 1133537 B/op 27703 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: FovKXiRVzm} with title: "an alert definition FTvFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: foDFXmRVkm} with title: "an alert definition fovFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: VQvFuigVkm} with title: "an alert definition VwDKXmR4kz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.619s ``` After: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 1440 816484 ns/op 352297 B/op 6529 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: 302r_igVzm} with title: "an alert definition q0h9lmR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: 71hrlmR4km} with title: "an alert definition nJ29_mR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: Cahr_mR4zm} with title: "an alert definition ja2rlmg4zz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.383s ``` So we cut time by about 75% and memory allocations by about 60% when storing and deleting 100 instances. This change also updates some of our tests so that they run successfully against postgreSQL - we were using random Int64s, but postgres integers, which our tables use, max out at 2^31-1	3 years ago
Timur Olzhabayev	b5b41988cf	Docs: Deprecating packages_api and removing it from our pipelines (#54473 )	3 years ago
Yuriy Tseretyan	76ea0b15ae	Alerting: Scheduler to fetch folders along with rules (#52842 ) * Update GetAlertRulesForScheduling to query for folders (if needed) * Update scheduler's alertRulesRegistry to cache folder titles along with rules * Update rule eval loop to take folder title from the * Extract interface RuleStore * Pre-fetch the rule keys with the version to detect changes, and query the full table only if there are changes.	3 years ago

1 2 3 4 5 ...

708 Commits (efed72096f1634b24885b0fb9d4b1b75ac9faa96)