708 Commits (efed72096f1634b24885b0fb9d4b1b75ac9faa96)

Author	SHA1	Message	Date
Yuriy Tseretyan	c8d891785d	Alerting: Ticker to support stopping (#48142) ... * add stop for ticker * stop ticker when scheduler stops * stop ticker when legacy engine stops	3 years ago
Yuriy Tseretyan	ad25e2a20c	Alerting: Update RBAC for alert rules to consider access to rule as access to group it belongs (#49033) ... * update authz to exclude entire group if user does not have access to rule * change rule update authz to not return changes because if user does not have access to any rule in group, they do not have access to the rule * a new query that returns alerts in group by UID of alert that belongs to that group * collect all affected groups during calculate changes * update authorize to check access to groups * update tests for calculateChanges to assert new fields * add authorization tests	3 years ago
Joe Blubaugh	56f40bd413	Alerting: Add Go error message to warning log for screenshots. (#49870) ... Makes debugging problems with alert screenshotting easier.	3 years ago
kyamau	8b2a3a018d	Alerting: Chore: Fix event name in ngalert/README.md (#49829) ... Fix event name from *evalContext to *evaluation as #45144.	3 years ago
Matthew Jacobson	d92625125b	Alerting: Add templated subject config to email notifier (#49742) ... * Add subject templating to email notifier * Fix linting	3 years ago
George Robinson	47a3ddd968	Alerting: Add GetImages to ImageStore (#49717) ... * Alerting: Add GetImages to ImageStore * Use assert.ElementsMatch instead of sort.Sort	3 years ago
Joe Blubaugh	d5a327f43d	Alerting: Add tests for Slack Notifier Image Upload (#49669) ... Tests that file bytes are correctly read from storage when an image is available without a URL. Tests that not found and success cases are both handled.	3 years ago
Alexander Weaver	909ebcf979	Alerting: Endpoints for provisioning mute timings (#49635) ... * Add validator for mute timing and make it provisionable * Add tests to ensure prometheus validators are running and errors are propagated * Internal API for manipulating mute timings * Define and generate API layer * Wire up generated code * Implement API handlers * Tests for golang layer * Fix reference bug * Fix linter and auth tests * Resolve semantic errors and regenerate * Remove pointless comment * Extract out provisioning path param keys, simplify * Expected number of paths	3 years ago
Johannes Hertenstein	16d738a03a	Alerting: Do not include button in googlechat notification if URL invalid (#47317) ... * Alerting: Do not include button in googlechat notification if URL invalid * Apply suggestions from code review Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com> * Alerting: Add test case for invalid external URL in googlechat notifier Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	3 years ago
Sofia Papagiannaki	7cf321d7bd	Alerting: Fix swagger specification (#49273) ... * Alerting: fix specification * Update merged swagger specification	3 years ago
Joe Blubaugh	9e8efaa459	Alerting: Add stored screenshot utilities to the channels package. (#49470) ... Adds three functions: `withStoredImages` iterates over a list of models.Alerts, extracting a stored image's data from storage, if available, and executing a user-provided function. `withStoredImage` does this for an image attached to a specific alert. `openImage` finds and opens an image file on disk. Moves `store.Image` to `models.Image` Simplifies `channels.ImageStore` interface and updates notifiers that use it to use the simpler methods. Updates all pkg/alert/notifier/channels to use withStoredImage routines.	3 years ago
sh0rez	3ca3a59079	pkg/web: remove dependency injection (#49123) ... * pkg/web: store http.Handler internally * pkg/web: remove injection Removes any injection code from pkg/web. It already was no longer functional, as we already only injected into `http.Handler`, meaning we only inject ctx.Req and ctx.Resp. Any other types (*Context, *ReqContext) were already accessed using the http.Request.Context.Value() method. * *: remove type mappings Removes any call to the previously removed TypeMapper, as those were non-functional already. * pkg/web: remove Context.Invoke was no longer used outside of pkg/web and also no longer functional	3 years ago
Kristin Laemmert	debbb8d59d	sqlstore: finish removing Find and SearchDashboards (#49347) ... * chore: replace artisnal FakeDashboardService with generated mock Maintaining a handcrafted FakeDashboardService is not sustainable now that we are in the process of moving the dashboard-related functions out of sqlstore. * sqlstore: finish removing Find and SearchDashboards Find and SearchDashboards were previously copied into the dashboard service. This commit completes that work, removing Find and SearchDashboards from the sqlstore and updating callers to use the dashboard service. * dashboards: remove SearchDashboards from Store interface SearchDashboards is a wrapper around FindDashboard that transforms the results, so it's been moved out of the Store entirely and the functionality moved into the Dashboard Service's search implementation. The database tests depended heavily on the transformation, so I added testSearchDashboards, a copy of search dashboards, instead of (heavily) refactoring all the tests.	3 years ago
Kat Yang	50c2b4682a	Chore: Rename integration tests (#49438) ... * Chore: Rename integration tests * Remove one Integration Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
Joe Blubaugh	a0193c248f	Alerting: Add entries to ngAlert changelog for screenshots. (#49457) ... Notes the PRs that added the feature.	3 years ago
Alexander Weaver	a92f85a87b	Alerting: Factor out shared code for working with configs in provisioning package (#49419) ... * Factor out shared code for working with configs * Refactor in notification policies and contact points * Better file ordering * Address feedback	3 years ago
Alexander Weaver	2ba4f7ed7d	Alerting: Attach image URLs to Google Chat notifications. (#49445) ... * Add a test card to see what styles look like * Add text and image cards * Address feedback	3 years ago
Alexander Weaver	d7c65d3323	Alerting: Attach image URLs or upload files to Discord notifications. (#49439) ... * Images in discord * Drop duplicated field initialization * Fix tests * Use the proper context	3 years ago
Alexander Weaver	ac8951f689	Alerting: Add support for documenting which alerting APIs are stable (#49018) ... * Support for documenting stable vs unstable alerting routes * empty commit, restart drone * Touch-up references in root makefile and drop trailing escape newline * Rebase and regenerate * Extend README with docs for this change	3 years ago
Joe Blubaugh	ccd160a75e	Alerting: Add image url or file attachment to email notifications. (#49381) ... If an image token is present in an alert instance, the email notifier will attempt to find a public URL for the image token. If found, it will add that to the email as the `ImageLink` field. If only local file data is available, the notifier will attach the file to the outgoing email using the `EmbeddedImage` field.	3 years ago
Joe Blubaugh	307e33614e	Alerting: Add image_urls to OpsGenie notification details. (#49379) ... Adds an array of image_urls to the OpsGenie details field in a message, if image urls are available. ```json { "message": "Alert with Images!", "details": { "image_urls": ["http://www.example.com"] } } ```	3 years ago
Yuriy Tseretyan	3dfafbadef	Alerting: Fix access to alerts for viewer with editor permissions when RBAC is disabled (#49270) ... * Add folder edit permission for users with Viewer role * relax permissions required to create an alert when RBAC is disabled	3 years ago
Joe Blubaugh	4ea0b39db1	Alerting: Add Image URLs to Microsoft Teams notifier. (#49385) ... If there are screenshot images with URLs, they will be attached to the Microsoft teams notification in the first sections, as a slice of image objects.	3 years ago
Joe Blubaugh	1cc034d960	Alerting: Add a "Reason" to Alert Instances to show underlying cause of state. (#49259) ... This change adds a field to state.State and models.AlertInstance that indicate the "Reason" that an instance has its current state. This helps us account for cases where the state is "Normal" but the underlying evaluation returned "NoData" or "Error", for example. Fixes #42606 Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com>	3 years ago
Joe Blubaugh	26a206cce2	Alerting: Attach image URL to alerts in Webhook notifier format. (#49378) ... Attaches an imageURL field to any alert messages that have a screenshot token whose URL we can successfully read from disk.	3 years ago
Joe Blubaugh	11a908cc91	Alerting: Add Screenshot URLs to Pagerduty Notifier (#49377) ... PagerDuty takes an "images" array of link objects in it's request body.	3 years ago
Joe Blubaugh	12c25759da	Alerting: Attach screenshot data to Slack notifications. (#49374) ... This change extracts screenshot data from alert messages via a private annotation `__alertScreenshotToken__` and attaches a URL to a Slack message or uploads the data to an image upload endpoint if needed. This change also implements a few foundational functions for use in other notifiers.	3 years ago
Joe Blubaugh	1d724810de	Alerting: State Manager takes screenshots. (#49338) ... The State Manager will now take screenshots when an alert instance switches to an Alerting or Resolved state. Signed-off-by: Joe Blubaugh joe.blubaugh@grafana.com	3 years ago
Joe Blubaugh	687e79538b	Alerting: Add a general screenshot service and alerting-specific image service. (#49293) ... This commit adds a pkg/services/screenshot package for taking and uploading screenshots of Grafana dashboards. It supports taking screenshots of both dashboards and individual panels within a dashboard, using the rendering service. The screenshot package has the following services, most of which can be composed: BrowserScreenshotService (Takes screenshots with headless Chrome) CachableScreenshotService (Caches screenshots taken with another service such as BrowserScreenshotService) NoopScreenshotService (A no-op screenshot service for tests) SingleFlightScreenshotService (Prevents duplicate screenshots when taking screenshots of the same dashboard or panel in parallel) ScreenshotUnavailableService (A screenshot service that returns ErrScreenshotsUnavailable) UploadingScreenshotService (A screenshot service that uploads taken screenshots) The screenshot package does not support wire dependency injection yet. ngalert constructs its own version of the service. See https://github.com/grafana/grafana/issues/49296 This PR also adds an ImageScreenshotService to ngAlert. This is used to take screenshots with a screenshotservice and then store their location reference for use by alert instances and notifiers.	3 years ago
Yuriy Tseretyan	258b3ab18b	Alerting: Fix RBAC actions for notification policies (#49185) ... * squash actions "alert.notifications:update", "alert.notifications:create", "alert.notifications:delete" to "alert.notifications:write" * add migration * update UI to use the write action * update docs * changelog	3 years ago
Karl Persson	4a61f4111f	Remove unused error from evaluator Evaluate (#49305)	3 years ago
Alexander Weaver	e8b498fe8b	Parse template when validating it (#49282)	3 years ago
Yuriy Tseretyan	f7f2253072	Alerting: Fix anonymous access to alerting (#49203) ... * introduce a fallback handler that checks that role is Viewer. * update UI nav links to allow alerting tabs for anonymous user * update rule api to check for Viewer role instead of SignedIn when RBAC is disabled	3 years ago
Yuriy Tseretyan	d87fdc1037	Alerting: Update migration to migrate only alerts that belong to existing org\dashboard (#49192) ... * Update migration to migrate only alerts that belong to existing org\dashboard	3 years ago
Alexander Weaver	25da759bf2	Indicate whether templates are provisioned (#49025)	3 years ago
George Robinson	43358c7248	Alerting: Keep private annotations across evaluations (#49080)	3 years ago
Gilles De Mey	1d18b5ccd3	Alerting: inject dashboardService in to AlertNG (#49139)	3 years ago
Kristin Laemmert	1df340ff28	backend/services: Move GetDashboard from sqlstore to dashboard service (#48971) ... * rename folder to match package name * backend/sqlstore: move GetDashboard into DashboardService This is a stepping-stone commit which copies the GetDashboard function - which lets us remove the sqlstore from the interfaces in dashboards - without changing any other callers. * checkpoint: moving GetDashboard calls into dashboard service * finish refactoring api tests for dashboardService.GetDashboard	3 years ago
Alexander Weaver	9af30f6570	Alerting: Provisioning GET routes for mute timings (#49044) ... * Define GET routes and run codegen * Wire up forked and non-generated API * Implement and wire * Tests, authorization * Fix linter error	3 years ago
Sofia Papagiannaki	925784f514	Alerting: Modify endpoint for testing a datasource rule using the UID (#48070) ... * Modify testing endpoint to expect the datasource UID * Update docs	3 years ago
Yuriy Tseretyan	952cb4fc0b	Alerting: introduce AlertRuleGroupKey and use it in API handlers (#48945) ... * create AlertGroupKey structure * update PrometheusSrv. - extract creation of RuleGroup to a separate method. Use group key for grouping * update RuleSrv - update calculateChanges to use groupKey - authorize to use groupkey	3 years ago
Yuriy Tseretyan	e528f2e430	Alerting: Use UID scope for folders authorization (#48970)	3 years ago
Yuriy Tseretyan	00ef1acb93	Alerting: Create folder for alerting when start from the scratch (#48866) ... * create folderHelper struct	3 years ago
Yuriy Tseretyan	186ba26b59	Alerting: refactor rule API to create rule group in a single place (#48915) ... * extract method toGettableRuleGroupConfig	3 years ago
Yuriy Tseretyan	369fcc5e9a	Alerting: scheduler to use short version of model for alert rule (#48916) ... * scheduler to use a short version of alert rule model	3 years ago
Yuriy Tseretyan	99156b40bd	Alerting: Move alertRuleRegistry to its own file (#48890) ... * move alertRuleRegistry to its own file * move tests to separate file	3 years ago
Yuriy Tseretyan	dc33e09b24	simplify getting a slice of keys (#48889)	3 years ago
Karl Persson	61772a66b6	AccessControl: Create own interface and impl for each permission service (#48871) ... * Create own interfaces for team, folder, dashboard and data source permissions services * Remove service container and inject them individually	3 years ago
Alexander Weaver	99eaa0fc20	Put identifier in path (#48831)	3 years ago
Alexander Weaver	809aa38103	POST routes to PUT routes (#48828)	3 years ago