fix(blooms): Cleanup temp blockdir in bloom compactor (#13622)

A follow up to #13522
This PR fixes the missing cleanup function call to remove temporary blocks from the filesystem.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
pull/13624/head
Christian Haudum 10 months ago committed by GitHub
parent 2b81a482c8
commit 64215e1849
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 10
      pkg/bloomcompactor/controller.go

@ -431,6 +431,9 @@ func (s *SimpleBloomController) buildGaps(
built, err := bloomshipper.BlockFrom(tenant, table.Addr(), blk)
if err != nil {
level.Error(logger).Log("msg", "failed to build block", "err", err)
if err = blk.Reader().Cleanup(); err != nil {
level.Error(logger).Log("msg", "failed to cleanup block directory", "err", err)
}
return nil, errors.Wrap(err, "failed to build block")
}
@ -439,10 +442,17 @@ func (s *SimpleBloomController) buildGaps(
built,
); err != nil {
level.Error(logger).Log("msg", "failed to write block", "err", err)
if err = blk.Reader().Cleanup(); err != nil {
level.Error(logger).Log("msg", "failed to cleanup block directory", "err", err)
}
return nil, errors.Wrap(err, "failed to write block")
}
s.metrics.blocksCreated.Inc()
if err := blk.Reader().Cleanup(); err != nil {
level.Error(logger).Log("msg", "failed to cleanup block directory", "err", err)
}
totalGapKeyspace := (gap.bounds.Max - gap.bounds.Min)
progress := (built.Bounds.Max - gap.bounds.Min)
pct := float64(progress) / float64(totalGapKeyspace) * 100

Loading…
Cancel
Save