chore(dataobj): do not panic on unrecognized compression type (#16088)

pull/16090/head
Robert Fratto 1 year ago committed by GitHub
parent 6d49d911dc
commit 66b2721cfa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 7
      pkg/dataobj/internal/dataset/page.go

@ -112,9 +112,12 @@ func (p *MemPage) reader(compression datasetmd.CompressionType) (presence io.Rea
case datasetmd.COMPRESSION_TYPE_ZSTD:
zr := &fixedZstdReader{page: p, data: compressedValuesData}
return bitmapReader, zr, nil
}
panic(fmt.Sprintf("dataset.MemPage.reader: unknown compression type %q", compression.String()))
default:
// We do *not* want to panic here, as we may be trying to read a page from
// a newer format.
return nil, nil, fmt.Errorf("unknown compression type %q", compression.String())
}
}
var snappyPool = sync.Pool{

Loading…
Cancel
Save