85 Commits (main)

Author	SHA1	Message	Date
Ashwanth	54f9723af1	chore(xcap): adds exporter to summarise capture as a structured log line (#20099)	3 weeks ago
Ashwanth	728b308edf	chore: update read stats to use xcap (#20095)	3 weeks ago
benclive	2ce207fbdb	chore: Use shared zstd encoders during dataobj build (#20044)	4 weeks ago
Robert Fratto	806bcd5dd7	chore(dataobj): stop preallocating memory for page builders (#20043)	4 weeks ago
benclive	a6de577b3a	chore: Fix page skipping with empty predicates (#19602)	2 months ago
Ashwanth	bfd70602dd	chore: correct dataobj reader rows read return value (#19583)	2 months ago
Stas Spiridonov	160dc2c493	chore: removed arrow-go allocators/retain/release (#19569)	2 months ago
Robert Fratto	7556192423	chore(dataobj): use single Zstd decoder (#19508)	2 months ago
benclive	2dac5ef8a7	chore: Write empty message values in logs section writer (#19359)	3 months ago
Sophie Waldman	af6983e9de	fix: Add special case handling for comparing empty and nil values (#19348) ... We can have a predicate checking for an empty string, e.g. {"foo" = ""}. If a row has no value for the column "foo", it will return a nil value for that column. Thus, when we go to compare the row with the predicate, we will be comparing an empty value to a nil value. This change adjusts the comparison check so that we correctly handle this special case.	3 months ago
Christian Haudum	a3017f2b13	chore(dataobj-consumer): Sort logs object-wide (#19231) ... Sorting logs globally (object-wide per tenant) removes overlapping time ranges of sections in the objects. Sections contain logs from multiple streams, and the ingest lag of streams may vary. This means that although logs of individual sections are sorted by timestamp, the overall sorting of logs is not guaranteed. Therefore sections are sorted with a k-way merge (SortMerge), which does over-query data in case the query would reach its result limit early. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	3 months ago
Christian Haudum	2ecf07d52c	chore(dataobj): Fix panic in column builder (#19153) ... There is an edge case in the column builder where it panics when the AppendNulls() call tries to append more NULL values than the specified MaxPageRows setting when backfilling rows. In that case the builder would panic because canAppend would always return false even when the previous page was flushed. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	4 months ago
Christian Haudum	4c81ebc7c3	chore(dataobj): Add option to set target row limit for pages (#19128) ... This PR introduces an option for the column builder to limit the number of rows in a page. It can be set for logs object and index objects separately using `-dataobj-consumer.max-page-rows` and `-dataobj-index-builder.max-page-rows` respectively. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	4 months ago
Robert Fratto	f6091a67d1	chore(engine): move to toggleable section prefetching (#19142) ... dataset.readerDownloader was originally introduced in #16429, an attempt to balance peak memory usage of reading a section with read times by downloading a configurable size of pages in advance. In practice, each roundtrip to object storage adds too much of a latency hit, and we've started to set the cache limit high enough to ensure that each reader only needs a single prefetch. Given what we've found, it no longer makes sense to control peak memory usage via the prefetch size. Other options, such as downloading directly to disk, may be explored in the future. In the meantime, this PR removes the ability to specify a cache size. All non-pruned pages will be bulk requested using the range reader (#19067) on the first read call. Pages which have left the potential read window will continue to be eagerly removed for garbage collection. However, we don't want to prefetch when the dataset is entirely in memory, which is the case when the logs section builder is performing k-way merge over in-memory sections. To lower the memory usage of builders, prefetching is configurable. For this initial PR, prefetching is only disabled for the logs section builder; all other reads force prefetching. Signed-off-by: Robert Fratto <robertfratto@gmail.com>	4 months ago
Robert Fratto	ba4bd5dc95	chore: introduce efficient byte range reader in new engine (#19024) ... Signed-off-by: Robert Fratto <robertfratto@gmail.com>	4 months ago
Robert Fratto	515ebea4f2	chore(dataobj): track total download time of page metadata/data (#18896)	4 months ago
Robert Fratto	595715146f	chore(dataobj)!: introduce new centralized dataset encoding format (#18871) ... Signed-off-by: Robert Fratto <robertfratto@gmail.com>	4 months ago
Robert Fratto	642d826a00	chore(dataobj): make section tenancy a global construct (#18857) ... Signed-off-by: Robert Fratto <robertfratto@gmail.com> Co-authored-by: George Robinson <george.robinson@grafana.com>	4 months ago
Ashwanth	5203a0c9ad	chore(dataobj): add reader stats (#18694)	4 months ago
George Robinson	916246a2be	feat: add tenant to section metadata (#18843)	4 months ago
Robert Fratto	100e259a8d	chore(dataobj): introduce the concept of section info "extensions" (#18832)	5 months ago
Robert Fratto	61c40fca0c	chore(dataobj): remove support for deprecated fields (breaking change) (#18822)	5 months ago
Robert Fratto	a5c722cbed	chore(dataobj): list pages across all columns in one request (#18678)	5 months ago
Robert Fratto	9129d8cdd0	chore(engine): use columnar logs.Reader for DataObjScan (#18577)	5 months ago
Ashwanth	da4e59f8c6	chore(dataobj): store sort order information in section metadata (#18499)	5 months ago
benclive	077e4196ef	chore: Add indexes to LogQL benchmarks (#18500)	5 months ago
Periklis Tsirakidis	6eedcaaded	chore(dataobj): Add new index pointers section type (#18441)	6 months ago
benclive	1f0edcd4ac	feat: Initial index-builder implementation (#18297)	6 months ago
Robert Fratto	26cb50e65a	chore(dataobj): Improve performance of dataset.Value API (#18339) ... Co-authored-by: Ashwanth <iamashwanth@gmail.com>	6 months ago
benclive	a238816751	perf: Use map for InPredicate when reading dataobj (#18325)	6 months ago
Ashwanth	5c02493fe2	chore(dataobj): avoid reading a predicate column more than once (#18324)	6 months ago
Robert Fratto	30ccf5172c	chore(util/arrowtest): export arrowtest package (#18255)	6 months ago
benclive	9642af3ac6	chore: Add new pointers section type for dataobj (#18243)	6 months ago
Robert Fratto	06cf52757b	chore(dataobj): Add columnar reading APIs to logs and streams sections (#17976) ... This PR introduces columnar reading APIs to both the logs and streams sections. As part of this change, both sections now expose the columns stored in the section, which are then used to define predicates on the readers. The columnar reading APIs emit a sequence of `arrow.Record`s, where each record has no more than the batch size passed to the `Reader.Read` method. Unlike the original row-based readers, the columnar readers: * Allow reading a subset of columns * Have column-based predicates that map literally to the new query engine To be able to represent a column's value for use in predicates, we import [github.com/apache/arrow-go/v18/arrow/scalar](https://pkg.go.dev/github.com/apache/arrow-go/v18@v18.3.0/arrow/scalar). Section Reader implementations perform mapping to and from the internal `dataset.Value`. The implementation of `logs.Reader` is almost an identical copy of the `streams.Reader` implementation. I've opted for duplicating the implementation in the short term, since there's no obvious way for how to deduplicate it in a way keeps the package structure easy to understand. We can change this in the future if a clean and simple approach presents itself. This PR does not yet update `DataObjScan` to make use of these new APIs; that's being left out of scope for another PR to handle.	7 months ago
Robert Fratto	c5ac922e55	chore(dataobj): Use pooled buffers when decoding pages (#17955)	7 months ago
Christian Haudum	48f1d0ebc0	chore(dataobj): Decompress zstd compressed pages upfront (#17841) ... This PR changes the decompression of data object pages, so that they are decompressed fully upfront into a bytes buffer, instead of passing a streaming zstd decompressor (reader) to the page decoder. This this allows to release the zstd decompressor to the pool earlier.Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	7 months ago
Robert Fratto	a237444f0d	refactor(dataobj): invert dependency between dataobj and sections (#17762) ... Originally, the dataobj package was a higher-level API around sections. This design caused it to become a bottleneck: * Implementing any new public behaviour for a section required bubbling it up to the dataobj API for it to be exposed, making it tedious to add new sections or update existing ones. * The `dataobj.Builder` pattern was focused on constructing dataobjs for storing log data, which will cause friction as we build objects around other use cases. This PR builds on top of the foundation laid out by #17704 and #17708, fully inverting the dependency between dataobj and sections: * The `dataobj` package has no knowledge of what sections exist, and can now be used for writing and reading generic sections. Section packages now create higher-level APIs around the abstractions provided by `dataobj`. * Section packages are now public, and callers interact directly with these packages for writing and reading section-specific data. * All logic for a section (encoding, decoding, buffering, reading) is now fully self-contained inside the section package. Previously, the implementation of each section was spread across three packages (`pkg/dataobj/internal/encoding`, `pkg/dataobj/internal/sections/SECTION`, `pkg/dataobj`). * Cutting a section is now a decision made by the caller rather than the section implementation. Previously, the logs section builder would create multiple sections. For the most part, this change is a no-op, with two exceptions: 1. Section cutting is now performed by the caller; however, this shouldn't result in any issues. 2. Removing the high-level `dataobj.Stream` and `dataobj.Record` types will temporarily reduce the allocation gains from #16988. I will address this after this PR is merged.	7 months ago
Robert Fratto	7b0d6d7144	chore(dataobj): Migrate to dynamic section types (#17708)	8 months ago
Robert Fratto	3fbebd3bc4	chore(dataobj): migrate to section-relative offsets (#17704)	8 months ago
Ashwanth	3ad1a64bc1	chore(dataobj): fixes a memory aliasing bug in dataobj reader (#17537)	8 months ago
Ashwanth	009600cb51	chore(dataobj): order predicates based on row selectivity and cost of reading (#17376)	8 months ago
Ashwanth	5961923836	chore(dataobj): apply predicates sequentially (#17283)	8 months ago
Ashwanth	42e2407137	chore(dataobj): backfill sparse rows using EncodeN (#16485)	8 months ago
Ashwanth	7dd4ab4b09	chore(dataobj): correct stats calculation for prepredicate bytes read (#17279)	8 months ago
benclive	9e68fb01f4	feat(dataobj): Add query stats collection to the dataobj readers (#17128)	9 months ago
benclive	e5784d7a82	perf: Reuse Values in dataobj.Reader to reduce allocs (#16988) ... Co-authored-by: Robert Fratto <robertfratto@gmail.com>	9 months ago
Robert Fratto	bd4331363b	chore: align benchmark results between chunks and dataobjs (#17127)	9 months ago
Ashwanth	42eed6ded5	chore(dataobj): introduce InPredicate to replace long chain of OR operators (#16919)	9 months ago
Robert Fratto	9be95a3e8c	chore(dataobj): reduce memory overhead of merging logs stripes (#16833)	9 months ago
benclive	979f7614bc	perf: Optimization pass for reading from dataobjs (#16747)	9 months ago