4495 Commits (3e5fb36f3053d6506e9995644638c2b4512fdd49)

 

All Branches   

Search

Author	SHA1	Message	Date
Teruya Ono	3e5fb36f30	Docker compose: Update loki and promtail version tags to 2.7.1 (#8230) ... **What this PR does / why we need it**: Updated loki and promtail version tags to the latest. **Which issue(s) this PR fixes**: **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Bryan Boreham	15b382294e	Remove dependency on thanos-io/thanos (#8227) ... **What this PR does / why we need it**: This avoids complications trying to match up versions between Prometheus and Thanos. **Special notes for your reviewer**: I don't know why the dependency on `github.com/efficientgo/e2e` has appeared in go.mod, but it doesn't seem to change what is in vendor. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - NA Documentation added - NA Tests updated - NA `CHANGELOG.md` updated - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Ed Welch	c8760f31e2	Loki: Remove validation of matchers when performing label values lookup. (#8224) ... the curren validation fails on != style matchers when they are the only matchers present, requiring at least one `=` matcher. However for looking up label values in TSDB, by design it uses a `desired_label != ""` style query, as such it should be allowed to also include these as matchers. Additional matchers on this Label Value queries typically only exist with LBAC headers adding additional labels. Signed-off-by: Edward Welch <edward.welch@grafana.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Edward Welch <edward.welch@grafana.com> Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Owen Diehl <ow.diehl@gmail.com> Co-authored-by: Danny Kopping <danny.kopping@grafana.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Jijo Thomas John	54f09b89fd	[loki-canary] Support passing loki address as environment variable (#8205)	2 years ago
Kaviraj Kanagaraj	db3a9c961e	distributor: Fix `loki_mutated_bytes_total` metric increment (#8223) ... Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> Previously this metric was not not incremented for all the log lines in the stream. This PR fixes it.	2 years ago
dependabot[bot]	2e834ae18d	Bump github.com/mitchellh/go-wordwrap from 1.0.0 to 1.0.1 (#8222) ... Bumps [github.com/mitchellh/go-wordwrap](https://github.com/mitchellh/go-wordwrap) from 1.0.0 to 1.0.1. <details> <summary>Commits</summary> <ul> <li><a href="ecf0936a07"><code>ecf0936</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/mitchellh/go-wordwrap/issues/3">#3</a> from dtolnay/nbsp</li> <li><a href="a2d9f5454f"><code>a2d9f54</code></a> Wrap multibyte characters properly</li> <li><a href="7256b9c0a8"><code>7256b9c</code></a> update go.mod</li> <li><a href="271c4e5dd7"><code>271c4e5</code></a> Do not break on non-breaking space</li> <li>See full diff in <a href="https://github.com/mitchellh/go-wordwrap/compare/v1.0.0...v1.0.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Kaviraj Kanagaraj	e18b4fca6f	ingester: Add `ingester_memory_streams_labels_bytes` metric (#8212) ... Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> This is to give visibility on `labels` size of in-memory streams on the ingesters. It caculate the size of labels via `len(labels.String())`. Meaning if you have ```go lbs := labels.Labels{ {Name: "foo", Value: "bar"}, {Name: "instance", Value: "loki"}, } ``` size would be number of bytes in `{foo="bar", instance="loki"}` which is `28`. NOTE: `len(string)` gives [bytes length in Go](https://pkg.go.dev/builtin#len)	2 years ago
Jack Baldry	de38da69bc	Update doc-validator to latest release (#8221)	2 years ago
Susana Ferreira	7fc25743eb	Docs fix: add missing sections on index.template file (#8216) ... **What this PR does / why we need it**: PR https://github.com/grafana/loki/pull/7916 which introduced the documentation automation tool for Loki's configuration values, incorrectly removed the last sections of the documentation. This PR introduces them accordingly. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Travis Patterson	636e19dfeb	place canary docs in their own package and fix links+description (#8217) ... There is a PR blocked on incorrect canary docs: https://github.com/grafana/loki/pull/8205 This PR should clear that CI error so the author can rebase and have the PR accepted This was failing three lint checks: 1. Docs need a `description` header 2. Images have to link to the same directory so `./` instead of `../` 3. Images can only be linked from `_index.md` files so a new package is required	2 years ago
Jack Baldry	a6047e9770	Remove template alias from Helm chart reference (#8213) ... With its inclusion, the page tries to redirect https://grafana.com/docs/writers-toolkit/latest/templates/reference-template/ to https://grafana.com/docs/loki/latest/installation/helm/reference/ Signed-off-by: Jack Baldry <jack.baldry@grafana.com> Signed-off-by: Jack Baldry <jack.baldry@grafana.com>	2 years ago
Yash Soni	c648968866	updating troubleshooting and upgrade changelog (#8206) ... **What this PR does / why we need it**: Updating docs which mentions `querier.query_timeout` to `limits_request.query_timeout` **Which issue(s) this PR fixes**: Fixes #8090 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Danny Kopping	fd3d362e0c	Removing duplicated limits file and refactored references (#8210)	2 years ago
dependabot[bot]	1b025e967a	Bump github.com/heroku/x from 0.0.50 to 0.0.55 (#8209) ... Bumps [github.com/heroku/x](https://github.com/heroku/x) from 0.0.50 to 0.0.55. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/heroku/x/releases">github.com/heroku/x's releases</a>.</em></p> <blockquote> <h2>Add pkg for low cardinality metrics providers</h2> <p>This release adds a <code>lowcard</code> pkg that allows for wrapping of metrics providers. Labels added to instruments using <code>With()</code> will be ignored unless explicitly marked for inclusion. Label inclusion is indicated by passing the list to <code>NewLowCardinalityWrappedProvider()</code> as an argument when creating the low card wrapper.</p> <h2>Add support for blocking in Redis Pools</h2> <p>No release notes provided.</p> <h2>Support dyno ID verification</h2> <p>This merges <a href="https://github-redirect.dependabot.com/heroku/x/issues/176">#176</a> to support dyno ID verification.</p> <h2>Adding support for redispool DialContext</h2> <p>The <code>redispool</code> package was updated to support passed-in contexts.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="280e8db3bb"><code>280e8db</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/heroku/x/issues/181">#181</a> from heroku/slizco-add-low-card-provider-wrapper</li> <li><a href="6c1897a8ec"><code>6c1897a</code></a> Satisfy linter</li> <li><a href="38ecadf682"><code>38ecadf</code></a> Add low card provider for optionally skipping labels</li> <li><a href="c12028c4f9"><code>c12028c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/heroku/x/issues/180">#180</a> from heroku/allow-redis-pools-to-wait</li> <li><a href="47f5f0972b"><code>47f5f09</code></a> allow redigo pools to wait</li> <li><a href="0e73480512"><code>0e73480</code></a> Merge branch 'support-dyno-id-verification'</li> <li><a href="36b4e8c10e"><code>36b4e8c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/heroku/x/issues/178">#178</a> from heroku/redis-compat</li> <li><a href="21d183853d"><code>21d1838</code></a> deal with Redis 4,5 &amp; 6 compatibility issues</li> <li><a href="33262c0e71"><code>33262c0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/heroku/x/issues/177">#177</a> from heroku/quick-enhancements</li> <li><a href="65db653d72"><code>65db653</code></a> upgrade redigo and utilize DialContext instead of Dial</li> <li>Additional commits viewable in <a href="https://github.com/heroku/x/compare/v0.0.50...v0.0.55">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Jack Baldry	33553c9462	Use latest release of doc-validator image (#8211) ... - Fixes regression where non-Markdown files are considered for linting. - Uses a canonical algorithm for converting headings to anchor identifiers taken from the Hugo source. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>	2 years ago
Jack Baldry	3cb15d62d5	Docs: Add doc-validator tool to lint technical documentation (#6569) ... Source code: https://github.com/grafana/technical-documentation/tree/main/tools/doc-validator Signed-off-by: Jack Baldry <jack.baldry@grafana.com> **What this PR does / why we need it**: Adds a CI step for pull requests that validates links in technical documentation and performs linting of technical documentation source files. **Special notes for your reviewer**: - Lots of issues will need to be fixed before we can merge this. - The tool is still in early development so each error should be scrutinized for validity. **Checklist** - [ ] Documentation added - [na] Tests updated - [na] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [na] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Jack Baldry <jack.baldry@grafana.com>	2 years ago
Kaviraj Kanagaraj	86461b3faa	promtail: Add doc for `max-line-size` flag. (#8202) ... Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> **What this PR does / why we need it**: Follow up from #8153 Changes: * Change type of the flag from `int` to `flagext.ByteSize` (to be consistent with similar flag in `distributor`) * Add doc to promtail config page * Fix changelog entries **Which issue(s) this PR fixes**: Fixes #NA **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] `CHANGELOG.md` updated Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Kaviraj Kanagaraj	959e275b4f	promtail: Fix title and image path on `logrotation` doc (#8208) ... Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> **What this PR does / why we need it**: This fixes 1. Missing UI link to the side panel 2. Image paths   **Which issue(s) this PR fixes**: Fixes #NA **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> Co-authored-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
nervo	7aa596752d	Helm - Loki: Introduce runtimeConfig (#8179)	2 years ago
nervo	65bef5c360	Helm: Fix components notes (#8194) ... Add component `backend` in the list of installed components on helm notes, based on `read.legacyReadTarget` value, just like backend statefulset.	2 years ago
Christian Haudum	d97aaca089	[docs] Clarify for what version the Helm chart docs are applicable (#8172) ... **What this PR does / why we need it**: The docs and reference of the Helm chart in the documentation is only applicable for the Loki Helm chart `>= 3.0` and therefore does not apply to the `grafana/loki-stack` chart, which depends on the Loki Helm chart `^2.15.2` ([requirements.yaml](https://github.com/grafana/helm-charts/blob/main/charts/loki-stack/requirements.yaml#L5)). Also added a headline to the "Install Loki using Helm" index page, because it looks awkward without, see screenshot.  **Which issue(s) this PR fixes**: Fixes: #8152 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Prabuddha Chakraborty	20627ad000	Helm: Add ingester config in helm values (#7733) ... **What this PR does / why we need it**: Allow configuring ingester config from helm values: https://grafana.com/docs/loki/latest/configuration/#ingester We wanted to change the default chunk_encoding, which right now not possible in the current values template. Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
TAY TS	94ee5a2930	Helm chart: Add enableServiceLinks (#7129) ... **What this PR does / why we need it**: This is to allow disable `enableServiceLinks` so that the service environments are not injected into the pods where in my scenario Loki is deployed in the same namespace as the Knative services resulted the Loki pod unable to start up due to too many service environment being injected. Reference issue for pod unable to startup due to too many services: https://github.com/kubernetes/kubernetes/issues/84539#issue-514261281 Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Callum Styan	399eb097fd	Remove the stream lag metric. (#6324) ... Removes the stream lag metric since it's not possible to get a correct value and also not cause issues with metrics registration or collection until we have the WAL Signed-off-by: Callum Styan <callumstyan@gmail.com> Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Owen Diehl	a7ea9c1422	Revert "fix(logql): remove __error_details__ label on drop __error__ or other way around" (#8200) ... Reverts grafana/loki#8150 I was talking with @adityacs about reverting this PR and found the following: Looking at why tests don’t keep `__error_details__` when `__error__` is dropped and I found this line of code: ```go // LabelsResult returns the LabelsResult from the builder. // No grouping is applied and the cache is used when possible. func (b *LabelsBuilder) LabelsResult() LabelsResult { // unchanged path. if len(b.del) == 0 && len(b.add) == 0 && b.err == "" { return b.currentResult } return b.toResult(b.labels()) }``` https://github.com/grafana/loki/blob/main/pkg/logql/log/labels.go#L314 We only add err details when err isn’t empty anyway, so I guess we’ll revert for simplicity but just keep the same functionality	2 years ago
Kaviraj Kanagaraj	5031ae1b4e	doc(promtail): Doc about how log rotate works with promtail. (#8096) ... Changes 1. Why log rotation matters? 2. Different components involving in reading, writing and rotating logs 3. Different types of log rotation. 4. How to configure log rotation effectively to work with promtail Fixes # Should resolve all confusions around log rotation errors with promtail Related: #7967 Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
openbob	af93f4a11e	Helm: Add Table Manager support to Loki helm chart (#8098) ... The Table Manager is a Loki component which takes care of creating a periodic table before its time period begins, and deleting it once its data time range exceeds the retention period. This PR is to add Table Manager support to the loki helm chart deployment as the current chart is based on the deprecated loki-simple-scalable chart that did not support Table Manager. Fixes #<6830>	2 years ago
Trevor Whitney	b6004050a6	[helm] Fix self-monitoring tenant secret (#8198) ... **What this PR does / why we need it**: https://github.com/grafana/loki/pull/8081 introduced a bug that caused the `provisioner` job to create an incorrect secret for the self-monitoring tenant used by the canary. This fixes that bug, as well as adding a readme on how to use the `helm-cluster` k3d env. **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Owen Diehl	e4cbe50279	support single & double hyphen arguments in version printing (#8199) ... Small fix for an annoyance due special case parsing for the `version` flag. Previously we looked for `-version`, now we use the the flag library to support both `--version|-version`	2 years ago
Herman	9a516ce813	[docs] fix dead link in the docker client documentation (#8196) ... **What this PR does / why we need it**: Just fixes a dead link in the docker client docs.	2 years ago
Aditya C S	cf23194d05	fix(logql): remove __error_details__ label on drop __error__ or other way around (#8150)	2 years ago
dependabot[bot]	5cfd6a3c49	Bump github.com/spf13/afero from 1.9.2 to 1.9.3 (#8191) ... Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.9.2 to 1.9.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spf13/afero/releases">github.com/spf13/afero's releases</a>.</em></p> <blockquote> <h2>v1.9.3</h2> <h2>What's Changed</h2> <ul> <li>Fix concurrency issue in MemMapFs.Mkdir/MkdirAll by <a href="https://github.com/bep"><code>@​bep</code></a> in <a href="https://github-redirect.dependabot.com/spf13/afero/pull/379">spf13/afero#379</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/spf13/afero/compare/v1.9.2...v1.9.3">https://github.com/spf13/afero/compare/v1.9.2...v1.9.3</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="a800a9de53"><code>a800a9d</code></a> Fix concurrency issue in MemMapFs.Mkdir/MkdirAll</li> <li>See full diff in <a href="https://github.com/spf13/afero/compare/v1.9.2...v1.9.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Michel Hollands	cac2a131c9	Do not run release stage when check stage fails (#8175)	2 years ago
Mohamed-Amine Bouqsimi	86a1feb2c1	operator: Add watch on the Alertmanager in OCP's user-workload-monitoring namespace (#8038)	2 years ago
Ashwanth	0723678573	limits: add tenant to log lines for per-stream rate-limited and out-of-order errors (#8177)	2 years ago
Karsten Jeschkies	f24da4a194	Display replicas, cores and nodes in sizing tool. (#8088) ... **What this PR does / why we need it**: No every users wants to deploy Loki with Helm. That's why we are going to display the required replicas as well.  This change also fixes two bugs in the algorithm and introduces some tests for its invariant. **Checklist** - [ ] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Danny Kopping <danny.kopping@grafana.com> Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com> Co-authored-by: liam-howe-maersk <118169897+liam-howe-maersk@users.noreply.github.com> Co-authored-by: JordanRushing <rushing.jordan@gmail.com> Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com> Co-authored-by: Periklis Tsirakidis <periklis@redhat.com> Co-authored-by: Ashwanth Goli <iamashwanth@gmail.com>	2 years ago
Trevor Whitney	da76b1394d	fix broken drone image for arm builds (#8186) ... **What this PR does / why we need it**: Harness pushed a bad drone image, causing the build to fail for all arm images. The build is currently failing on `main`, this should fix it. Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com> Co-authored-by: Ashwanth Goli <iamashwanth@gmail.com>	2 years ago
Periklis Tsirakidis	664ea78154	operator: Remove custom webhook cert mounts for OLM-based deployment (#8173)	2 years ago
Trevor Whitney	eb39e2645f	[helm] allow provisioned tokens to be created in different namespaces (#8081) ... **What this PR does / why we need it**: _Note_: This PR bumps the chart to 4.0, so it includes a few other breaking changes we've been waiting to make. The new helm chart has a few different ways to create tokens when running in enterprise mode: * The tokengen job creates the initial admin token * The provisioner job creates the self-monitoring tenant if enabled * The provisioner job can also create additional tenants if configured The problem with these jobs is they put the generated read/write tokens for these tenants in secrets in the same namespace as the loki deploiyment. This is problematic if you need these tokens for a specific application, for example a Grafana datasource, that is deployed in a separate namespace. This PR introduces two breaking changes, one of which is breaking as it significantly changes how both the self monitoring and additional tenants are configured. First it adds the value `enterprise.adminToken.additionalNamespaces` and moves `enterprise.adminTokenSecret` to `enterprise.adminToken.secret`. If `additionalNamespaces` are included, additional secrets containing the GEL admin token are created in those namespaces as well as the release namespace. Second, it changes the structure of defining a tenant from just a string name, to an object containing a `name` and `secretNamespace` field. The `secretNamespace` is the namespace the secret containing that tenants token(s) will be placed in. In the case of the self-monitoring token, a secret will still be created in the default namespace in addition to the `secretNamespace` specified as that token is required by multiple components.	2 years ago
JordanRushing	d8a0c6f87f	Revert "[loki-canary] Support passing loki address as environment variable (#8024)" (#8183) ... **What this PR does / why we need it**: This PR reverts commit f9ed9cb7d9 which introduced breaking config changes for the Loki canary. The relevant change introduced support for configuring a new `LOKI_ADDRESS` canary environment variable by adopting a new library for flags. This is the easiest path forward to avoid forcing breaking config changes on canary operators; such a change is likely better suited to join other configuration changes in a future major Loki release. **Which issue(s) this PR fixes**: N/A **Special notes for your reviewer**: Related PR: - https://github.com/grafana/loki/pull/8024 **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
liam-howe-maersk	4681f9f487	Alerts: Exclude '/schedulerpb.SchedulerForQuerier/QuerierLoop' route in LokiRequestLatency alert (#8138) ... Excludes the route `/schedulerpb.SchedulerForQuerier/QuerierLoop` from the `LokiRequestLatency` alert query config. We have found that this route often has extremely high request latencies which will trigger the alert constantly for us. Looking through the source code it seems like it is expected to have high request latencies for this route and so in our configuration have excluded the route. We can see that this route is also being excluded in the [respective mimir config](https://github.com/grafana/mimir/blob/main/operations/mimir-mixin-compiled/alerts.yaml#L33) so believe it might be relevant to exclude here in loki as well	2 years ago
dependabot[bot]	70997fd090	Bump github.com/imdario/mergo from 0.3.12 to 0.3.13 (#8176) ... Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.12 to 0.3.13. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/imdario/mergo/releases">github.com/imdario/mergo's releases</a>.</em></p> <blockquote> <h2>Merging same-type slices supported, YAML upgraded to v3 (only used in tests), and more flexibility for transformers</h2> <h2>What's Changed</h2> <ul> <li>Fix typo in README.md by <a href="https://github.com/eltociear"><code>@​eltociear</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/184">imdario/mergo#184</a></li> <li>Adding StructBot to Mergo in the wild section by <a href="https://github.com/tjpnz"><code>@​tjpnz</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/193">imdario/mergo#193</a></li> <li>Add Goreleaser to featured projects by <a href="https://github.com/marcauberer"><code>@​marcauberer</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/191">imdario/mergo#191</a></li> <li>fix: gate transformers on valid non-nil destinations by <a href="https://github.com/zaquestion"><code>@​zaquestion</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/211">imdario/mergo#211</a></li> <li>Support slices of same type by <a href="https://github.com/heaths"><code>@​heaths</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/210">imdario/mergo#210</a></li> <li>Upgrade yaml to v3 by <a href="https://github.com/imdario"><code>@​imdario</code></a> in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/212">imdario/mergo#212</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/eltociear"><code>@​eltociear</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/184">imdario/mergo#184</a></li> <li><a href="https://github.com/tjpnz"><code>@​tjpnz</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/193">imdario/mergo#193</a></li> <li><a href="https://github.com/marcauberer"><code>@​marcauberer</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/191">imdario/mergo#191</a></li> <li><a href="https://github.com/zaquestion"><code>@​zaquestion</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/211">imdario/mergo#211</a></li> <li><a href="https://github.com/heaths"><code>@​heaths</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/imdario/mergo/pull/210">imdario/mergo#210</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/imdario/mergo/compare/0.3.12...v0.3.13">https://github.com/imdario/mergo/compare/0.3.12...v0.3.13</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="1949787570"><code>1949787</code></a> Update README.md</li> <li><a href="80c13e16e7"><code>80c13e1</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/imdario/mergo/issues/212">#212</a> from imdario/dcc/issue-206</li> <li><a href="f86e6f60b7"><code>f86e6f6</code></a> Upgrade yaml to v3</li> <li><a href="39ebbbb298"><code>39ebbbb</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/imdario/mergo/issues/210">#210</a> from heaths/issue209</li> <li><a href="fd7d2bcdb0"><code>fd7d2bc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/imdario/mergo/issues/211">#211</a> from zaquestion/transformer_valid_destination</li> <li><a href="8109749b3e"><code>8109749</code></a> add test for deepMerge panic</li> <li><a href="4bed36ec55"><code>4bed36e</code></a> add test for keeping zero values with transformer</li> <li><a href="ab6b2707a1"><code>ab6b270</code></a> fix: gate transformers on valid non-nil destinations</li> <li><a href="200f90d970"><code>200f90d</code></a> Support slices of same type</li> <li><a href="fd3dfc91a2"><code>fd3dfc9</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/imdario/mergo/issues/191">#191</a> from marcauberer/master</li> <li>Additional commits viewable in <a href="https://github.com/imdario/mergo/compare/0.3.12...v0.3.13">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Danny Kopping	4e16ea6b4d	Minor LID fixes (#8167) ... Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Kaviraj Kanagaraj	2597429c89	promtail: Add `max-line-size` limit to drop on client side (#8153)	2 years ago
Kaviraj Kanagaraj	9b5fa5e100	doc(distributor): Clarify `distributor.max-line-size` flag. (#8165) ... **What this PR does / why we need it**: Add a clarrification of two flags `distributor.max-line-size` and `distributor.max-line-size-truncate`. And clarity on [discarding the logs](https://github.com/grafana/loki/blob/main/pkg/distributor/validator.go#L84-L92) if later is disabled while still former is set to non-zero values. Whereas if `distributor.max-line-size-truncate` is set, [log line is only truncated.](https://github.com/grafana/loki/blob/main/pkg/distributor/distributor.go#L517-L534) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> **Which issue(s) this PR fixes**: Fixes #NA **Special notes for your reviewer**: Figured while working on PR #8153 **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Danny Kopping	7c78d7ea44	Removing "replace" directive for line-buffered logger (#8162)	2 years ago
dependabot[bot]	36907a81dd	Bump golang.org/x/time from 0.1.0 to 0.3.0 (#8161) ... Bumps [golang.org/x/time](https://github.com/golang/time) from 0.1.0 to 0.3.0. <details> <summary>Commits</summary> <ul> <li><a href="2c09566ef1"><code>2c09566</code></a> rate: the state of the limiter should not be changed when the requests failed</li> <li><a href="80b9fac54d"><code>80b9fac</code></a> x/time/rate: add rate.Sometimes, which runs a function occasionally.</li> <li>See full diff in <a href="https://github.com/golang/time/compare/v0.1.0...v0.3.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Karsten Jeschkies	17fdfcbaa1	Emit help message when check-mod fails (#8157)	2 years ago
dependabot[bot]	a8a4ba742d	Bump github.com/Masterminds/sprig/v3 from 3.2.2 to 3.2.3 (#8159) ... Bumps [github.com/Masterminds/sprig/v3](https://github.com/Masterminds/sprig) from 3.2.2 to 3.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Masterminds/sprig/releases">github.com/Masterminds/sprig/v3's releases</a>.</em></p> <blockquote> <h2>v3.2.3</h2> <h2>Changed</h2> <ul> <li>Updated docs (thanks <a href="https://github.com/book987"><code>@​book987</code></a> <a href="https://github.com/aJetHorn"><code>@​aJetHorn</code></a> <a href="https://github.com/neelayu"><code>@​neelayu</code></a> <a href="https://github.com/pellizzetti"><code>@​pellizzetti</code></a> <a href="https://github.com/apricote"><code>@​apricote</code></a> <a href="https://github.com/SaigyoujiYuyuko233"><code>@​SaigyoujiYuyuko233</code></a> <a href="https://github.com/AlekSi"><code>@​AlekSi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/348">#348</a>: Updated huandu/xstrings which fixed a snake case bug (thanks <a href="https://github.com/yxxhero"><code>@​yxxhero</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/353">#353</a>: Updated masterminds/semver which included bug fixes</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/354">#354</a>: Updated golang.org/x/crypto which included bug fixes</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/Masterminds/sprig/blob/master/CHANGELOG.md">github.com/Masterminds/sprig/v3's changelog</a>.</em></p> <blockquote> <h2>Release 3.2.3 (2022-11-29)</h2> <h3>Changed</h3> <ul> <li>Updated docs (thanks <a href="https://github.com/book987"><code>@​book987</code></a> <a href="https://github.com/aJetHorn"><code>@​aJetHorn</code></a> <a href="https://github.com/neelayu"><code>@​neelayu</code></a> <a href="https://github.com/pellizzetti"><code>@​pellizzetti</code></a> <a href="https://github.com/apricote"><code>@​apricote</code></a> <a href="https://github.com/SaigyoujiYuyuko233"><code>@​SaigyoujiYuyuko233</code></a> <a href="https://github.com/AlekSi"><code>@​AlekSi</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/348">#348</a>: Updated huandu/xstrings which fixed a snake case bug (thanks <a href="https://github.com/yxxhero"><code>@​yxxhero</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/353">#353</a>: Updated masterminds/semver which included bug fixes</li> <li><a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/354">#354</a>: Updated golang.org/x/crypto which included bug fixes</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="581758eb7d"><code>581758e</code></a> Updating the changelog for the 3.2.3 release</li> <li><a href="5787448a04"><code>5787448</code></a> Updating changelog for 3.2.2 release</li> <li><a href="8489c3eb22"><code>8489c3e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/354">#354</a> from mattfarina/bump-crypto-v0.3.0</li> <li><a href="42ac6ac131"><code>42ac6ac</code></a> Updating crypto library</li> <li><a href="d65147bc88"><code>d65147b</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/353">#353</a> from mattfarina/bump-semver-3.2.0</li> <li><a href="92ac1aee6a"><code>92ac1ae</code></a> Updating semver package</li> <li><a href="ce20d69f9f"><code>ce20d69</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/313">#313</a> from book987/master</li> <li><a href="f9a478a510"><code>f9a478a</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/334">#334</a> from aJetHorn/patch-1</li> <li><a href="58a4f651e0"><code>58a4f65</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/349">#349</a> from mattfarina/bump-go-19</li> <li><a href="32424cc260"><code>32424cc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Masterminds/sprig/issues/347">#347</a> from neelayu/patch-1</li> <li>Additional commits viewable in <a href="https://github.com/Masterminds/sprig/compare/v3.2.2...v3.2.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Dimitar Dimitrov	723f524e3b	Fix link to CONTRIUTING.md in PR template (#8156) ... The previous link lead to https://github.com/grafana/loki/CONTRIBUTING.md which doesn't exist.	2 years ago