apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Trevor Whitney	5a570cb921	Query ingesters for SeriesVolume in single binary (#9888 ) This change is necessary to get recent SeriesVolume data from the ingesters when running without an `AsyncStore` in single binary. It changes the queriers to query both the ingester and the store, rather than relying on the `AsyncStore` to query the ingesters.	2 years ago
Travis Patterson	cb2b3ca9ea	Add limit to the series volume endpoint (#9833 ) To protect index gateways, this PR adds a per-tenant limit to the `series_volume` endpoint so the accumulation of series can't grow without bound.	2 years ago
SeamusGrafana	72ea9d778c	[Docs] - Add example of Conditional OR to IP Filter (#9848 ) What this PR does / why we need it: This updates the Docs with an example of how to use an OR conditional filter when filtering by IP addresses. Example of this working on [Grafana Play can be found here](https://play.grafana.org/explore?orgId=1&left=%7B%22datasource%22:%22grafanacloud-logs%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22expr%22:%22%7Bcontainer%3D%5C%22grafana%5C%22%7D%20%7C%20logfmt%20%7C%20remote_addr%3Dip%28%6010.10.0.0%2F24%60%29%20or%20remote_addr%3Dip%28%6010.4.1.0%2F24%60%29%22,%22queryType%22:%22range%22,%22datasource%22:%7B%22type%22:%22loki%22,%22uid%22:%22grafanacloud-logs%22%7D,%22editorMode%22:%22code%22%7D%5D,%22range%22:%7B%22from%22:%221688342400000%22,%22to%22:%221688428799000%22%7D%7D) Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Karsten Jeschkies	02027e442c	Document deadlocked Docker daemon workaround. (#9896 ) What this PR does / why we need it: This pulls @Pandry's [workaround](https://github.com/grafana/loki/issues/2361#issuecomment-718024318) for the seemingly deadlocked Docker daemon into the documentation. Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
dependabot[bot]	f986492bb7	Bump github.com/Workiva/go-datastructures from 1.0.53 to 1.1.0 (#9886 ) Bumps [github.com/Workiva/go-datastructures](https://github.com/Workiva/go-datastructures) from 1.0.53 to 1.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Workiva/go-datastructures/releases">github.com/Workiva/go-datastructures's releases</a>.</em></p> <blockquote> <h2>v1.1.0</h2> <h2>Info</h2> <p>Build: <a href="https://ci.webfilings.com/build/4575457">https://ci.webfilings.com/build/4575457</a> Skynet Results: <a href="https://wf-skynet-hrd.appspot.com/apps/test/smithy/4575457/latest">https://wf-skynet-hrd.appspot.com/apps/test/smithy/4575457/latest</a> Pipeline: No Pipeline This <strong>minor</strong> release includes the following changes:</p> <h2>Miscellaneous</h2> <ul> <li>[x] <a href="https://redirect.github.com/Workiva/go-datastructures/issues/221">#221</a> Add <code>GetSetBits</code> and <code>Count</code> to <code>BitArray</code></li> </ul> <p>Notes created on Thursday, May 18 02:26 PM UTC</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="`68e77ee215`"><code>68e77ee</code></a> Merge pull request <a href="https://redirect.github.com/Workiva/go-datastructures/issues/221">#221</a> from Workiva/add-bitarray-getsetbits</li> <li><a href="`8f1c722b5c`"><code>8f1c722</code></a> Clarify purpose of bit-clearing expression</li> <li><a href="`33a45f0b71`"><code>33a45f0</code></a> Return an empty slice from <code>GetSetBits</code> for <code>nil</code>/empty buffers</li> <li><a href="`9c88543cfc`"><code>9c88543</code></a> Make <code>BitArray.Count</code> return an <code>int</code></li> <li><a href="`e309fb35d0`"><code>e309fb3</code></a> Fix spacing for binary expression example</li> <li><a href="`64dafb748c`"><code>64dafb7</code></a> Implement <code>Count</code> for <code>bitArray</code> and <code>sparseBitArray</code></li> <li><a href="`d95ee5d5fa`"><code>d95ee5d</code></a> Define <code>BitArray.Count</code> and add test coverage</li> <li><a href="`9eab2dfcee`"><code>9eab2df</code></a> Implement <code>GetSetBits</code> for <code>bitArray</code> and <code>sparseBitArray</code></li> <li><a href="`42ddd6d73a`"><code>42ddd6d</code></a> Add test coverage for <code>GetSetBits</code></li> <li><a href="`4a54802cc0`"><code>4a54802</code></a> Define <code>BitArray.GetSetBits</code></li> <li>See full diff in <a href="https://github.com/Workiva/go-datastructures/compare/v1.0.53...v1.1.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/Workiva/go-datastructures&package-manager=go_modules&previous-version=1.0.53&new-version=1.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Jara Suárez de Puga García	10e38b8b74	Request to change the loki-overview-2 image (#9359 ) What this PR does / why we need it: We in support are doing some review of public documents in general, the Overview is okay but the image seemed quite outdated, I was wondering if it would be nice to have it updated to this or something else ( not sure if it is the correct format). Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
DoomAndLove	5f380872b4	helm: fix formatting in CHANGELOG.md (#9891 ) What this PR does / why we need it: Fix the formatting for 5.8.6 in the changelog, which was bugging me too much. I have no idea why my change did anything Which issue(s) this PR fixes: N/A Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
J Stickler	0d79b219b2	Update redirects to use new alias format. (part 1 of 2) (#9881 ) Special notes for your reviewer: @jdbaldry commented on #9717 that the alias format had changed, but we [agreed](https://github.com/grafana/loki/pull/9717#issuecomment-1594960563) that I could update it in a follow up PR. This is that follow up. Also updating previously merged file moves that used the old alias format. Breaking the alias updates into two PRs to make for smaller reviews.	2 years ago
J Stickler	f70f9110aa	Update version in docker driver command. (#9870 ) Which issue(s) this PR fixes: Fixes #9802 There is an 2.5 year old image in Docker Hub with the tag `latest`, so updating the documentation to not reference this tag, as it pulls the incorrect image.	2 years ago
J Stickler	7797a98074	TOC Sync: Move configuration files under Configure (#9879 ) Which issue(s) this PR fixes: Fixes #8713 Special notes for your reviewer: Replaces PR [#8817](https://github.com/grafana/loki/pull/8817), which was stale and badly out of date. Part of the Database products table of contents alignment project. Moves configuration files from Configuration to new Configure heading in TOC. Updates front matter for the topic. Fixes links broken by the move. Updates the MakeFile to point to the new Configure DOCS_SOURCES_PATH.	2 years ago
Travis Patterson	e2e695e8cd	Get basic statistics from series volume requests (#9832 ) The `series_volume` endpoint returns stats about the call. This PR wires things up such that basic stats are returned: - Execution time - Number of responses	2 years ago
David Peleg	c129cfe93c	Docs: add reference to flog CLI args (#9638 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Paul Rogers	40d0536e45	Migrate tool: Fetch chunks as big batch, only go one by one in case of an error (#9867 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
dependabot[bot]	497dccea83	Bump golang.org/x/crypto from 0.10.0 to 0.11.0 (#9876 ) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.10.0 to 0.11.0. <details> <summary>Commits</summary> <ul> <li><a href="`e98487292d`"><code>e984872</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`183630ada7`"><code>183630a</code></a> x509roots: generate a stable sort, for real this time</li> <li><a href="`a9e447dde7`"><code>a9e447d</code></a> x509roots/fallback: add //go:build go1.20 to bundle.go</li> <li><a href="`64c3993f5c`"><code>64c3993</code></a> ssh: add hmac-sha2-512</li> <li><a href="`5fe8145aca`"><code>5fe8145</code></a> x509roots: remove list hash and generation date, change ordering</li> <li><a href="`043e94c17a`"><code>043e94c</code></a> x509roots: fix generate script argument checking</li> <li><a href="`0d502d7cd6`"><code>0d502d7</code></a> x509roots: use "generate" build tag</li> <li><a href="`0ff60057bb`"><code>0ff6005</code></a> ssh/test: set a timeout and WaitDelay on sshd subcommands</li> <li>See full diff in <a href="https://github.com/golang/crypto/compare/v0.10.0...v0.11.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/crypto&package-manager=go_modules&previous-version=0.10.0&new-version=0.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
dependabot[bot]	9ee918d359	Bump google.golang.org/grpc from 1.52.0 to 1.53.0 in /pkg/push (#9871 ) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.52.0 to 1.53.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p> <blockquote> <h2>Release 1.53.0</h2> <h1>API Changes</h1> <ul> <li>balancer: support injection of per-call metadata from LB policies (<a href="https://redirect.github.com/grpc/grpc-go/issues/5853">#5853</a>)</li> <li>resolver: remove deprecated field <code>resolver.Target.Endpoint</code> and replace with <code>resolver.Target.Endpoint()</code> (<a href="https://redirect.github.com/grpc/grpc-go/issues/5852">#5852</a>) <ul> <li>Special Thanks: <a href="https://github.com/kylejb"><code>@kylejb</code></a></li> </ul> </li> </ul> <h1>New Features</h1> <ul> <li>xds/ringhash: introduce <code>GRPC_RING_HASH_CAP</code> environment variable to override the maximum ring size. (<a href="https://redirect.github.com/grpc/grpc-go/issues/5884">#5884</a>)</li> <li>rls: propagate headers received in RLS response to backends (<a href="https://redirect.github.com/grpc/grpc-go/issues/5883">#5883</a>)</li> </ul> <h1>Bug Fixes</h1> <ul> <li>transport: drain client transport when streamID approaches MaxStreamID (<a href="https://redirect.github.com/grpc/grpc-go/issues/5889">#5889</a>)</li> <li>server: after GracefulStop, ensure connections are closed when final RPC completes (<a href="https://redirect.github.com/grpc/grpc-go/issues/5968">#5968</a>)</li> <li>server: fix a few issues where grpc server uses RST_STREAM for non-HTTP/2 errors (<a href="https://redirect.github.com/grpc/grpc-go/issues/5893">#5893</a>)</li> <li>xdsclient: fix race which can happen when multiple load reporting calls are made at the same time. (<a href="https://redirect.github.com/grpc/grpc-go/issues/5927">#5927</a>)</li> <li>rls: fix a data race involving the LRU cache (<a href="https://redirect.github.com/grpc/grpc-go/issues/5925">#5925</a>)</li> <li>xds: fix panic involving double close of channel in xDS transport (<a href="https://redirect.github.com/grpc/grpc-go/issues/5959">#5959</a>)</li> <li>gcp/observability: update method name validation (<a href="https://redirect.github.com/grpc/grpc-go/issues/5951">#5951</a>)</li> </ul> <h1>Documentation</h1> <ul> <li>credentials/oauth: mark <code>NewOauthAccess</code> as deprecated (<a href="https://redirect.github.com/grpc/grpc-go/issues/5882">#5882</a>) <ul> <li>Special Thanks: <a href="https://github.com/buzzsurfr"><code>@buzzsurfr</code></a></li> </ul> </li> </ul> <h2>Release 1.52.3</h2> <h1>Bug Fixes</h1> <ul> <li>Fix user-agent version</li> </ul> <h2>Release 1.52.2</h2> <h1>Bug Fixes</h1> <ul> <li>xds: fix panic involving double close of channel in xDS transport (<a href="https://redirect.github.com/grpc/grpc-go/issues/5959">#5959</a>)</li> </ul> <h2>Release 1.52.1</h2> <h1>Bug Fixes</h1> <ul> <li>grpclb: rename grpclbstate package back to state (<a href="https://redirect.github.com/grpc/grpc-go/issues/5963">#5963</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="`dba26e15a0`"><code>dba26e1</code></a> Change version to 1.53.0 (<a href="https://redirect.github.com/grpc/grpc-go/issues/5983">#5983</a>)</li> <li><a href="`2a1e9348ff`"><code>2a1e934</code></a> server: after GracefulStop, ensure connections are closed when final RPC comp...</li> <li><a href="`e2d69aa076`"><code>e2d69aa</code></a> tests: fix spelling of variable (<a href="https://redirect.github.com/grpc/grpc-go/issues/5966">#5966</a>)</li> <li><a href="`a6376c9893`"><code>a6376c9</code></a> xds/resolver: cleanup tests to use real xDS client 3/n (<a href="https://redirect.github.com/grpc/grpc-go/issues/5953">#5953</a>)</li> <li><a href="`bf8fc46fa6`"><code>bf8fc46</code></a> xds/resolver: cleanup tests to use real xDS client 5/n (<a href="https://redirect.github.com/grpc/grpc-go/issues/5955">#5955</a>)</li> <li><a href="`3930549b38`"><code>3930549</code></a> resolver: replace resolver.Target.Endpoint field with Endpoint() method (<a href="https://redirect.github.com/grpc/grpc-go/issues/5852">#5852</a>)</li> <li><a href="`894816c487`"><code>894816c</code></a> grpclb: rename <code>grpclbstate</code> package back to <code>state</code> (<a href="https://redirect.github.com/grpc/grpc-go/issues/5962">#5962</a>)</li> <li><a href="`e5a0237a46`"><code>e5a0237</code></a> encoding: fix duplicate compressor names (<a href="https://redirect.github.com/grpc/grpc-go/issues/5958">#5958</a>)</li> <li><a href="`4adb2a7a00`"><code>4adb2a7</code></a> xds/resolver: cleanup tests to use real xDS client 2/n (<a href="https://redirect.github.com/grpc/grpc-go/issues/5952">#5952</a>)</li> <li><a href="`52a8392f37`"><code>52a8392</code></a> gcp/observability: update method name validation (<a href="https://redirect.github.com/grpc/grpc-go/issues/5951">#5951</a>)</li> <li>Additional commits viewable in <a href="https://github.com/grpc/grpc-go/compare/v1.52.0...v1.53.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google.golang.org/grpc&package-manager=go_modules&previous-version=1.52.0&new-version=1.53.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/grafana/loki/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Karsten Jeschkies	f5992274f4	Switch on pointer `logproto.SeriesResponse` in JSON serialization. (#9868 ) What this PR does / why we need it: Commit `b35bbd80d6` introduced a regression in the deserialization code. It would switch on `logproto.SeriesResponse` instead of the pointer type `logproto.SeriesResponse`. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Dylan Guedes	bc0069756e	Queriers: Stop emitting spans for every objectstorage call (#9857 ) What this PR does / why we need it: Stop emitting spans for every call to our object storages (like S3 or Azure). They are causing every chunk fetching to emit a span. Request metrics will still be reported just fine. Which issue(s) this PR fixes: N/A	2 years ago
Karsten Jeschkies	9393f3f11a	Test querier handlers reponse format. (#9854 ) What this PR does / why we need it: This is a follow up to #9813 that introduced a handler test to verify the response format for the legacy and v1 APIs. The test requires mocking of the engine and query which meant the introduction of a query engine interface. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
dependabot[bot]	9aadb348ed	Bump golang.org/x/crypto from 0.9.0 to 0.10.0 (#9865 ) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.9.0 to 0.10.0. <details> <summary>Commits</summary> <ul> <li><a href="`8e447d8cc5`"><code>8e447d8</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`22c9997952`"><code>22c9997</code></a> go.mod: tell x repo tagging to ignore dep on net</li> <li><a href="`d0b316056b`"><code>d0b3160</code></a> x509roots: add new module</li> <li><a href="`16222386f4`"><code>1622238</code></a> Add support for "<a href="mailto:hmac-sha2-512-etm@openssh.com">hmac-sha2-512-etm@openssh.com</a>"</li> <li>See full diff in <a href="https://github.com/golang/crypto/compare/v0.9.0...v0.10.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/crypto&package-manager=go_modules&previous-version=0.9.0&new-version=0.10.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
wanddynosios	8037d96558	helm: fix dashboard multiple levels (#9010 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #9009 Special notes for your reviewer: Dashboard from the helm chart had a `=` instead of a `=~` operator for the level filter Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Ashwanth	de937e72cd	promtail: apply defaults to HTTP client config (#9863 ) What this PR does / why we need it: Apply defaults to HTTPClientConfig and validate it. similar to how it's done [here](`e9644d8186/vendor/github.com/prometheus/prometheus/config/config.go (L524)`) in prometheus. promtail [configuration page](https://grafana.com/docs/loki/latest/clients/promtail/configuration/) incorrectly claims that `follow_redirects` is true, but it is being set to false given that the defaults are not being applied currently Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Robert Jacob	8d74b8ccae	operator: Regenerate bundles after docs change (#9859 )	2 years ago
dependabot[bot]	0d9a124e69	Bump github.com/alicebob/miniredis/v2 from 2.30.2 to 2.30.4 (#9850 ) Bumps [github.com/alicebob/miniredis/v2](https://github.com/alicebob/miniredis) from 2.30.2 to 2.30.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/alicebob/miniredis/releases">github.com/alicebob/miniredis/v2's releases</a>.</em></p> <blockquote> <h2>fix ZADD, fix COPY, speedy SPOP</h2> <ul> <li>fix ZADD LT/LG (thanks <a href="https://github.com/sejin-P"><code>@sejin-P</code></a>)</li> <li>fix COPY (thanks <a href="https://github.com/jerargus"><code>@jerargus</code></a>)</li> <li>quicker SPOP</li> </ul> <h2>ZMSCORE, lua error_reply, lua cache</h2> <ul> <li>fix lua error_reply (thanks <a href="https://github.com/pkierski"><code>@pkierski</code></a>)</li> <li>fix use of blocking functions in lua</li> <li>support for ZMSCORE (thanks <a href="https://github.com/lsgndln"><code>@lsgndln</code></a>)</li> <li>lua cache (thanks <a href="https://github.com/tonyhb"><code>@tonyhb</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/alicebob/miniredis/blob/master/CHANGELOG.md">github.com/alicebob/miniredis/v2's changelog</a>.</em></p> <blockquote> <h3>v2.30.4</h3> <ul> <li>fix ZADD LT/LG (thanks <a href="https://github.com/sejin-P"><code>@sejin-P</code></a>)</li> <li>fix COPY (thanks <a href="https://github.com/jerargus"><code>@jerargus</code></a>)</li> <li>quicker SPOP</li> </ul> <h3>v2.30.3</h3> <ul> <li>fix lua error_reply (thanks <a href="https://github.com/pkierski"><code>@pkierski</code></a>)</li> <li>fix use of blocking functions in lua</li> <li>support for ZMSCORE (thanks <a href="https://github.com/lsgndln"><code>@lsgndln</code></a>)</li> <li>lua cache (thanks <a href="https://github.com/tonyhb"><code>@tonyhb</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="`082add4914`"><code>082add4</code></a> changelog</li> <li><a href="`1dfc2776b5`"><code>1dfc277</code></a> quicker SPOP</li> <li><a href="`fb75409cf5`"><code>fb75409</code></a> do proper list copy</li> <li><a href="`f507fa8d65`"><code>f507fa8</code></a> Merge pull request <a href="https://redirect.github.com/alicebob/miniredis/issues/330">#330</a> from sejin-P/ZADD-LT-default-value</li> <li><a href="`b0d3aeee12`"><code>b0d3aee</code></a> fix; check value existence when applying LT GT option to ZADD</li> <li><a href="`df419454ee`"><code>df41945</code></a> gofmt error</li> <li><a href="`ae47488375`"><code>ae47488</code></a> typo</li> <li><a href="`d6eb001ed5`"><code>d6eb001</code></a> update changelog</li> <li><a href="`a946a99f2c`"><code>a946a99</code></a> use the cleaner variable to get the result length</li> <li><a href="`a3211dedea`"><code>a3211de</code></a> Merge pull request <a href="https://redirect.github.com/alicebob/miniredis/issues/328">#328</a> from tonyhb/perf/precompile-lua-functions</li> <li>Additional commits viewable in <a href="https://github.com/alicebob/miniredis/compare/v2.30.2...v2.30.4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/alicebob/miniredis/v2&package-manager=go_modules&previous-version=2.30.2&new-version=2.30.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Sandeep Sukhani	7cbfdb5d6d	cache: fix a mistake in returning cached error in the index list cache (#9853 ) What this PR does / why we need it: I did a mistake in returning a cached error in the code pushed in PR #9798. Fixing it in the PR with some tests. Checklist - [x] Tests updated	2 years ago
Ashwanth	26f36d07f4	ksonnet: refer to tsdb_shipper_shared_store only if using_tsdb_shipper is true (#9852 ) What this PR does / why we need it: https://github.com/grafana/loki/pull/9790 introduced a new config `tsdb_shipper_shared_store`, but it's being referred to even if tsdb index is not enabled. This fixes it by accessing the value only if using_tsdb_shipper is set to true Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Sandeep Sukhani	e089b4b60d	address feedback on pr 9798 (#9842 ) What this PR does / why we need it: PR #9798 got merged by mistake without me addressing the feedback. There is some critical feedback which needs to be addressed, particularly https://github.com/grafana/loki/pull/9798#discussion_r1243526743.	2 years ago
Jonathan Duncan	1d3f0b1001	Documentation: limits_config.enforce_metric_name removed (#9393 ) What this PR does / why we need it: ["The config still exists though, it's just not used anywhere."](https://github.com/grafana/loki/issues/2096) Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Hamish Forbes	d0baa40df3	Only modify identical timestamps when increment-duplicate-timestamps enabled (#9437 ) When `-validation.increment-duplicate-timestamps` is enabled out of order log entries within the same push request can have their timestamps incorrectly mutated. The code is currently just looking for 2 consecutive entries where the timestamp is not increasing. It should only affect entries where the timestamp is a duplicate Test push request payload: ```json { "streams": [ { "stream": { "increment_duplicate_timestamp": "fixed\|true\|false" }, "values": [ [ "1683665111628000000", "1a: 1683665111628000000" ], [ "1683665111628000000", "1b: 1683665111628000000" ], [ "1683665111628000003", "3: 1683665111628000003" ], [ "1683665111628000002", "2: 1683665111628000002" ] ] } ] } ```` As only the first 2 of these timestamps are the same I would expect all but `1b` to have the timestamps recorded as-is and the logs returned by a query in the order: 1a,1b,2,3. Actual Results: ``` > logcli query --forward --limit 100 -z UTC -q --no-labels --since 60m -o jsonl '{increment_duplicate_timestamp="fixed"}' \| jq { "line": "1a: 1683665111628000000", "timestamp": "2023-05-09T20:45:11.628Z" } { "line": "1b: 1683665111628000000", "timestamp": "2023-05-09T20:45:11.628000001Z" } { "line": "2: 1683665111628000002", "timestamp": "2023-05-09T20:45:11.628000002Z" } { "line": "3: 1683665111628000003", "timestamp": "2023-05-09T20:45:11.628000003Z" } > logcli query --forward --limit 100 -z UTC -q --no-labels --since 60m -o jsonl '{increment_duplicate_timestamp="true"}' \| jq { "line": "1a: 1683665111628000000", "timestamp": "2023-05-09T20:45:11.628Z" } { "line": "1b: 1683665111628000000", "timestamp": "2023-05-09T20:45:11.628000001Z" } { "line": "3: 1683665111628000003", "timestamp": "2023-05-09T20:45:11.628000003Z" } { "line": "2: 1683665111628000002", "timestamp": "2023-05-09T20:45:11.628000004Z" } > logcli query --forward --limit 100 -z UTC -q --no-labels --since 60m -o jsonl '{increment_duplicate_timestamp="false"}' \| jq { "line": "1a: 1683665111628000000", "timestamp": "2023-05-09T20:45:11.628Z" } { "line": "1b: 1683665111628000000", "timestamp": "2023-05-09T20:45:11.628Z" } { "line": "2: 1683665111628000002", "timestamp": "2023-05-09T20:45:11.628000002Z" } { "line": "3: 1683665111628000003", "timestamp": "2023-05-09T20:45:11.628000003Z" } ``` `true` and `false` were written to Loki 2.8.2 with the `-validation.increment-duplicate-timestamps` enabled or disabled `fixed` with this patch applied and the flag enabled Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
aryalireza	dc4277fd86	Update tanka.md (#9820 ) Add delete loki's environment and resources from k8s cluster. What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Co-authored-by: Travis Patterson <masslessparticle@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Alvin Townsend	8e25567e9f	Loki Promtail: Don't Create home directory for `promtail` user in promtail-postinstall.sh (#9800 ) What this PR does / why we need it: When the `promtail-postinstall` script creates a `promtail` user, I do not believe that user requires a home directory to function correctly, and there are cases where the directory cannot be created causing the installation to fail. Which issue(s) this PR fixes: n/a - trivial fix Special notes for your reviewer: Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required)	2 years ago
Sandeep Sukhani	2ed3c15c22	index: allow refreshing index file names cache for specific tables (#9798 ) What this PR does / why we need it: We have a cache for index files available in the object storage, which helps reduce the number of list calls we make to the object storage. Currently, we only support refreshing the whole index cache, which includes all the files for all tables and users. However, in a large cell with many tables and tenants, it is less likely that all the tables are being referenced. Also, most iterative operations would only need a fresh listing of just a few tables at a time so it is wasteful to always refresh the whole index cache. This PR adds support for refreshing the index cache for only specific tables. I am doing it as part of some compactor improvements to run compaction and retention in separate goroutines to avoid blocking compaction when some expensive delete requests are being processed. To make those changes, I needed a way to cost-effectively refresh the index files in the table being picked up for processing. Checklist - [x] Tests updated	2 years ago
Bryan Boreham	5c3e2a5cf8	Fix link to blog in readme (#9838 ) I noticed this link was 404-ing.	2 years ago
Karsten Jeschkies	b35bbd80d6	Support content negotiation between query frontend and querier. (#9813 ) What this PR does / why we need it: Currently, the querier sends results to the query frontend in JSON which is then decoded to Protobuf. It is more efficient to send the results as Protobuf. This will also allow to extend the results with custom data structures. The change is backwards compatible through content negotiation. Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
ZhenYi Liang	0711580154	helm: support endpoint_suffix for azure storage (#9791 ) What this PR does / why we need it: According the [official document](https://grafana.com/docs/loki/latest/storage/#using-account-name-and-key), support storage_config.azure.endpoint_suffix, example blob.core.chinacloudapi.cn Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
cui fliter	4b53909ccf	all: remove repetitive the (#9823 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) Signed-off-by: cui fliter <imcusg@gmail.com>	2 years ago
Owen Diehl	b251a10234	uses lowercase standard for logging and adds total bytes to shard res… (#9828 ) Minor logging cleanup + helpful to have total bytes on this log line to correlate without needing to derive total bytes from factor * bytes_per_shard	2 years ago
Periklis Tsirakidis	bcdc807dd3	operator: Expose limits config setting cardinality_limit (#9830 )	2 years ago
Karsten Jeschkies	125e168a91	Replace flaky server for log level handler test. (#9822 ) What this PR does / why we need it: I've noticed that the `TestLevelHandler` were flaky because the code wasn't waiting to the server to be running. Since the test is for a handler it's much simpler to call it directly with a response recorder. Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Lukas Grossar	6a1f34f4f1	Helm: remove PVC retention policy in single-binary mode when persistence is disabled (#9805 ) When there are no volumeClaimTemplates configured in the StatefulSet then the Kubernetes API doesn't store the configuration for persistentVolumeClaimRetentionPolicy in turn leading to the application being constantly out of sync in e.g. Argo CD What this PR does / why we need it: Fixes an issue where the chart is out constantly out of sync in e.g. Argo CD Which issue(s) this PR fixes: Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Dylan Guedes	1d20fdbf57	LogPushFailures: Log the tenant id (#9819 ) What this PR does / why we need it: Modify the `writefailures.Manager` to - Log the tenant id. Otherwise, it is hard to identify which tenant is responsible for a problematic push - Log stream parsing failures Which issue(s) this PR fixes: N/A	2 years ago
Trevor Whitney	d4cfbaac4f	Implement series volume range queries (#9812 ) This PR adds a `series_volume_range` endpoint which allows for series volume queries over time with a specified step, returning timeseries data in the form of a Prometheus matrix response. The existing `series_volume` endpoint still returns Prometheus vector responses, and hardcodes the step to 0.	2 years ago
Salva Corts	6cc581bd26	Add back cache stats for index stats requests (#9816 ) What this PR does / why we need it: In https://github.com/grafana/loki/pull/9536, we added cache stats for index stats requests. That PR had a bug that inflated the query stats due to reusing the stats context in the query engine. Therefore, we had to revert the PR at https://github.com/grafana/loki/pull/9721. This PR brings back the changes from https://github.com/grafana/loki/pull/9536 but fixes the inflated starts by no longer reusing the same context in the query engine, but rather creating a new one for the shard resolver. I tested it on a dev cluster and seems to be working fine. here's the output for the same query: Stats with the bug from #9536: ``` ... Cache.StatsResult.Requests 980 Cache.StatsResult.EntriesRequested 490 Cache.StatsResult.EntriesFound 0 Cache.StatsResult.EntriesStored 490 Cache.StatsResult.BytesSent 0 B Cache.StatsResult.BytesReceived 0 B ... Summary.BytesProcessedPerSecond 43 GB Summary.LinesProcessedPerSecond 93305142 Summary.TotalBytesProcessed 945 GB Summary.TotalLinesProcessed 2059694183 ``` Stats from _main_ ``` ... Summary.BytesProcessedPerSecond 1.6 GB Summary.LinesProcessedPerSecond 3403718 Summary.TotalBytesProcessed 95 GB Summary.TotalLinesProcessed 207971404 ``` Stats with fix in this PR ``` .. Cache.StatsResult.Requests 132 Cache.StatsResult.EntriesRequested 66 Cache.StatsResult.EntriesFound 0 Cache.StatsResult.EntriesStored 66 Cache.StatsResult.BytesSent 0 B Cache.StatsResult.BytesReceived 0 B ... Summary.BytesProcessedPerSecond 4.3 GB Summary.LinesProcessedPerSecond 9468900 Summary.TotalBytesProcessed 95 GB Summary.TotalLinesProcessed 207793816 ``` As can be seen, with the changes in this PR, the summary stats are no longer inflated. Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki/pull/9536 Special notes for your reviewer: I think it's ok to skip reviewing the changes from the commit cherry-picking the changes from https://github.com/grafana/loki/pull/9536 Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Tiago Posse	a24ef7b206	Helm: support metricRelabelings for loki serviceMonitors (#9784 ) What this PR does / why we need it: Add support for `metricRelabelings` in the `ServiceMonitor` resources when monitoring Loki. Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Signed-off-by: Tiago Posse <tiagoposse@gmail.com> Co-authored-by: Tiago Posse <tiago.posse@hi.health>	2 years ago
Victor Login	15538ac4fc	loki: upgrade version grafana-agent-operator (#9041 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes: - https://github.com/prometheus-community/helm-charts/issues/3122 - https://github.com/grafana/helm-charts/issues/2236 Special notes for your reviewer: update dependencies for fix problem with CRD Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Victor Login <batazor@evrone.com>	2 years ago
manohar-koukuntla	999259a4d3	jsonnet: Add TSDB shipper configuration flag (#9790 ) This commit adds the TSDB equivalent of `use_boltdb_shipper` flag to be able to configure `tsdb_shipper` section. Fixes #9789	2 years ago
dependabot[bot]	579e54228e	Bump github.com/prometheus/client_golang from 1.15.1 to 1.16.0 (#9794 ) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.15.1 to 1.16.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prometheus/client_golang/releases">github.com/prometheus/client_golang's releases</a>.</em></p> <blockquote> <h2>v1.16.0</h2> <h2>What's Changed</h2> <ul> <li>[BUGFIX] api: Switch to POST for LabelNames, Series, and QueryExemplars. <a href="https://redirect.github.com/prometheus/client_golang/issues/1252">#1252</a></li> <li>[BUGFIX] api: Fix undefined execution order in return statements. <a href="https://redirect.github.com/prometheus/client_golang/issues/1260">#1260</a></li> <li>[BUGFIX] native histograms: Fix bug in bucket key calculation. <a href="https://redirect.github.com/prometheus/client_golang/issues/1279">#1279</a></li> <li>[ENHANCEMENT] Reduce constrainLabels allocations for all metrics. <a href="https://redirect.github.com/prometheus/client_golang/issues/1272">#1272</a></li> <li>[ENHANCEMENT] promhttp: Add process start time header for scrape efficiency. <a href="https://redirect.github.com/prometheus/client_golang/issues/1278">#1278</a></li> <li>[ENHANCEMENT] promlint: Improve metricUnits runtime. <a href="https://redirect.github.com/prometheus/client_golang/issues/1286">#1286</a></li> </ul> <!-- raw HTML omitted --> <ul> <li>Merge v1.15 to main by <a href="https://github.com/bwplotka"><code>@bwplotka</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1250">prometheus/client_golang#1250</a></li> <li>Switch to POST for LabelNames, Series, and QueryExemplars to DoGetFallback by <a href="https://github.com/jacksontj"><code>@jacksontj</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1252">prometheus/client_golang#1252</a></li> <li>✏️ [collectors]: fix typo in test assertion by <a href="https://github.com/vegerot"><code>@vegerot</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1153">prometheus/client_golang#1153</a></li> <li>Added interactive tutorial [kubeCon] by <a href="https://github.com/bwplotka"><code>@bwplotka</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1255">prometheus/client_golang#1255</a></li> <li>Fixed tutorial. by <a href="https://github.com/bwplotka"><code>@bwplotka</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1256">prometheus/client_golang#1256</a></li> <li>Bump golang.org/x/sys from 0.6.0 to 0.7.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1265">prometheus/client_golang#1265</a></li> <li>Cleanup proto use in tests by <a href="https://github.com/SuperQ"><code>@SuperQ</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1264">prometheus/client_golang#1264</a></li> <li>Fix tutorial on WSL-based systems by <a href="https://github.com/marevers"><code>@marevers</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1257">prometheus/client_golang#1257</a></li> <li>Fix undefined execution order in return statements by <a href="https://github.com/PiotrLewandowski323"><code>@PiotrLewandowski323</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1260">prometheus/client_golang#1260</a></li> <li>Merge release 1.15.1 to main by <a href="https://github.com/bwplotka"><code>@bwplotka</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1267">prometheus/client_golang#1267</a></li> <li>GitHub Workflows security hardening by <a href="https://github.com/sashashura"><code>@sashashura</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1180">prometheus/client_golang#1180</a></li> <li>add process start time header to client_golang prometheus by <a href="https://github.com/logicalhan"><code>@logicalhan</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1278">prometheus/client_golang#1278</a></li> <li>Fix bug in bucket key calculation by <a href="https://github.com/beorn7"><code>@beorn7</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1279">prometheus/client_golang#1279</a></li> <li>Bump github.com/prometheus/procfs from 0.9.0 to 0.10.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1283">prometheus/client_golang#1283</a></li> <li>Reduce constrainLabels allocations by <a href="https://github.com/khasanovbi"><code>@khasanovbi</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1272">prometheus/client_golang#1272</a></li> <li>added circleci as gh action YAML by <a href="https://github.com/krishnaduttPanchagnula"><code>@krishnaduttPanchagnula</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1281">prometheus/client_golang#1281</a></li> <li>Improve metricUnits runtime by <a href="https://github.com/avlitman"><code>@avlitman</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1286">prometheus/client_golang#1286</a></li> <li>Moving fully to GH actions. by <a href="https://github.com/bwplotka"><code>@bwplotka</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1288">prometheus/client_golang#1288</a></li> <li>Fix docstring references to renamed native histogram fields / functions. by <a href="https://github.com/juliusv"><code>@juliusv</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1290">prometheus/client_golang#1290</a></li> <li>Fixed README & CHANGELOG; Added fmt makefile command (+bingo) for easier contributions. by <a href="https://github.com/bwplotka"><code>@bwplotka</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1289">prometheus/client_golang#1289</a></li> <li></li> </ul> <!-- raw HTML omitted --> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/vegerot"><code>@vegerot</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/client_golang/pull/1153">prometheus/client_golang#1153</a></li> <li><a href="https://github.com/marevers"><code>@marevers</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/client_golang/pull/1257">prometheus/client_golang#1257</a></li> <li><a href="https://github.com/PiotrLewandowski323"><code>@PiotrLewandowski323</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/client_golang/pull/1260">prometheus/client_golang#1260</a></li> <li><a href="https://github.com/sashashura"><code>@sashashura</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/client_golang/pull/1180">prometheus/client_golang#1180</a></li> <li><a href="https://github.com/logicalhan"><code>@logicalhan</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/client_golang/pull/1278">prometheus/client_golang#1278</a></li> <li><a href="https://github.com/khasanovbi"><code>@khasanovbi</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/client_golang/pull/1272">prometheus/client_golang#1272</a></li> <li><a href="https://github.com/krishnaduttPanchagnula"><code>@krishnaduttPanchagnula</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/client_golang/pull/1281">prometheus/client_golang#1281</a></li> <li><a href="https://github.com/avlitman"><code>@avlitman</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/client_golang/pull/1286">prometheus/client_golang#1286</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/prometheus/client_golang/compare/v1.15.1...v1.16.0">https://github.com/prometheus/client_golang/compare/v1.15.1...v1.16.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md">github.com/prometheus/client_golang's changelog</a>.</em></p> <blockquote> <h2>1.16.0 / 2023-06-15</h2> <ul> <li>[BUGFIX] api: Switch to POST for LabelNames, Series, and QueryExemplars. <a href="https://redirect.github.com/prometheus/client_golang/issues/1252">#1252</a></li> <li>[BUGFIX] api: Fix undefined execution order in return statements. <a href="https://redirect.github.com/prometheus/client_golang/issues/1260">#1260</a></li> <li>[BUGFIX] native histograms: Fix bug in bucket key calculation. <a href="https://redirect.github.com/prometheus/client_golang/issues/1279">#1279</a></li> <li>[ENHANCEMENT] Reduce constrainLabels allocations for all metrics. <a href="https://redirect.github.com/prometheus/client_golang/issues/1272">#1272</a></li> <li>[ENHANCEMENT] promhttp: Add process start time header for scrape efficiency. <a href="https://redirect.github.com/prometheus/client_golang/issues/1278">#1278</a></li> <li>[ENHANCEMENT] promlint: Improve metricUnits runtime. <a href="https://redirect.github.com/prometheus/client_golang/issues/1286">#1286</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="`3583c1e1d0`"><code>3583c1e</code></a> Cut v1.16.0 (<a href="https://redirect.github.com/prometheus/client_golang/issues/1292">#1292</a>)</li> <li><a href="`2feda42e44`"><code>2feda42</code></a> Fixed README & CHANGELOG; Added fmt makefile command (+bingo) for easier cont...</li> <li><a href="`5b9cf9c6a8`"><code>5b9cf9c</code></a> Merge pull request <a href="https://redirect.github.com/prometheus/client_golang/issues/1290">#1290</a> from prometheus/fix-nh-docstring-refs</li> <li><a href="`1b19d5f458`"><code>1b19d5f</code></a> Fix docstring references to renamed native histogram fields / functions.</li> <li><a href="`7352ab7f80`"><code>7352ab7</code></a> Moving fully to GH actions. (<a href="https://redirect.github.com/prometheus/client_golang/issues/1288">#1288</a>)</li> <li><a href="`e4ff34d23e`"><code>e4ff34d</code></a> Improve metricUnits runtime (<a href="https://redirect.github.com/prometheus/client_golang/issues/1286">#1286</a>)</li> <li><a href="`781ea28024`"><code>781ea28</code></a> added circleci as gh action YAML (<a href="https://redirect.github.com/prometheus/client_golang/issues/1281">#1281</a>)</li> <li><a href="`a09a1d34cb`"><code>a09a1d3</code></a> Reduce constrainLabels allocations (<a href="https://redirect.github.com/prometheus/client_golang/issues/1272">#1272</a>)</li> <li><a href="`8840afcfc2`"><code>8840afc</code></a> Bump github.com/prometheus/procfs from 0.9.0 to 0.10.1 (<a href="https://redirect.github.com/prometheus/client_golang/issues/1283">#1283</a>)</li> <li><a href="`5e78d5f66b`"><code>5e78d5f</code></a> Merge pull request <a href="https://redirect.github.com/prometheus/client_golang/issues/1279">#1279</a> from prometheus/beorn7/histogram</li> <li>Additional commits viewable in <a href="https://github.com/prometheus/client_golang/compare/v1.15.1...v1.16.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/prometheus/client_golang&package-manager=go_modules&previous-version=1.15.1&new-version=1.16.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Ashwanth	f9fc1df4c0	logfmt: add --strict flag to enable strict parsing, perform nostrict parsing by default (#9626 ) What this PR does / why we need it: Introduces `--strict` flag for logfmt parser to enable strict parsing. With strict parsing enabled, logfmt parser stops scanning the log line and returns early with an error if it encounters any poorly formatted key=value pair. This pr updates the parser to perform non-strict parsing by default where it skips over the invalid tokens. This offers the flexibility to parse semi-structured log lines. Also adds `--keep-empty` flag to retain standalone keys(with empty value) as labels with value set to empty string Special notes for your reviewer: Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [X] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Dylan Guedes	dc5d458c14	Failures logging: avoid logging generic errors (#9796 ) What this PR does / why we need it: Modify our write path to not log generic messages with the `writefailures.Manager`. With generic messages I mean: contextCancel errors and contextDeadlineExceeded errors. Which issue(s) this PR fixes: N/A	2 years ago
Salva Corts	08e505dd50	Return all errors for a failed push request (#9807 ) What this PR does / why we need it: Distributors enforce limits and validate each push payload. before this PR, if a single push request yields multiple errors, only the last error is forwarded to the client. This PR modifies the distributor push handler so we forward all errors from a single push request to the client. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: - I wonder if the use of [MultiError][1] is well-suited for this. [This test case][2] will return 100 errors with the same content. I wonder if we can leverage the MultiError to group errors that have the same content. Printing for example: `1 error like: 'Error parsing labels...'; 100 errors like: 'Max entry size...'`. This would require extra processing but If we do this processing in the Error() method I think it should be ok-ish? - Edit: I ended up implementing this in [`4b0816f`](`4b0816f67f`) Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) [1]: `d4a4728933/pkg/util/errors.go (L32)` [2]: `f544b93c20/pkg/distributor/distributor_test.go (L75)`	2 years ago
Owen Diehl	e2a63e582c	adds tsdb-max-bytes-per-shard limit (#9811 ) Adds the per tenant limit `tsdb-max-bytes-per-shard` which is used in configuring the shard size for tsdb subqueries. This effectively gives control over how big subqueries should be (assuming they're shardable). The default is no different (`600MB`) than the previously hardcoded initial value. This should help us iterate to find optimal shard sizes to improve operations in the long term.	2 years ago

1 2 3 4 5 ...

5286 Commits (5a570cb921545aa5aaff7532b2cad8799f151c33) All Branches Search

5286 Commits (5a570cb921545aa5aaff7532b2cad8799f151c33)

All Branches