apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Ashwanth	470cbbf118	querier: remove query_timeout and engine timeout from querier conf (#10302 ) What this PR does / why we need it: Removes `query_timeout` and `engine:timeout` from querier's config section Both these configs have been deprecated in 2.7.0 release in favor of `query_timeout` in `limits_config` which also allows applying per-tenant overrides at runtime. CLI flag `-querier.engine.timeout` is also removed Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [X] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Sandeep Sukhani	962e03932d	non-indexed labels: support for deletion of logs with non-indexed labels (#10337 ) What this PR does / why we need it: We recently added support for storing and querying non-indexed labels with each log line. This PR wires up the code for supporting deletion using non-indexed labels. Checklist - [x] Tests updated	2 years ago
Christian Haudum	210c937c41	chore(schema-v13): Fix series store schema creation for v13 (#10348 ) The creation of a series store schema failed when using v13 schema version. Special notes for your reviewer: When adding the `v13` to the series store test cases (`pkg/storage/stores/series/series_store_test.go`) they fail. Example error: ``` === RUN TestSeriesStore_LabelValuesForMetricName/foo_/_toms_/_v13_/_store series_store_test.go:700: ========= Running labelValues with metricName foo with labelName toms with schema v13 series_store_test.go:93: Error Trace: /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:93 /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:77 /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:702 Error: Received unexpected error: invalid schema version Test: TestSeriesStore_LabelValuesForMetricName/foo_/_toms_/_v13_/_store === RUN TestSeriesStore_LabelValuesForMetricName/foo_/_toms_/_v13_/_cached_store series_store_test.go:700: ========= Running labelValues with metricName foo with labelName toms with schema v13 series_store_test.go:93: Error Trace: /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:93 /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:77 /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:702 Error: Received unexpected error: invalid schema version Test: TestSeriesStore_LabelValuesForMetricName/foo_/_toms_/_v13_/_cached_store ``` Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Trevor Whitney	45b127cfd6	add `trivy` to Makefile and build image (#10231 ) `trivy` is a command line utility that can scan our images for vulnerabilities. For example, this is how I checked #10217 addressed the CVEs we were hoping it would ``` ❯ trivy i grafana/loki:release-2.8.x-d784431 2023-08-11T12:34:15.272-0600 INFO Vulnerability scanning is enabled 2023-08-11T12:34:15.272-0600 INFO Secret scanning is enabled 2023-08-11T12:34:15.272-0600 INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning 2023-08-11T12:34:15.272-0600 INFO Please see also https://aquasecurity.github.io/trivy/dev/docs/scanner/secret/#recommendation for faster secret detection 2023-08-11T12:34:15.283-0600 INFO Detected OS: alpine 2023-08-11T12:34:15.283-0600 INFO Detecting Alpine vulnerabilities... 2023-08-11T12:34:15.286-0600 INFO Number of language-specific files: 1 2023-08-11T12:34:15.286-0600 INFO Detecting gobinary vulnerabilities... grafana/loki:release-2.8.x-d784431 (alpine 3.18.2) Total: 6 (UNKNOWN: 0, LOW: 0, MEDIUM: 6, HIGH: 0, CRITICAL: 0) ┌────────────┬───────────────┬──────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────────┐ │ Library │ Vulnerability │ Severity │ Installed Version │ Fixed Version │ Title │ ├────────────┼───────────────┼──────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────────┤ │ libcrypto3 │ CVE-2023-2975 │ MEDIUM │ 3.1.1-r1 │ 3.1.1-r2 │ AES-SIV cipher implementation contains a bug that causes it │ │ │ │ │ │ │ to ignore empty... │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-2975 │ │ ├───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ │ CVE-2023-3446 │ │ │ 3.1.1-r3 │ Excessive time spent checking DH keys and parameters │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-3446 │ │ ├───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ │ CVE-2023-3817 │ │ │ 3.1.2-r0 │ Excessive time spent checking DH q parameter value │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-3817 │ ├────────────┼───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ libssl3 │ CVE-2023-2975 │ │ │ 3.1.1-r2 │ AES-SIV cipher implementation contains a bug that causes it │ │ │ │ │ │ │ to ignore empty... │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-2975 │ │ ├───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ │ CVE-2023-3446 │ │ │ 3.1.1-r3 │ Excessive time spent checking DH keys and parameters │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-3446 │ │ ├───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ │ CVE-2023-3817 │ │ │ 3.1.2-r0 │ Excessive time spent checking DH q parameter value │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-3817 │ └────────────┴───────────────┴──────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────────┘ ``` This PR adds that command as `Makefile` target, as well as adding the `trivy` binary to our drone build image so we can add it to our pipelines in the future.	2 years ago
Travis Patterson	12221f43b5	Put unescaped regexes in a raw string literal (#10331 ) [This PR](https://github.com/grafana/loki/pull/10277) fixed an issue where regexes were being escaped multiple times and causing otherwise valid queries to fail our length check. It put the resulting regexes in double quotes which meant that any regexes that _needed_ escaping were now invalid. This PR make is so the unescaped regex is put in a raw string literal so any extra escaping in unnecessary.	2 years ago
Kaviraj Kanagaraj	4bd5e617c3	chore(schema-v13): Fix `periodConfig.Validate` for `v13` schema (#10336 ) What this PR does / why we need it: Fix periodConfigs `Validate()` for new schema `v13`. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Found when testing archiver with latest loki Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Salva Corts	603eb637f6	Add docs for non-indexed labels (#10073 ) What this PR does / why we need it: Adds documentation for the new experimental non-indexed labels feature. --------- Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> Co-authored-by: Vladyslav Diachenko <82767850+vlad-diachenko@users.noreply.github.com>	2 years ago
Karsten Jeschkies	5ba154a6de	Report missing metrics in querytee. (#10304 ) What this PR does / why we need it: Sometimes we want to not just fail a querytee but also report results on the comparison between expected and actual results. That's why querytee is extended with special metrics to give more insights into the differences. Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Karsten Jeschkies	3789f1717c	Set buckets for querier_wait_seconds histogram. (#10334 ) What this PR does / why we need it: We should set buckets for the `querier_wait_seconds` histogram. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Kaviraj Kanagaraj	81f2cb4aea	release-notes: Add back the entry on hedged requests improvements. (#10327 ) What this PR does / why we need it: This PR somehow overwrote the entry. https://github.com/grafana/loki/pull/10286/files probably some rebase issue. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Kaviraj Kanagaraj	bbfb13c3e4	Pin `chunk` and `index` format to `schema` version. (#10213 ) We pin all three `Chunk`, `HeadBlock` and `TSDB` Version to `schema` version in period config. This is the following mapping (after being discussed with @owen-d and @sandeepsukhani ) `v12` (current existing schema) - ChunkFormatV3 (UnorderedHeadBlock) + TSDBv2 `v13` (introducing new schema) - ChunkFormatV4 (UnorderedWithNonIndexedLabelsHeadBlockFmt) + TSDBv3 Note the new schema `v13` supports the latest chunk and index format. NOTES for Reviewer 1. General approach is we removed the idea of `index.LiveFormat`, `chunkenc.DefaultChunkFormat` and `chunkenc.DefaultHeadBlockFmt` and made following two changes. These variables were used before to tie chunk and tsdb formats specific to Loki versions. This PR remove that coupling and pin these formats to `schema` version instead. 1. These variables were replaced with explicit chunk and index formats within those packages (and it's tests) 2. If these variables were used outside it's own packages say by ingester, compactor, etc. Then we extract correct chunk and index versions from the `schema` config. 2. Add two methods to `periodConfig`. (1) `ChunkFormat()` returning chunk and head format tied to schema (2) `TSDBFormat()` returning tsdb format tied to schema. 2. Other ideas I thought of doing but didn't end up doing is make `ChunkFormat` and `IndexFormat` as separate type (rather than `byte` and `int` currently. Similar to `HeadBlockFmt` type). But didnt' do it eventually to keep the PR small and don't want to complicate with lots of changes. 4. Moved couple of test cases from `chunkenc` to `config` package, because the test case was actually testing methods on `schemaconfig` and it was creating cycling dependencies. --------- Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
akhilanarayanan	3303844cb0	Refactored forGivenIngestors to use DoUntilQuorum instead of Do (#9984 ) This changes the forGivenIngestors function in pkg/querier/ingester_querier.go to use `DoUntilQuorum` (from [PR #293](https://github.com/grafana/dskit/pull/293)) instead of `Do`. `DoUntilQuorum` is much more efficient than `Do`. The exact differences between them can be seen [here](https://github.com/grafana/dskit/pull/293). --------- Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Dylan Guedes	becc9bee99	Jsonnet: Add `default` section to runtime jsonnet file (#10330 ) What this PR does / why we need it: Add a `default` section to our runtime jsonnet file. The `default` section was introduced by https://github.com/grafana/loki/pull/10193.	2 years ago
Christian Haudum	e3b25fb36c	Deprecate ruler setting with misleading name (#10322 ) The setting defaults to `0s` and is not supposed to be changed, therefore it should be removed in a future version (e.g. 3.0) of Loki. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Ivana Huckova	5722696703	Update CODEOWNERS to include logs team for grammar file (#10325 ) What this PR does / why we need it: To keep LogQL grammar in sync with https://github.com/grafana/lezer-logql, we would like to add @grafana/observability-logs as a co-codeowner for grammar file `/pkg/logql/syntax/expr.y` to get notification when this file change.	2 years ago
Hervé Nicol	c6a909b0ec	helm: Add rbac.pspAnnotations (#9900 ) What this PR does / why we need it: Allows to define annotations for PSPs. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Co-authored-by: Herve Nicol <12008875+hervenicol@users.noreply.github.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
dependabot[bot]	ca19e8d794	build(deps): bump github.com/maxbrunsfeld/counterfeiter/v6 from 6.3.0 to 6.7.0 in /operator (#10261 )	2 years ago
dependabot[bot]	7c7c5e3511	build(deps): bump golangci/golangci-lint-action from 3.5.0 to 3.7.0 (#10303 )	2 years ago
dependabot[bot]	a3feacea34	build(deps): bump github.com/google/uuid from 1.3.0 to 1.3.1 in /operator (#10305 )	2 years ago
Grot (@grafanabot)	65116c43eb	[Release Notes Appender] Add PR #7754 : index-shipper: add support for multiple stores (#10306 ) Add PR #7754 to release notes for next release --------- Co-authored-by: Ashwanth Goli <iamashwanth@gmail.com>	2 years ago
Bryan Boreham	cf353bb9a0	Series Index Store: fix race in GetSeries (#10310 )	2 years ago
Danny Kopping	9734c4b832	Minor fixes to congestion control mechanism (#10319 ) What this PR does / why we need it: Minor logging / metric improvements to #10140	2 years ago
Kaviraj Kanagaraj	416320dc5f	Revert "Stopped String() from doubly escaping regex characters" (#10318 ) Reverts grafana/loki#10277 This currently breaks and cause panics for query with regex label matcher. Reverting it till we find the fix.	2 years ago
Bryan Boreham	f89a51fde8	Tracing: elide small traces for Stats call (#10308 ) What this PR does / why we need it: At work I see a lot of traces getting data dropped due to being tens of megabytes in size. Looking at what was captured, I see many many repeats of these four spans: <img width="1070" alt="image" src="https://github.com/grafana/loki/assets/8125524/4268e664-6910-49bb-8f68-69b139a5a66b"> Events on the parent trace are cheaper and, for small operations like this, just as useful. Where there was an event line I added a `function` field matching the previous span name. For `storeEntry.Stats()` I didn't add an event line as it doesn't seem to do very much. But please correct me; I'm not hugely familiar with the Loki codebase. Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - NA Tests updated - [x] `CHANGELOG.md` updated - NA If the change is worth mentioning in the release notes, add `add-to-release-notes` label - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - NA For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Ashwanth	b1cd5da607	upgrade doc: suggest disabling transfers (#8648 ) What this PR does / why we need it: Explicitly mention that WAL and `ingester.max-transfer-retries` are [incompatible](https://github.com/grafana/loki/blob/ashwanth/disable-transfers-upgrade-doc/pkg/ingester/ingester.go#L146) in 2.4.0 upgrade notes. Given that WAL is enabled by default, suggest users to unset `ingester.max-transfer-retries` in case they explicitly configured it. Which issue(s) this PR fixes: Fixes #8625 Special notes for your reviewer: Checklist - [X ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>	2 years ago
Chris Shih	05997ae7b9	Fixes typo: removes extra "a" (#10312 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki/issues/10311 Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Bryan Boreham	ecd371db87	indexshipper/compactor: fix two race conditions (#10313 ) What this PR does / why we need it: We must call wg.Add before starting the goroutine. And protect the data in mockCompactorClient. And another fix in shipper/index/compactor. Which issue(s) this PR fixes: Part of #8586 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - NA Tests updated - NA `CHANGELOG.md` updated - NA If the change is worth mentioning in the release notes, add `add-to-release-notes` label - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - NA For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
loanshark	43e542ee64	Storage: Remove `SignatureVersionv2` from the AWS S3 API request authentication. (#10295 ) AWS S3 stopped accepting requests signed using SigV2 in all regions on June 24, 2019, any requests signed using SigV2 made after this time will fail. * https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingAWSSDK.html#UsingAWSSDK-sig2-deprecation * https://aws.amazon.com/blogs/aws/amazon-s3-update-sigv2-deprecation-period-extended-modified/	2 years ago
Owen Diehl	f53498c4aa	allows filter-only matchers in series endpoint (#10269 ) We already allow empty matchers `{}` as a special case in series queries to return all series. This PR also allows specifying only filter-style matchers. This is specifically helpful when a tenant is trying to understand all streams which do _not_ have a corresponding label. ``` $ logcli series '{does_not_exist=""}' --analyze-labels --org-id="fake" 2023/08/16 10:13:32 http://localhost:3100/loki/api/v1/series?end=1692206012889997000&match=%7Bdoes_not_exist%3D%22%22%7D&start=1692202412889997000 Total Streams: 6 Unique Labels: 2 ``` Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Anthony Goddard	509896137d	[docs] replace use of "examplifies" (#10296 ) minor spelling correction What this PR does / why we need it: Trivial patch for grammar, updated sentence to match sentence structure used elsewhere in the docs Checklist - [ x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required)	2 years ago
William Dumont	a1c1152b79	Promtail: Add additional fields in cloudflare config (#10301 ) What this PR does / why we need it: In this PR the cloudflare config is enhanced by adding a custom fields type and by having a new property "additional_types" to give the customer the ability to specify the fields that he wants. This functionality has been added in the grafana agent and therefore should also be added in promtail. Which issue(s) this PR fixes: Fixes https://github.com/grafana/agent/issues/4860 Special notes for your reviewer: Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [X] Tests updated - [x] `CHANGELOG.md` updated - [x] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md`	2 years ago
Arve Knudsen	a60e0167a8	Upgrade to latest dskit main (#10300 ) What this PR does / why we need it: Upgrade to latest dskit main branch, which mainly has changes to its `log` package, which requires corresponding fixing up in Loki.	2 years ago
Karsten Jeschkies	b1a948e28b	Record waiting time for queriers to receive requests. (#10253 ) What this PR does / why we need it: We want to investigate whether work stealing among queriers would be useful. So we are recording the wait time of queriers for new requests in their queue. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Danny Kopping	a30629e36e	Azure Blob Storage is no longer experimental (#10299 ) What this PR does / why we need it: Azure Blob Storage is being used in production by many organisations, including Grafana Labs. It should no longer be marked experimental. Which issue(s) this PR fixes: Fixes #10298 Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
akhilanarayanan	4013c1f8b5	Stopped String() from doubly escaping regex characters (#10277 ) What this PR does / why we need it: When queries have regex, characters that needed escaping were escaped twice. Now they're only singly escaped. This is good because it reduces the character count so users can submit queries closer to the 5120 byte limit. Which issue(s) this PR fixes: Sort of addresses #10153 Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) Co-authored-by: Akhila Narayanan <akhilanarayanan@Akhilas-MacBook-Air.local>	2 years ago
willcramer	7f48efb60a	Update labels.md (#10124 ) What this PR does / why we need it: - Reworded some phrasing to achieve a more formal tone - Corrected some grammatical errors - Modified sentence structure for improved readability - Removed extra blank lines and made a pass at ensuring uniformity through the document	2 years ago
Dylan Guedes	9bfe1d81d4	Add zone-aware ingesters to Index panel. (#10291 ) What this PR does / why we need it: Modify the Index panel on `Loki/Writes` to account for any ingesters, to avoid ignoring zone-aware ingesters.	2 years ago
Danny Kopping	beed298549	Dynamic client-side throttling to avoid object storage rate-limits (GCS only) (#10140 ) What this PR does / why we need it: Across the various cloud providers' object storage services, there are different rate-limits implemented. Rate-limits can be imposed under multiple conditions, such as server-side scale up (ramping up from low volume to high, "local" limit), reaching some defined upper limit ("absolute" limit), etc. We cannot know apriori when these rate-limits will be imposed, so we can't set up a client-side limiter to only allow a certain number of requests through per second. Additionally, that would require global coordination between queriers - which is difficult. With the above constraints, I have instead taken inspiration from TCP's [congestion control algorithms](https://en.wikipedia.org/wiki/TCP_congestion_control). This PR implements [AIMD](https://en.wikipedia.org/wiki/Additive_increase/multiplicative_decrease) (Additive Increase, Multiplicative Decrease), which is used in the congestion _avoidance_ phase of congestion control. The default window size (object store requests per second) is 2000; in other words, we skip the "slow start" phase. The controller uses the Go [`rate.Limiter`](https://pkg.go.dev/golang.org/x/time/rate), which implements the token-bucket algorithm. To put it simply: - every successful request widens the window (per second client rate-limit) - every rate-limited response reduces the window size by a backoff factor (0.5 by default, so it will halve) - when the limit has been reached, the querier will be delayed from making further requests until tokens are available	2 years ago
Mohamed-Amine Bouqsimi	176e9b7292	Add filter on rules' labels to API query (#9128 )	2 years ago
Jan-Otto Kröpke	def76e0897	[helm] Use the correct name of the service inside the ingress. (#10290 ) What this PR does / why we need it: Use the correct name of the service inside the ingress. The service names could be different, if release name is not loki. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Jan-Otto Kröpke	409d6bed9d	[helm] Make table_manager configuration toggle. (#10288 ) What this PR does / why we need it: table_manager is deprecated. It would be nice the add the possibility to remove the key from the config. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>	2 years ago
Paul Rogers	391ffcec69	Add compat libs to Loki Canary BoringCrypto Docker image (#10287 ) What this PR does / why we need it: Add compatibility libs to BoringCrypto Loki Canary image. As it is dynamically linked, the runtime libs need to be added so the executable can run	2 years ago
Grot (@grafanabot)	f951f083ca	[Release Notes Appender] Add PR #8646 : Optimize .+ regex line filter (#10286 ) Add PR #8646 to release notes for next release --------- Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
J Stickler	d0545bff2d	[docs] Create top level Send data section, part 2 (#10247 ) Part of the database information architecture Epic # 8710 Which issue(s) this PR fixes: Second half of work for issue # 8741 that was started in PR #10192 When closed, fixes #8741 Move the following files under Send data: ./sources/clients/promtail/_index.md ./sources/clients/promtail/configuration.md ./sources/clients/promtail/gcplog-cloud.md ./sources/clients/promtail/installation.md ./sources/clients/promtail/logrotation/_index.md ./sources/clients/promtail/pipelines.md ./sources/clients/promtail/scraping.md ./sources/clients/promtail/stages/_index.md ./sources/clients/promtail/stages/cri.md ./sources/clients/promtail/stages/decolorize.md ./sources/clients/promtail/stages/docker.md ./sources/clients/promtail/stages/drop.md ./sources/clients/promtail/stages/json.md ./sources/clients/promtail/stages/labelallow.md ./sources/clients/promtail/stages/labeldrop.md ./sources/clients/promtail/stages/labels.md ./sources/clients/promtail/stages/limit.md ./sources/clients/promtail/stages/logfmt.md ./sources/clients/promtail/stages/match.md ./sources/clients/promtail/stages/metrics.md ./sources/clients/promtail/stages/multiline.md ./sources/clients/promtail/stages/output.md ./sources/clients/promtail/stages/pack.md ./sources/clients/promtail/stages/regex.md ./sources/clients/promtail/stages/replace.md ./sources/clients/promtail/stages/static_labels.md ./sources/clients/promtail/stages/template.md ./sources/clients/promtail/stages/tenant.md ./sources/clients/promtail/stages/timestamp.md ./sources/clients/promtail/troubleshooting/_index.md This PR also - Revises the Clients landing page to clarify supported clients. - Updates the metadata (descriptions, weights) - Adds aliases to redirect from the old URLs. - Updates cross-references broken by the move/renaming. - A few other small fixes (headings, typos, etc.) Special notes for your reviewer: Please review the updates to the Clients landing page (now called Send Data) as I've made some extensive edits to try to clarify recommended/supported clients. The file is docs/sources/send-data/_index.md --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
J Stickler	ec35db458b	Update broken links (#10276 )	2 years ago
Danny Kopping	26c7af7923	Add PR #10281 to release notes for next release (#10283 ) Co-authored-by: grafanabot <bot@grafana.com>	2 years ago
Danny Kopping	a18ca92375	Track effectiveness of hedged requests (#10281 ) What this PR does / why we need it: We currently have request hedging implemented in many object store clients. Right now we track how many hedged requests we make, and how many are rate-limited, but nothing actually tells us _how effective_ the hedged requests are. In other words, we don't know how many hedged requests were issued and _won_ (completed before the original).	2 years ago
Paul Rogers	de471fdb60	loki-canary boringcrypto version (#10246 ) What this PR does / why we need it: This creates a 'BoringCrypto' version of the Loki canary code, and publishes it to a loki-canary-boringcrypto repo Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Elliot Dobson	6a8225d533	lambda-promtail: s3: update log parsing to support NLBs (#7194 ) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: Fixes the filename and timestamp regex for AWS Network Load Balancer (NLB) logs and adds logic to make NLB log timestamps RFC3339 compatible. Also adds a test to check the parsed timestamp is as expected. Which issue(s) this PR fixes: Fixes #6455 Special notes for your reviewer: <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [x] Documentation added - [x] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>	2 years ago
Ward Bekker	7733be0658	making clearer that TSDB is the new recommended index, and make expli… (#9246 ) What this PR does / why we need it: making clearer that TSDB is the new recommended index, and make explicit that non TSDB and BoltDB shipper are deprecated and not recommended Fixes #9105 Special notes for your reviewer: This needs to be changed in more places, but this is a start as it concerns the main storage docs Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Travis Patterson <masslessparticle@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago

... 5 6 7 8 9 ...

5806 Commits (8628b15624e0c1f5cd730cc9ee585416926c09c3) All Branches Search

5806 Commits (8628b15624e0c1f5cd730cc9ee585416926c09c3)

All Branches