apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
李国忠	98936437a9	[opt] s3: add s3 client http timeout for GetObject or PutObject (#8951 ) What this PR does / why we need it: add s3 client http timeout for GetObject or PutObject, why？ The flush queue has been increasing. This is a difficult problem. We have been investigating this problem for half a year. When the querier has a large query, the load on the s3 server is too high and the number of connections is full. It will cause the flush queue of the ingester to increase continuously and cannot be reduced. When this problem occurs, after we restart the s3 server, the flush queue will quickly become 0. We checked with our s3 (object storage compatible with the s3 protocol) team and found that it was because we used the s3 v1 sdk. The v1 sdk did not configure timeout by default, and it would wait indefinitely without configuration. The s3 v2 sdk defaults to a timeout of 30s, which only causes write failures and does not cause loki to get stuck. Which issue(s) this PR fixes: Fixes #<issue number> At present, as long as there are large logql queries such as 30 days, I must restart the s3 server, otherwise our ingester queue will continue to increase. We hope that we can break the stuck go routine after the 5m timeout occurs. Special notes for your reviewer: ingester flush queue length up 🔝 ![image](https://user-images.githubusercontent.com/9583245/228786401-cf07dc32-dcc0-428f-9558-561b588ea2c4.png) big query, 30day logql or something happen ![image](https://user-images.githubusercontent.com/9583245/228789991-57185bc3-e628-45a5-82df-e4682590b786.png) pprof goroutine list profile snapshot ![image](https://user-images.githubusercontent.com/9583245/228787732-6170b8ec-db86-4ca7-8ea0-a7f19b7d6141.png) There are other alternatives: ``` ingester: flush_op_timeout: 10m ``` This `flush_op_timeout` configuration is more about the timeout of loki, not the timeout of s3 client. We will also have various s3 operations such as delete and getObject. We should add an independent timeout for s3, just like the cassandra client has a separate The timeout period can be configured. And the parameter `flush_op_timeout` in the early version of loki represents the timeout of writing `a batch of chunks `to s3, not a timeout of s3. Now it is indeed changed to write to s3 one by one, but it is not ruled out that in the future, it will be changed back to write a batch of chunks to s3 sequentially. In this way, `flush_op_timeout: 5m` is far from enough to write a batch of chunks to s3. ``` cassandra: timeout: 5m ``` Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Nils	afee8bcabf	Re-add helm configuration for Azure OIDC federation (#9168 ) What this PR does / why we need it: This re-adds the configuration that was removed in https://github.com/grafana/loki/pull/8515 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Owen Diehl	ec516facaf	removes 20 user test from compaction; seems redundant and hits timeouts (#9201 ) just a little cleanup to make tests run faster -- the 20 user test doesn't seem to test any additional surface area and takes a long time.	2 years ago
Dylan Guedes	46f044fdb7	Loki: Fix wrong association of PSRL when sharding is enabled (#9176 ) Obs: PSRL stands for `per-stream rate limit` What this PR does / why we need it: - Fixes the scenario where all entries errors are accounted as PSRL if sharding is enabled - Fixes invalid/rejected entries being accounted as candidates to be inserted	2 years ago
irizzant	7f98b09148	Loki microservices tanka: add some ingester replicas (#9160 ) What this PR does / why we need it: This PR makes Ingester pods available in multi zone mode which, based on the previous defaults, were not created. Which issue(s) this PR fixes: Fixes #9139	2 years ago
Mohamed-Amine Bouqsimi	f73e9b2993	operator: Add PodDisruptionBudgets to the query path (#9188 )	2 years ago
Michel Hollands	abd6131bba	Update prepare shutdown (#9175 ) What this PR does / why we need it: This updates the PrepareShutdown method so it supports GET and DELETE methods as well. This makes it similar to Mimir: https://github.com/grafana/mimir/pull/4718. The status is now stored in a local file. A new config setting had to be added for this file as there is no obvious place to store it. Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [X] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Michel Hollands <michel.hollands@grafana.com> Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	2 years ago
Dylan Guedes	8580b8f8ad	Distributor: Reuse `time.Now()` for better performance (#9192 ) What this PR does / why we need it: Modifies `AggregateByShard` to reuse `time.Now()` to improve performance.	2 years ago
Salva Corts	56bbb43748	Logcli - Better logging when object cannot get loaded from object store (#9194 ) What this PR does / why we need it: This PR improves the error messaging for Logcli when an object cannot be downloaded from the store by printing the name of the object along with the error. Which issue(s) this PR fixes: Internal support escalation Special notes for your reviewer: There are other places where GetObject is called: - `indexStorageClient.GetFile` - `indexStorageClient.GetUserFile` Looks like both of them are used only by the compactor and the table manager. IIUC, these functions are not used by LogCLI. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Danny Kopping	52655706b8	Prevent redis client from incorrectly choosing cluster mode with local address (#9185 )	2 years ago
Salva Corts	422560b6b1	Flag to disable index stats cache (#9177 ) What this PR does / why we need it: At https://github.com/grafana/loki/pull/8972 we started caching all index stats requests. If the results cache gets overloaded, it can quickly take down the rest of the loki cell due to all the increased work. This PR adds a new flag so we can easily disable caching index stats requests. Which issue(s) this PR fixes: This PR is a follow up for https://github.com/grafana/loki/pull/8972 Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Dylan Guedes	9c2e11d186	Ingester: Reuse allocations on `GetStreamRates` (#9180 ) What this PR does / why we need it: - Reuse rates mapping returned by the calculator to reduce the number of allocations	2 years ago
Dylan Guedes	bdfc0f92a0	Loki: Add debug event to ingester `GetStreamRates` (#9157 ) What this PR does / why we need it: - Add a new span event to our ingesters `GetStreamRates` function. - Add how many streams were updated on a `updateRates` call.	2 years ago
Owen Diehl	dbbadafca2	Tsdb/v3 (#9070 ) brief: adds page support for chunks within a series. This lets us do a few optimizations, most notably skipping chunk ranges that don't overlap with our query bounds. It also allows us to use aggregated stats for pages when computing `Stats` calls that completely overlap all chunks in a page. teaser: ``` pkg: github.com/grafana/loki/pkg/storage/stores/tsdb/index BenchmarkChunkStats/version_2/2_chunks-10 10121240 109.4 ns/op 24 B/op 1 allocs/op BenchmarkChunkStats/version_3/2_chunks-10 27591069 43.51 ns/op 0 B/op 0 allocs/op BenchmarkChunkStats/version_2/4_chunks-10 9410245 128.7 ns/op 24 B/op 1 allocs/op BenchmarkChunkStats/version_3/4_chunks-10 21808070 54.44 ns/op 0 B/op 0 allocs/op BenchmarkChunkStats/version_2/10_chunks-10 6048235 201.3 ns/op 24 B/op 1 allocs/op BenchmarkChunkStats/version_3/10_chunks-10 9517605 125.1 ns/op 0 B/op 0 allocs/op BenchmarkChunkStats/version_2/100_chunks-10 1000000 1081 ns/op 24 B/op 1 allocs/op BenchmarkChunkStats/version_3/100_chunks-10 1669972 715.4 ns/op 528 B/op 3 allocs/op BenchmarkChunkStats/version_2/1000_chunks-10 118125 10165 ns/op 24 B/op 1 allocs/op BenchmarkChunkStats/version_3/1000_chunks-10 570576 2125 ns/op 4816 B/op 6 allocs/op BenchmarkChunkStats/version_2/10000_chunks-10 10000 117447 ns/op 123014 B/op 3 allocs/op BenchmarkChunkStats/version_3/10000_chunks-10 74524 16225 ns/op 48601 B/op 9 allocs/op BenchmarkChunkStats/version_2/100000_chunks-10 842 1240380 ns/op 3211679 B/op 13 allocs/op BenchmarkChunkStats/version_3/100000_chunks-10 8494 141169 ns/op 516530 B/op 13 allocs/op ``` ``` pkg: github.com/grafana/loki/pkg/storage/stores/tsdb/index BenchmarkReadChunks/version_2/2_chunks-10 13673050 80.52 ns/op 172 B/op 0 allocs/op BenchmarkReadChunks/version_3/2_chunks-10 25713412 64.06 ns/op 201 B/op 0 allocs/op BenchmarkReadChunks/version_2/4_chunks-10 12302040 96.56 ns/op 373 B/op 0 allocs/op BenchmarkReadChunks/version_3/4_chunks-10 20512030 84.93 ns/op 346 B/op 0 allocs/op BenchmarkReadChunks/version_2/10_chunks-10 6974947 168.7 ns/op 490 B/op 0 allocs/op BenchmarkReadChunks/version_3/10_chunks-10 7436360 161.0 ns/op 632 B/op 0 allocs/op BenchmarkReadChunks/version_2/50_chunks-10 2038724 599.3 ns/op 2034 B/op 0 allocs/op BenchmarkReadChunks/version_3/50_chunks-10 2251822 619.8 ns/op 1926 B/op 0 allocs/op BenchmarkReadChunks/version_2/100_chunks-10 946430 1092 ns/op 4132 B/op 0 allocs/op BenchmarkReadChunks/version_3/100_chunks-10 1467297 1000 ns/op 3308 B/op 1 allocs/op BenchmarkReadChunks/version_2/150_chunks-10 674575 1721 ns/op 5767 B/op 0 allocs/op BenchmarkReadChunks/version_3/150_chunks-10 1000000 1373 ns/op 6171 B/op 1 allocs/op BenchmarkReadChunks/version_2/1000_chunks-10 109153 10554 ns/op 33063 B/op 0 allocs/op BenchmarkReadChunks/version_3/1000_chunks-10 158086 6963 ns/op 32829 B/op 1 allocs/op BenchmarkReadChunks/version_2/10000_chunks-10 9043 114121 ns/op 345258 B/op 0 allocs/op BenchmarkReadChunks/version_3/10000_chunks-10 22083 79896 ns/op 435493 B/op 1 allocs/op BenchmarkReadChunks/version_2/100000_chunks-10 1039 1103621 ns/op 3479873 B/op 0 allocs/op BenchmarkReadChunks/version_3/100000_chunks-10 2101 1155419 ns/op 4680266 B/op 1 allocs/op ``` --------- Signed-off-by: Owen Diehl <ow.diehl@gmail.com>	2 years ago
Mohamed-Amine Bouqsimi	3d017a4b25	operator: Add a PodDisruptionBudget to lokistack-gateway (#9162 )	2 years ago
Ramon Cuñat	4c4f3adbf1	logql: handle negative offset (#7545 ) What this PR does / why we need it: Handles negative offset in logql correctly Which issue(s) this PR fixes: Fixes #7476 Special notes for your reviewer: I'm not really sure that I've implemented the best solution as it maybe tries to parse duration in many other cases. Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
ndrpnt	afe8f91d0c	logcli: Allow negative filters when omitting stream selector with --stdin (#8566 ) Which issue(s) this PR fixes: Fixes #8565 Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] `CHANGELOG.md` updated Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
Salva Corts	fd16425062	Cache index stats requests (#8972 ) What this PR does / why we need it: As described in https://github.com/grafana/loki/issues/8973, we are substantially increasing the load of index stat requests we sent to our index gateways. Many of these requests should be easily re-used by caching them. This PR adds caching for index stat requests by reusing the results cache. Here's a demo ([source][1]): ![image](https://user-images.githubusercontent.com/8354290/229104609-4dd26f0a-9260-4f21-85ef-ac4a86ebba7a.png) Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki/issues/8973 Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` [1]: https://ops.grafana-ops.net/d/afcaef21-e5ad-49e7-ab06-42a9d7d915eb/index-stats?orgId=1&var-datasource=dev-cortex&var-cluster=dev-eu-west-2&var-namespace=loki-dev-009&var-loki_datasource=Grafana%20Logging&from=1680259907288&to=1680260431814&var-operation=All --------- Co-authored-by: Owen Diehl <ow.diehl@gmail.com>	2 years ago
J Stickler	a99c73dd97	Update weights for Helm Charts topics (#9169 )	2 years ago
Karsten Jeschkies	cbc9c60b59	Give config snippets for automatic stream sharding. (#9098 )	2 years ago
Julien Duchesne	6f83c01c14	Fix pipeline skipping in forks (#9165 )	2 years ago
Trevor Whitney	0f4a7f4d92	[helm] Bump GEL version, default to 3 scalable targets (#9170 ) What this PR does / why we need it: This PR bumps the GEL version to match the Loki version that was added in version 5 of the helm chart. With these new versions we can now default to 3 targets in scalable mode `read`, `write`, and `backend`. This PR also fixes 2 bugs when running in scalable mode: * the gateway should forward requests to the admin api to the `backend` target when running 3 targets * the index gateway should default to using `ring` mode, which will allow the queriers in the new `read` target to find the index gateway address for their index gateway clients via the ring.	2 years ago
Owen Diehl	dc9ca8e19a	Tools/index analyzer (#9074 ) Adds a tool that allows downloading and querying statistics across TSDB indices. Example output: ``` analyzed 1046302 series and 7607495 chunks for an average of 7.270841 chunks per series. max chunks/series was 45695. number of series with over 1k chunks: 15 ``` --------- Signed-off-by: Owen Diehl <ow.diehl@gmail.com>	2 years ago
Trevor Whitney	76c6681feb	Add release notes appender action (#9063 ) What this PR does / why we need it: This PR aims to remove the manual process required to create release notes during a release. It will allow contributors to add the label `add-to-release-notes` to any PR. When that PR is merged, this action will create another PR appending the original PR's # and title to the release notes for the next release. This second PR will give the author an opportunity to add a description to their addition, as well as give maintainers an opportunity to discuss it's relevance in the release notes.	2 years ago
Trevor Whitney	068a995134	upgrade go to 1.20 in nix flake (#9024 ) What this PR does / why we need it: Updates `flake.lock` to grab the latest `nixpkgs-unstable` in order to upgrade go version to `1.20`.	2 years ago
Trevor Whitney	b7057f5128	Fix comment in helm values.yaml (#9088 ) What this PR does / why we need it: Fix comment in the `values.yaml` and re-generate the reference docs.	2 years ago
Julien Duchesne	15714b11c2	Skip pipelines that require secrets in forks (#9161 )	2 years ago
Ashwanth	4544f7b738	expiration: do not drop index if period is a zero value (#9156 ) What this PR does / why we need it: `DropFromIndex` should be return false when `retention_period` is set to a zero value. If we take chunks that overlap period boundary and are indexed in two tables, we drop these from the table on the left side of the period boundary even if they have not expired - https://github.com/grafana/loki/blob/ashwanth/drop-from-index-zero-value/pkg/storage/stores/indexshipper/compactor/retention/retention.go#L218 Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Tests updated - [x] `CHANGELOG.md` updated --------- Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>	2 years ago
Callum Styan	220cbdd4f1	Revert "Use centralized make-docs script from Writers' Toolkit (#9126 )" (#9146 ) This reverts commit `df1b34898b`. Sorry @jdbaldry but something in your PR made the helm-docs check fail, and only fail in CI, I tried a few things to figure out what was happening locally but the same make target always passed locally. cc @trevorwhitney	2 years ago
Alex Close	1ff4ad75d3	Updated Scalability benefit to call out decoupled read/write paths an… (#9032 ) What this PR does / why we need it: Updated Scalability benefit to call out decoupled read/write paths and that benefit - this is a huge competitive edge over tools like Splunk and Elastic and it makes sense to explicitly call it out under our benefits	2 years ago
Alfredo	b26ff7df45	Update replication factor impact to read path (#9061 ) What this PR does / why we need it: Update a note to callout that replication factor also impacts read path behavior. Which issue(s) this PR fixes: Fixes #<issue number> N/A Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) --------- Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Labesse Kévin	0215a17148	gcplog: improve formatter (#9044 ) What this PR does / why we need it: Add two improvement to the target `gcplog` * capability to ignore the `textPayload` from the log line -> don't trunk important metadata * add new source labels (severity and root labels of log entry) -> more relabel_config possibilities Special notes for your reviewer: I'm not sure about the naming of the option `useFullLine`, feel free to suggest any name, but I guess this feature must be disable by default for compatibility? Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [X] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Kevin Labesse <kevin@labesse.me> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Alfredo	8f6d31c34e	Docs: update template function (#9037 ) What this PR does / why we need it: - Add `eq` function - Add example for nested if and `AND`/`OR` logic Which issue(s) this PR fixes: Fixes #<issue number> N/A Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
dependabot[bot]	691b6aaae9	Bump anchore/sbom-action from 0.12.0 to 0.14.1 (#9083 ) Bumps [anchore/sbom-action](https://github.com/anchore/sbom-action) from 0.12.0 to 0.14.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/anchore/sbom-action/releases">anchore/sbom-action's releases</a>.</em></p> <blockquote> <h2>v0.14.1</h2> <h2>Changes in v0.14.1</h2> <ul> <li>chore(deps): update Syft to v0.76.0 (<a href="https://redirect.github.com/anchore/sbom-action/issues/403">#403</a>) [<a href="https://github.com/anchore-actions-token-generator">anchore-actions-token-generator</a>]</li> </ul> <h2>v0.13.4</h2> <h2>Changes in v0.13.4</h2> <ul> <li>Added support of workflow artifact's retention policy (<a href="https://redirect.github.com/anchore/sbom-action/issues/398">#398</a>) [<a href="https://github.com/ViacheslavKudinov">ViacheslavKudinov</a>]</li> <li>Use the correct SHA for dependency snapshots from pull requests (<a href="https://redirect.github.com/anchore/sbom-action/issues/401">#401</a>) [<a href="https://github.com/juxtin">juxtin</a>]</li> <li>Update Syft to v0.75.0 (<a href="https://redirect.github.com/anchore/sbom-action/issues/394">#394</a>) [<a href="https://github.com/anchore-actions-token-generator">anchore-actions-token-generator</a>]</li> </ul> <h2>v0.13.3</h2> <h2>Changes in v0.13.3</h2> <ul> <li>Update Syft to v0.68.1 (<a href="https://redirect.github.com/anchore/sbom-action/issues/391">#391</a>) [<a href="https://github.com/anchore-actions-token-generator">anchore-actions-token-generator</a>]</li> </ul> <h2>v0.13.2</h2> <h2>Changes in v0.13.2</h2> <ul> <li>Update Syft to v0.68.0 (<a href="https://redirect.github.com/anchore/sbom-action/issues/387">#387</a>) [<a href="https://github.com/anchore-actions-token-generator">anchore-actions-token-generator</a>]</li> </ul> <h2>v0.13.1</h2> <h2>Changes in v0.13.1</h2> <ul> <li>File input not being passed properly to Syft invocation (<a href="https://redirect.github.com/anchore/sbom-action/issues/385">#385</a>) [<a href="https://github.com/kzantow">kzantow</a>]</li> <li>Update Syft to v0.60.3 (<a href="https://redirect.github.com/anchore/sbom-action/issues/386">#386</a>) [<a href="https://github.com/anchore-actions-token-generator">anchore-actions-token-generator</a>]</li> </ul> <h2>v0.13.0</h2> <h2>Changes in v0.13.0</h2> <ul> <li>Allow type "file:..." to enable creation of SBOMs from tar and other package formats (<a href="https://redirect.github.com/anchore/sbom-action/issues/357">#357</a>) [<a href="https://github.com/malt3">malt3</a>]</li> <li>Update Syft to v0.59.0 (<a href="https://redirect.github.com/anchore/sbom-action/issues/371">#371</a>) [<a href="https://github.com/anchore-actions-token-generator">anchore-actions-token-generator</a>]</li> <li>Update dependencies and node version (<a href="https://redirect.github.com/anchore/sbom-action/issues/372">#372</a>) [<a href="https://github.com/kzantow">kzantow</a>]</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="`422cb34a0f`"><code>422cb34</code></a> chore(deps): update Syft to v0.76.0 (<a href="https://redirect.github.com/anchore/sbom-action/issues/403">#403</a>)</li> <li><a href="`785eb5c59a`"><code>785eb5c</code></a> chore: tweak some workflow text (<a href="https://redirect.github.com/anchore/sbom-action/issues/402">#402</a>)</li> <li><a href="`448520c4f1`"><code>448520c</code></a> [FEATURE] Added support of workflow artifact's retention policy (<a href="https://redirect.github.com/anchore/sbom-action/issues/398">#398</a>)</li> <li><a href="`8a5a132123`"><code>8a5a132</code></a> Use the correct SHA for pull request snapshots (<a href="https://redirect.github.com/anchore/sbom-action/issues/401">#401</a>)</li> <li><a href="`98774eae87`"><code>98774ea</code></a> chore: Update Syft to v0.75.0 (<a href="https://redirect.github.com/anchore/sbom-action/issues/394">#394</a>)</li> <li><a href="`f65c4834e1`"><code>f65c483</code></a> Update Syft to v0.69.1 (<a href="https://redirect.github.com/anchore/sbom-action/issues/393">#393</a>)</li> <li><a href="`71b5f8c8f8`"><code>71b5f8c</code></a> Update Syft to v0.69.0 (<a href="https://redirect.github.com/anchore/sbom-action/issues/392">#392</a>)</li> <li><a href="`07978da4bd`"><code>07978da</code></a> Update Syft to v0.68.1 (<a href="https://redirect.github.com/anchore/sbom-action/issues/391">#391</a>)</li> <li><a href="`54e36e45f3`"><code>54e36e4</code></a> feat: update Syft to v0.68.0 (<a href="https://redirect.github.com/anchore/sbom-action/issues/387">#387</a>)</li> <li><a href="`06e109483e`"><code>06e1094</code></a> fix: file input not being passed properly to syft invocation (<a href="https://redirect.github.com/anchore/sbom-action/issues/385">#385</a>)</li> <li>Additional commits viewable in <a href="https://github.com/anchore/sbom-action/compare/v0.12.0...v0.14.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=anchore/sbom-action&package-manager=github_actions&previous-version=0.12.0&new-version=0.14.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
logan	556af7609a	Fixing spelling errors and incorrect units (#9082 ) What this PR does / why we need it: mild grammar changes Which issue(s) this PR fixes: None Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] ~~Tests updated~~ - [ ] ~~`CHANGELOG.md` updated~~ - [ ] ~~Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`~~	2 years ago
dependabot[bot]	9dd2aac9e4	Bump actions/checkout from 2 to 3 (#9084 ) Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <ul> <li>Updated to the node16 runtime by default <ul> <li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0">Actions Runner</a> version of v2.285.0 to run, which is by default available in GHES 3.4 or later.</li> </ul> </li> </ul> <h2>v2.7.0</h2> <h2>What's Changed</h2> <ul> <li>Add new public key for known_hosts (<a href="https://redirect.github.com/actions/checkout/issues/1237">#1237</a>) by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1238">actions/checkout#1238</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2.6.0...v2.7.0">https://github.com/actions/checkout/compare/v2.6.0...v2.7.0</a></p> <h2>v2.6.0</h2> <h2>What's Changed</h2> <ul> <li>Add backports to v2 branch by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1040">actions/checkout#1040</a> <ul> <li>Includes backports from the following changes: <a href="https://redirect.github.com/actions/checkout/pull/964">actions/checkout#964</a>, <a href="https://redirect.github.com/actions/checkout/pull/1002">actions/checkout#1002</a>, <a href="https://redirect.github.com/actions/checkout/pull/1029">actions/checkout#1029</a></li> <li>Upgraded the licensed version to match what is used in v3.</li> </ul> </li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2.5.0...v2.6.0">https://github.com/actions/checkout/compare/v2.5.0...v2.6.0</a></p> <h2>v2.5.0</h2> <h2>What's Changed</h2> <ul> <li>Update <code>@actions/core</code> to 1.10.0 by <a href="https://github.com/rentziass"><code>@rentziass</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/962">actions/checkout#962</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2...v2.5.0">https://github.com/actions/checkout/compare/v2...v2.5.0</a></p> <h2>v2.4.2</h2> <h2>What's Changed</h2> <ul> <li>Add set-safe-directory input to allow customers to take control. (<a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>) by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/776">actions/checkout#776</a></li> <li>Prepare changelog for v2.4.2. by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/778">actions/checkout#778</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2...v2.4.2">https://github.com/actions/checkout/compare/v2...v2.4.2</a></p> <h2>v2.4.1</h2> <ul> <li>Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></li> </ul> <h2>v2.4.0</h2> <ul> <li>Convert SSH URLs like <code>org-<ORG_ID>@github.com:</code> to <code>https://github.com/</code> - <a href="https://redirect.github.com/actions/checkout/pull/621">pr</a></li> </ul> <h2>v2.3.5</h2> <p>Update dependencies</p> <h2>v2.3.4</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/379">Add missing <code>await</code>s</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/360">Swap to Environment Files</a></li> </ul> <h2>v2.3.3</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/345">Remove Unneeded commit information from build logs</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/326">Add Licensed to verify third party dependencies</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>v3.4.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@actions/io</code></a></li> </ul> <h2>v3.3.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li> <li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li> </ul> <h2>v3.2.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@actions/io</code> to 1.1.2</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li> </ul> <h2>v3.1.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@actions/core</code> <code>saveState</code> and <code>getState</code></a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li> </ul> <h2>v3.0.2</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/770">Add input <code>set-safe-directory</code></a></li> </ul> <h2>v3.0.1</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/762">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/744">Bumped various npm package versions</a></li> </ul> <h2>v3.0.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/689">Update to node 16</a></li> </ul> <h2>v2.3.1</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/284">Fix default branch resolution for .wiki and when using SSH</a></li> </ul> <h2>v2.3.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/278">Fallback to the default branch</a></li> </ul> <h2>v2.2.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/258">Fetch all history for all tags and branches when fetch-depth=0</a></li> </ul> <h2>v2.1.1</h2> <ul> <li>Changes to support GHES (<a href="https://redirect.github.com/actions/checkout/pull/236">here</a> and <a href="https://redirect.github.com/actions/checkout/pull/248">here</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="`8f4b7f8486`"><code>8f4b7f8</code></a> Add new public key for known_hosts (<a href="https://redirect.github.com/actions/checkout/issues/1237">#1237</a>)</li> <li><a href="`cd6a9fd493`"><code>cd6a9fd</code></a> Update update-main-version.yml</li> <li><a href="`24cb908017`"><code>24cb908</code></a> Bump <code>@actions/io</code> to v1.1.3 (<a href="https://redirect.github.com/actions/checkout/issues/1225">#1225</a>)</li> <li><a href="`27135e314d`"><code>27135e3</code></a> Upgrade dependencies (<a href="https://redirect.github.com/actions/checkout/issues/1210">#1210</a>)</li> <li><a href="`7b187184d1`"><code>7b18718</code></a> Upgrade codeql actions to v2 (<a href="https://redirect.github.com/actions/checkout/issues/1209">#1209</a>)</li> <li><a href="`ac59398561`"><code>ac59398</code></a> Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>) (<a href="https://redirect.github.com/actions/checkout/issues/1057">#1057</a>)</li> <li><a href="`3ba5ee6fac`"><code>3ba5ee6</code></a> Add in explicit reference to private checkout options (<a href="https://redirect.github.com/actions/checkout/issues/1050">#1050</a>)</li> <li><a href="`8856415920`"><code>8856415</code></a> Implement branch list using callbacks from exec function (<a href="https://redirect.github.com/actions/checkout/issues/1045">#1045</a>)</li> <li><a href="`755da8c3cf`"><code>755da8c</code></a> 3.2.0 (<a href="https://redirect.github.com/actions/checkout/issues/1039">#1039</a>)</li> <li><a href="`26d48e8ea1`"><code>26d48e8</code></a> Update <code>@actions/io</code> to 1.1.2 (<a href="https://redirect.github.com/actions/checkout/issues/1029">#1029</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/checkout/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
nikuljain	b5946df30e	Update configuration.md (#9085 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Mitsuru Kariya	926a4e148e	Docs: add missing configuration option (#9092 ) What this PR does / why we need it: Promtail can set the tenant id from a label with PR 6290 (commit `a1e0298a5`). However, while docs/sources/clients/promtail/stages/tenant.md was appropriately updated, docs/sources/clients/promtail/configuration.md was left untouched. Which issue(s) this PR fixes: Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Kaviraj Kanagaraj	f42942768e	Makefile: Support debug build for `logcli`. (#9093 ) What this PR does / why we need it: Support debug build for `logcli` binary. This writes debug binary under `logcli-debug` name in the same `cmd/logcli` directory. Already faced situation multiple times this is useful to debug some issues with LogQL locally. Which issue(s) this PR fixes: Fixes NA Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
W.T. Chang	46e835fb3c	Docs: Replace mimir example config path with a loki one (#9125 ) What this PR does / why we need it: The example config path on Loki's query scheduler is using `-config.file=/mimir/config/mimir.yaml`, which looks a little bit confusing on Loki's document, even though there are multiple references to Mimir. `7bec727c6d/docs/sources/operations/scalability.md`?plain=1#L23 This PR replaces the Mimir config path with the one found in query-frontend's document. `7bec727c6d/docs/sources/configuration/query-frontend.md`?plain=1#L115 Which issue(s) this PR fixes: N/A Special notes for your reviewer: I noticed this when checking configuration of 2.6, but this is still the case in the [latest version](https://grafana.com/docs/loki/v2.8.x/operations/scalability/). Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Jack Baldry	df1b34898b	Use centralized make-docs script from Writers' Toolkit (#9126 ) - Adds ability to build multiple projects simultaneously using, for example, `make docs PROJECTS='grafana grafana-cloud'`. - Adds `make doc-validator` which runs [`doc-validator`](https://github.com/grafana/technical-documentation/tree/main/tools/cmd/doc-validator) on all documentation. Using a centralized script will help ensure consistency in workflow across all projects. Signed-off-by: Jack Baldry <jack.baldry@grafana.com> Signed-off-by: Jack Baldry <jack.baldry@grafana.com>	2 years ago
melGL	d107fbe538	Removed deprecated navigation names (#9133 ) Changed "integrations and connections" to "connections" and removed the lightning bolt icon reference. --------- Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Abdelkrim	f4db6a76b8	Update _index.md (#9138 ) Removed the single binary from the scalability section as this is confusing. This should be called monolithic also. What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Salva Corts	5697bec427	Move misplaced recent changes in changelog to Loki Enhancements (#9137 ) What this PR does / why we need it: Some changelog entries were misplaced into _Promtail Enhancements_ instead of _Loki Enhancements_. This PR fixes this by moving the items to the correct section. Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki/pull/9042 Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
René Scheibe	e050d5c494	Docs: Update Loki GitHub URLs (#9080 ) * use `main` instead of `master` branch * fix outdated URLs	2 years ago
Salva Corts	8cf921a145	Pass engine opts down to middlewares (#9130 ) What this PR does / why we need it: The following middlewares in the query frontend uses a downstream engine: - `NewQuerySizeLimiterMiddleware` and `NewQuerierSizeLimiterMiddleware` - `NewQueryShardMiddleware` - `NewSplitByRangeMiddleware` These were all creating the downstream engine as follows: ```go logql.NewDownstreamEngine(logql.EngineOpts{LogExecutingQuery: false}, DownstreamHandler{next: next, limits: limits}, limits, logger), ``` As can be seen, the [engine options configured in Loki][1] were not being used at all. In the case of `NewQuerySizeLimiterMiddleware`, `NewQuerierSizeLimiterMiddleware` and `NewQueryShardMiddleware`, the downstream engine was created to get the `MaxLookBackPeriod`. When creating a new Downstream Engine as above, the `MaxLookBackPeriod` [would always be the default][2] (30 seconds). This PR fixes this by passing down the engine config to these middlewares, so this config is used to create the new downstream engines. Which issue(s) this PR fixes: Adresses some pending tasks from https://github.com/grafana/loki/pull/8670#issuecomment-1507031976. Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` [1]: `1bcf683513/pkg/querier/querier.go (L52)` [2]: `edc6b0bff7/pkg/logql/engine.go (L136-L140)`	2 years ago
Ashwanth	5cef03d0ea	index-shipper: add support for multiple stores (#7754 ) Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com> What this PR does / why we need it: Currently loki initializes a single instance of index-shipper to [handle all the table ranges](`ff7b462973/pkg/storage/factory.go (L188)`) (from across periods) for a given index type `boltdb-shipper, tsdb`. Since index-shipper only has the object client handle to the store defined by `shared_store_type`, it limits the index uploads to a single store. Setting `shared_store_type` to a different store at a later point in time would mean losing access to the indexes stored in the previously configured store. With this PR, we initialize a separate index-shipper & table manager for each period if `shared_store_type` is not explicity configured. This offers the flexibility to store index in multiple stores (across providers). Note: - usage of `shared_store_type` in this commit text refers to one of these config options depending on the index in use: `-boltdb.shipper.shared-store`, `-tsdb.shipper.shared-store` - `shared_store_type` used to default to the `object_store` from the latest `period_config` if not explicitly configured. This PR removes these defaults in favor of supporting index uploads to multiple stores. Which issue(s) this PR fixes: Fixes #7276 Special notes for your reviewer: All the instances of downloads table manager operate on the same cacheDir. But it shouldn't be a problem as the tableRanges do not overlap across periods. Checklist - [X] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [X] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Travis Patterson	c4261b19fd	Fix parsing of long queries (#9134 ) Loki uses a `scanner.Scanner` to consume the characters in a query. `lex.go` relies heavily on the assumption a scanner can be copied to perform speculative parsing. The problem is that sometimes speculative parsing overruns the scanners internal buffer of `1024` bytes and incurs an additional read to the underlying reader. At that point, all subsequent scanners are out of sync with their underlying readers and the query may fail to be parsed. In the case of #9132, there is a function call at line `1024`. `lex.go` tries to understand this is a function call by speculatively parsing and incurs an underlying read which consumers the rest of the reader. When the lexer tries to scan the next character with the original scanner, the reader is already consumed even though only 1024 bytes have been scanned The scanner has an internal buffer size of `1024 bytes`. This PR copies `scanner.Scanner` from the `text/scanner` package and increases the internal buffer to `maxInputSize` which guarantees that no calls to `Scan` will incur reads beyond the first one. Ideally we wouldn't pass Scanners around in such a way but the cost of that is to rethink much of Loki's lexing logic. Given we know a max input size and we already have that in memory, this solution should suffice. Fixes https://github.com/grafana/loki/issues/9132	2 years ago
Alan Conway	ac1c1fdf03	operator: Revert 1x.extra-small changes, add 1x.tiny-test (#9049 )	2 years ago
Peter Feigl	b744678c67	Feature/helm single binary extra containers (#8956 ) What this PR does / why we need it: Add a new helm value `singleBinary.extraContainers` to allow running sidecar containers in a singleBinary loki deployment. Useful for a container that keeps the data PV from filling up. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago

1 2 3 4 5 ...

4947 Commits (98936437a937447a163023d1c5961549614fa93a) All Branches Search

4947 Commits (98936437a937447a163023d1c5961549614fa93a)

All Branches