apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Trevor Whitney	9e275792e3	Fix k3d and docker-compose local development envs (#10387 ) This PR fixes bugs in two of the local dev envs we have. * production/docker was missing a required CLI flag for the backend target * tools/dev/k3d was failing to bring up a k8s cluster due to an issue with the prometheus operator crd bundled with the kube-prometheus-stack chart.	2 years ago
Karsten Jeschkies	569de47d76	Remove anonymous step evaluator and add `explain`. (#10400 )	2 years ago
Fausto David Suarez Rosario	bcf917f65a	Helm: Increase HPA minReplicas and maxReplicas (#9843 )	2 years ago
Shantanu Alshi	3e80e7ed9d	Fix changelog entry (#10406 ) Changes the changelog entry as per suggestion in #10395	2 years ago
Christian Haudum	738ccbb372	Add deprecation notes to Storage documentation (#10383 ) What this PR does / why we need it: Legacy storage backends (that are not single store aka "shipper") have been deprecated with https://github.com/grafana/loki/pull/10341 The docs should reflect this change. Special notes for your reviewer: The structure of the page changed _slightly_: * Made object storage a separate section under "Chunk storage" * Refer to this section in the "Single Store" section for supported backends * Moved Azure example underneath the rest of the single store examples While it is not yet perfect, I tried to change as little as possible and keep the big change for when the legacy storage backends are removed. --------- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Shantanu Alshi	f1bbdc51dc	Remove split_queries_by_interval and forward_headers_list (#10395 ) …range config Removed split_queries_by_interval and forward_headers_list from query_range config The fields were deprecated and hence going to be removed in the next major version What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Paul Rogers	794471b1eb	Fix fluentbit plugin for manifest step (#10399 ) What this PR does / why we need it: It appears that this commit (`d484d31856`) is causing a failure when on the manifest.manifest-fluent-bit step (2023/08/28 09:53:47 pushing by spec time="2023-08-28T09:53:47Z" level=fatal msg="Inspect of image \"grafana/fluent-bit:main-586b904-amd64\" failed with error: errors:\ndenied: requested access to the resource is denied\nunauthorized: authentication required\n" exit status 1). Subsequent investigation has shown that the grafana/fluent-bit docker repo does not exist. This PR is to change the manifest step to reference 'fluent-bit-plugin-loki' instead of 'fluent-bit'. The former is referenced for other steps in the Make process. I have also moved the boringcrypto canary ahead of the fluent-bit step to put the canaries next to each other, and to further help debug this step, should this change not be correct. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Dylan Guedes	6ce510dc55	Storage: Introduce new "ObjectExists" API (#10360 ) What this PR does / why we need it: Introduce to our `Store` interface a new function named `ObjectExists`, which can be used by external tools to validate if a given file is present on an object store without downloading the file. Which issue(s) this PR fixes: N/A	2 years ago
Karsten Jeschkies	3a4c0e2d47	Rename evaluator and its method to emphasize it's a factory. (#10381 )	2 years ago
Danny Kopping	e3ab2c22de	Fix CLI flags for congestion control (#10394 ) What this PR does / why we need it: Adds `congestion-control` prefixes to new flags. Currently to enable congestion control via a flag, one must use `-store.enabled` which is obviously misleading. --------- Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Ishan Jain	749894b161	bugfix/promtail.sh: Updated script to work better by default in k8s environment (#10390 ) What this PR does / why we need it: This PR fixes a bug in [promtail.sh](`94a5f94cf4/tools/promtail.sh`). promtail.sh is a script to deploy promtail in kubernetes clusters as a daemonset. The defaults should make sense in that environment. Currently, The default log parser in pipeline stages is, `- docker: `. Kubernetes uses CRI format so it makes more sense to default to CRI parser and this PR does exactly that. This PR does not affect any existing users of loki and it'll improve it for people who decide to use this script with the default arguments in the future because kubernetes uses cri format and grafana can't parse JSON logs properly if they were fed to loki with docker parser instead of the more appropriate cri parser.	2 years ago
Travis Patterson	60edfe0006	Implement "or" statement in line filters (#8962 ) It might be nice to not force a user to use `\|~` when they need to express `or` in LogQL. Example: `{app="foo"} \|= "foo" or "bar"` Edit: A ton of this is generated code or refactors. I've highlighed the parts most interesting to a reviewer --------- Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
Sheikh-Abubaker	04685ea512	Added a line in loki.yaml file to enable ruler sharding (#10066 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #8843 Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Bryan Boreham	a32cbeb37a	indexshipper/storage: fix race conditions (#10314 ) What this PR does / why we need it: There were many race conditions reported if you run `go test -race` on this package. Google's 'singleflight' package is much neater and makes all the race warnings go away. Which issue(s) this PR fixes: Relates to #8586 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - NA Tests updated - [x] `CHANGELOG.md` updated - NA If the change is worth mentioning in the release notes, add `add-to-release-notes` label - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - NA For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Karsten Jeschkies	f58ef7008b	Remove `t2.4xlarger` from sizing tool. (#10347 ) What this PR does / why we need it: The sizing tool was listing an AWS EC2 instance that does not exsit. Which issue(s) this PR fixes: Fixes #10315 Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Paul Rogers	11f4906223	Publish tagged images of loki-canary-boringcrypto (#10386 ) What this PR does / why we need it: Examining the images contained in the loki-canary repo ( https://hub.docker.com/repository/docker/grafana/loki-canary/tags?page=1&ordering=last_updated ) compared to the loki-canary-boringcrypto repo ( https://hub.docker.com/repository/docker/grafana/loki-canary-boringcrypto/tags?page=1&ordering=last_updated ), it appears that the explicitly tagged images (such as 'main') are not being sent to the boringcrypto repo. This PR is to adjust that behavior so that both repos receive the same number of builds (one will be boringcrypto enabled, the other will not be) Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Alexandre Salomé	94a5f94cf4	Docker: Update the analytics sourcecode URL in the docker local configuration (#10363 ) What this PR does / why we need it: The URL about Analytics sourcecode in the docker configuration file returns a 404. Which issue(s) this PR fixes: no issue opened, trivial fix Special notes for your reviewer: hello 👋 nice to meet you	2 years ago
Trevor Whitney	85e2e52279	fix: respect query matcher in ingester when getting label values (#10375 ) There is a bug when passing a query parameter to the `/label/:label/values`. Currently the ingester is not respecting this query string, and so is always returning all label values. This PR fixes that bug.	2 years ago
Shantanu Alshi	145319e5f5	Remove experimental enable ruler api toggle (#10380 ) Remove `-experimental.ruler.enable-api` in favour of `-ruler.enable-api`. The former was already deprecated for some time.	2 years ago
Christian Haudum	31981bd4af	Remove dependency on Bigchunk, which is a leftover of Cortex and is only used in tests (#10354 ) What this PR does / why we need it: This PR removes the dependency on "Bigchunk", which is a "default" implementation of the `chunk.Data` interface and used only in tests. Special notes for your reviewer: The PR replaces the usage of this chunk type with the Loki implementation (`chunkenc.MemChunk` wrapped into `chunkenc.Facade`) where possible. In case where it was not possible (tests in `pkg/storage/chunk` package) due to otherwise circular import, it was replaces by the `chunk.dummyChunk` implementation, which is just a no-op that implements `chunk.Data` interface) The PR also removes the protos for the ingester client (`pkg/ingester/client/ingester.proto`) which were only referenced in the removed `pkg/util/chunkcompat/compat.go` file. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Shantanu Alshi	92ba055ae5	Remove ruler.wal-cleaer.period (#10378 ) The config with typo is now replaced by `-ruler.wal-cleaner.period`	2 years ago
Shantanu Alshi	325c332f3e	Remove deprecated s3 sse toggle (#10377 ) This PR removes a legacy and already deprecated boolean setting `-s3.sse-encryption` in favor of the more fine-grain `-s3.sse.*` settings.	2 years ago
Salva Corts	44e1c88aca	Add changelog for non-indexed labels (#10379 ) What this PR does / why we need it: We recently implemented a new feature to support attaching and querying non-indexed labels attached to each log line. This PR updates the changelog with entries referencing the main PRs of this feature. --------- Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>	2 years ago
Karsten Jeschkies	f8658fdc38	Enable sharding for avg_over_time. (#10373 ) What this PR does / why we need it: The range aggregation `avg_over_time` is simply shardable if there's no label reduction. If there is one it can be express as ``` sum by (method) ( sum_over_time( {container="app"} \| json \| unwrap bytes [$__interval]) ) / sum by (method) ( count_over_time( {container="app"} \| json [$__interval] ) ) ``` Note that `sum by`, `sum_over_time` and `count_over_time` are shardable once more. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Co-authored-by: Owen Diehl <ow.diehl@gmail.com>	2 years ago
Calvin Bui	05195f2e9b	helm: add dnsConfig (#10339 ) What this PR does / why we need it: Adds dnsConfig value to Helm deployments and statefulsets Which issue(s) this PR fixes: N/A Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Grot (@grafanabot)	a6f68fff52	[Release Notes Appender] Add PR #10047 : add volume and volume_range docs (#10074 ) Add PR #10047 to release notes for next release --------- Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Danny Kopping	c725de6035	Querier: add chunk refs fetch time to metrics (#10362 ) What this PR does / why we need it: Adds an entry to the `metrics.go` log line to track how long a query waits for its chunk references to be returned by the index. This is useful when trying to understand where processing time is being spent.	2 years ago
Ashwanth	dff3622eaa	deprecate old index types and non-object stores (#10341 ) What this PR does / why we need it: Deprecates old index types: `aws, aws-dynamo, gcp, gcp-columnkey, bigtable, bigtable-hashed, cassandra, grpc`. Only `tsdb` and `boltdb-shipper` are supported. Deprecates non-object stores. The next major release might not allow the usage of these as `object_store` in `schema_config`: `aws-dynamo, gcp, gcp-columnkey, bigtable, bigtable-hashed, cassandra, grpc.` Deprecates table manager which is not needed once when using `boltdb-shipper` or `tsdb` index type Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Ashwanth	364226108a	chore: fix flaky querytee proxy test (#10367 ) What this PR does / why we need it: `Test_ProxyEndpoint_SummaryMetrics` does not wait for `compareResponses` call to finish which causes the test to fail as the expected metric response does not match this pr updates the test to wait for `responses_compared_total` to be set to 1 before asserting `missingMetrics` Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Shantanu Alsi	586b9042c6	Upgrade Thanos objstore, dskit and other modules (#10366 ) What this PR does / why we need it: Upgrades various common modules including dskit, thanos objstore, prometheus, etc. Fixes errors/ changes resulting due to module upgrades. This is required in order to eventually upgrade BEL dependency in GEL to point to master. Which issue(s) this PR fixes: None Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Ashwanth	18482c67d6	compactor: deprecate -boltdb.shipper.compactor. prefix in favor of -compactor. (#10344 ) What this PR does / why we need it: Compactor config use `-boltdb.shipper.compactor.` as prefix which is misleading as the config options apply to tsdb index as well. This pr introduces `-compactor.` prefix which can now be used to configure compactor configuration options and deprecates `-boltdb.shipper.compactor.` Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Hongbo Miao	238053f8c3	docs: fix menu title (#10343 ) What this PR does / why we need it: Just fix a small typo at https://grafana.com/docs/loki/latest/logql/analyzer/ ☺️ ![image](https://github.com/hongbo-miao/loki/assets/3375461/19b79610-eb69-4c99-b2da-3aea8d9acb35) Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Kaviraj Kanagaraj	c030217e1b	Revert "LogQL: Introduce `distinct` (#8662 )" (#10356 ) What this PR does / why we need it: This reverts commit `38b298c3fe`. We are removing this PR #8662 because [known issue tracked here](https://github.com/grafana/loki/issues/9594) and some issues we facing internally with query splitting and sharding work(hard to parallelize, merging two `distinct` sets can have duplicates, hard to make it work with metric queries, etc). We decided best to remove it before make it to public release. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Kaviraj Kanagaraj	760c255431	doc(schema): Start recommending `v12` schema instead of `v11` (#10355 ) What this PR does / why we need it: `v12` is stable schema with more efficient/stable chunks and index formats. Start recommending it instead of old `v11`. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added --------- Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Ashwanth	cc6634972f	config: deprecates unordered-writes and few unused configs (#10324 ) What this PR does / why we need it: Deprecates the following configs: out of order writes will be the default and the only format with the next major release - ingester.unordered-writes these need not be configurable, were added for testing - log.use-buffered - log.use-sync unused - frontend.forward-headers-list Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Ashwanth	470cbbf118	querier: remove query_timeout and engine timeout from querier conf (#10302 ) What this PR does / why we need it: Removes `query_timeout` and `engine:timeout` from querier's config section Both these configs have been deprecated in 2.7.0 release in favor of `query_timeout` in `limits_config` which also allows applying per-tenant overrides at runtime. CLI flag `-querier.engine.timeout` is also removed Checklist - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [X] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [X] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) --------- Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Sandeep Sukhani	962e03932d	non-indexed labels: support for deletion of logs with non-indexed labels (#10337 ) What this PR does / why we need it: We recently added support for storing and querying non-indexed labels with each log line. This PR wires up the code for supporting deletion using non-indexed labels. Checklist - [x] Tests updated	2 years ago
Christian Haudum	210c937c41	chore(schema-v13): Fix series store schema creation for v13 (#10348 ) The creation of a series store schema failed when using v13 schema version. Special notes for your reviewer: When adding the `v13` to the series store test cases (`pkg/storage/stores/series/series_store_test.go`) they fail. Example error: ``` === RUN TestSeriesStore_LabelValuesForMetricName/foo_/_toms_/_v13_/_store series_store_test.go:700: ========= Running labelValues with metricName foo with labelName toms with schema v13 series_store_test.go:93: Error Trace: /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:93 /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:77 /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:702 Error: Received unexpected error: invalid schema version Test: TestSeriesStore_LabelValuesForMetricName/foo_/_toms_/_v13_/_store === RUN TestSeriesStore_LabelValuesForMetricName/foo_/_toms_/_v13_/_cached_store series_store_test.go:700: ========= Running labelValues with metricName foo with labelName toms with schema v13 series_store_test.go:93: Error Trace: /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:93 /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:77 /home/christian/sandbox/grafana/loki/pkg/storage/stores/series/series_store_test.go:702 Error: Received unexpected error: invalid schema version Test: TestSeriesStore_LabelValuesForMetricName/foo_/_toms_/_v13_/_cached_store ``` Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Trevor Whitney	45b127cfd6	add `trivy` to Makefile and build image (#10231 ) `trivy` is a command line utility that can scan our images for vulnerabilities. For example, this is how I checked #10217 addressed the CVEs we were hoping it would ``` ❯ trivy i grafana/loki:release-2.8.x-d784431 2023-08-11T12:34:15.272-0600 INFO Vulnerability scanning is enabled 2023-08-11T12:34:15.272-0600 INFO Secret scanning is enabled 2023-08-11T12:34:15.272-0600 INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning 2023-08-11T12:34:15.272-0600 INFO Please see also https://aquasecurity.github.io/trivy/dev/docs/scanner/secret/#recommendation for faster secret detection 2023-08-11T12:34:15.283-0600 INFO Detected OS: alpine 2023-08-11T12:34:15.283-0600 INFO Detecting Alpine vulnerabilities... 2023-08-11T12:34:15.286-0600 INFO Number of language-specific files: 1 2023-08-11T12:34:15.286-0600 INFO Detecting gobinary vulnerabilities... grafana/loki:release-2.8.x-d784431 (alpine 3.18.2) Total: 6 (UNKNOWN: 0, LOW: 0, MEDIUM: 6, HIGH: 0, CRITICAL: 0) ┌────────────┬───────────────┬──────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────────┐ │ Library │ Vulnerability │ Severity │ Installed Version │ Fixed Version │ Title │ ├────────────┼───────────────┼──────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────────┤ │ libcrypto3 │ CVE-2023-2975 │ MEDIUM │ 3.1.1-r1 │ 3.1.1-r2 │ AES-SIV cipher implementation contains a bug that causes it │ │ │ │ │ │ │ to ignore empty... │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-2975 │ │ ├───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ │ CVE-2023-3446 │ │ │ 3.1.1-r3 │ Excessive time spent checking DH keys and parameters │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-3446 │ │ ├───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ │ CVE-2023-3817 │ │ │ 3.1.2-r0 │ Excessive time spent checking DH q parameter value │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-3817 │ ├────────────┼───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ libssl3 │ CVE-2023-2975 │ │ │ 3.1.1-r2 │ AES-SIV cipher implementation contains a bug that causes it │ │ │ │ │ │ │ to ignore empty... │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-2975 │ │ ├───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ │ CVE-2023-3446 │ │ │ 3.1.1-r3 │ Excessive time spent checking DH keys and parameters │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-3446 │ │ ├───────────────┤ │ ├───────────────┼─────────────────────────────────────────────────────────────┤ │ │ CVE-2023-3817 │ │ │ 3.1.2-r0 │ Excessive time spent checking DH q parameter value │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2023-3817 │ └────────────┴───────────────┴──────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────────┘ ``` This PR adds that command as `Makefile` target, as well as adding the `trivy` binary to our drone build image so we can add it to our pipelines in the future.	2 years ago
Travis Patterson	12221f43b5	Put unescaped regexes in a raw string literal (#10331 ) [This PR](https://github.com/grafana/loki/pull/10277) fixed an issue where regexes were being escaped multiple times and causing otherwise valid queries to fail our length check. It put the resulting regexes in double quotes which meant that any regexes that _needed_ escaping were now invalid. This PR make is so the unescaped regex is put in a raw string literal so any extra escaping in unnecessary.	2 years ago
Kaviraj Kanagaraj	4bd5e617c3	chore(schema-v13): Fix `periodConfig.Validate` for `v13` schema (#10336 ) What this PR does / why we need it: Fix periodConfigs `Validate()` for new schema `v13`. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Found when testing archiver with latest loki Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Salva Corts	603eb637f6	Add docs for non-indexed labels (#10073 ) What this PR does / why we need it: Adds documentation for the new experimental non-indexed labels feature. --------- Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> Co-authored-by: Vladyslav Diachenko <82767850+vlad-diachenko@users.noreply.github.com>	2 years ago
Karsten Jeschkies	5ba154a6de	Report missing metrics in querytee. (#10304 ) What this PR does / why we need it: Sometimes we want to not just fail a querytee but also report results on the comparison between expected and actual results. That's why querytee is extended with special metrics to give more insights into the differences. Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Karsten Jeschkies	3789f1717c	Set buckets for querier_wait_seconds histogram. (#10334 ) What this PR does / why we need it: We should set buckets for the `querier_wait_seconds` histogram. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`)	2 years ago
Kaviraj Kanagaraj	81f2cb4aea	release-notes: Add back the entry on hedged requests improvements. (#10327 ) What this PR does / why we need it: This PR somehow overwrote the entry. https://github.com/grafana/loki/pull/10286/files probably some rebase issue. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Kaviraj Kanagaraj	bbfb13c3e4	Pin `chunk` and `index` format to `schema` version. (#10213 ) We pin all three `Chunk`, `HeadBlock` and `TSDB` Version to `schema` version in period config. This is the following mapping (after being discussed with @owen-d and @sandeepsukhani ) `v12` (current existing schema) - ChunkFormatV3 (UnorderedHeadBlock) + TSDBv2 `v13` (introducing new schema) - ChunkFormatV4 (UnorderedWithNonIndexedLabelsHeadBlockFmt) + TSDBv3 Note the new schema `v13` supports the latest chunk and index format. NOTES for Reviewer 1. General approach is we removed the idea of `index.LiveFormat`, `chunkenc.DefaultChunkFormat` and `chunkenc.DefaultHeadBlockFmt` and made following two changes. These variables were used before to tie chunk and tsdb formats specific to Loki versions. This PR remove that coupling and pin these formats to `schema` version instead. 1. These variables were replaced with explicit chunk and index formats within those packages (and it's tests) 2. If these variables were used outside it's own packages say by ingester, compactor, etc. Then we extract correct chunk and index versions from the `schema` config. 2. Add two methods to `periodConfig`. (1) `ChunkFormat()` returning chunk and head format tied to schema (2) `TSDBFormat()` returning tsdb format tied to schema. 2. Other ideas I thought of doing but didn't end up doing is make `ChunkFormat` and `IndexFormat` as separate type (rather than `byte` and `int` currently. Similar to `HeadBlockFmt` type). But didnt' do it eventually to keep the PR small and don't want to complicate with lots of changes. 4. Moved couple of test cases from `chunkenc` to `config` package, because the test case was actually testing methods on `schemaconfig` and it was creating cycling dependencies. --------- Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
akhilanarayanan	3303844cb0	Refactored forGivenIngestors to use DoUntilQuorum instead of Do (#9984 ) This changes the forGivenIngestors function in pkg/querier/ingester_querier.go to use `DoUntilQuorum` (from [PR #293](https://github.com/grafana/dskit/pull/293)) instead of `Do`. `DoUntilQuorum` is much more efficient than `Do`. The exact differences between them can be seen [here](https://github.com/grafana/dskit/pull/293). --------- Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Dylan Guedes	becc9bee99	Jsonnet: Add `default` section to runtime jsonnet file (#10330 ) What this PR does / why we need it: Add a `default` section to our runtime jsonnet file. The `default` section was introduced by https://github.com/grafana/loki/pull/10193.	2 years ago
Christian Haudum	e3b25fb36c	Deprecate ruler setting with misleading name (#10322 ) The setting defaults to `0s` and is not supposed to be changed, therefore it should be removed in a future version (e.g. 3.0) of Loki. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Ivana Huckova	5722696703	Update CODEOWNERS to include logs team for grammar file (#10325 ) What this PR does / why we need it: To keep LogQL grammar in sync with https://github.com/grafana/lezer-logql, we would like to add @grafana/observability-logs as a co-codeowner for grammar file `/pkg/logql/syntax/expr.y` to get notification when this file change.	2 years ago

1 2 3 4 5 ...

5541 Commits (9e275792e3023fa269ca009d978ef34bbe55030a) All Branches Search

5541 Commits (9e275792e3023fa269ca009d978ef34bbe55030a)

All Branches