apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Christian Simon	dad39f7ea6	Improve comments on sample timestamp validation errors (#8018 ) This has come up time and time again, I have tried to write it up a bit better in code first, I would also strongly suggest that we improve the error messaging and the documentation of this.	2 years ago
Michel Hollands	872c29dacc	Use gotestsum to run unit tests (#8022 ) What this PR does / why we need it: Add gotestsum to the build image. Then use it to run the unit tests. The output format is easier to parse so we can get statistics about the builds. Passing test cases look like this: ``` PASS pkg/storage/stores/shipper/index/compactor.TestTable_RecreateCompactedDB/compacted_db_old_enough (2.64s) PASS pkg/storage/stores/shipper/index/compactor.TestTable_RecreateCompactedDB (10.26s) PASS pkg/storage/stores/shipper/index/compactor.TestExtractIntervalFromTableName/0 (0.00s) ``` Failing test cases are shown at the end and are easier to parse: ``` === FAIL: pkg/storage/stores/indexshipper/compactor/deletion TestGRPCGetCacheGenNumbers (unknown) panic: Fail in goroutine after TestGRPCGetCacheGenNumbers/error_getting_from_store has completed goroutine 293 [running]: testing.(*common).Fail(0xc0005aa680) /usr/local/Cellar/go/1.19.4/libexec/src/testing/testing.go:824 +0xe5 ... ``` Signed-off-by: Michel Hollands <michel.hollands@grafana.com> Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	2 years ago
Christian Haudum	17577b4d47	Shut down query frontend gracefully (#7978 ) What this PR does / why we need it: This PR fixes a bug in the shutdown process of the query frontend. In order to shut down the frontend gracefully without cancelling any in-flight operations/sub-requests, the frontend service has to wait until all in-flight operations are finished. Only then its sub-services may be stopped. In order to control the deterministic order of the shutdown of the service and its child services, child services need to be started with their own context (not with their parent context). Otherwise, if the context of the frontend is cancelled, also the contexts of the child services are cancelled, leading to a parallel stopping of the parent and its child services. During the time of the shutdown, the `RoundTripGRCP` function still needs to accept any round-tripping requests. This is, because the frontend round tripper is wrapped into a query range tripper ware, which splits incoming (HTTP) query requests into multiple (gRPC) query requests if needed. Which issue(s) this PR fixes: This fixes a race condition where queries fail, because the query frontend shut down before the queriers that processed in-flight request could send the query response to the frontend. This manifested in an increased error rate of queries during restarts (rollouts) of the query frontend. Special notes for your reviewer: Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Danny Kopping <danny.kopping@grafana.com>	2 years ago
Kaviraj Kanagaraj	1375fa0654	chore(promtail): Make `batchwait` and `batchsize` config explicit with yaml tags. (#8027 ) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> What this PR does / why we need it: These configs can be used via `batchwait` and `batchsize` keys in yaml. This PR just makes it explicit via yaml tags. Which issue(s) this PR fixes: Fixes #NA Special notes for your reviewer: We already have test to cover those keys. https://github.com/grafana/loki/blob/kavirajk%2Fbatch-configs-make-yaml-explicit/clients/pkg/promtail/client/config_test.go#L28-L29 Also we have config pages for those keys. https://grafana.com/docs/loki/latest/clients/promtail/configuration/#clients Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] `CHANGELOG.md` updated Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Sandeep Sukhani	3a8325d828	make query-frontend service grpc lb friendly (#8025 ) What this PR does / why we need it: In PR #7966, I made changes to Query Frontend service. Part of it was creating a new service. To make the service properly load balance grpc requests, we need to use `grpclbServiceFor`, but since we do not use grpc in QF, I went with the usual method, i.e. I used `serviceFor`. Thinking more about it, I think there is no harm in keeping it grpc LB friendly, and it would save us from any possible bugs if we make QF accept queries via grpc.	2 years ago
irizzant	ff7b462973	updated versions to the latest release v2.7.1 (#7940 ) Signed-off-by: irizzant <i.rizzante@gmail.com> What this PR does / why we need it: This PR updates Loki version to v2.7.1 Which issue(s) this PR fixes: Fixes #7768 Signed-off-by: irizzant <i.rizzante@gmail.com>	2 years ago
Susana Ferreira	0f139e2cb3	Update log queries regex documentation (#8002 ) What this PR does / why we need it: Update log queries regex documentation with a clarification on the difference between the newline character in: * label matching operator: `.` does not match newlines line filter expressions: `.` matches newlines Checklist* - [x] Documentation updated	2 years ago
Michel Hollands	59eff5ca58	Add count to template functions (#7951 ) What this PR does / why we need it: Add a `count` template function to count occurrences of a substring. For example if `label="abc abd abc"` ``` {{ .label \| count "abc" }} ``` would return 2. Signed-off-by: Michel Hollands <michel.hollands@grafana.com> Co-authored-by: Danny Kopping <dannykopping@gmail.com>	2 years ago
Ashwanth	dc5cc4c494	store: write overlapping chunks to multiple stores (#7988 ) Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com> What this PR does / why we need it: When a chunk falls on the period boundary it should be written to both the stores as it gets referred to by the indexes on both sides. But we currently skip the writes for subsequent periods if the chunk is found in the cache. This PR ensures that overlapping chunks get written to both the stores Which issue(s) this PR fixes: Fixes #7847 Special notes for your reviewer: Downside of this approach is that we end up writing the overlapping chunk multiple times, once from each instance in the replica set. But these duplicate writes would be infrequent given this occurs only on schema changes Checklist - [X] Reviewed the `CONTRIBUTING.md` guide - [X] Tests updated - [x] `CHANGELOG.md` updated Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>	2 years ago
Christian Haudum	089ec1b05f	Fix various linter errors These changes have been generated using `make lint`. ```console $ golangci-lint --version golangci-lint has version 1.50.0 built from 704109c6 on 2022-10-04T10:25:07Z ``` Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Kaviraj Kanagaraj	d5b68c0257	fix(promtail): Fix cri tags extra new lines. (#7997 )	2 years ago
Travis Patterson	92fca94bb5	Revert "Update Ingester Rate Calculations (#7652 )" (#7991 ) This change was supposed to smooth out the per-second rate of streams so distributors could react more uniformly to streams with variable rates. In practice, it resulted in drastically more resource usage on distributors because `GetStreamRates` now responds with all streams on an ingester rather than only the streams seen in the last second. This change also didn't seem to affect sharding precision one way or another. If we'd still like to implement exponential smoothing for stream rates, it should be implemented in distributors to keep communication overhead to a minimum.	2 years ago
Susana Ferreira	d086c237df	Add missing period_config root block to doc generator (#7981 ) What this PR does / why we need it: Update doc generator tool to validate if slice element is a root block. Add missing `period_config` root block to doc generator tool. Special notes for your reviewer: Checklist - [ ] Documentation updated	2 years ago
Susana Ferreira	d36dd9edc4	Add README file to doc-generator tool (#7983 ) What this PR does / why we need it: Add README file to doc-generator tool	2 years ago
Danny Kopping	a4f306399a	Add store & cache download statistics (#7982 )	2 years ago
Javier Vela	fe69443a05	Fix links to configuration page (#7164 ) What this PR does / why we need it: Fix links to configuration page: - kafka - Cloudflare - Kubernetes Discovery - Windows Event Log - Heroku Drain - HTTP client options Signed-off-by: Javier Vela <fjvela@gmail.com>	2 years ago
Mohamed-Amine Bouqsimi	88f04beb4e	operator: Configure Alertmanager per-tenant (#7839 )	2 years ago
Sandeep Sukhani	9e7ac3d853	fix query-frontend request load balancing when using k8s service (#7966 ) What this PR does / why we need it: We noticed an imbalance in the requests sent to the Query Frontend pods using `query-frontend` k8s service. This seems to be caused by `query-frontend` being a headless service that resolves to each QF pod IP and leaves it up to the client to load balance the requests as mentioned [here](https://kubernetes.io/docs/concepts/services-networking/service/#headless-services). This PR fixes the issue by creating two separate services for pod IP discovery and load balancing of queries: * `query-frontend` to be used for load balancing incoming Loki queries. * `query-frontend-headless` to be used for discovering QF pod IPs from queriers to connect as workers. Checklist - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Michel Hollands	cc4ab7487a	Fix typo (#7956 ) What this PR does / why we need it: Fix docs as reported by user Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki/issues/7893 Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	2 years ago
Travis Patterson	209b281593	Fix min and max aggregations when using instant queries. (#7957 ) Instant queries use the new `streamRangeVectorIterator` which has a new set of `aggregators`. Before, aggregations were based on the first point in the range to be aggregated. With `streamRangeVectorIterator`, points are instead treated one at a time. The aggregations were simply checking whether the value was less than the min or greater than the max without any initialization. This PR fixes these aggregations by initializing `min` or `max` to `math.Nan` so the first point is always considered.	2 years ago
mfordjody	b6ae4b4b73	fix error helm install monolithic path (#7948 )	2 years ago
Karsten Jeschkies	0f3eecd209	Show help tooltip on hover in sizing tool. (#7919 )	2 years ago
Michel Hollands	5fe9c964db	Fix validation for pattern and rexexp parsers to they don't panic in query-frontend (#7926 ) Running the query `topk(10,sum by(namespace)(count_over_time({application="nginx", site!="eu-west-1-dev"} \|= "/artifactory/" != "api" != "binarystore" \| regexp `` [1d])))` causes a panic. This PR adds validation for regexp and pattern parsers at parse time. If they don't have a (valid) parameter an error will be returned. Signed-off-by: Michel Hollands <michel.hollands@grafana.com> Co-authored-by: Susana Ferreira <ssncferreira@gmail.com>	2 years ago
Trevor Whitney	05d2110681	[helm] control order provisioner and tokengen jobs run in (#7939 ) What this PR does / why we need it: This adds `hook-weight` annotations to the tokengen and provisioner jobs to make sure tokengen always runs first. The fixes a race condition where provisioner attempts to go first but locks and fails the deployment because no token is available. Which issue(s) this PR fixes: Fixes #7251 Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Susana Ferreira	86d33a4e4a	Add CI step to check generated documentation to check pipeline (#7938 ) What this PR does / why we need it: Follow up from PR: https://github.com/grafana/loki/pull/7916 to add a CI step to check if the configuration flag documentation file `doc/sources/configuration/_index.md` was generated successfully. Requirements: * CI `check` pipeline should fail if the documentation file is updated manually * CI `check` pipeline should fail if registration flags are changed in the code, but the documentation file is not generated. Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki-private/issues/83 Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Susana Ferreira	e07fe7c338	Deprecate CLI flag -ruler.wal-cleaer.period in favor of CLI flag -ruler.wal-cleaner.period (#7937 ) What this PR does / why we need it: Deprecate CLI flag `-ruler.wal-cleaer.period` in favor of CLI flag `-ruler.wal-cleaner.period`. Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki/pull/7916#issuecomment-1348276269 and https://github.com/grafana/loki/pull/7916#discussion_r1047043534 NOTE: correctly registring the `ruler.wal-cleaner` configuration flags is not a breaking change and doesn't require an upgrade guide, because the ruler WAL cleaner initialization code already guarantees that the default values are used: `c71620ae94/pkg/ruler/storage/cleaner/cleaner.go (L76-L101)` Special notes for your reviewer: Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Kaviraj Kanagaraj	cbd6ec15ce	feat(logql): Supporting prettifying LogQL expressions (#7906 ) What this PR does / why we need it: Changes 1. Added `Pretty()` method to `Expr` interface. So that every expression would know how to render themselfs as pretty :) 2. Implemented `Pretty()` for every single LogQL expressions 3. Exposed `/api/v1/format_query` endpoint that takes `query` argument and returns formatted version. 4. Integerated into `logcli`. echo `'<query>' \| logcli fmt` would format the query. Why? 1. Readability, helpful in debugging and more importantly, to understand the execution flow example before ``` quantile_over_time(0.99,{container="ingress-nginx",service="hosted-grafana"}\| json\| unwrap response_latency_seconds\| __error__=""[1m]) by (cluster) ``` ``` sum(rate({job="loki", namespace="loki", cluster="loki-dev-us"} \|= "err" [5m])) + sum(rate({job="loki-dev", namespace="loki", cluster="loki-dev-eu"}\|logfmt \| level != "info" [5m])) / sum(rate({job="loki-prod", namespace="loki", cluster="loki-prod-us"} \|logfmt \| level="error"[5m])) ``` ``` label_replace(rate({job="api-server",service="a:c"}\|= "err" [5m]), "foo", "$1", "service", "(.):.") ``` after ``` quantile_over_time( 0.99, {container="ingress-nginx", service="hosted-grafana"} \| json \| unwrap response_latency_seconds \| __error__="" [1m] ) by (cluster) ``` ``` sum( rate( {job="loki", namespace="loki", cluster="loki-dev-us"} \|= "err" [5m] ) ) + sum( rate( {job="loki-dev", namespace="loki", cluster="loki-dev-eu"} \| logfmt \| level!="info" [5m] ) ) / sum( rate( {job="loki-prod", namespace="loki", cluster="loki-prod-us"} \| logfmt \| level="error" [5m] ) ) ``` ``` label_replace( rate({job="api-server", service="a:c"} \|= "err"[5m]), "foo", "$1", "service", "(.):." ) ``` You can find more examples in the `prettier_test.go` Future plans * Integerate into LogQL analyzer * Integrate into Grafana UI. Which issue(s) this PR fixes: Fixes # NA Special notes for your reviewer: This whole idea was inspired from last [PromCon lighting talk](https://youtu.be/pjkWzDVxWk4?t=24469) Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Christian Simon <simon@swine.de>	2 years ago
Karsten Jeschkies	c71620ae94	Flush buffered logger on exit. (#7924 ) What this PR does / why we need it: I ran into this issue several times. No error logs were printed or no generated token for GEL. This is because crashing runs can be much faster than the flush period. Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Irina	10b869c82e	Move to fork github.com/grafana/gomemcache (#7936 )	2 years ago
Irina	8fe386fbb3	Move to fork github.com/grafana/tail (#7931 )	2 years ago
Susana Ferreira	68a4d3271a	Fix documentation typos from #7916 (#7934 ) What this PR does / why we need it: Fix documentation typos from https://github.com/grafana/loki/pull/7916#pullrequestreview-1217192817 Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki/pull/7916#pullrequestreview-1217192817 Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Susana Ferreira	f93b91bfb5	Add configuration documentation generation tool (#7916 ) What this PR does / why we need it: Add a tool to generate configuration flags documentation based on the flags properties defined on registration on the code. This tool is based on the [Mimir doc generation tool](https://github.com/grafana/mimir/tree/main/tools/doc-generator) and adapted according to Loki configuration specifications. Prior to this PR, the configuration flags documentation was dispersed across two sources: * [_index.md](`5550cd65ec/docs/sources/configuration/_index.md`) * configuration flags registration in the code This meant that there was no single source of truth. In this PR, the previous `_index.md` file is replaced with the new file generated by the tool. The next step includes adding a CI step that validates if the _index.md file was generated according to the flags settings. This will be done in a follow-up PR. NOTE: this is not a documentation update PR. Apart from some minor typo fixes, the documentation changes on the code, were copied from the `_index.md` file. Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki-private/issues/83 Special notes for your reviewer: Files: * [docs/sources/configuration/index.template](`5550cd65ec/docs/sources/configuration/index.template`): template used to generate the final configuration file * [/docs/sources/configuration/_index.md](`c32e5d0acb/docs/sources/configuration/_index.md`): file generated by tool * `loki/pkg` directory files updated with up-to-date documentation from `_index.md` file * [tools/doc-generator](`5550cd65ec/tools/doc-generator`) directory with documentation generation tool. Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Kaviraj Kanagaraj	4768b6d997	doc(api): Default value for `delete_ring_tokens` on `/ingester/shutdown` endpoint (#7921 ) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> What this PR does / why we need it: PR documents the default value for `delete_ring_tokens` params on `/ingester/shutdown` endpoint. Which issue(s) this PR fixes: Fixes #NA Special notes for your reviewer: Checklist - [x] Documentation added Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>	2 years ago
Tobias Wolf	79e0d96978	Helm: Decouple the Canary from self-monitoring (#7757 ) What this PR does / why we need it: The Canary has no dependency on the Grafana Agent-based self-monitoring. This PR decouples that dependency, allowing the canary to be deployed with the other self-monitoring features. Which issue(s) this PR fixes: Fixes #7364	2 years ago
Charlie N	9d5665e34a	[Jsonnet] Fix memberlist when using a stateful ruler (#6662 ) Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com> <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: When using stateful rulers and the memberlist as its ring, generating the resources with jsonnet throws in an error regarding the `ruler_deployment`. The `ruler_statefulset` didn't receive the meberlist labels either. <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [ ] Documentation added - [ ] Tests updated - [x] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com>	2 years ago
Trevor Whitney	f5fbfabd84	Add 3rd target (`backend`) to SSD/Scalable mode (#7650 ) What this PR does / why we need it: This adds a 3rd target to SSD/Scalable mode, as well as a config flag to run the legacy `read` mode from the original 2 target configuration in order to give people time to migrate before we remove this option in Loki 3.0 (hopefully). The 3rd target has the two major advantages: 1. Allows the read path to be run as a deployment and thus auto-scaled using our existing auto-scaling logic for queriers 2. Creates consistency with Mimir since they went with a 3 target model for their SSD deployment.	2 years ago
Karsten Jeschkies	c4eb8c87ed	Remove duplicate sizing tool (#7917 ) What this PR does / why we need it: The sizing tool was checked in twice. Also, there was a function error in fetching the nodes. Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Karsten Jeschkies	9b90aad7ce	Fix sizing tool. (#7899 ) What this PR does / why we need it The current sizing tool is broken because it would not allow cross origin requests. See LogQL Analyzer (https://github.com/grafana/loki/blob/main/docs/sources/logql/analyzer/script.js#L115) for the proper way to call its API.	2 years ago
dependabot[bot]	04ce1b8721	Bump azure/setup-helm from 1 to 3 (#7608 ) Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 1 to 3. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Justin Avery Rexroad	7546c4041e	Fix typo in helm install monolithic docs (#7909 ) What this PR does / why we need it: Add missing letter to end of word. Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Christian Haudum	f86d12f498	Update dskit to latest commit Diff: `b1b307db4f..3e308a4944` Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Periklis Tsirakidis	fb3ad058e0	operator: Update Loki operand to v2.7.1 (#7910 )	2 years ago
Maxim Ivanov	b773a7a3cf	promtail: ratelimiting by label (#7597 ) Limit stage can now takes optional `by_label_name` param, which tracks distinct values of that label and ratelimit entries independently. Log lines without expected label are not considered for ratelimiting and passed to the next pipeline stage.	2 years ago
Trevor Whitney	99b7c14e09	Prepare changelog and release notes for 2.7.1 (#7895 ) What this PR does / why we need it: Prepares changelog and release notes for 2.7.1 release. Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	2 years ago
Karsten Jeschkies	95ec710168	Introduce sizing tool to documentation page. (#7830 ) What this PR does / why we need it: The sizing tool should help to find a good cluster sizing when starting out with Loki. It's a dynamic form withing the documentation. ![image](https://user-images.githubusercontent.com/2418440/205147901-1fe86403-60af-4639-8ce3-9a192549900b.png) This pull request will be followed by help on hover. Special notes for your reviewer: Checklist - [ ] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Karsten Jeschkies <karste.jeschkies@grafana.com>	2 years ago
dependabot[bot]	655ab05b91	build(deps): bump golang.org/x/crypto from 0.1.0 to 0.4.0 (#7883 ) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.1.0 to 0.4.0. <details> <summary>Commits</summary> <ul> <li><a href="`eb2c406296`"><code>eb2c406</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`2c476679df`"><code>2c47667</code></a> cryptobyte: add support for ReadASN1Integer into []byte</li> <li><a href="`0ec7e8322c`"><code>0ec7e83</code></a> internal/wycheproof: update Go 1.20 crypto/ecdh API</li> <li><a href="`6fad3dfc18`"><code>6fad3df</code></a> ssh: support rsa-sha2-256/512 on the server side</li> <li><a href="`21d60a1521`"><code>21d60a1</code></a> all: remove redundant type conversion</li> <li><a href="`183a9b70cc`"><code>183a9b7</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`334521b960`"><code>334521b</code></a> ssh: fix typo</li> <li><a href="`a3485e1740`"><code>a3485e1</code></a> all: use math/bits.RotateLeft</li> <li>See full diff in <a href="https://github.com/golang/crypto/compare/v0.1.0...v0.4.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/crypto&package-manager=go_modules&previous-version=0.1.0&new-version=0.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Sandeep Sukhani	e9c93cd0f5	consider range and offset in queries while looking for schema config for query sharding (#7880 ) What this PR does / why we need it: We disable query sharding when a query touches multiple schema configs since they might have different sharding factors and might handle sharding differently. This check was done purely on the start and end time of the query without considering `range` and `offset`, which would change the length of the actual data being queried. Besides being incorrect, it also causes us to fail queries when migrating between tsdb and non-tsdb stores since both handle query sharding differently. For e.g., if the prev schema is `boltdb-shipper` and starting today, `tsdb` index is being used, so if we do a query `sum(rate({foo="bar"}[24h])` even with start and end within `tsdb` range, we will fail the query with error `incompatible index shard` if dynamic sharding goes with shard factor other than `32`(default shard factor in ingester for inverted index). The reason being the `range` here is `24h` which causes us to process data from previous schema as well. This PR takes care of the issue by factoring in `range` and `offset` in the queries while looking for schema config for query sharding. Checklist - [x] `CHANGELOG.md` updated	2 years ago
Leonardo Taccari	74906222c6	[helm] Release 3.6.1 to reintroduce PrometheusRule alerts (#7873 ) Commit `30caf142b2` introduced a regression ending up in generating no PrometheusRule alerts. That was fixed in commit `433d883fcd` but no releases were done. Bump version to have a release about it. What this PR does / why we need it: Which issue(s) this PR fixes: Should hopefully fix a request done by @xinbinhuang - who spotted and fixed this problem, thanks! - in #7860. I think it is important to tag a release ASAP because stopping having alerts can be a regression in possible production environments. Special notes for your reviewer: I have no idea if that will force to release a 3.6.1 Helm release without doing any tag or similar, sorry! I have tried to skim documentation about that and I have skimmed `.github/workflows/helm-release.yaml` and `grafana/helm-charts/.github/workflows/update-helm-repo.yaml@main` and I think that this will create a tag... but I'm not super-sure about that! If I've missed anything please let me know! Thanks! Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
dependabot[bot]	819112ba62	build(deps): bump cloud.google.com/go/bigtable from 1.3.0 to 1.18.1 (#7850 ) Bumps [cloud.google.com/go/bigtable](https://github.com/googleapis/google-cloud-go) from 1.3.0 to 1.18.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/googleapis/google-cloud-go/releases">cloud.google.com/go/bigtable's releases</a>.</em></p> <blockquote> <h2>bigtable: v1.18.1</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/bigtable/v1.18.0...bigtable/v1.18.1">1.18.1</a> (2022-12-02)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>bigtable:</strong> downgrade some dependencies (<a href="`754015236d`">7540152</a>)</li> </ul> <h2>bigtable: v1.18.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/bigtable/v1.17.0...bigtable/v1.18.0">1.18.0</a> (2022-11-10)</h2> <h3>Features</h3> <ul> <li><strong>bigtable:</strong> Add support for request stats (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/6991">#6991</a>) (<a href="`609421e87f`">609421e</a>)</li> </ul> <h2>securitycenter: v1.17.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/securitycenter/v1.16.0...securitycenter/v1.17.0">1.17.0</a> (2022-11-16)</h2> <h3>Features</h3> <ul> <li><strong>securitycenter:</strong> Add files field to finding's list of attributes (<a href="`ac0c5c2122`">ac0c5c2</a>)</li> </ul> <h2>securitycenter: v1.16.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/securitycenter/v1.15.0...securitycenter/v1.16.0">1.16.0</a> (2022-11-03)</h2> <h3>Features</h3> <ul> <li><strong>securitycenter:</strong> rewrite signatures in terms of new location (<a href="`3c4b2b3456`">3c4b2b3</a>)</li> </ul> <h2>compute: v1.13.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/compute/v1.12.1...compute/v1.13.0">1.13.0</a> (2022-12-01)</h2> <h3>Features</h3> <ul> <li><strong>compute:</strong> start generating stubs dir (<a href="`5d0b405033`">5d0b405</a>)</li> <li><strong>compute:</strong> Update Compute Engine API to revision 20221101 (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/751">#751</a>) (<a href="`7231644e71`">7231644</a>)</li> </ul> <h2>documentai: v1.13.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.12.0...documentai/v1.13.0">1.13.0</a> (2022-12-01)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> added field_mask field in DocumentOutputConfig.GcsOutputConfig in document_io.proto (<a href="`2a0b1aeb16`">2a0b1ae</a>)</li> </ul> <h2>documentai: v1.12.0</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/googleapis/google-cloud-go/blob/main/documentai/CHANGES.md">cloud.google.com/go/bigtable's changelog</a>.</em></p> <blockquote> <h1>Changes</h1> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.12.0...documentai/v1.13.0">1.13.0</a> (2022-12-01)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> added field_mask field in DocumentOutputConfig.GcsOutputConfig in document_io.proto (<a href="`2a0b1aeb16`">2a0b1ae</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.11.0...documentai/v1.12.0">1.12.0</a> (2022-11-16)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> added TrainProcessorVersion, EvaluateProcessorVersion, GetEvaluation, and ListEvaluations v1beta3 APIs feat: added evaluation.proto feat: added document_schema field in ProcessorVersion processor.proto feat: added image_quality_scores field in Document.Page in document.proto feat: added font_family field in Document.Style in document.proto (<a href="`ac0c5c2122`">ac0c5c2</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.10.0...documentai/v1.11.0">1.11.0</a> (2022-11-09)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> added font_family to document.proto feat: added ImageQualityScores message to document.proto feat: added PropertyMetadata and EntityTypeMetadata to document_schema.proto (<a href="`9c5d6c857b`">9c5d6c8</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.9.0...documentai/v1.10.0">1.10.0</a> (2022-11-03)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> rewrite signatures in terms of new location (<a href="`3c4b2b3456`">3c4b2b3</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.8.0...documentai/v1.9.0">1.9.0</a> (2022-10-25)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> start generating stubs dir (<a href="`de2d18066d`">de2d180</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.7.0...documentai/v1.8.0">1.8.0</a> (2022-09-21)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> rewrite signatures in terms of new types for betas (<a href="`9f303f9efc`">9f303f9</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.6.0...documentai/v1.7.0">1.7.0</a> (2022-09-19)</h2> <h3>Features</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="`4ec9eed76b`"><code>4ec9eed</code></a> chore: release storage 1.18.1 (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4984">#4984</a>)</li> <li><a href="`e17334d1fe`"><code>e17334d</code></a> fix(storage): don't assume auth from a client option (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4982">#4982</a>)</li> <li><a href="`0f7457c6a9`"><code>0f7457c</code></a> chore(all): auto-regenerate gapics (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4977">#4977</a>)</li> <li><a href="`d28ba7868b`"><code>d28ba78</code></a> test(spanner): fix flaky TestIntegration_StartBackupOperation test (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4978">#4978</a>)</li> <li><a href="`5edfd3693b`"><code>5edfd36</code></a> chore: release spanner 1.26.0 (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4751">#4751</a>)</li> <li><a href="`090cc3ae0f`"><code>090cc3a</code></a> chore(all): auto-regenerate gapics (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4972">#4972</a>)</li> <li><a href="`acece394a3`"><code>acece39</code></a> chore(all): update all (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4971">#4971</a>)</li> <li><a href="`309b59e583`"><code>309b59e</code></a> fix(internal/godocfx): only put TOC status on mod if all pkgs have same statu...</li> <li><a href="`3441e1f1b6`"><code>3441e1f</code></a> test(bigtable): abbrviate instance and cluster names to avoid length overrun ...</li> <li><a href="`26dff4fca8`"><code>26dff4f</code></a> chore: release storage 1.18.0 (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4951">#4951</a>)</li> <li>Additional commits viewable in <a href="https://github.com/googleapis/google-cloud-go/compare/dlp/v1.3.0...storage/v1.18.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=cloud.google.com/go/bigtable&package-manager=go_modules&previous-version=1.3.0&new-version=1.18.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Rutger	17517bfea8	Promtail: Fix broken promtail-debug docker image (#7852 ) What this PR does / why we need it: The 'grafana/loki-build-image' version was not specified for the promtail-debug docker image, resulting in a ~6 month old 'latest' image as a build image. Updating this resulted in one more change: the newer version has a different location for the 'dlv' binary. The promtail-debug image would also hang waiting for a connection when ran, this adds the same flag, `--continue`, as added to the loki debug file in #1372. Special notes for your reviewer: I was interested in using the `-server.profiling_enabled=true` flag, to enable pprof endpoints, and scrape with phlare. This flag is not available in the non-debug version. Therefore I do not really care for attaching a debugger right away. Open to removing that change though. Checklist - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago

1 2 3 4 5 ...

4347 Commits (dad39f7ea67be378401ccbd846da450dca039bc7) All Branches Search

4347 Commits (dad39f7ea67be378401ccbd846da450dca039bc7)

All Branches