apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Salva Corts	df4461d712	Evenly spread memcached across nodes (#7183 ) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: This PR enables the [TopologySpreadConstraints](https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/) for Memcached chunks cache introduced at https://github.com/grafana/jsonnet-libs/pull/832. Now the chunks cache will be evenly spread across nodes but more than one cache can run on the same node. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [ ] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Karsten Jeschkies	a1dce32d9a	Abide to Mixin linting rules. (#7010 ) Cloud integrations need to pass linting rules such as proper dashboard names. It should be `Data Source` not `datasource`. See also grafana/cloud-onboarding#2228	3 years ago
Owen Diehl	12ebd33f94	TSDB indexBuckets helper logs instead of errors (#7187 ) indexBuckets will return the list of overlapping TSDB buckets for a time range. Historically, this errored when there was no overlap, which is generally impossible. While mutating period configurations as a test (which should never be done in production), I realized this would preemptively error us when there were old TSDB WALs from a bucket that no longer belonged to a TSDB period (i.e. by replacing a `tsdb` index with a `boltdb-shipper` one). This PR changes this to a log line instead as we don't need to error and stop computation; it's better to return an empty overlap instead. Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	3 years ago
MiggL	1e22b14430	Helm: Bump helm chart patch version (#7184 ) What this PR does / why we need it: Bumps the helm chart version to trigger a release for #7182	3 years ago
Owen Diehl	f1114fd221	[Bugfix] TSDB index bucket calculation (#7178 ) When calculating the index buckets a chunk belongs to, we shouldn't error when a bucket falls outside the current TSDB store's periodConfig range. This can happen when a chunk is written across the bounds between a previous index type (i.e. boltdb-shipper) and a new tsdb type or vice versa. Instead of erroring when this happens, we'll now correctly return only the buckets matching the TSDB store (the other buckets are handled by their respective stores). I think we can also remove the error from this function signature, although I left it in as it's conceivably helpful in the case of a chunk range that doesn't overlap at all with the store (which shouldn't happen). Dependent on https://github.com/grafana/loki/pull/7177	3 years ago
Owen Diehl	85e8f00958	fixes azure client secret duplicate CLI registration (#7185 ) Fixes duplicate key registration from https://github.com/grafana/loki/pull/7179/files#diff-665c7ce7ef736bdf9f9da76a8e389d5b6fcdc90099db913ce36b4c0da2a97ef2R121-R122	3 years ago
MiggL	62f0596afe	Helm: Fix limits_config key in helm values file (#7182 )	3 years ago
Owen Diehl	ab24efe1bf	allow backup store metrics registration by including backend type in labels (#7177 ) The refactor [here](https://github.com/grafana/loki/blob/main/pkg/storage/store.go#L237) introduced in https://github.com/grafana/loki/pull/7154 will cause a panic due to duplicate registration via the same store prefix when using a backup index store (for use during tsdb migrations). This PR adds more granularity to the label value to differentiate these and avoid the problem.	3 years ago
Vladyslav Diachenko	7f629c8849	[loki] Azure auth using Service Principal (#7179 ) This PR adds the ability to use Service Principal credentials to authenticate through Azure OAuth. It might be needed when we want to access Azure Blob storage from another tenant. Previously we could use only StorageAccount key that can not be used cross-tenant.	3 years ago
Owen Diehl	2766e0a8c7	fixes nil interface value with non-nil type in cache construction (#7175 ) Fixes a bug introduced in https://github.com/grafana/loki/pull/7013 This will panic when the interface's _value_ is nil because it's been assigned a concrete type already and then passed as an interface. Instead, we treat it as a nil interface with no type bound to it: ``` panic: runtime error: invalid memory address or nil pointer dereference goroutine 40570 [running]: github.com/grafana/loki/pkg/util/server.onPanic({0x2209320, 0x3dfae20}) /src/enterprise-logs/vendor/github.com/grafana/loki/pkg/util/server/recovery.go:41 +0x53 github.com/grafana/loki/pkg/util/server.glob..func1.1.1() /src/enterprise-logs/vendor/github.com/grafana/loki/pkg/util/server/recovery.go:29 +0x3a panic({0x2209320, 0x3dfae20}) /usr/local/go/src/runtime/panic.go:838 +0x207 github.com/grafana/loki/pkg/storage/stores/indexshipper/compactor/generationnumber.(GenNumberLoader).getCacheGenNumber(0x0, {0xc0081e14d7, 0x2}) /src/enterprise-logs/vendor/github.com/grafana/loki/pkg/storage/stores/indexshipper/compactor/generationnumber/gennumber_loader.go:120 +0x60 github.com/grafana/loki/pkg/storage/stores/indexshipper/compactor/generationnumber.(GenNumberLoader).getCacheGenNumbersPerTenants(0x2?, {0xc000e8c4d0?, 0x1, 0x0?}) /src/enterprise-logs/vendor/github.com/grafana/loki/pkg/storage/stores/indexshipper/compactor/generationnumber/gennumber_loader.go:98 +0xe7 github.com/grafana/loki/pkg/storage/stores/indexshipper/compactor/generationnumber.(*GenNumberLoader).GetResultsCacheGenNumber(0x2b26298?, {0xc000e8c4d0?, 0xc0050ad080?, 0x2dcdeeb9bcc040e4?}) ```	3 years ago
Trevor Whitney	4b6df86333	Add local k3d environment for enterprise-logs (#7146 ) What this PR does / why we need it: This adds a local k3d based development cluster for testing out the enterprise logs side of the helm chart, which can be enabled by setting: ``` enterprise: enabled: true ``` It requires both the `gex-plugins` and `enterprise-logs` repos to be checked out locally (though the latter soon will not be needed once the provisioner is published). We need this environment when developing enterprise features for the helm chart.	3 years ago
Jarjar	41861bdacb	Helm: Allows loki s3 http_config block to be configured (#7041 ) What this PR does / why we need it: This will allow users of the chart to configure the s3 http_config block as documented here [https://grafana.com/docs/loki/latest/configuration/#s3_storage_config](https://grafana.com/docs/loki/latest/configuration/#s3_storage_config) through values. Which issue(s) this PR fixes: Fixes grafana/helm-charts#1762 Checklist - [x] Documentation added - [x] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: CAJNA Jarod <contact@jarodcajna.fr>	3 years ago
Danny Rehelis	180a93e430	Helm: Make server configuration configurable (#7137 ) What this PR does / why we need it: Expose server configuration to be configurable with Helm values Checklist - [x] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>	3 years ago
Mohamed-Amine Bouqsimi	c9ea27532f	operator: Fix TLSProfile not working on vanilla k8s (#7167 )	3 years ago
Trevor Whitney	d972e77ae2	Expose limits and compactor config via helm values (#7108 ) What this PR does / why we need it: Exposes the compactor and limits config in the helm chart via helm values. Replaces https://github.com/grafana/loki/pull/7055 with some minor stylistic changes, and moving default limits into the new `limits_config` value.	3 years ago
Trevor Whitney	35003f3da0	Fix minio values, reduce replicas, and fix tokengen job (#7147 ) What this PR does / why we need it: This PR fixes a few small things with the helm chart: * After upgrading to the new minio chart, the subvalues for that chart were not correctly changed to the new values for `rootUser` and `rootPassword` * The default replica count for the new minio chart is 16, which seems a little much for our needs. * The `grafana-token` created by the tokengen job was meant to be used when configuring the GEL plugin, but it was not working, so I removed it.	3 years ago
Trevor Whitney	a6101f47ac	Update GEL helm deployment example (#7144 ) What this PR does / why we need it: This update the example for deploying a GEL cluster using the new helm chart. The previous example was a bit out of date.	3 years ago
Chris Hodges	d1f42fff50	promtail: Fix issue with dropping logs when a file based SD target's labels are updated (#7016 ) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: Allows for modifying labels for a target and continuing to scrape logs afterwards. Which issue(s) this PR fixes: Fixes #7001 Special notes for your reviewer: <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [ ] Documentation added - [x] Tests updated - [x] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Travis Patterson	071118a090	revert stream push error response (#7160 ) We've changed approaches to how we want to do per-stream rate limiting. The new approach will rely on creating an api on the ingester so the distributors can decide how streams should be sharded. As a result, the work to return rate-limited streams in the error body is no longer needed.	3 years ago
Robert Jacob	a95e900a76	operator: Skip enforcing matcher for certain tenants on OpenShift (#7037 )	3 years ago
Robert Jacob	d21f0d3725	operator: Manage global stream-based retention (#7106 )	3 years ago
Sandeep Sukhani	c8c8303a6a	refactor index storage code to index reader/writer interfaces for better monitoring (#7154 ) What this PR does / why we need it: Currently, it is hard to monitor just the index latencies since the chunks PUT code is coupled with both object storage and index writer. This PR refactors the code to have separate interfaces defined for index readers/writers. I have also added a wrapper called `monitoredReaderWriter`, which measures the latency on the index operations. Special notes for your reviewer: Cortex had added `PutChunksAndIndex` for DynamoDB, which would write both chunks and index in a single request when configured for storing both. I have removed the use of it since it would be too complex to support it with this refactoring. Loki, anyways does not recommend using chunks in the index store, and using a hosted object storage would be much cheaper. Also, this is not a breaking change, it might somewhat impact the performance of flushing the chunks. Co-authored-by: Owen Diehl <ow.diehl@gmail.com>	3 years ago
Ashwanth	88503ae2e1	tsdb: clean-up metrics (#7150 ) What this PR does / why we need it: clean-up unused tsdb metrics and refactor others to use a `CounterVec` Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>	3 years ago
李国忠	a290549a59	Promtail: Add support for max stream limit (#7101 ) What this PR does / why we need it: Add Promtail support to a new feature/configuration named `max_stream_limit` * This new feature limits the max number of streams Promtail can materialize. The new feature is also useful to avoid OOMing Promtail Which issue(s) this PR fixes: Fixes #6968	3 years ago
Kaviraj Kanagaraj	6f0690e7bf	fix(ruler): Initialize multi remote clients config (#7151 ) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: To be backward compatible with single client config. ``` ts=2022-09-14T08:24:04.549961234Z caller=memberlist_logger.go:74 level=debug msg="Initiating push/pull sync with: 10.132.18.167:7946" │ │ panic: assignment to entry in nil map │ │ goroutine 1 [running]: │ │ github.com/grafana/loki/pkg/ruler.NewRuler({{{0xc00002a120}, {0x0, 0x0, 0x0}, {0x6400000, 0x6400000, {0x0, 0x0}, 0x0, 0x0, ...}, ...}, ...}, ...) │ │ /src/enterprise-logs/vendor/github.com/grafana/loki/pkg/ruler/ruler.go:21 +0x1b7 ``` Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [ ] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Brian Evans	e7acb5356b	Docs: Fix template function examples (#7148 ) Some examples only had a single open brace, but require two. I added the missing braces. What this PR does / why we need it: Improves documentation, helps users who are reading docs about template functions.	3 years ago
Karol Bakunowski	4e7e51ceb5	Remove duplicated `loki_boltdb_shipper` prefix from `tables_upload_operation_total` metric (#7040 ) This PR removes the duplicated `loki_boltdb_shipper` prefix from the `tables_upload_operation_total` metric.	3 years ago
Travis Patterson	3f0ecd3c7b	Implement all-or-nothing stream ingestion (#7094 ) Per-stream sharding will introduce automatic stream sharding on rate-limited streams. The ingester's current line-by-line behavior may result in duplicates when a partially-accepted stream is resharded and sent to other ingesters. This PR makes the ingester either rate limit the entire stream before attempting to write lines to a chunk. The PR 1. Separates validation, storage, and wal replay into their own functions 2. Implements a flag to rate limit the whole stream or not 3. Checks rate limits for the whole stream rather than line-by-line 4. Returns an error with information on the whole stream when rate limited	3 years ago
李国忠	461f844044	[bugfix] fix query_frontend init fail error (#7013 ) Co-authored-by: Ashwanth <iamashwanth@gmail.com>	3 years ago
Sandeep Sukhani	61794710a7	tsdb: boltdb shipper backup store tsdb (#7130 ) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: Since we are planning to start deploying `tsdb` to critical cells, we want to have a disaster recovery without any data loss. This PR adds support to `tsdb` store itself to configure `boltdb-shipper` as a backup chunk writer. When the flag is enabled, `tsdb` store would also index chunks in `boltdb-shipper` index store with table names set to `<configured-tsdb-table-prefix>`+`backup_`+`<table-number>`. This is the simplest option that I can come up with without maintaining a lot of code and we can simply drop the support before marking `tsdb` as production ready. The rollback/recovery plan would just be to change the schema config to use `boltdb-shipper` as index store with `<configured-tsdb-table-prefix>`+`backup_` as prefix like below: tsdb enabled: ``` schema_config: configs: - from: 2022-01-01 store: boltdb-shipper index: prefix: index_ - from: 2022-09-10 store: tsdb index: prefix: index_ ``` rollback: ``` schema_config: configs: - from: 2022-01-01 store: boltdb-shipper index: prefix: index_ - from: 2022-09-10 store: boltdb-shipper index: prefix: index_backup_ ``` <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [x] Tests updated	3 years ago
Periklis Tsirakidis	630a491580	loki: Attach the panic recovery handler on all HTTP handlers (#6780 )	3 years ago
Julien Pinsonneau	ef97c1df2f	operator: Add network tenant for netobserv (#6769 )	3 years ago
Periklis Tsirakidis	16d4f874f0	operator: Fix flaky TLSProfile feature gate test (#7131 )	3 years ago
Guilherme Marz Vazzolla	c491e68c92	Docs: Fix Helm chart link path (#7107 ) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: Fix the link path leading to Loki's Helm chart, in `production/README.md`. [Current broken link](https://github.com/grafana/loki/blob/main/production/production/helm/loki/README.md). Special notes for your reviewer: Hey @trevorwhitney, just found out the broken link added by #6985. <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [ ] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	3 years ago
Travis Patterson	ef47e0ee8a	Fix errors loading deletes after force-removing partially-completed delete (#7125 ) When sharded deletes that are partially completed are force-removed, everything is removed except the shards that are currently being deleted. The shards being deleted aren't necessarily in numerical order so there's no way to know assume which shards have and haven't been deleted. The Delete store assumed it could look up requests in sequential order and returned empty requests where there were gaps in the stored data. This change takes the `sequence number` from the stored key of the delete requests it finds and uses that to look up details.	3 years ago
Trevor Whitney	1407f0f43d	Bump chart version to test release (#7124 ) What this PR does / why we need it: Bumps the helm chart version to trigger a release to test if that action is fixed.	3 years ago
Trevor Whitney	18a443f999	Fix helm release name template (#7123 ) What this PR does / why we need it: The helm release job is failing because it's looking for the wrong release name. This is an attempt to fix it. Special notes for your reviewer: The addition of `on: pull_request` to the github action is a temporary hack so I can test if this fixes the issue. Please don't merge until we have a chance to remove that.	3 years ago
Michel Hollands	accb5e1ca2	Log the interval of a delete request (#7120 ) What this PR does / why we need it: An interval is generated automatically for a delete request: this is the max size of a shard of a deletion request. This value is now logged. Additionally a setting name that should have been renamed was fixed. Checklist - [ ] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago
Trevor Whitney	cf94dac37b	Make helm with style more consistent (#7096 ) What this PR does / why we need it: Small helm style fix to be more consistent across templates when checking an `enabled` flag in a nested struct.	3 years ago
Trevor Whitney	637315779a	Fix pod affinity selector for single binary (#7109 ) What this PR does / why we need it: Fix incorrect selectors for anti-affinity rules for loki single binary. Which issue(s) this PR fixes: Fixes #7105	3 years ago
Michel Hollands	ebdb64b3f5	Small updates to the deletion documentation (#7112 ) What this PR does / why we need it: - Fix a typo - Fix the links in for the deletion API Checklist - [X] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago
Kaviraj Kanagaraj	2c9fa05c29	feat(loki-canary): Add support to push logs directly to Loki. (#7063 ) Add additional `push` mode to loki-canary, which pushes the logs directly to given Loki URL as it generates logs. The real function of Loki Canary is to act like a tenant and help us know the whether Loki installation is working as perceived by a real tenant. Main rationale for this additional push mode is to make canary more standalone without needing for `promtail` (or `grafana-agent`) to scrape it's logs and send to loki, with this change, Loki canary happily tests Loki behavior without needing any other dependencies. NOTES: 1. If you run Loki behind any proxy that has different authorization policies to READ or WRITE to Loki, then important change that canary operator need to be aware of it, now the user credentials they pass via `-user` and `-pass` to access loki endpoints need to have both `read' and `write` permissions (previously canary just query the logs where as promtail is the one pushes the logs, so just READ permissions was sufficient). 2. There will be follow up PR(s) to cleanup, particularly `reader` and `comparitor` component in terms of logging with proper logger. Rationale is to keep the changes small per PR to make it easy to review. 3. This changes were tested it in one of the internal Loki dev cell. 4. This PR is a no-op if this new `push` flag is disabled (it's disabled by default) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> Co-authored-by: Danny Kopping <danny.kopping@grafana.com>	3 years ago
Mohamed-Amine Bouqsimi	3d4788fb51	Add ability for Ruler to remote write to multiple clients (#6823 )	3 years ago
Old Schepperhand	96623440c9	docs: fix alertmanager_client config settings (#6858 ) when setting ``` basic_auth: username: xxx password: yyy ``` following error gets thrown: ``` failed parsing config: /etc/loki/loki-config.yaml: yaml: unmarshal errors: line 123: field basic_auth not found in type base.NotifierConfig ``` <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [ ] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Trevor Whitney	7d750ea564	Add chart-tools and chart-releaser for helm (#7095 ) What this PR does / why we need it: Adds the `chart-tools` and `chart-releaser` binaries to the nix shell for doing helm releases/testing.	3 years ago
Guilherme Marz Vazzolla	57a1193d93	Docs: Fix Helm Chart links (#6985 ) What this PR does / why we need it: - Fix the link pointing to a Loki Helm chart, found in the [Contribute to Helm](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md#contribute-to-helm) section of the [CONTRIBUTING.MD](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) file. - Fix the link pointing to a Promtail Helm chart, found in the [Using Helm to deploy on Kubernetes](https://github.com/grafana/loki/blob/main/production/README.md#using-helm-to-deploy-on-kubernetes) section of the [production/README.md](https://github.com/grafana/loki/tree/main/production) file. The previous links used were pointing to a [deprecated file](https://github.com/grafana/loki/tree/main/production/helm). Special notes for your reviewer: None. <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [X] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	3 years ago
Pablo	76c1198d58	Improvements to Promtail GCP push target (#7057 ) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: This PR includes some pending improvements to newish promtail GCP push target: - Pending low hanging optimization for replacing a regex that gets evaluated on every incoming request from GCP, for a simpler solution. [Related comments](https://github.com/grafana/loki/pull/6777#discussion_r935804383) - Some small refactors. See: [this](https://github.com/grafana/loki/pull/6777#pullrequestreview-1059064564) - Add some validations over the payload the target receives. Payload details are [here](https://cloud.google.com/pubsub/docs/push). This PR adds just validation over the log line, the incoming GCP message ID to add some traceability if needed, and the subscription name because it can be used as label. - Add `subscription` GCP payload field as label, which includes the PubSub subscription identifier. - Add `cause` label to error metrics. Since there's multiple failure point this might help debugging / notice strange behaviours. Also, by running the push target in some dev workloads, we noticed it has some labels different to the ones added in the pull target. This PR also refactors the logic to re-use the same GCP log entry parsing logic in both targets. That way the labels exposed to the user in the push target are $Labels_{pull} \cup Labels_{push}$. Which issue(s) this PR fixes: Related to: https://github.com/grafana/cloud-onboarding/issues/2067 Special notes for your reviewer: This PR is a follow up [this other one](https://github.com/grafana/loki/pull/6777). It works on some comments made after merge, and adds some changes we saw necessary upon running this target in real environments. <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [x] Documentation added - [x] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>	3 years ago
Karsten Jeschkies	947d0f1cbf	Automatically label Helm realted pull requests. (#7083 ) What this PR does / why we need it: Labelling Helm related pull requests with `area/helm` will ease discovery. Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>	3 years ago
Adam Strawson	4d46cf5dd9	Missing conditional on ServiceMonitor (#7067 ) What this PR does / why we need it: Affects the Loki Helm chart The ServiceMonitor resource was missing a conditional for the `enabled` flag, as per the other monitoring resources. Which issue(s) this PR fixes: Fixes #7066 Checklist - [ ] Documentation added - [ ] Tests updated - [ ] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Trevor Whitney	3990b13a25	Only release helm for helm paths (#7093 ) What this PR does / why we need it: Only need to run the helm release action when helm paths were changed	3 years ago

1 2 3 4 5 ...

3943 Commits (df4461d712b8a101006f4a0345a8f7cff0e45f91) All Branches Search

3943 Commits (df4461d712b8a101006f4a0345a8f7cff0e45f91)

All Branches