apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Ed Welch	e21b525674	Loki: increase the limit for query length from 5k to 128k (#11701 ) What this PR does / why we need it: We originally added this limit from fuzz testing and realizing there should be some maximum limit to an allowed query size. The original limit was 5120 based on some internet searching and a best estimate of what a reasonable limit would be. We have seen use cases with queries containing a lot of filter expressions or long expanded variable names where this limit was too small. Apparently the spec does not specify a limit, and more internet searching suggests almost all browsers will handle 100k+ length urls without issue Some limit here still seems prudent however, so the new limit is now 128k. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`) --------- Signed-off-by: Edward Welch <edward.welch@grafana.com>	1 year ago
Daniel Vaz	dc1cb52149	Add capability to disable specific alert rules Loki (#11241 ) What this PR does / why we need it: Currently using the Loki Chart we can only either enable\disable ALL alert rules. For specific environments and use-cases sometimes not all alert Rules are useful to have enabled. With this PR change, we can cleanly and through the Chart values disable specific Alerts.	1 year ago
Christian Haudum	bdcb69540f	Bloom gateway: Add metrics for store operations and chunk ref counts (#11677 ) For better observability of the bloom gateway, this PR adds two additional metrics that expose the amount of chunk refs pre and post filtering. This can be used to calculate the filter ratio of the gateways. The PR also adds a metric that observes the latency of the actual processing time of bloom filters within the worker. --------- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	1 year ago
Trevor Whitney	96839fadd1	fix: remove shared state noParserHints to avoid data race (#11685 ) What this PR does / why we need it: A data race introduced in https://github.com/grafana/loki/pull/11587 was caught in the [backport to k184](https://github.com/grafana/loki/pull/11668). This removes the shared state of a single global `noParserHints` in favor of creating an empty `Hint` object for each label builder, since the `Hints` is keeping state of `extracted` and `requiredLabels`.	1 year ago
Derek Cadzow	cf6d43068f	Update MAINTAINERS.md (#11666 ) What this PR does / why we need it: Removed the name of a departed employee from the maintainers list. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`) Co-authored-by: J Stickler <julie.stickler@grafana.com>	1 year ago
Ashwanth	51899b521b	feat(metadata cache): adds max_metadata_cache_freshness (#11682 ) What this PR does / why we need it: Adds `max_metadata_cache_freshness` to limit the metadata requests that get cached. When configured, only metadata requests with end time before `now - max_metadata_cache_freshness` are cacheable. _reason for setting the default to 24h?_ metric results cache can [extract samples for the desired time range from an extent](`b6e64e1ef1/pkg/querier/queryrange/queryrangebase/results_cache.go (L78)`) since the samples are associated with a timestamp. But the same is not true for metadata caching, it is not possible to extract a subset of labels/series from a cached extent. As a result, we could return inaccurate results, more that what was requested. for ex: returning results from an entire 1h extent for a 5m query Setting `max_metadata_cache_freshness` to 24h should help us avoid caching recent data. For anything older, we would report cached metadata results at a granularity controlled by `split_metadata_queries_by_interval` Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`)	1 year ago
Kaviraj Kanagaraj	86f2001c39	chore(promtail): Use minimal init config in rpm/deb packaging. (#11511 ) Related issue: https://github.com/grafana/loki/issues/11398 This minimal config scrape only single file thus not overloading the systems as described in the issue	1 year ago
Periklis Tsirakidis	0065fd6e95	operator: Refactor CreateOrUpdateLokiStack handler (#11592 ) Co-authored-by: Robert Jacob <xperimental@solidproject.de>	1 year ago
Alexey Solodkiy	edba360e43	Update query_examples.md (#11670 ) Co-authored-by: J Stickler <julie.stickler@grafana.com>	1 year ago
Vladyslav Diachenko	a5aa8b315d	[bloom-compactor] downloading chunks in batches (#11649 ) What this PR does / why we need it: Added chunks batches iterator to download chunks in batches instead of downloading all of them at once. Otherwise, when the stream contains a lot of chunks, it can lead to OOM. Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`) --------- Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>	1 year ago
Dreamy	6ae46dc6ef	helm: added missing namespace to query-scheduler-discovery service (#11648 ) What this PR does / why we need it: This PR adds the namespace attribute to the query-scheduler-service descriptor because it is needed when deploying loki in non-default namespace Which issue(s) this PR fixes: Fixes #10048 Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) I hope I did everything right with the changelog, chat and readme updates since this my first PR, please tell me if something needs fixing.	1 year ago
Joao Marcal	c7ad168a33	operator: updates mixins to fix structured metadata dashboards (#11671 )	1 year ago
Joao Marcal	0694d797de	mixins: add route to write Distributor Latency dashboard (#11637 ) Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>	1 year ago
Salva Corts	ef75ba35d6	Deprecate and flip -legacy-read-mode to false by default (#11665 ) What this PR does / why we need it: This PR addresses a pending TODO to flip the value of the `-legacy-read-mode` to false by default. We also deprecate it as we plan to remove it after Loki 3.0.	1 year ago
Cyril Tovena	5517eaa1b8	feat: Add tracing integration to profiling. (#11633 ) Same as https://github.com/grafana/tempo/pull/3276 this adds profiling integration to tracing instrumentation allowing to get profile for a single request removing the noise of everything else.	1 year ago
Christian Haudum	6bcac00c70	Add e2e tests for bloom filtering (#11645 ) What? This PR adds an end-to-end integration test for creating bloom filters and using them in the gateway to filter chunks. Why? This test helped to identify bugs in the bloom shipper code that would have taken a very long time to discover in other ways, such as deploying to a dev environment or running a long-running docker compose setup. Notes The following commits of this PR are actual changes to the compactor/gateway code to make e2e test work: * `2dcc761ba0` * `84052ddb34` * `3ba44f83c8` The bloom gateway code path for processing blocks was cleaned up, because it still contained the unused "sequention processing" path of blocks, which was initially kept to verify the callback based processing works alike: * `f55d79b84f` --------- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	1 year ago
Trevor Whitney	9759c130fe	fix: align semantics of metric and log query label extraction (#11587 ) both metric and log queries use the first extracted label when multiple values are requested for the same label Fixes #11647	1 year ago
Salva Corts	9287c93dd3	Support bloom compactor and gateway in SSD mode (#11661 ) What this PR does / why we need it: This PR fixes adds support for running the bloom compactor and gateway in SSD mode. If `legacy-read-mode` is `true` (default): - `write` runs: Ingester, Distributor. - `read` runs: QueryFrontend, Querier, QueryScheduler, Ruler, Compactor, IndexGateway, BloomGateway, BloomCompactor. Otherwise: - `write` runs: Ingester, Distributor. - `read`: QueryFrontend, Querier. - `backend`: QueryScheduler, Ruler, Compactor, IndexGateway, BloomGateway, BloomCompactor. I tested this out with a local SSD deployment and seems to be building blooms fine (when bloom compactor is enabled). ``` $ tree .data/minio/loki-data/bloom -I "meta" -I "part" -L 5 .data/minio/loki-data/bloom └── index_19733 └── docker ├── blooms │ ├── 38dad41ad5f1b79-fe294823bd539109 │ │ ├── 1704976430461-1704978045667-7e33bf85 │ │ ├── 1704976430461-1704978922898-dd3be57e │ │ ├── 1704976430461-1704979829636-33ae0d37 │ │ ├── 1704976430461-1704980743484-33ae0d37 │ │ ├── 1704976430461-1704981642000-33ae0d37 │ │ └── 1704976430461-1704982541351-33ae0d37 │ ├── 437383945fca166-f5ebd41d2edc508f │ │ ├── 1704976430460-1704978044909-b2767d8c │ │ ├── 1704976430460-1704978923151-183db34c │ │ ├── 1704976430460-1704979833202-183db34c │ │ ├── 1704976430460-1704980745263-183db34c │ │ ├── 1704976430460-1704981641237-183db34c │ │ └── 1704976430460-1704982542614-183db34c │ └── 46938d684d3cf87-fd4f06a77900049a │ ├── 1704976430447-1704978045918-ba691f3c │ ├── 1704976430447-1704978045918-fe558bee │ ├── 1704976430447-1704978921878-de5e8dc0 │ ├── 1704976430447-1704979833964-de5e8dc0 │ ├── 1704976430447-1704980744753-de5e8dc0 │ ├── 1704976430447-1704981640725-de5e8dc0 │ └── 1704976430447-1704982541858-de5e8dc0 └── metas ├── 38dad41ad5f1b79-fe294823bd539109-1704976430461-1704978045667-1d179deb ├── 38dad41ad5f1b79-fe294823bd539109-1704976430461-1704978045667-1f3b9273 ├── 38dad41ad5f1b79-fe294823bd539109-1704976430461-1704978922898-296c7d14 ├── 38dad41ad5f1b79-fe294823bd539109-1704976430461-1704979829636-a3833f21 ├── 38dad41ad5f1b79-fe294823bd539109-1704976430461-1704980743484-8abbc022 ├── 38dad41ad5f1b79-fe294823bd539109-1704976430461-1704981642000-7d80fe65 ├── 38dad41ad5f1b79-fe294823bd539109-1704976430461-1704982541351-cfcbb8b6 ├── 437383945fca166-f5ebd41d2edc508f-1704976430460-1704978044909-bdb8aad0 ├── 437383945fca166-f5ebd41d2edc508f-1704976430460-1704978044909-e0d7b52c ├── 437383945fca166-f5ebd41d2edc508f-1704976430460-1704978923151-692d2033 ├── 437383945fca166-f5ebd41d2edc508f-1704976430460-1704979833202-d0b8c046 ├── 437383945fca166-f5ebd41d2edc508f-1704976430460-1704980745263-aa0521f ├── 437383945fca166-f5ebd41d2edc508f-1704976430460-1704981641237-87636172 ├── 437383945fca166-f5ebd41d2edc508f-1704976430460-1704982542614-dba1fd47 ├── 46938d684d3cf87-fd4f06a77900049a-1704976430447-1704978045918-8fb7a27c ├── 46938d684d3cf87-fd4f06a77900049a-1704976430447-1704978045918-e031baad ├── 46938d684d3cf87-fd4f06a77900049a-1704976430447-1704978921878-635ccc8f ├── 46938d684d3cf87-fd4f06a77900049a-1704976430447-1704979833964-376036ef ├── 46938d684d3cf87-fd4f06a77900049a-1704976430447-1704980744753-628b5958 ├── 46938d684d3cf87-fd4f06a77900049a-1704976430447-1704981640725-7cefe675 └── 46938d684d3cf87-fd4f06a77900049a-1704976430447-1704982541858-1e4de9d4 ``` Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`)	1 year ago
Salva Corts	c9c8692d21	Fix backend target in docker compose (#11663 ) What this PR does / why we need it: At https://github.com/grafana/loki/pull/9899 added the new `backend` SSD target to the docker compose we ship at `production/docker`. Later on, https://github.com/grafana/loki/pull/8836 removed it since the current stable version of Loki was 2.7.3 and `backend` was introduced with 2.8 (RC at the time of this PR). The backend target is now GA, this PR enables it back in our provided docker compose. Additionally, the following improvements/updates are made: - Move storage config from `common.storage.s3` to `storage.aws` - Remove schema period using boltdb-shipper - Update tsdb schema to latest (v13) - Expose minio web console	1 year ago
Peter Stolz	3b2278d6ff	docs: Update _index.md addressing #11575 (#11626 ) What this PR does / why we need it: It improves the docs by addressing #11575 allowing users to use the official fluent-bit helm chart over the deprecated grafana one Which issue(s) this PR fixes: Fixes #11575 Special notes for your reviewer: @JStickler wanted to take a look at this. Checklist - [ x ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ x ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`) --------- Co-authored-by: J Stickler <julie.stickler@grafana.com>	1 year ago
Poyzan	10c88aaefd	Bloom compactor/debug compacting with existing metas (#11638 ) What this PR does / why we need it: This branch was used to debug uploading and getting existing metas correctly. Uncommented functions to clean up archive directories will be addressed once debugging bloom filters is completed. The work was verified in the dev cell. --------- Co-authored-by: Paul Rogers <paul.rogers@grafana.com>	1 year ago
Danny Kopping	bcd03150c9	Query-frontend: customisable query splitting for queries overlapping `query_ingester_within` window (#11535 ) What this PR does / why we need it: The config option `query_ingesters_within` defines the window during which logs _could_ be present on ingesters, and as such queriers will send queries to ingesters instead. `split_queries_by_interval` is defined to split queries into subqueries for increased parallelism. Aggressive query splitting within the `query_ingesters_within` window can result in overloading ingesters with unnecessarily large numbers of subqueries, which perversely can impact writes. `query_ingesters_within` is set to 3h by default. In Grafana Cloud Logs we set `split_queries_by_interval` as low as 15m (defaults to 1h), which would result in result in 3*60/15=12 requests. Every querier queries every ingester during this window, so that's 12 requests _per ingester per query_ which has the `query_ingesters_within` window in its time range _(i.e. a query from now to now-7d would include the `query_ingesters_within` window as well, now-3h to now-7d would not)_. However, we _do_ want to split queries so an ingester won't have to handle a query for a full `query_ingesters_within` window - this could involve a large amount of data. To account for this, this PR introduces a new option `split_ingester_queries_by_interval` on the query-frontend; this setting is disabled by default. ![image](https://github.com/grafana/loki/assets/373762/2e671bd8-9e8d-4bf3-addf-bebcfc25e8d7)	1 year ago
Ashwanth	e915efc7f8	fix(log results cache): compose empty response based on the request (#11657 ) What this PR does / why we need it: Log results cache when handling a hit composes an empty response based on the cached request. But the limit or direction fields in the cached request need not match with the current request being served. This causes the log results cache to return a response with incorrect limit. This incorrect limit could then get applied when merging responses upstream (split by interval mw for ex.) This pr fixes this by composing the response based on the request being served. I also thought about updating the cache key to include both limit and direction to have a clear separation, but I left it as is for the following reason: if a time range contains no log lines, that result would not change irrespective of a different limit or direction Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`)	1 year ago
Robert Jacob	e7b9455327	operator: React to changes in ConfigMap used for storage CA (#11624 )	1 year ago
Danny Kopping	88aaa7dc5e	Cache: correctly check background cache size (#11654 ) What this PR does / why we need it: The size check was not being performed atomically, which led to flakiness in the `TestBackgroundSizeLimit` test. --------- Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com>	1 year ago
Karsten Jeschkies	2182bacd9d	Validate dev cluster config in CI (#11642 ) What this PR does / why we need it: The configuration in `tools/dev/loki-boltdb-storage-s3` was broken in the past because it's easy to miss. This change covers the validation in the CI to raise awareness. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`)	1 year ago
Karsten Jeschkies	88e957af58	Skip optimization for DownstreamSampleExpr (#11651 ) This fixes a four year old bug. The `optimizeSampleExpr` was switching on the wrong `DownstreamSampleExpr` type. This bug only surfaced because of the recent fix how binop expressions are executed.	1 year ago
Joao Marcal	5559b26856	operator: Fixes Ruler RBAC to allow it to send alerts to UWM AM (#11620 ) Updated RBAC now match the new updated requirements by UWM Alertmanager introduced on: https://github.com/openshift/cluster-monitoring-operator/pull/2099	1 year ago
Karsten Jeschkies	6a463664ed	Publish loki-build-image 0.33.0 for ARM as well. (#11643 ) What this PR does / why we need it: This upates the loki-build-image tag for Drone so it's also published for ARM.	1 year ago
deresolution20	37a2f73e7c	Update _index.md (#11548 ) What this PR does / why we need it: doc is confusing/lacking detail on setting up regular fluentbit container and we needed an example config for fluent-bit that works with HG Loki. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`)	1 year ago
Karsten Jeschkies	03156ed0dd	Support sharding of binary operation for non shardable side. (#11635 ) Binary expressions with one un-shardable side have been broken for quite some time. The error `unimplemented` however was shadowed by some other code. It surfaced only with a fix for an issue with `quantile_over_time` with was solved with #11629 --------- Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com>	1 year ago
Trevor Whitney	8b48a18d77	Bump build image (#11608 ) What this PR does / why we need it: Bumps alpine in the loki build image and ass the build image to the `scan-vulnerabilities` target to make it easier to scan in the future --------- Co-authored-by: Danny Kopping <danny.kopping@grafana.com>	1 year ago
J Stickler	0dc8c75331	Update admonitions to add shortcode (#11622 ) What this PR does / why we need it: Completing the work that was started in #9409 but not completed because there were multiple variations on how to format notes in the docs source files. We rolled out different colors for admonitions recently, which highlighted that there were still a few notes not using the admonition shortcode. I searched the docs for the following words: * tip * caution * important * warning * note So hopefully I've caught all of the admonitions that weren't using the shortcode.	1 year ago
Joao Marcal	4421efe32e	operator: adds AWS sts support (#11481 ) Adds support for users to configure the S3 object storage with AWS STS. Co-authored-by: Periklis Tsirakidis <periklis@nefeli.eu> Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>	1 year ago
Karsten Jeschkies	24fa648893	Do not attempt to shard quantile_over_time if feature flag is disabled. (#11628 ) What this PR does / why we need it: If `quantile_over_time` sharding is disabled the code would still shard it naively. That was a bug. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`)	1 year ago
Oğuzcan Küçükbayrak	3cb2a6b0c4	Documentation: Update template_functions.md (#11615 ) Fix incorrect example What this PR does / why we need it: Fix incorrect example in [Template functions](https://grafana.com/docs/loki/latest/query/template_functions/) Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`) Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	1 year ago
Sheikh-Abubaker	87023f4a32	[area/loki]: Added "swift" type object storage to resolve Loki HELM Chart error (#11621 ) What this PR does / why we need it: The code in https://github.com/grafana/loki/blob/main/production/helm/loki/templates/_helpers.tpl file doesn't include "swift" type object storage. when user using swift by configure `loki.storage.swift.`, then `loki.storage.type` shall = `swift` , but the "loki.isUsingObjectStorage" cannot get the proper value in this case. As of now "swift" type object storage has been added to resolve Loki HELM Chart error. Which issue(s) this PR fixes:. Fixes #11611 Special notes for your reviewer: Checklist* - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`) Signed-off-by: Sheikh-Abubaker <sheikhabubaker761@gmail.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	1 year ago
Callum Styan	3048e4af13	labels/line formatter pooling panic fix (#11607 ) Big thanks to @slim-bean, even after ~1 day of trying to find a cause here I didn't track down this issue, that I was returning something to the pool that hadn't actually been retrieved from the pool. The test here in the 2nd commit will fail if you pass the `-race` flag without the fix from the 3rd commit. --------- Signed-off-by: Callum Styan <callumstyan@gmail.com>	1 year ago
Jason Swank	d7f945c7f4	docs: Fix the link to the docker-driver documention (#11609 ) Fix the link to the docker-driver documentation. Co-authored-by: J Stickler <julie.stickler@grafana.com>	1 year ago
J Stickler	adb2089a6a	Update paths in cloud config topics (#11618 ) What this PR does / why we need it: Updates links to path for a couple of example files that were missed in the information architecture moves. Which issue(s) this PR fixes: Fixes #11617 (This is in addition to the updates in https://github.com/grafana/loki/pull/11568)	1 year ago
Danny Kopping	61a4205313	Ruler: catering for another data race in tenant config (#11612 ) Expands on #11601 What this PR does / why we need it: Turns out the previous tests didn't expose all possible causes for data races (another one occurs at `5a55158cc7/pkg/ruler/registry.go (L204)`). Moving the mutex to the calling function adds more safety. Which issue(s) this PR fixes: Fixes #11569 Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	1 year ago
Sijmen	5e50ea0a7f	Promtail: Fix excludepath not evaluated on newly added files (#9831 ) What this PR does / why we need it: In promtail, when a file matching the exclude path is created in a directory that is being watched, this file should not be tailed by promtail. However, previously this was the case. As described in #7115. This change checks the filename to the excludePath and if it matches, ignores the file. Which issue(s) this PR fixes: Fixes #7115 Special notes for your reviewer: We tested manually this by running Promtail locally and creating a bunch of files which should and should not be tailed by Promtail. Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	1 year ago
Edson C	20d1fa641d	Docs: Add a note about Loki labels format (#11597 ) What this PR does / why we need it: Which issue(s) this PR fixes: Fixes #9928 Special notes for your reviewer: This PR adds a note about an important requirement in the format of Loki labels (with a small example). Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`) --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	1 year ago
Danny Kopping	627e09365b	Restore previous behaviour of no trailing newlines in HTTP error response bodies (#11606 ) What this PR does / why we need it: #11487 introduced a regression which added trailing newlines to HTTP error response bodies, which may affect client integrations. This regression hasn't made it into the 2.9.x or 2.8.x releases yet so no backporting is necessary.	1 year ago
zry98	142d3564e6	Promtail: show a clearer reason in "disable watchConfig" log message when server is disabled (#11420 ) What this PR does / why we need it: This PR improves the clarity of log message when the Promtail server is disabled (if `server.disable` is true in config file, or flag `-server.disable` is used). Previously, the reason "promtailServer cast fail" in log message (as below) was ambiguous, leading to confusion about potential error in config file. ``` level=warn ts=2023-12-09T15:40:24.064376445Z caller=promtail.go:260 msg="disable watchConfig" reason="promtailServer cast fail" ``` The updated message is more understandable, indicating directly that the Promtail server is disabled. ``` level=warn ts=2023-12-09T15:50:58.723168763Z caller=promtail.go:260 msg="disable watchConfig" reason="Promtail server is disabled" ``` Which issue(s) this PR fixes: N/A. Special notes for your reviewer: Should we turn down the log level to INFO? Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](`d10549e3ec`) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](`0d4416a4b0`)	1 year ago
Sandeep Sukhani	46fc0bed48	deletion: delete chunk overlapping multiple tables when processing oldest table that has it indexed (#11600 ) What this PR does / why we need it: When a delete request has a line filter and/or is deleting a chunk partially, we create a new chunk from the source chunk and mark the original chunk for deletion. However, when a chunk overlaps multiple tables, we apply heuristics to retain the chunk until all the tables that have it indexed get processed since we need the original chunk to build a new one. Earlier, we used to process tables from oldest to newest, so the logic to detect if all the tables indexing a chunk are processed was done by seeing if `chunk-end-time` <= `table-end-time`. To put it in simple terms, if the chunk ends in the current table we are processing, it means this is the last table that we are processing, which has the chunk indexed. However, this does not work anymore since we changed the order of processing tables to process the newest tables first. To get it working back, I have updated the logic to `chunk-start-time` >= `table-start-time`. In simple terms, if the chunk starts in the current table we are processing, it means this is the last table we are processing, which has the chunk indexed. Checklist - [x] Tests updated	1 year ago
Sandeep Sukhani	3a7940af1c	compactor" track number of times table compactions were skipped consecutively (#11604 ) What this PR does / why we need it: Earlier we had a counter for the number of times tables were skipped by compaction due to them being locked by retention. Counter makes it hard to reliably write an alert without making it noisy. I am changing the counter to gauge which would count the number of times tables were consecutively skipped by compaction. This would make it easier to write alerts. Checklist - [x] Tests updated --------- Co-authored-by: Ashwanth <iamashwanth@gmail.com>	1 year ago
Danny Kopping	cd3cf6291f	Ruler: protect overrides map with mutex when accessing tenant configs (#11601 ) What this PR does / why we need it: A ruler handling many hundreds of rules can provoke a situation where the WAL appender reads & modifies tenant configs concurrently in an unsafe way; this PR protects that with a mutex. Which issue(s) this PR fixes: Fixes #11569	1 year ago
Travis Patterson	3373cc54f6	fix: use syntax.MustClone to avoid panics when cloning expressions (#11595 ) The clone function in rangemapper has been a persistent source of panics due to the way stringifying exprs changed the way the original query was represented. This PR replaces the `clone` function with `syntax.MustClone`. It clones the expression by actually walking the AST rather than doing `expr -> string -> parse`. It might still panic but for a more fundamental reason than because of issues with the string representation.	1 year ago
J Stickler	efdea22db4	Update descriptions (#11586 ) What this PR does / why we need it: Updates the `description` field in the metadata to support the Docs Landing Page project --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	1 year ago

1 2 3 4 5 ...

6079 Commits (e21b52567447d65292ee0ce80a78382573227a70) All Branches Search

6079 Commits (e21b52567447d65292ee0ce80a78382573227a70)

All Branches