apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Dylan Guedes	ea6abbfd07	Loki-Mixin: Remove query-readiness panel (#8735 ) What this PR does / why we need it: Remove from loki-mixin the panel that shows the query_readiness metric. The metric was removed a while ago.	2 years ago
J Stickler	673bfd603b	Fixing broken link (404) (#8688 ) This was reported to the docs team via Slack. Fixing broken link from Promtail Scraping file to Promtail Configuration file.	2 years ago
Danny Kopping	6c0f3442cc	Tools: add tool to determine which release (if any) a commit appears in (#8706 ) I've often found myself needing to determine which release a particular PR appears in. This tool makes that easy, and it accepts the merge commit ref of the PR. Example from https://github.com/grafana/loki/pull/7044, in which [a user is asking which version this feature appears in](https://github.com/grafana/loki/pull/7044#issuecomment-1455694087). ```bash $ ./tools/which-release.sh `93a5a71` Commit was found in the following releases: release-2.7.x ```	2 years ago
Dylan Guedes	656ad800fe	Promtail: Stop ticker to avoid leaking (#8695 ) What this PR does / why we need it: Call `Stop` to positions ticker to release associated resources/avoid leaking.	2 years ago
Mohamed-Amine Bouqsimi	519e25c714	operator: Fix gateway's nodeSelector and tolerations (#8707 )	2 years ago
Libby Anderson	06db3b96bb	Update retention_support.md (#8342 ) Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Karsten Jeschkies	28d845d26c	Make Loki Overrides public. (#8696 ) What this PR does / why we need it: Follow up to #8689 that will allow to inject a different overrides implementation. Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>	2 years ago
Travis Patterson	7f42137584	Use Line Filters in StringLabelFilter (#8659 ) We've done a ton of work to optimize regexes in line filters but nothing in label filters. To avoid duplicating the work or reworking all of our filter types, this PR creates a new label filter that has an optimized line filter. It uses that against the label value to determine if they match. Note on Benchmarks: the input string for this is 1114195 bytes long. The `not` test tells us that our approach is quite a lot slower when the literal pattern isn't present in the input. The size of the input really emphasizes it. Benchmarks: ``` name old time/op new time/op delta LineLabelFilters/foo-8 50.6ns ± 9% 14.3ns ± 1% -71.67% (p=0.000 n=10+8) LineLabelFilters/not-8 15.7ns ± 1% 64165.6ns ± 2% +407766.77% (p=0.000 n=10+10) LineLabelFilters/(foo)-8 58.4ns ± 1% 14.8ns ±10% -74.68% (p=0.000 n=9+9) LineLabelFilters/(foo\|ba)-8 64.9ns ± 0% 18.2ns ± 2% -71.90% (p=0.000 n=7+9) LineLabelFilters/(foo\|ba\|ar)-8 74.8ns ± 7% 21.4ns ± 2% -71.42% (p=0.000 n=10+8) LineLabelFilters/(foo\|(ba\|ar))-8 65.1ns ± 1% 18.1ns ± 2% -72.22% (p=0.000 n=8+8) LineLabelFilters/foo.-8 882ns ± 4% 15ns ±11% -98.30% (p=0.000 n=9+10) LineLabelFilters/.foo-8 11.5ns ± 8% 14.9ns ± 7% +30.39% (p=0.000 n=10+10) LineLabelFilters/.foo.-8 5.46µs ± 7% 0.01µs ± 3% -99.74% (p=0.000 n=10+9) LineLabelFilters/(.)(foo).-8 6.26µs ± 7% 0.01µs ± 2% -99.77% (p=0.000 n=10+9) LineLabelFilters/(foo.\|.ba)-8 5.58µs ± 3% 0.02µs ± 8% -99.67% (p=0.000 n=9+10) LineLabelFilters/(foo.\|.bar.)-8 7.02µs ± 7% 0.02µs ± 8% -99.73% (p=0.000 n=10+10) LineLabelFilters/.foo.\|bar-8 5.53µs ± 6% 0.02µs ± 2% -99.67% (p=0.000 n=10+8) LineLabelFilters/.foo\|bar-8 3.73µs ± 6% 0.02µs ± 3% -99.52% (p=0.000 n=10+9) LineLabelFilters/(?:.foo.\|bar)-8 5.43µs ± 8% 0.02µs ± 8% -99.65% (p=0.000 n=10+10) LineLabelFilters/(?P<foo>.foo.\|bar)-8 5.71µs ± 3% 0.02µs ±10% -99.68% (p=0.000 n=9+9) LineLabelFilters/.foo.\|bar\|buzz-8 5.34µs ± 2% 0.02µs ± 3% -99.65% (p=0.000 n=10+9) LineLabelFilters/.foo.\|bar\|uzz-8 5.36µs ± 1% 0.02µs ± 3% -99.60% (p=0.000 n=8+8) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 68.8ns ± 8% 22.6ns ± 7% -67.19% (p=0.000 n=10+10) LineLabelFilters/f\|foo\|foobar-8 77.1ns ± 1% 18.6ns ± 9% -75.90% (p=0.000 n=8+10) LineLabelFilters/f.\|foobar.\|.buzz-8 5.64µs ± 7% 0.02µs ±10% -99.60% (p=0.000 n=10+10) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 6.29µs ± 8% 0.02µs ±10% -99.65% (p=0.000 n=10+10) LineLabelFilters/.-8 963ns ± 8% 2ns ±14% -99.77% (p=0.000 n=10+10) LineLabelFilters/.\|.-8 4.46µs ± 8% 0.00µs ± 8% -99.95% (p=0.000 n=10+10) LineLabelFilters/.\|\|\|\|-8 2.99µs ± 1% 0.00µs ±16% -99.93% (p=0.000 n=8+10) LineLabelFilters/#00-8 43.5ns ± 8% 2.1ns ± 1% -95.25% (p=0.000 n=10+8) LineLabelFilters/(?i)foo-8 71.7ns ± 6% 13.1ns ± 1% -81.73% (p=0.000 n=10+8) LineLabelFilters/(?i)界-8 16.5ns ± 8% 150.2ns ± 8% +809.55% (p=0.000 n=10+10) LineLabelFilters/(?i)ïB-8 23.8ns ± 1% 14748979.8ns ± 7% +62074730.81% (p=0.000 n=8+10) LineLabelFilters/(?:)foo\|fatal\|exception-8 185ns ± 2% 21ns ± 2% -88.38% (p=0.000 n=9+8) LineLabelFilters/(?i)foo\|fatal\|exception-8 78.4ns ± 3% 20.2ns ± 2% -74.23% (p=0.000 n=9+9) LineLabelFilters/(?i)f\|foo\|foobar-8 94.3ns ±16% 15.4ns ± 9% -83.66% (p=0.000 n=10+10) LineLabelFilters/(?i)f\|fatal\|e.-8 65.7ns ± 5% 18.2ns ± 3% -72.24% (p=0.000 n=9+8) LineLabelFilters/(?i).foo.-8 6.04µs ± 8% 0.01µs ± 2% -99.78% (p=0.000 n=10+10) name old alloc/op new alloc/op delta LineLabelFilters/foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/not-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|ba)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|ba\|ar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|(ba\|ar))-8 0.00B 0.00B ~ (all equal) LineLabelFilters/foo.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(.)(foo).-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo.\|.ba)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo.\|.bar.)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo\|bar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?:.foo.\|bar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?P<foo>.foo.\|bar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar\|buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar\|uzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/f\|foo\|foobar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/f.\|foobar.\|.buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.\|.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.\|\|\|\|-8 0.00B 0.00B ~ (all equal) LineLabelFilters/#00-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)界-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)ïB-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?:)foo\|fatal\|exception-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)foo\|fatal\|exception-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)f\|foo\|foobar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)f\|fatal\|e.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i).foo.-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta LineLabelFilters/foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/not-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|ba)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|ba\|ar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|(ba\|ar))-8 0.00 0.00 ~ (all equal) LineLabelFilters/foo.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.-8 0.00 0.00 ~ (all equal) LineLabelFilters/(.)(foo).-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo.\|.ba)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo.\|.bar.)-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo\|bar-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?:.foo.\|bar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?P<foo>.foo.\|bar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar\|buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar\|uzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 0.00 0.00 ~ (all equal) LineLabelFilters/f\|foo\|foobar-8 0.00 0.00 ~ (all equal) LineLabelFilters/f.\|foobar.\|.buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.\|.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.\|\|\|\|-8 0.00 0.00 ~ (all equal) LineLabelFilters/#00-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)界-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)ïB-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?:)foo\|fatal\|exception-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)foo\|fatal\|exception-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)f\|foo\|foobar-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)f\|fatal\|e.-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i).foo.*-8 0.00 0.00 ~ (all equal) ```	2 years ago
Dylan Guedes	f9a1f2d94e	Loki: Stop running tickers on deletes (#8697 ) What this PR does / why we need it: Calls `ticker.Stop()` to avoid leaking ticker resources for `GenNumberLoader` and `deleteRequestsClient`.	2 years ago
Callum Styan	9a2a038f43	Allow passing of context to query related limits functions (#8689 ) In this PR we're allowing for passing of a `context.Context` via the Limits interfaces (some of which are new, to clean up hardcoding/embedding of `validation.Overrides`) This is based on work/ideas by @jeschkies . Fixes #8694 --------- Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
Kaviraj Kanagaraj	371455770f	doc(best-practices): Update default value of `max_chunk_age`. (#8685 )	2 years ago
e0031374	2dcaba3176	Loki Getting Started: Fix example query that was not working (#8668 ) What this PR does / why we need it: Previously example query was `evaluate-loki_flog_1` this was not the label used in flog. This results in query not returning any logs which beginners may be unsure of the cause of the issue. This might also be an issue if flog was running in the background and logs are not displayed. Changed to `evaluate-loki-flog-1`. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Trivial fix to "Getting Started" documentation Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Danny Kopping	ab7a970b94	Querier/Ruler: add histogram to track fetched chunk size distribution (#8682 ) What this PR does / why we need it: We are looking at making some changes to the chunk caching strategy, and we need this data to know what size chunks we're typically requesting. For example, if the overwhelming majority of chunks are small we may decide to cache only small chunks to decrease the number of requests to the object store; we could fit more chunks in cache this way, which may have a positive performance impact.	2 years ago
Bryan Boreham	08ac5336d5	WAL: store pointers in record pool (#8667 ) What this PR does / why we need it: Storing a slice in `sync.Pool` wastes 24 bytes every time it is returned to the heap; see https://staticcheck.io/docs/checks#SA6002 Storing a pointer to a slice allows the Pool to work without waste. This came up in discussion about the benchmark in #8489 - with this change the memory usage comes down: ``` name old time/op new time/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 7.37ms ±13% 7.45ms ± 9% ~ (p=0.841 n=5+5) name old alloc/op new alloc/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 727kB ± 0% 679kB ± 0% -6.63% (p=0.008 n=5+5) name old allocs/op new allocs/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 12.0k ± 0% 10.0k ± 0% -16.68% (p=0.000 n=5+4) ``` Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - [x] Tests updated - NA `CHANGELOG.md` updated - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Travis Patterson	c42a0ba868	Optimize .+ regex line filter (#8646 ) Interpolated variables from Grafana dashboards may result in the regex matcher `.+`. Filters with `+` are already being rewritten to be non greedy but there is a further optimization to make replace the regex altogether with a filter that just matchers `len(line) > 0`	2 years ago
Robert Jacob	0c071d8a79	operator: Fix version inconsistency in generated OpenShift bundle (#8666 )	2 years ago
Christian Haudum	a5652c8027	Clean up scheduler code to prepare upcoming changes (#8643 ) In preparation of https://github.com/grafana/loki/pull/8585 this PR contains some cleanups. Changes in this PR do not change the implementation, but only rename functions and data structures to make them more generic and/or suitable for extending. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Pablo	a15365202d	Optimize Promtail wal writer to batch both series and entries record (#8489 )	2 years ago
Grot (@grafanabot)	215f37cfa3	[CI/CD] Update yaml file `./production/helm/loki/values.yaml` (+1 other) (#8655 ) Here is a summary of the updates contained in this PR: * Update attribute `$.enterprise.version` in yaml file `./production/helm/loki/values.yaml` to the following value: `v1.6.2` * Bump version of Helm Chart Add changelog entry to `./production/helm/loki/CHANGELOG.md` Re-generate docs Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	2 years ago
Christian Haudum	cec264996b	LID: Improve scheduler to control QoS across users within a tenant (#8585 ) Even though Loki is built as multi-tenant system by default, there are use-cases where a Loki installation only has a very large, single tenant, e.g. dedicated Loki cells for customers in Grafana Cloud. However, there are potentially a lot of different users using the same tenant to query logs, such as users accessing Loki from Grafana or via CLI or HTTP API. This can lead to contention between queries of different users, because they all share the same tenant. While the current implementation of the scheduler queues allows for QoS guarantees between tenants, it does not account for QoS guarantees across individual users within a single tenant. --- Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
Jan Jansen	84c5e20af1	S3: add support for s3 session token (#8474 ) We want to automate the access account rotation. This is that easy at moment with service accounts in MinIO. Our currently life time of tokens is 3 months with MinIO STS works this fine. Signed-off-by: Jan Jansen <jan.jansen@gdata.de>	2 years ago
Danny Kopping	6bf782b0a7	Ruler: do not keep appending logger keys (#8650 ) What this PR does / why we need it: Corrects a logger which was accidentally appending keys in every loop iteration, causing massive lines to be ingested	2 years ago
Dylan Guedes	c06f1daf59	Update CHANGELOG.md (#8633 ) What this PR does / why we need it: Update our changelog to inherit v2.7.4 release notes	2 years ago
Angus Dippenaar	5c5b27db50	[logcli] set default instead of error for parallel-max-workers validation (#8641 ) What this PR does / why we need it: Fixes regression reported here: https://github.com/grafana/loki/pull/8518#issuecomment-1446014229 @dannykopping can you please verify that it fixes the issue for you? Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Vladyslav Diachenko	88120a0857	added missed binaries required to run `./tools/image-tag` script (#8640 ) What this PR does / why we need it: [This drone step](https://drone.grafana.net/grafana/loki/20764/21/3) had to prepare a config for the `updater` to update loki helm chart with the latest image version automatically. However, it failed due to an error: ``` + RELEASE_TAG=$(./tools/image-tag) env: can't execute 'bash': No such file or directory ``` I forgot to install `bash` and `git` before running this script inside `alpine` container.	2 years ago
J Stickler	5fbc747392	Fixing broken link and removing out of date blog post. (#8632 ) Which issue(s) this PR fixes: * Starts to address #8631 * Removes link to outdated blog post that says "Loki is very much alpha software and should not be used in production environments." * Fixes broken link to Configuration file.	2 years ago
Trevor Whitney	dac3b84d08	Loki cloud integration instructions (and necessary mixin changes) (#8492 ) What this PR does / why we need it: This PR is a first stab at documentation for setting up the Grafana Cloud Loki Integration to monitor a local Loki cluster, installed using the helm chart, using Grafana Cloud. In addition to instructions on how to collect the necessary kubernetes metrics, there were also some things with the Loki mixin (which provides dashboards, alerts, and rules to the integration) that needed to be fixed. For example, our dashboards rely on there being a cluster label on our recording rules, yet our mixin does not include this? Also, we are still including `cortex-gw` panels even when the mixin is compile with `internal_components: false`. Special notes for your reviewer: The changes to the mixin will not be reflected in the current version of the integration. We need to merge this PR first then update the integration. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Susana Ferreira	9f8aa4b98a	Helm: fix enterprise-logs license secret name (#8498 ) What this PR does / why we need it: Rename `gel-license.jwt` property of secret `gel-secrets` to `license.jwt` on enterprise-logs chart to make it consistent betwen `gel-secrets` and `gel-license` kubectl secrets. * Fix the `stringData` property of the GEL secret, to contain `license.jwt` property when importing: * `gel-secrets`: containing both the `gcp_service_account.json` and `license.jwt` properties `6ece17a82f/production/helm/loki/docs/examples/enterprise/enterprise-secrets.yaml (L1-L12)` * `gel-license`: containing only the `license.jwt` property `6a7403c4f5/tools/dev/k3d/environments/helm-cluster/main.jsonnet (L213-L217)` * Minor fixes in the README documentation. Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Vladyslav Diachenko	78db3f8d11	Helm chart auto update (#8331 ) What this PR does / why we need it: implemented a pipeline that will run on Loki tag that starts with `v` and will prepare updater config and run updater with prepared config to update Loki helm chart with the released Loki version. Example of PR that is generated by this Pipeline : [here](https://github.com/grafana/loki/pull/8328)	2 years ago
Susana Ferreira	141ee25c0e	Helm: update changelog CI comment (#8603 ) What this PR does / why we need it: Update the helm changelog CI comment to clarify that the pipeline is only used for new Loki releases. Related to PR: https://github.com/grafana/loki/pull/8323 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Susana Ferreira	2a3874b240	Helm: update changelog with changes from PR #8467 (#8601 ) What this PR does / why we need it: Update changelog with changes from PR #8467 and bump helm chart version to 4.6.2 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
dependabot[bot]	31f8bf9a73	Bump golang.org/x/net from 0.4.0 to 0.7.0 in /pkg/push (#8562 ) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.4.0 to 0.7.0. <details> <summary>Commits</summary> <ul> <li><a href="`8e2b117aee`"><code>8e2b117</code></a> http2/hpack: avoid quadratic complexity in hpack decoding</li> <li><a href="`547e7edf38`"><code>547e7ed</code></a> http2: avoid referencing ResponseWrite.Write parameter after returning</li> <li><a href="`39940adcaa`"><code>39940ad</code></a> html: parse comments per HTML spec</li> <li><a href="`87ce33ecb4`"><code>87ce33e</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`415cb6d518`"><code>415cb6d</code></a> all: fix some comments</li> <li><a href="`7e3c19ca52`"><code>7e3c19c</code></a> all: correct typos in comments</li> <li><a href="`296f09aa38`"><code>296f09a</code></a> http2: case insensitive handling for 100-continue</li> <li><a href="`f8411da775`"><code>f8411da</code></a> nettest: fix tests on dragonfly and js/wasm</li> <li><a href="`8e0e7d8d38`"><code>8e0e7d8</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`7805fdc37d`"><code>7805fdc</code></a> http2: rewrite inbound flow control tracking</li> <li>Additional commits viewable in <a href="https://github.com/golang/net/compare/v0.4.0...v0.7.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.4.0&new-version=0.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/grafana/loki/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
dependabot[bot]	0b1bffaa9e	Bump golang.org/x/net from 0.5.0 to 0.7.0 (#8563 ) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0. <details> <summary>Commits</summary> <ul> <li><a href="`8e2b117aee`"><code>8e2b117</code></a> http2/hpack: avoid quadratic complexity in hpack decoding</li> <li><a href="`547e7edf38`"><code>547e7ed</code></a> http2: avoid referencing ResponseWrite.Write parameter after returning</li> <li><a href="`39940adcaa`"><code>39940ad</code></a> html: parse comments per HTML spec</li> <li><a href="`87ce33ecb4`"><code>87ce33e</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`415cb6d518`"><code>415cb6d</code></a> all: fix some comments</li> <li><a href="`7e3c19ca52`"><code>7e3c19c</code></a> all: correct typos in comments</li> <li><a href="`296f09aa38`"><code>296f09a</code></a> http2: case insensitive handling for 100-continue</li> <li><a href="`f8411da775`"><code>f8411da</code></a> nettest: fix tests on dragonfly and js/wasm</li> <li>See full diff in <a href="https://github.com/golang/net/compare/v0.5.0...v0.7.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.5.0&new-version=0.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/grafana/loki/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Zach Watson	d59792ffa3	production: Add missing string formatter token to nginx.conf config map (#8580 ) The `nginx.conf` config map server settings has a `proxy_set_header` line setting the X-Scope-OrgID using the gateway tenant ID. The Jsonnet string formatter is missing the `s` token. This PR adds the missing formatter token to the `nginx.conf` config map that's causing an `Unrecognized conversion type: ;` when trying to deploy. Fixes a bug introduced in #7624	2 years ago
Bryan Boreham	6fd4b5e89b	Update prometheus/prometheus from 2.41 to 2.42 (#8571 ) What this PR does / why we need it: Brings in the latest updates from upstream. These open up some opportunities for optimisations in TSDB indexing. Dependencies updated: * github.com/Azure/go-autorest/autorest/adal v0.9.21 -> v0.9.22 (comment-only change) * github.com/docker/docker v20.10.21 -> v20.10.23 (fixing filters bug) * golang.org/x/exp fae10dda9338 -> d38c7dcee874 (optimisations in `BinarySearch` function) Indirect dependencies also updated: * github.com/digitalocean/godo v1.91.1 -> v1.95.0 (nothing alarming in [release notes](https://github.com/digitalocean/godo/releases)) * github.com/google/pprof aee1124e3a93 -> 76d1ae5aea2b (no changes pulled into vendor) * golang.org/x/tools v0.4.0 -> v0.5.0 (relating to Go compiler utilities) * google.golang.org/genproto 76db0878b65f -> 31e0e69b6fc2 * k8s.io/api v0.26.0 -> v0.26.1 (comment-only change) * k8s.io/apimachinery v0.26.0 -> v0.26.1 (no changes pulled into vendor) * k8s.io/client-go v0.26.0 -> v0.26.1 (small fixes) Special notes for your reviewer: A couple of interfaces changed; these have required matching changes in Loki code. Those changes are split into separate commits. I also note that most calls to `relabel` ignore when the rule says "drop". Maybe this is wrong?	2 years ago
Joseph Shanak	7204216187	chore: Fix typos in Helm documentation (#8593 )	2 years ago
Christian Haudum	d4a6b159fa	chore: Cleanup label extraction expression (#8596 ) The aim of this is to remove redundancy from the parser grammar and make the expression name more descriptive. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Bryan Boreham	019ac9975c	Iterators: re-implement entrySortIterator using loserTree for performance (#8351 ) What this PR does / why we need it: [Draft PR for comment at this time] This implementation uses a data structure called Loser Tree, also known as Tournament Tree, based on Knuth, "Sorting and Searching" section 5.4.1. I couldn't find an existing Loser Tree in Go, so I wrote my own; the file is 132 lines long. It uses generics in the hope it can also be applied elsewhere. One benchmark result: ``` name old time/op new time/op delta SortIterator/sort-4 3.78ms ± 4% 2.66ms ± 3% -29.54% (p=0.008 n=5+5) name old alloc/op new alloc/op delta SortIterator/sort-4 319kB ± 0% 14kB ± 0% -95.52% (p=0.008 n=5+5) name old allocs/op new allocs/op delta SortIterator/sort-4 104 ± 0% 5 ± 0% -95.19% (p=0.008 n=5+5) ``` Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Karsten Jeschkies	eeca4589fb	Define Container for Codespaces (#8561 )	2 years ago
Susana Ferreira	b8118b1e7b	Helm enterprise-logs: update kubernetes secrets creation (#8467 ) What this PR does / why we need it: Fix the Kubernetes secrets creation for the tokengen and provisioner jobs for multiple helm installations/uninstallations. The execution flow for the helm installation is the following: 1) `tokengen` job `loki` container generates a new admin token, stores it in the object storage and writes it to the `shared` mount. 2) `tokengen` job `create-secret` container creates a new Kubernetes secret for the generated admin token. 3) `provisioner` job `provisioner` container creates the new admin resources via the Admin API and writes the tokens to the `bootstrap` mount. 4) `provisioner` job `create-secret` container creates new Kubernetes secrets for each token of the additional tenants. ## Previous implementation Uninstall and re-install the enterprise-logs helm: 1) `tokengen` job `loki` container generates a new admin token, stores it in the object storage, and writes it to the `shared` mount. This is because this job uses an [emptyDir](https://kubernetes.io/docs/concepts/storage/volumes/#emptydir) mount which is deleted once the job completes. When a new job is created, the directory will be again empty, forcing the `tokengen` to generate a new token. 2) `tokengen` job `create-secret` container fails, because an admin token secret already exists: ``` Defaulted container "create-secret" out of: create-secret, loki (init) error: failed to create secret secrets "enterprise-logs-admin-token" already exists ``` 3) The helm installation fails ❌ ## Implementation in this PR 1) `tokengen` job `loki` container generates a new admin token, stores it in the object storage, and writes it to the `shared` mount. 2) `tokengen` job `create-secret` container updates the previously created Kubernetes secret for the admin token. 3) `provisioner` job `provisioner` container checks that the admin resources already exist and doesn't write the token files to the `bootstrap` mount. 4) `provisioner` job `create-secret` container checks that the token files are not present on the `bootstrap` mount, and does not create new secrets. 5) The helm installation succeeds ✅ Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Michel Hollands	4f8d3240f6	Use 0.28.1 build image and update go and alpine versions (#8583 ) What this PR does / why we need it: - Use the 0.28.1 build image - Update Go version to 1.20.1 - Use Alpine 3.16.4 - Fix linter issues due to updated govet in 1.20.1 - Modify images to not create `/etc/nsswitch.conf` file anymore (available by default on Alpine 3.16.4) - Remove impossible test cases for `TestMemChunk_IteratorBounds`(see https://github.com/grafana/loki/pull/8591#discussion_r1115020111 for context) Signed-off-by: Michel Hollands <michel.hollands@grafana.com> Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: DylanGuedes <djmgguedes@gmail.com>	2 years ago
dependabot[bot]	48aa833229	Bump golang.org/x/text from 0.3.7 to 0.3.8 in /operator (#8597 ) Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.3.8. <details> <summary>Commits</summary> <ul> <li><a href="`434eadcdbc`"><code>434eadc</code></a> language: reject excessively large Accept-Language strings</li> <li><a href="`23407e72ed`"><code>23407e7</code></a> go.mod: ignore cyclic dependency for tagging</li> <li><a href="`b18d3dd8a4`"><code>b18d3dd</code></a> secure/precis: replace bytes.Compare with bytes.Equal</li> <li><a href="`795e854ff3`"><code>795e854</code></a> all: replace io/ioutil with io and os package</li> <li><a href="`b0ca10ff35`"><code>b0ca10f</code></a> internal/language: bump script types to uint16 and update registry</li> <li><a href="`ba9b0e1d4b`"><code>ba9b0e1</code></a> go.mod: update x/tools to HEAD</li> <li><a href="`d03b418000`"><code>d03b418</code></a> A+C: delete AUTHORS and CONTRIBUTORS</li> <li><a href="`b4bca84b03`"><code>b4bca84</code></a> language/display: fix Tag method comment</li> <li><a href="`ea49e3e2d5`"><code>ea49e3e</code></a> go.mod: update x/tools to HEAD</li> <li><a href="`78819d01d0`"><code>78819d0</code></a> go.mod: update to golang.org/x/text v0.1.10</li> <li>Additional commits viewable in <a href="https://github.com/golang/text/compare/v0.3.7...v0.3.8">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/text&package-manager=go_modules&previous-version=0.3.7&new-version=0.3.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/grafana/loki/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Christian Haudum	25d266e1f4	Clean up CHANGELOG (#8595 ) Keep the changelog clean so it's easier for the release shepherd to compile the changelog and release notes for the next release. * Add newline underneath section heading * Move promtail related changelog entries into promtail section * Remove changelog entry from already released enhancement * Move changelog entry into correct position	2 years ago
Robert Jacob	93c35a7a13	operator: Refactor status update to reduce API calls (#8578 )	2 years ago
Gerard Vanloo	233997ef20	operator: Store gateway tenant information in secret instead of configmap (#8577 )	2 years ago
Owen Diehl	2836c79537	Revert "Loki: Fix memchunk headblock filter" (#8594 ) Reverts grafana/loki#8591 This altered an internal API. We execute queries that are inclusive of start and exclusive of end: `[start,end)` and shouldn't break this. We use other ways to ensure `start==end` still works, such as by using the lookback-period to alter the range of queries: https://github.com/grafana/loki/blob/main/pkg/logql/evaluator.go#L179-L181	2 years ago
Bayan Taani	68a9fd6c0a	Add logfmt selective label extraction (#6675 ) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> What this PR does / why we need it: This PR introduces extracting labels from a log line in `logfmt`, with an extra option to rename them. For example, this query: ``` {app=”foo”} \| logfmt msg,status ``` will extract the labels `msg` and `status` from the following logfmt line: ``` level=error ts=2021-02-12T19:18:10.037940878Z caller=client.go:294 component=client host=observability-loki-gateway msg="final error sending batch" status=400 error="server returned HTTP status 400 Bad Request (400): entry with timestamp 2021-02-12 19:18:08.917452 +0000 UTC ignored, reason: 'entry out of order' for stream..." ``` With the following results: ``` msg="final error sending batch" status=”400” ``` -------------- Another possible scenario with label renaming: ``` {app=”foo”} \| logfmt message="msg", status ``` That produces the following results: ``` message="final error sending batch" status=”400” ``` Which issue(s) this PR fixes: Fixes #3355 Special notes for your reviewer: <!-- Note about CHANGELOG entries, if a change adds: * an important feature * fixes an issue present in a previous release, * causes a change in operation that would be useful for an operator of Loki to know then please add a CHANGELOG entry. For documentation changes, build changes, simple fixes etc please skip this step. We are attempting to curate a changelog of the most relevant and important changes to be easier to ingest by end users of Loki. Note about the upgrade guide, if this changes: * default configuration values * metric names or label names * changes existing log lines such as the metrics.go query output line * configuration parameters * anything to do with any API * any other change that would require special attention or extra steps to upgrade Please document clearly what changed AND what needs to be done in the upgrade guide. --> Checklist - [x] Documentation added - [x] Tests updated - [x] Is this an important fix or new feature? Add an entry in the `CHANGELOG.md`. - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Dylan Guedes	030d3232ff	Loki: Fix memchunk headblock filter (#8591 ) What this PR does / why we need it: Fix our memchunk headblock filter to not skip entries that have timestamp=maxT.	2 years ago
Gerard Vanloo	f6871d8f5f	operator: Remove deprecated field querier.engine.timeout (#8579 )	2 years ago
Travis Patterson	eb1b72ab80	Fix ruler deadlock (#8486 ) A circular dependency between the Prometheus rules.Manager and the MemStore causes occasional deadlock in the rulers. This change makes both the manager and the memstore rely on the `GroupLoader` interface to break the circular dependency. The manger holding the `GroupLoader` only ever adds rules to it so we add another layer to cleanup any leftover state after an update happens. This supersedes https://github.com/grafana/loki/pull/8453 --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago

1 2 3 4 5 ...

4714 Commits (ea6abbfd079f79dcc0d019bf1691a6a3a9803a8f) All Branches Search

4714 Commits (ea6abbfd079f79dcc0d019bf1691a6a3a9803a8f)

All Branches