4281 Commits (ea9ad336dc7ecb1f8047c451c8fb56216872544a)

 

All Branches   

Search

Author	SHA1	Message	Date
cadrake	ea9ad336dc	Loki: Modified heroku drain target to make any url query parameters available as labels (#7619) ... **What this PR does / why we need it**: This PR reads the url query parameters included in Heroku drain POST request and creates `__param_<name>` labels similar to how the parameters work with prometheus metrics and metric endpoints as a way to allow setting the true application name when ingesting logs from a Heroku drain. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: The existing `app` field coming from Heroku only specifies application source (either the application itself or Heroku) and thus is insufficient for uniquely identifying a log lines source. **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Travis Patterson	eb7fbfe0b4	Improve ratestore performance (#7810) ... This PR changes the Rate Store to use multi-level maps rather than `tenant+stream-fingerprint` key. Benchmarks: *old* ``` goos: linux goarch: amd64 pkg: github.com/grafana/loki/pkg/distributor cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz BenchmarkRateStore-8 117 10420080 ns/op 3201761 B/op 200025 allocs/op PASS ok github.com/grafana/loki/pkg/distributor 14.646s ``` *new* ``` goos: linux goarch: amd64 pkg: github.com/grafana/loki/pkg/distributor cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz BenchmarkRateStore-8 320 3811906 ns/op 2660 B/op 26 allocs/op ``` *stats* ``` name old time/op new time/op delta RateStore-8 10.7ms ± 8% 4.1ms ± 8% -61.42% (p=0.000 n=10+10) name old alloc/op new alloc/op delta RateStore-8 3.20MB ± 0% 0.00MB ± 0% -99.92% (p=0.000 n=8+9) name old allocs/op new allocs/op delta RateStore-8 200k ± 0% 0k ± 0% -99.99% (p=0.000 n=9+10) ```	3 years ago
李国忠	63a57c7b5c	[bugfix] scheduler: Gracefully shutdown querier when using query-scheduler (#7735) ... **What this PR does / why we need it**: Gracefully shutdown querier when using query-scheduler This PR is an attempt to fix a bug that my loki cluster is unavailable for logql. The source code and ideas are from mimir of LGTM. Thanks mimir and pr author @pracucci **Which issue(s) this PR fixes**: Fixes #7722 **Special notes for your reviewer**: mimir PR https://github.com/grafana/mimir/pull/1756 https://github.com/grafana/mimir/pull/1767 **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>	3 years ago
Kaviraj Kanagaraj	4efdc131be	fix(memcached): panic on `send on closed channel`. (#7817)	3 years ago
Christian Simon	2ff6f13c8b	Better error message for empty selector queries (#6936) ... This improves the error when an empty label selector is given: Before: ```sh-session # Before $ logcli query "{}" Error response from server: parse error at line 1, col 2: syntax error: unexpected }, expecting IDENTIFIER # After $ logcli query "{}" Error response from server: parse error : queries require at least one regexp or equality matcher that does not have an empty-compatible value. For instance, app=~".*" does not meet this requirement, but app=~".+" will ``` I fear that might have wider implications, so it would be great to get a lot of eyes on this. In theory I think we should remove the restriction on querying all log streams, but this should maybe discussed in a follow up PR 🙂 Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	3 years ago
Periklis Tsirakidis	54e6c19fc6	operator: Apply delete client changes for compat with release-2.7.x (#7815)	3 years ago
Anders Bennedsgaard	b5563cee08	[Helm] Remove unused value and set default values explicitly (#7576) ... **What this PR does / why we need it**: `monitoring.alerts` are not used in the Loki Helm chart. This removes it. Furthermore, some values are referenced in the templates, but not used in the values file. This adds the default values. **Which issue(s) this PR fixes**: Fixes #7575 **Special notes for your reviewer**: https://github.com/AndersBennedsgaard/loki/blob/main/production/helm/loki/templates/single-binary/pdb.yaml#L15 should probably also be updated since `podDisruptionBudget` is not referenced in the values file. However, I am unsure what default values should be used. https://github.com/AndersBennedsgaard/loki/blob/main/production/helm/loki/templates/networkpolicy.yaml#L124 should probably also be updated since the `loki.rulerSelectorLabels` is not a valid helper function. However, I am unsure which selector labels to use. Especially since it seems like `ruler` is not used. Perhaps any reference to `ruler` should be removed? **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Sandeep Sukhani	89d81020ce	fix lint issues from PR 7804 (#7814) ... **What this PR does / why we need it**: I had enabled auto-merge in PR #7804, but somehow it still merged the PR without all the checks passing. This PR fixes the failing lint and tests.	3 years ago
Jan-Otto Kröpke	5dc60567da	[Helm] Add support for azure blob storage (#7500) ... **What this PR does / why we need it**: Support Azure Blob Storage in helm chart. See https://grafana.com/docs/loki/latest/storage/#azure-storage-account-1 **Which issue(s) this PR fixes**: **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Jan-Otto Kröpke <jok@cloudeteer.de>	3 years ago
Sandeep Sukhani	1410808ee9	use grpc for communicating with compactor for query time filtering of data requested for deletion (#7804) ... **What this PR does / why we need it**: Add grpc support to compactor for getting delete requests and gen number for query time filtering. Since these requests are internal to Loki, it would be good to use grpc instead of HTTP same as all the internal requests we do in Loki. I have added a new config for accepting the grpc address of the compactor. I tried having just the existing config and detecting if it is a grpc server, but it was hard to do it reliably, considering the different deployment modes we support. I think it is safe to keep it the same and eventually deprecate the existing config. **Checklist** - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated	3 years ago
George Tsilias	d3615f7e9e	promtail: Handle nil error on target Details() call (#7771) ... **What this PR does / why we need it**: This PR addresses issue [#6930](https://github.com/grafana/loki/issues/6930). Promtail should not panic when the Details() method is called for a target that has no errors. **Which issue(s) this PR fixes**: Fixes #6930	3 years ago
Kaviraj Kanagaraj	30ddd77150	loki-canary: respect `useTLS` flag when `push` mode is enabled. (#7701) ... **What this PR does / why we need it**: Currently `useTLS` flag is ignored on the push writer. This PR consider that flag and adjust the schema (http -> https) when that flag is enabled. **Which issue(s) this PR fixes**: Fixes #7692 **Special notes for your reviewer**: **Checklist**	3 years ago
Robert Jacob	6e217c6aa1	operator: Fix alert unit tests (#7812) ... **What this PR does / why we need it**: Fixes the Prometheus alert tests broken by #7809 **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Tests updated	3 years ago
Josef Johansson	b05f4fced3	Remove hardwired '127.0.0.1' values in default addresses (#7784) ... While running all-in-one Loki instance, it's not possible to listen on anything other than IPv4 since compactor_address is then set to http://127.0.0.1. This enables listening on only IPv6. Also if frontend_address, scheduler_ring and scheduler_address is not set, the default value is to connect to '127.0.0.1:<grpc_listen_port>'. Which means that grpc_listen_address is ignored. **What this PR does / why we need it**: It's not possible to use compactor while using an all-in-one instance and listening to IPv6. Let's not ignore grpc_listen_address to not confuse users. **Special notes for your reviewer**: As noted in the first commit, the default behavior is changed from defaulting to `127.0.0.1` to `localhost`. Not sure how major that change is though. My /etc/hosts says ``` $ grep localhost /etc/hosts 127.0.0.1 localhost ``` Signed-off-by: Josef Johansson <josef@oderland.se>	3 years ago
Robert Jacob	4bcecefd05	operator: Fix histogram-based alerting rules (#7809)	3 years ago
Robert Jacob	6d7d537518	operator: Replace fifocache usage by embedded_cache (#7808)	3 years ago
Dylan Guedes	4567d01ac6	Loki: Add new sharding metrics (histogram based) (#7762) ... **What this PR does / why we need it**: Add histogram-version of two existing stream sharding metrics. The new metrics are: - `rate_store_stream_shards`: Will show us the distribution of shards reported by ingesters. This will help us on monitoring the number of shards we're dealing with. As of now we only have access to the max number of shards seen, which is helpful but not enough. - `rate_store_stream_rate_bytes`: Same as below: will help us understand the distribution of stream sizes instead of only showing us the max stream size seen.	3 years ago
Karsten Jeschkies	691b8be6c7	Provide Terraform script for setting up S3 and document role based access. (#7656) ... **What this PR does / why we need it**: Role based access to S3 on an EKS cluster via service account annotation was not documented well and let to some confusion. This change documents how a role based accessis achieved with providing an AWS secret access key and access key id. Thus there is no change of accidentally leaking credentials. A Terraform module is provided under `production/terraform/modules/s3` that provisions and S3 bucket and IAM role and policy. **Which issue(s) this PR fixes**: Fixes #7279 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Pablo Angulo <pablo.angulo@grafana.com>	3 years ago
李国忠	6d05ade6a8	[performance] metrics query: range vector support streaming agg when no overlap (#7380) ... metrics query: range vector support streaming agg when no overlap	3 years ago
Paul Wheeler	85d6794d2b	fluent-bit: Update the Fluent Bit plugin README with correct golang minimum version (#7302) ... **What this PR does / why we need it**: The Loki plugin for Fluent Bit will not build with golang < 1.17 because of the use of net.IP.IsPrivate in the referenced version of github.com/grafana/dskit/netutil/netutil.go **Which issue(s) this PR fixes**: No issue exists (this is a minor documentation issue). **Special notes for your reviewer**: **Checklist** - [X] Reviewed the `CONTRIBUTING.md` guide - [N/A] Documentation added - [N/A] Tests updated - [N/A] `CHANGELOG.md` updated - [N/A] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Periklis Tsirakidis	54d3e0e64e	operator: Check for mandatory CA configmap name in ObjectStorageTLS spec (#7753)	3 years ago
Teddy Andrieux	217a914f98	helm/loki: Allow to override default loki `target` (#7791) ... **What this PR does / why we need it**: Add the ability to change the Loki `target` argument. E.g. one might want to use the single-binary which has target `all` but also the `table-manager` which is not part of it. So one can override the target with `all,table-manager`. **Which issue(s) this PR fixes**: Fixes #7788 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] `CHANGELOG.md` updated	3 years ago
Karsten Jeschkies	7ec51e8b9d	Log rule changes through API. (#7790) ... **What this PR does / why we need it**: This change should make it easier to detect changes to rules via the API. **Which issue(s) this PR fixes**: Fixes #7789 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Christian Haudum <christian.haudum@gmail.com>	3 years ago
MarNicGit	59c1abe259	Docs - Move PR's in CHANGELOG.md that weren't actually implemented in 2.7.x (#7690) ... Fixes the changelog. - PR #7462 and #7461 were **not** included in the 2.7.x release (they were submitted right after the cutoff and did not get backported) and accidentally ended up in the 2.7.x changelog. Moved them up to Main/Unreleased. - Moved #7602 to enhancements section of Promtail	3 years ago
李国忠	720dfe0476	fifocache config is deprecated. use embedded-cache instead (#7800)	3 years ago
Travis Patterson	343e39f67b	Update Ingester Rate Calculations (#7652) ... - Use weighted moving average for rates - Keep Streams around until they are removed Previously, the rate calculator only kept the most recent second. This led to issues where bursty streams that didn't get pushes every second resulted in undersharding those streams	3 years ago
Marc Sensenich	409c13131c	docs(embedded-cache): config uses embedded_cache (#7797)	3 years ago
Danny Kopping	6c8d04fe78	Completing step 2 of updating loki-build-image (#7796)	3 years ago
Danny Kopping	bd110d2b92	Improvements to loki-build-image build & release process (#7795)	3 years ago
Danny Kopping	d0bbeffbb2	Update delve version to be compatible with Go 1.19 (#7793) ... In order to use the `production/docker` with an interactive debugger, we need to upgrade the Delve tool to a version that works with the version of Go which Loki uses: 1.19	3 years ago
Duc Tran	71b21c924e	[Docs] Typo: Fix build path of promtail binary (#7776)	3 years ago
Alexandre de Sá	040c549845	[Docs] Fix helm loki examples links (#7779) ... Fixes links to Helm documentation.	3 years ago
Chris Hodges	e80b4deb43	Promtail: Add tenant label to client drop metrics and logs (#7593) ... **What this PR does / why we need it**: Provides better visibility for per-tenant drops/retries in Promtail **Which issue(s) this PR fixes**: Fixes #7570 **Special notes for your reviewer**: Does anything depend on these metrics only having 1 label that this change would break? I decided against a reason label due to cardinality concerns given how widely promtail is often deployed. **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Danny Kopping	a63ad06509	Querier/Ruler: query blocker (#7785) ... Block malicious or expensive queries using a per-tenant runtime configuration.	3 years ago
Vladyslav Diachenko	c6b55e7512	[docs] removed static URL to LogQL Analyzer API (#7773) ... added logic to determine logql-analyzer version dynamically based on the value selected in docs version dropdown. Adding this logic to the docs, allows us to skip the step on release when we manually update the link to the new version of LogQL Analyzer	3 years ago
Wade Fitzpatrick	8a5c8f0a3d	Add closing code block backticks (#7772)	3 years ago
Owen Diehl	22089415e8	Split parallelism across Period Configs (#7769) ... One of things we watch while updating non-TSDB period configs to TSDB period configs is the difference in query parallelism. TSDB dynamically shards queries into (potentially) much smaller units of work compared to the static shard factors uses prior. To account for this, we use much higher query parallelism configurations with TSDB period configs. This creates a potential problem when querying across `non-tsdb, tsdb` period boundaries: we may want a query parallelism of 512 for the tsdb portion but only 64 for the non-tsdb portion! However, we only had one limit to specify this per tenant, meaning this would be too high when querying non-tsdb periods or too low when querying tsdb ones. This PR * Introduces `tsdb_max_query_parallelism` (default `512`) to `limits_config` * Uses `tsdb_max_query_parallelism` and `max_query_parallelism` limits to find a better parallelism _per query_ by weighting the two respective configs by the proportion of each query spent on TSDB or non-TSDB period configurations. Signed-off-by: Owen Diehl <ow.diehl@gmail.com>	3 years ago
Kaviraj Kanagaraj	c44fb2e882	chore(tools): Update promtail image version (#7770) ... **What this PR does / why we need it**: update promtail version on `tools/promtail.sh` which generates promtail config for kubernetes **Which issue(s) this PR fixes**: Fixes #NA **Special notes for your reviewer**: This image is part of latest loki 2.7.0 release and[ it does exists ](https://hub.docker.com/layers/grafana/promtail/2.7.0/images/sha256-d54b599ea154df295486068f1545731bd5ab9790602d8518816c9285eec3df5e?context=repo) **Checklist**	3 years ago
Joel Takvorian	44942c5f60	operator: Fix docs AWS storage uses bucketnames (#7767)	3 years ago
Dylan Guedes	ad2260aec2	Loki: Fix multitenant querying (#7708) ... **What this PR does / why we need it**: We recently broke multitenant querying because of recent changes to how timeouts working across Loki. This PR fixes this by: - Adapt the timeout wrapper to work with multitenant queries. It will take the shortest timeout across all given tenants - Adapt the query engine timeout assigning to work with multitenant queries. It will take the shortest timeout between all the tenants - Adapt query sharding to use smallest max query parallelism across given tenants - Add a functional test to ensure multitenant is behaving as expected Signed-off-by: DylanGuedes <djmgguedes@gmail.com> Signed-off-by: Mehmet Burak Devecí <mhmtbrkdvc@gmail.com> **Which issue(s) this PR fixes**: https://github.com/grafana/loki/issues/7696 **Special notes for your reviewer**: The regression was probably introduced by https://github.com/grafana/loki/pull/7555	3 years ago
Vladyslav Diachenko	81f4643f8a	[CI/CD] fixed step `deploy` (#7715)	3 years ago
Trevor Whitney	ea4a764143	[helm] Fix incorrect ingress paths when using single binary deployment (#7530) ... **What this PR does / why we need it**: The helm ingress template was copied over from the simple scalable chart and does not work when deploying the chart in single binary configuration. This fixes that by adding a set of single binary routes, and conditionally configuring the ingress resource based on deployment type. **Which issue(s) this PR fixes**: Fixes #7080 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Karsten Jeschkies	dd098bbd6d	Return error on JSON serialization error. (#7745) ... Clean up of https://github.com/grafana/loki/pull/7721	3 years ago
Christian Haudum	48c3fb4c7c	Fix label selector for gateway service in operational dashboard ... Use `job=~\"$namespace/cortex-gw(-internal)?\"` throughout the dashboard. This fixes the occurrence where a regex value was used in combination with an exact label match. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	3 years ago
Trevor Whitney	1aa7991828	Update release instructions (#7663) ... We usually tag releases from the HEAD of the release branch	3 years ago
Karsten Jeschkies	eb176b6a47	Only release Helm Chart when version changed. (#7747) ... **What this PR does / why we need it**: The Helm Chart release often breaks when changes missed to update the Helm Chart version. There is also often a conflict in the version. This solution proposes to check the `Chart.yaml` for changes.	3 years ago
Kaviraj Kanagaraj	3a0be48975	config: Improve error message loading config with ENV variables. (#7759) ... **What this PR does / why we need it**: Before: ``` Unable to parse config: ./clients/cmd/promtail/promtail-local-config.yaml: parse "http://${LOKI_URL}localhost:3100/loki/api/v1/push": invalid character "{" in host name ``` After: ``` Unable to parse config: ./clients/cmd/promtail/promtail-local-config.yaml: parse "http://${LOKI_URL}localhost:3100/loki/api/v1/push": invalid character "{" in host name. Use `-config.expand-env=true` flag if you want to expand environment variables in your config file ``` **Which issue(s) this PR fixes**: Fixes #NA **Special notes for your reviewer**: **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] `CHANGELOG.md` updated	3 years ago
Christian Haudum	6c7a4dcdbd	[loki-mixin] Make "Success Rate" panels in operational dashboard more accurate (#7756)	3 years ago
Karsten Jeschkies	8e9702950c	Only check mixin on file changes. (#7755) ... **What this PR does / why we need it**: The mixin check sometimes (e.g. [this build](https://drone.grafana.net/grafana/loki/17667/4/2)) which blocks pull requests with unrelated changes. This is a quick fix. Ideally we would investigate why Jsonnet Bundler is failing sometimes. **Checklist** - [ ] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Sandeep Sukhani	97a7ed0b61	fix logs deletion integration test to properly validate deleted data (#7751) ... **What this PR does / why we need it**: Currently, the integration test for deletion does not validate whether the delete request properly deleted the requested data or not. It just currently checks if the delete request got processed. This was due to the singleton `boltdb-shipper` client causing problems in flushing chunks. I have used `ResetBoltDBIndexClientWithShipper` to reset the boltdb-shipper client to get the chunk flush from the ingester working. The test now does the checks to ensure that the right data got deleted by the compactor. This should help us catch any bugs earlier for any future changes in deletion code. **Checklist** - [x] Tests updated	3 years ago