commit
9ed6b20672
@ -1,15 +1,17 @@ |
|||||||
<!-- |
<!-- |
||||||
Don't forget! |
Don't forget! |
||||||
|
|
||||||
|
- Please sign CNCF's Developer Certificate of Origin and sign-off your commits by adding the -s / --sign-off flag to `git commit`. See https://github.com/apps/dco for more information. |
||||||
|
|
||||||
- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test. |
- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test. |
||||||
|
|
||||||
- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage. |
- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage. |
||||||
|
|
||||||
- No tests are needed for internal implementation changes. |
- No tests are needed for internal implementation changes. |
||||||
|
|
||||||
- Performance improvements would need a benchmark test to prove it. |
- Performance improvements would need a benchmark test to prove it. |
||||||
|
|
||||||
- All exposed objects should have a comment. |
- All exposed objects should have a comment. |
||||||
|
|
||||||
- All comments should start with a capital letter and end with a full stop. |
- All comments should start with a capital letter and end with a full stop. |
||||||
--> |
--> |
||||||
|
Loading…
Reference in new issue